Re: [edk2-devel] [PATCH V3 0/2] Initial commit for RISC-V Qemu-based Server

2024-07-25 Thread Fu Siyuan
Hi Evan On 25 Jul 2024, at 20:08, EvanChai wrote: > Hi Siyuan, > Thanks for your comments. > 1. will remove it in the next patch > 2. In my oppinion, we should keep the content here. Similar to how writing a > manual for a development board starts with an introduction to its hardware > archi

Re: [edk2-devel] [PATCH edk2-platforms 5/5] Platform/RaspberryPi: Drop platform specific EfiResetSystemLib

2024-07-25 Thread Ard Biesheuvel
On Thu, 25 Jul 2024 at 22:21, Jeremy Linton wrote: > > Hi, > > On 7/25/24 06:38, Leif Lindholm wrote: > > On Thu, Jul 25, 2024 at 12:43:30 +0200, Ard Biesheuvel wrote: > >> From: Ard Biesheuvel > >> > >> Drop the now unused EfiResetSystemLib implementation, which has been > >> superseded by the g

Re: [edk2-devel] [PATCH edk2-platforms 5/5] Platform/RaspberryPi: Drop platform specific EfiResetSystemLib

2024-07-25 Thread Jeremy Linton
Hi, On 7/25/24 06:38, Leif Lindholm wrote: On Thu, Jul 25, 2024 at 12:43:30 +0200, Ard Biesheuvel wrote: From: Ard Biesheuvel Drop the now unused EfiResetSystemLib implementation, which has been superseded by the generic one from EDK2. Signed-off-by: Ard Biesheuvel --- Platform/RaspberryP

Re: [edk2-devel] edk2 Automatic PR Reviewers

2024-07-25 Thread Rebecca Cran
On 7/24/24 20:35, Michael Kubacki wrote: A change was just pushed to edk2 to automatically add reviewers to pull request based on those listed in Maintainers.txt. For more details and in case of any issues, I put some information on this wiki page: https://github.com/tianocore/tianocore.gith

Re: [edk2-devel] [PATCH edk2-platforms 5/5] Platform/RaspberryPi: Drop platform specific EfiResetSystemLib

2024-07-25 Thread Ard Biesheuvel
On Thu, 25 Jul 2024 at 14:12, Alexander D wrote: > > Shouldn't there be an alternative to gRaspberryPiEventResetGuid for the FVB > driver? If you make changes to the var store then reset, pretty sure they'll > be getting lost, right? Indeed. This is handled in a preceding patch. -=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 5/5] Platform/RaspberryPi: Drop platform specific EfiResetSystemLib

2024-07-25 Thread Alexander D
Shouldn't there be an alternative to gRaspberryPiEventResetGuid for the FVB driver? If you make changes to the var store then reset, pretty sure they'll be getting lost, right? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120039): htt

Re: [edk2-devel] [PATCH edk2-platforms 5/5] Platform/RaspberryPi: Drop platform specific EfiResetSystemLib

2024-07-25 Thread Leif Lindholm
On Thu, Jul 25, 2024 at 12:43:30 +0200, Ard Biesheuvel wrote: > From: Ard Biesheuvel > > Drop the now unused EfiResetSystemLib implementation, which has been > superseded by the generic one from EDK2. > > Signed-off-by: Ard Biesheuvel > --- > Platform/RaspberryPi/RaspberryPi.dec

Re: [edk2-devel] [PATCH edk2-platforms 00/11] Phase out ArmSmcPsciResetSystemLib

2024-07-25 Thread Ard Biesheuvel
On Thu, 25 Jul 2024 at 11:49, Leif Lindholm wrote: > > On Thu, Jul 25, 2024 at 10:24:51 +0200, Ard Biesheuvel wrote: > > From: Ard Biesheuvel > > > > ArmSmcPsciResetSystemLib is being replaced with a generic implementation > > that is shared between physical and virtual placement, executing at >

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] Platform/Sgi: Rename RD-Fremont to RD-V3

2024-07-25 Thread levi.yun
LGTM Reviewed-by: Levi Yun -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120035): https://edk2.groups.io/g/devel/message/120035 Mute This Topic: https://groups.io/mt/107049626/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH edk2-platforms 04/11] Platform/ARM: Switch to generic ArmPsciResetSystemLib

2024-07-25 Thread Sami Mujawar
Hi Ard, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 25/07/2024, 09:25, "Ard Biesheuvel" mailto:ardb+...@google.com>> wrote: From: Ard Biesheuvel mailto:a...@kernel.org>> The PSCI reset libraries in ArmPkg are being consolid

Re: [edk2-devel] [PATCH edk2-platforms 00/11] Phase out ArmSmcPsciResetSystemLib

2024-07-25 Thread Leif Lindholm
On Thu, Jul 25, 2024 at 10:24:51 +0200, Ard Biesheuvel wrote: > From: Ard Biesheuvel > > ArmSmcPsciResetSystemLib is being replaced with a generic implementation > that is shared between physical and virtual placement, executing at > either EL2 or EL1. > > So update all library class resolutions

Re: [edk2-devel] [PATCH V3 0/2] Initial commit for RISC-V Qemu-based Server

2024-07-25 Thread Fu Siyuan
Hi, Evan Here are some more comments for the Readme.md in the v2.5 branch. https://github.com/ChaiEvan/edk2-platforms/blob/RV_ServerPlatformRef_v2.5/Platform/Qemu/RiscVQemuServerPlatform/Readme.md 1. Please remove the Revision History section, since this is a readme file instead of a formal rel