Merged: https://github.com/tianocore/edk2/pull/5294
> -Original Message-
> From: Kinney, Michael D
> Sent: Tuesday, January 23, 2024 3:27 PM
> To: devel@edk2.groups.io; jbra...@nvidia.com
> Cc: gaolim...@byosoft.com.cn; Liu, Zhiguang ;
> Kinney, Michael D
> Subject: RE: [edk2-devel] [PAT
Reviewed-by: Michael D Kinney
I also see you opened a PR to run EDK II CI and it passed.
I will merge V3
Thanks,
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Jeff
> Brasen via groups.io
> Sent: Tuesday, January 23, 2024 7:08 PM
> To: devel@edk2.groups.io
> Cc:
From: Doug Flick
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4540
SECURITY PATCH - Unit Tests
TCBZ4540
CVE-2023-45235
CVSS 8.3 : CVSS:3.1/AV:A/AC:L/PR:N/UI:N/S:U/C:H/I:L/A:H
CWE-119 Improper Restriction of Operations within the Bounds of
a Memory Buffer
Cc: Saloni Kasbekar
Cc: Zachary
This creates / adds a security file that tracks the security fixes
found in this package and can be used to find the fixes that were
applied.
Cc: Saloni Kasbekar
Cc: Zachary Clark-williams
Signed-off-by: Doug Flick [MSFT]
---
NetworkPkg/SecurityFixes.yaml | 123 +++
This adds support for GetTime Google Test Mock
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Doug Flick [MSFT]
---
.../GoogleTest/Library/MockUefiRuntimeServicesTableLib.h | 7 +++
.../MockUefiRuntimeServicesTableLib.cpp| 5 +++--
2 files chang
From: Doug Flick
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4540
SECURITY PATCH - Patch
TCBZ4540
CVE-2023-45235
CVSS 8.3 : CVSS:3.1/AV:A/AC:L/PR:N/UI:N/S:U/C:H/I:L/A:H
CWE-119 Improper Restriction of Operations within the Bounds of
a Memory Buffer
Cc: Saloni Kasbekar
Cc: Zachary Clar
From: Doug Flick
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4539
SECURITY PATCH - Patch
TCBZ4539
CVE-2023-45234
CVSS 8.3 : CVSS:3.1/AV:A/AC:L/PR:N/UI:N/S:U/C:H/I:L/A:H
CWE-119 Improper Restriction of Operations within the Bounds of
a Memory Buffer
Cc: Saloni Kasbekar
Cc: Zachary Clar
From: Doug Flick
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4539
SECURITY PATCH - Unit Tests
TCBZ4539
CVE-2023-45234
CVSS 8.3 : CVSS:3.1/AV:A/AC:L/PR:N/UI:N/S:U/C:H/I:L/A:H
CWE-119 Improper Restriction of Operations within the Bounds of a Memory Buffer
Cc: Saloni Kasbekar
Cc: Zachary
From: Doug Flick
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4537
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4538
SECURITY PATCH - Unit Tests
TCBZ4537
CVE-2023-45232
CVSS 7.5 : CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H
CWE-835 Loop with Unreachable Exit Condition ('Infinite Lo
From: Doug Flick
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4537
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4538
SECURITY PATCH - Patch
TCBZ4537
CVE-2023-45232
CVSS 7.5 : CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H
CWE-835 Loop with Unreachable Exit Condition ('Infinite Loop')
The security patches contained in this series with the exception of
"MdePkg/Test: Add gRT_GetTime Google Test Mock" and
"NetworkPkg: : Adds a SecurityFix.yaml file" have been reviewed
during GHSA-hc6x-cw6p-gj7h infosec review.
This patch series contains the following security patches for the
secur
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4534
SECURITY PATCH - Unit Tests
TCBZ4534
CVE-2023-45229
CVSS 6.5 : CVSS:3.1/AV:A/AC:L/PR:N/UI:N/S:U/C:H/I:N/A:N
CWE-125 Out-of-bounds Read
Cc: Saloni Kasbekar
Cc: Zachary Clark-williams
Signed-off-by: Doug Flick [MSFT]
---
NetworkPkg/Test
From: Doug Flick
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4536
SECURITY PATCH - Patch
TCBZ4536
CVE-2023-45231
CVSS 6.5 : CVSS:3.1/AV:A/AC:L/PR:N/UI:N/S:U/C:H/I:N/A:N
CWE-125 Out-of-bounds Read
Cc: Saloni Kasbekar
Cc: Zachary Clark-williams
Signed-off-by: Doug Flick [MSFT]
---
Ne
From: Doug Flick
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4536
SECURITY PATCH - Unit Tests
TCBZ4536
CVE-2023-45231
CVSS 6.5 : CVSS:3.1/AV:A/AC:L/PR:N/UI:N/S:U/C:H/I:N/A:N
CWE-125 Out-of-bounds Read
Cc: Saloni Kasbekar
Cc: Zachary Clark-williams
Signed-off-by: Doug Flick [MSFT]
--
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4534
SECURITY PATCH - Patch
TCBZ4534
CVE-2023-45229
CVSS 6.5 : CVSS:3.1/AV:A/AC:L/PR:N/UI:N/S:U/C:H/I:N/A:N
CWE-125 Out-of-bounds Read
Cc: Saloni Kasbekar
Cc: Zachary Clark-williams
Signed-off-by: Doug Flick [MSFT]
---
NetworkPkg/Dhcp6Dxe/
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4535
SECURITY PATCH - Unit Tests
TCBZ4535
CVE-2023-45230
CVSS 8.3 : CVSS:3.1/AV:A/AC:L/PR:N/UI:N/S:U/C:H/I:L/A:H
CWE-119 Improper Restriction of Operations within the Bounds
of a Memory Buffer
Cc: Saloni Kasbekar
Cc: Zachary Clark-williams
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4535
SECURITY PATCH - Patch
TCBZ4535
CVE-2023-45230
CVSS 8.3 : CVSS:3.1/AV:A/AC:L/PR:N/UI:N/S:U/C:H/I:L/A:H
CWE-119 Improper Restriction of Operations within the Bounds
of a Memory Buffer
Cc: Saloni Kasbekar
Cc: Zachary Clark-williams
Signed
To support unregister SMI handler inside SMI handler itself,
get next node before SMI handler is executed, since LIST_ENTRY that
Link points to may be freed if unregister SMI handler in SMI handler
itself.
Cc: Liming Gao
Cc: Jiaxin Wu
Cc: Ray Ni
Signed-off-by: Zhiguang Liu
---
MdeModulePkg/Co
Add Google Mock Library for FdtLib
Signed-off-by: Jeff Brasen
---
MdePkg/Test/MdePkgHostTest.dsc| 1 +
.../GoogleTest/MockFdtLib/MockFdtLib.inf | 28 +++
.../Include/GoogleTest/Library/MockFdtLib.h | 164 ++
.../GoogleTest/MockFdtLib/MockFdtLib.cpp
Add intel linux guys in CC list.
> -Original Message-
> From: Gerd Hoffmann
> Sent: Wednesday, January 24, 2024 12:12 AM
> To: Laszlo Ersek
> Cc: devel@edk2.groups.io; Johnson, Brian ; West,
> Catharine ; Xu, Min M ; Ni,
> Ray ; Wu, MingliangX ; Yao,
> Jiewen ; Xue, Shengfeng
> ; Dong, E
Oops not sure how that happened will fix and push a v3.
-Jeff
> -Original Message-
> From: Kinney, Michael D
> Sent: Tuesday, January 23, 2024 4:52 PM
> To: Jeff Brasen ; devel@edk2.groups.io
> Cc: gaolim...@byosoft.com.cn; Liu, Zhiguang ;
> Kinney, Michael D
> Subject: RE: [PATCH v2
Hi Liming,
I do not see any reviews of this patch.
What is the status?
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Dhaval
> Sharma
> Sent: Monday, January 8, 2024 7:00 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Liu, Zhiguang
> ; Bi, Dandan ; Pedro
> Falca
Reviewed-by: Gua Guo
-Original Message-
From: devel@edk2.groups.io On Behalf Of Michael D Kinney
Sent: Wednesday, January 24, 2024 7:19 AM
To: Jeff Brasen ; devel@edk2.groups.io
Cc: gaolim...@byosoft.com.cn; Liu, Zhiguang ; Kinney,
Michael D
Subject: Re: [edk2-devel] [PATCH v2 1/1] Mde
Hi Christine,
I did not see this merged yet.
Is this change also in edk2-basetools repo? I do not see it there.
I thought the process was to do changed in edk2-basetools repo first where
there are a large set of CI checks and then make the same change in the
edk2 repo.
Mike
> -Original M
Hi Jeff,
I just noticed that the DSC file in MdePkg/Test has not been updated to
make sure this mock lib always builds. I added as part of PR to run
EDK II CI.
EDK II CI did fail.
https://github.com/tianocore/edk2/pull/5293
https://github.com/tianocore/edk2/pull/5293/checks?check_run_id=20795
On Mon, 22 Jan 2024 at 03:34, Nhi Pham via groups.io
wrote:
>
> From: Laszlo Ersek
>
> The current dependency evaluator violates the memory access permission
> when patching depex grammar directly in the read-only depex memory area.
>
> Laszlo pointed out the optimization issue in the thread (1)
Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Jeff
> Brasen via groups.io
> Sent: Tuesday, January 23, 2024 3:16 PM
> To: devel@edk2.groups.io
> Cc: gaolim...@byosoft.com.cn; Kinney, Michael D
> ; Liu, Zhiguang ;
> Jeff Brasen
> Subject: [
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Jeff Brasen
> Sent: Tuesday, January 23, 2024 3:13 PM
> To: devel@edk2.groups.io
> Cc: gaolim...@byosoft.com.cn; Kinney, Michael D
> ; Liu, Zhiguang ;
> Jeff Brasen
> Subject: [PATCH v2 1/1] MdePkg: Add FdtLib gmock support
>
>
Rename the standard functions in the LibFdtSupport to remove conflicts
with other libraries that define them.
Signed-off-by: Jeff Brasen
---
MdePkg/Library/BaseFdtLib/LibFdtSupport.h | 7 +--
MdePkg/Library/BaseFdtLib/LibFdtWrapper.c | 25 ++-
2 files changed, 7 insertio
Hi Ming,
Please update the function headers for the following drivers that
provide implementations of the Storage Security Command Protocol.
MdeModulePkg\Bus\Ata\AtaBusDxe\AtaBus.c:
1485@param This Indicates a pointer to the
calling context.
1486: @param Medi
Add Google Mock Library for FdtLib
Signed-off-by: Jeff Brasen
---
.../GoogleTest/MockFdtLib/MockFdtLib.inf | 28 +++
.../Include/GoogleTest/Library/MockFdtLib.h | 164 ++
.../GoogleTest/MockFdtLib/MockFdtLib.cpp | 34
3 files changed, 226 insertions(+)
create
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of ryderkeys
> via groups.io
> Sent: Monday, January 22, 2024 10:25 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] Resources for Creating Packages
>
> Hello,
>
> (Originally sent to edk2 discuss but it looks like my mes
* Add InitializeFloatingPointUnits() to x86 specific file
* Add GetCpuFamilyModel() to x86 specific file
* Add GetCpuSteppingId() to x86 specific file
* Move StandardSignatureIsAuthenticAMD() to x86 specific file.
* Add CpuLib library class include to all C files.
Cc: Liming Gao
Cc: Zhiguang Liu
Hi Laszlo,
Thanks for the feedback. Sorry I missed this email this morning.
I will prepare a 2nd patch with these additional updates.
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo
> Ersek
> Sent: Tuesday, January 23, 2024 5:57 AM
> To: devel@edk2.groups.io
Hi Zhi,
Thanks for the update. One minor comment on 'STATIC' should be 'static'.
We no longer depend on macros to redefine 'STATIC' and it is better to
just used the standard C 'static' form.
With that change:
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: Jin, Zhi
Hi Jeff,
Thanks for this mock lib contribution.
I few comments below.
Thanks,
Mike
> -Original Message-
> From: Jeff Brasen
> Sent: Monday, December 11, 2023 7:43 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Kinney, Michael D
> ; Liu, Zhiguang ;
> Jeff Brasen
> Subject: [PATCH
Hi Jeff,
One comment below.
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Jeff
> Brasen via groups.io
> Sent: Monday, December 11, 2023 7:40 AM
> To: devel@edk2.groups.io
> Cc: Jeff Brasen
> Subject: [edk2-devel] [PATCH] MdePkg/BaseFdtLib: Rename standard
> functi
Merged: https://github.com/tianocore/edk2/pull/5291
> -Original Message-
> From: Kinney, Michael D
> Sent: Tuesday, January 23, 2024 9:26 AM
> To: devel@edk2.groups.io; Huang, Qing
> Cc: Kinney, Michael D
> Subject: RE: [edk2-devel] [PATCH v1] MdePkg/BaseCpuLibNull: Add stub
> function
Merged: https://github.com/tianocore/edk2/pull/5290
> -Original Message-
> From: Kinney, Michael D
> Sent: Tuesday, January 23, 2024 9:13 AM
> To: Ren, SuqiangX ; devel@edk2.groups.io
> Cc: Liming Gao ; Liu, Zhiguang
> ; Kinney, Michael D
> Subject: RE: [PATCH V3 1/1] MdePkg: Update the
Provide an optional method for PEI to declare a specific address
range to use for the Memory Type Information bins. The current
algorithm uses heuristics that tends to place the Memory Type
Information bins in the same location, but memory configuration
changes across boots or algorithm changes acr
Gerd,
As a new EDK2 developer, I'm working through getting the patches up to EDK2 but
I have to follow the EDK2 patch process which is not the fastest thing to
follow and also not my day job. If you want to see where I am you can look at
the CI Pipeline. The patches were reviewed during the GHS
On 23/01/2024 16:55, Laszlo Ersek wrote:
+ ///
+ /// Number of self-tests performed.
+ ///
+ UINTN SelfTestCount;
} NESTED_INTERRUPT_STATE;
/**
I suggest that the new field be UINT32. The (exclusive) limit is a
32-bit PCD. Making the counter (potentially) wider than the limit is
Hi Qing,
Thank you for this update to add the missing API to BaseCpuLibNull.
There are a few very minor comments below. I will make those updates
in the PR for merge. With those changes:
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf
On 23/01/2024 17:10, Laszlo Ersek wrote:
Other than that, the patch looks great to me; I'd only propose one
(superficial) improvement:
rather than include , scavenge
#ifdef MDE_CPU_ARM
#include
#elif defined (MDE_CPU_AARCH64)
#include
#endif
from it.
Reasons:
(a) Those are the headers that
Any comments on this patch?
Thanks,
Jeff
> -Original Message-
> From: Jeff Brasen
> Sent: Monday, December 11, 2023 8:43 AM
> To: devel@edk2.groups.io
> Cc: gaolim...@byosoft.com.cn; michael.d.kin...@intel.com;
> zhiguang@intel.com; Jeff Brasen
> Subject: [PATCH] MdePkg: Add FdtLib
CC the maintainers which I missed in the email on this originally.
> -Original Message-
> From: Jeff Brasen
> Sent: Monday, December 11, 2023 9:53 AM
> To: Pedro Falcato ; devel@edk2.groups.io
> Subject: RE: [edk2-devel] [PATCH] MdePkg/BaseFdtLib: Rename standard
> functions
>
> Hit send
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Ren, SuqiangX
> Sent: Monday, January 22, 2024 11:03 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Liming Gao
> ; Liu, Zhiguang
> Subject: [PATCH V3 1/1] MdePkg: Update the definition of FileName on
> EFI_FILE_INFO
>
On 1/23/24 16:31, Michael Brown wrote:
> The only architecture-specific portion of NestedInterruptTplLib is in
> Iret.c, which must manipulate the interrupt stack frame such that the
> return-from-interrupt instruction will not re-enable interrupts. The
> remaining logic in Tpl.c is architecture-a
On 23/01/2024 16:32, Laszlo Ersek wrote:
On 1/23/24 16:31, Michael Brown wrote:
At TPL_HIGH_LEVEL, CPU interrupts are disabled (as per the UEFI
specification) and so we should never encounter a situation in which
an interrupt occurs at TPL_HIGH_LEVEL.
Restoring TPL to TPL_HIGH_LEVEL is always a
only superficial comments:
On 1/23/24 16:31, Michael Brown wrote:
> Add the ability to perform self-tests on the first few invocations of
> NestedInterruptRestoreTPL(), to verify that:
>
> - the timer interrupt handler correctly rearms the timer interrupt
> before calling NestedInterruptRestore
On Tue, Jan 23, 2024 at 11:42:57AM +0530, Dhaval Sharma wrote:
> Sunil,
> I thought "WriteBackDataCacheRange not supported" is more explicit over
> "CMO not available".
>
Okay.
> @Pedro Falcato For the example you mentioned, is
> your concern more about someone not being able to notice the probl
On 23/01/2024 15:51, Ard Biesheuvel wrote:
On Tue, 23 Jan 2024 at 16:31, Michael Brown wrote:
Add implementations of DisableInterruptsOnIret() for MDE_CPU_ARM and
MDE_CPU_AARCH64. In both cases, the saved IRQs-disabled and
FIQs-disabled flags are set in the stored processor status register
(ma
Hi,
What is the state of affairs wrt. the pixiefail vulnerabilities?
The advisory is published
(https://github.com/tianocore/edk2/security/advisories/GHSA-hc6x-cw6p-gj7h),
it says the plan is to have the fixes included in the next (Feb 2024)
stable tag. I see bugzilla has patches attached, mos
On 1/23/24 16:31, Michael Brown wrote:
> At TPL_HIGH_LEVEL, CPU interrupts are disabled (as per the UEFI
> specification) and so we should never encounter a situation in which
> an interrupt occurs at TPL_HIGH_LEVEL.
>
> Restoring TPL to TPL_HIGH_LEVEL is always a no-op. Return immediately
> from
Hi,
> >>> Well, it's OVMF in a virtual machine. No boot guard involved.
> >>> So we could probably go for a OVMF-specific patch here.
> >>>
> >>> But I'd prefer to figure what exactly is happening here before going
> >>> down that route. An extreme slowdown just because we flip that bit
> >>>
Thanks Mike,
I've prepared a Pull request with your Reviewed-By Tag. Feel free to add the
push tag at your convenience. I appreciate your time!
.pytool/Plugin: UncrustifyCheck: use stat instead of os.stat by Javagedes ·
Pull Request #5287 · tianocore/edk2 (github.com) (
https://github.com/tian
On Tue, 23 Jan 2024 at 16:31, Michael Brown wrote:
>
> The only architecture-specific portion of NestedInterruptTplLib is in
> Iret.c, which must manipulate the interrupt stack frame such that the
> return-from-interrupt instruction will not re-enable interrupts. The
> remaining logic in Tpl.c is
The only architecture-specific portion of NestedInterruptTplLib is in
Iret.c, which must manipulate the interrupt stack frame such that the
return-from-interrupt instruction will not re-enable interrupts. The
remaining logic in Tpl.c is architecture-agnostic.
Add implementations of DisableInterru
Add the ability to perform self-tests on the first few invocations of
NestedInterruptRestoreTPL(), to verify that:
- the timer interrupt handler correctly rearms the timer interrupt
before calling NestedInterruptRestoreTPL(), and
- the architecture-specific DisableInterruptsOnIret() implementat
At TPL_HIGH_LEVEL, CPU interrupts are disabled (as per the UEFI
specification) and so we should never encounter a situation in which
an interrupt occurs at TPL_HIGH_LEVEL.
Restoring TPL to TPL_HIGH_LEVEL is always a no-op. Return immediately
from NestedInterruptRestoreTPL(TPL_HIGH_LEVEL), so that
Allow build system to detect changes to Iret.h.
Suggested-by: Ray Ni
Reviewed-by: Laszlo Ersek
Signed-off-by: Michael Brown
---
.../Library/NestedInterruptTplLib/NestedInterruptTplLib.inf | 1 +
1 file changed, 1 insertion(+)
diff --git
a/MdeModulePkg/Library/NestedInterruptTplLib/Neste
NestedInterruptTplLib provides a way for timer interrupt handlers
(which must support nested interrupts) to prevent unbounded stack
consumption.
The underlying issue was first observed in OvmfPkg, since interrupt
storms can arise more easily in virtual machines due to CPU
starvation. However, car
NestedInterruptTplLib provides a way for timer interrupt handlers
(which must support nested interrupts) to prevent unbounded stack
consumption.
The underlying issue was first observed in OvmfPkg, since interrupt
storms can arise more easily in virtual machines due to CPU
starvation. However, car
For MdeModulePkg, I think no need to change because no any logic change.
For StandaloneMmPkg and EmbeddedPkg
- Don't have enough abilities to close Sami Mujawar and Ni Ray open currently,
so hold on the change until I find how to introduce Panic. So give up these two
packages patch currently.
-
On Fri, Jan 12, 2024 at 10:25:16AM +0800, gua@intel.com wrote:
> From: Gua Guo
>
> PR: https://github.com/tianocore/edk2/pull/5252
> Gua Guo (4):
> UefiPayloadPkg/Hob: Integer Overflow in CreateHob()
> StandaloneMmPkg/Hob: Integer Overflow in CreateHob()
> EmbeddedPkg/Hob: Integer Over
On 1/22/24 20:04, Rebecca Cran wrote:
> Originally posted at
> https://twitter.com/UEFIForum/status/1745518769232077208
>
> The Multi-ISA Driver Compatibility Survey is at
> https://docs.google.com/forms/d/e/1FAIpQLScXjwaSBgLeqB1coEDxCPxho5JWF3AMqshOTJ2wd6Tf0He4LA/viewform
>
> From that page:
>
On 1/23/24 11:52, Gerd Hoffmann wrote:
> On Mon, Jan 22, 2024 at 01:11:52PM -0600, Brian J. Johnson wrote:
>> On 1/18/24 09:46, Gerd Hoffmann wrote:
>>> On Wed, Jan 10, 2024 at 04:43:47PM +, West, Catharine wrote:
Disabling cache by default results in violation of BTG protections (if BTG
Hi Rebecca,
Thank you for this patch.
I have a minor suggestion marked inline as [SAMI].
Otherwise, this patch looks good to me.
With that fixed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 19/01/2024, 15:46, "Rebecca Cran" mailto:rebe...@os.amperecomputing.com>> wrote:
Update Gener
Hi Rebecca,
Thank you for this patch.
Please find my feedback inline marked as [SAMI].
Regards,
Sami Mujawar
On 19/01/2024, 15:46, "Rebecca Cran" mailto:rebe...@os.amperecomputing.com>> wrote:
The generic watchdog offset register is 48 bits wide, and can be set by
performing two 32-bit writ
Hi Rebecca,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 19/01/2024, 15:46, "Rebecca Cran" mailto:rebe...@os.amperecomputing.com>> wrote:
The calculation of the timer period was broken. Introduce a global
mTimerPeriod so the ca
On 22/01/2024 10:36, Laszlo Ersek wrote:
(1) Does LocalApicTimerDxe have any other dependencies on OvmfPkg than
the library class header?
In other words, can't we remove "OvmfPkg/OvmfPkg.dec" from this
[Packages] section, too?
I can't see anything else, so I'd suggest to remove
"OvmfPkg/OvmfPkg
On 1/23/24 12:36, Huang, Qing wrote:
> CpuLib.h exposes StandardSignatureIsAuthenticAMD() API and we require stub
> function in its BaseCpuLibNull library
> instance to avoid potential link issue.
>
> Signed-off-by: Qing Huang
> ---
> MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.c | 17
On 1/23/24 08:15, Zhiguang Liu wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4614
>
> About the IsModified, current function doesn't consider that hardware
> also may change the pagetable. The issue is that in the first call of
> internal function PageTableLibMapInLevel, the functio
On Tue, Jan 23, 2024 at 6:13 AM Dhaval Sharma wrote:
>
> Sunil,
> I thought "WriteBackDataCacheRange not supported" is more explicit over "CMO
> not available".
>
> @Pedro Falcato For the example you mentioned, is your concern more about
> someone not being able to notice the problem (that the s
CpuLib.h exposes StandardSignatureIsAuthenticAMD() API and we require stub
function in its BaseCpuLibNull library
instance to avoid potential link issue.
Signed-off-by: Qing Huang
---
MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.c | 17 -
1 file changed, 16 insertions(+), 1 dele
On Mon, Jan 22, 2024 at 01:11:52PM -0600, Brian J. Johnson wrote:
> On 1/18/24 09:46, Gerd Hoffmann wrote:
> > On Wed, Jan 10, 2024 at 04:43:47PM +, West, Catharine wrote:
> > > Disabling cache by default results in violation of BTG protections (if
> > > BTG enabled).
> > > BIOS cannot assume
[AMD Official Use Only - General]
Ok, I got it! Thanks.
Abner
> -Original Message-
> From: Xing, Eric
> Sent: Tuesday, January 23, 2024 6:28 PM
> To: Chang, Abner ; Attar, AbdulLateef (Abdul
> Lateef) ; devel@edk2.groups.io; Zhai, MingXin
> (Duke)
> Cc: Fu, Igniculus
> Subject: RE: [e
[AMD Official Use Only - General]
Ok, got it!
Thanks
Abner
> -Original Message-
> From: Xing, Eric
> Sent: Tuesday, January 23, 2024 6:20 PM
> To: Chang, Abner ; Zhai, MingXin (Duke)
> ; devel@edk2.groups.io
> Cc: Yao, Ken ; Fu, Igniculus
> Subject: RE: [PATCH 28/33] AMD/VanGoghBoard:
[AMD Official Use Only - General]
Hi Abner and Abdul,
Thanks for the review, it is good catch.
Currently, our current override files are based on UDK202208 code base now.
AmdMmSaveStateLib.inf is not existed in UDK2208 code base, we will leverage
latest EDK2 changes after we update to new EDK2
[AMD Official Use Only - General]
Hi Abner,
Thanks for the review, it is good catch.
Currently, our current override files are based on UDK202208 code base now. We
will leverage latest EDK2 changes after we update to new EDK2 code base.
Thanks,
Eric
> -Original Message-
> From: Chang, A
Hi All,
Please find the links to previous discussions below :
V1 -
https://edk2.groups.io/g/devel/topic/96088980#100022
V2 -
https://edk2.groups.io/g/devel/topic/96671861#103652
V3 -
https://edk2.groups.io/g/devel/topic/100912169#112452
Thanks,
Sahil
On Thu, 4 Jan 2024 at 18:46, sahil wrote:
Hi All,
Please find the links to previous discussions below :
V1 -
https://edk2.groups.io/g/devel/topic/96088980#100022
V2 -
https://edk2.groups.io/g/devel/topic/96671861#103652
V3 -
https://edk2.groups.io/g/devel/topic/100912169#112452
Thanks,
Sahil
On Thu, 4 Jan 2024 at 18:46, sahil wrote:
Hi All,
Please find the links to previous discussions below :
V1 -
https://edk2.groups.io/g/devel/topic/96088980#100022
V2 -
https://edk2.groups.io/g/devel/topic/96671861#103652
V3 -
https://edk2.groups.io/g/devel/topic/100912169#112452
Thanks,
Sahil
On Thu, 4 Jan 2024 at 18:46, sahil wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4614
About the IsModified, current function doesn't consider that hardware
also may change the pagetable. The issue is that in the first call of
internal function PageTableLibMapInLevel, the function assume page
table is not changed, and add ASSE
Hi All,
Please find the links to previous discussions below :
V1 -
https://edk2.groups.io/g/devel/topic/96088980#100022
V2 -
https://edk2.groups.io/g/devel/topic/96671861#103652
V3 -
https://edk2.groups.io/g/devel/topic/100912169#112452
Thanks,
Sahil
On Thu, 4 Jan 2024 at 18:46, sahil wrote:
>
85 matches
Mail list logo
