[edk2-devel] [PATCH v2] MinPlatformPkg: Fix/Update code design gap.

2023-10-05 Thread Susovan Mohapatra
https://bugzilla.tianocore.org/show_bug.cgi?id=4461 1. The function GetRandomNumber128() returns a boolean TRUE/FALSE. The existing code was getting data in EFI_STATUS.0==FALSE==EFI_SUCCESS Updated code to check for the return value before proceeding further. 2. The 'seed' from the GetRandomN

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg: Add ClockRate field to SerialPortInfo

2023-10-05 Thread Pedro Falcato
On Wed, Oct 4, 2023 at 9:01 PM MrChromebox wrote: > > Add the ClockRate field to the UNIVERSAL_PAYLOAD_SERIAL_PORT_INFO > struct, so that the field can be used by UefiPayloadPkg to properly > set up the serial port on boards using a non-standard clock rate. > > Signed-off-by: Matt DeVillier > Cha

[edk2-devel] [PATCH v2] DynamicTablesPkg/AmlLib: Enumerate memory attributes

2023-10-05 Thread Jeshua Smith via groups.io
AmlCodeGenRdQWordMemory's and AmlCodeGenRdDWordMemory's Cacheable and MemoryRangeType parameters treat specific values as having specific meanings as defined by the spec. This change adds enums to map those meanings to their corresponding values. Signed-off-by: Jeshua Smith --- Notes: v2: based

[edk2-devel] [PATCH v2] BaseStackCheckLib: Fix STACK FAULT message

2023-10-05 Thread Jake Garver via groups.io
__builtin_return_address returns a pointer, not a string. Fix the STACK FAULT message in BaseStackCheckLib appropriately. Signed-off-by: Jake Garver --- MdePkg/Library/BaseStackCheckLib/BaseStackCheckGcc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MdePkg/Library/Base

Re: [edk2-devel] [edk2-discuss] PLDM messages via MCTP over KCS

2023-10-05 Thread Konstantin Aladyshev
Sorry for many messages today, but I have one more observation. I think the MCTP code should set specific 'AdditionalTransferError' for the caller when it fails on each of the response header checks: https://github.com/changab/edk2-platforms/blob/5af7ca1555863288bd2887ca465ad07d74b9868e/Features/M

Re: [edk2-devel] [PATCH V1 1/1] uefi-sct/SctPkg: RouteConfig() returns EFI_ACCESS_DENIED passes with warning

2023-10-05 Thread G Edhaya Chandran
The solution is upstreamed thorugh the commit: https://github.com/tianocore/edk2-test/commit/81dfa8d53d4290366ae41e1f4c2ed6d6c5016c07 Thank you all. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109357): https://edk2.groups.io/g/devel/m

[edk2-devel] Now: TianoCore edk2-test Bug Triage Meeting - Thursday, October 5, 2023 #cal-notice

2023-10-05 Thread Group Notification
*TianoCore edk2-test Bug Triage Meeting* *When:* Thursday, October 5, 2023 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://armltd.zoom.us/j/91247522013?pwd=ei9nUndTbG9oWEROS2M1aVREZkpiQT09&from=addon *Organizer:* Edhaya Chandran edhaya.chand...@arm.com ( edhaya.chand...@arm.com?su

[edk2-devel] Event: TianoCore edk2-test Bug Triage Meeting - Thursday, October 5, 2023 #cal-reminder

2023-10-05 Thread Group Notification
*Reminder: TianoCore edk2-test Bug Triage Meeting* *When:* Thursday, October 5, 2023 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://armltd.zoom.us/j/91247522013?pwd=ei9nUndTbG9oWEROS2M1aVREZkpiQT09&from=addon *Organizer:* Edhaya Chandran edhaya.chand...@arm.com ( edhaya.chand...@

Re: [edk2-devel] [PATCH v4 20/28] MdeModulePkg: Add Additional Profiles to SetMemoryProtectionsLib

2023-10-05 Thread Laszlo Ersek
On 10/5/23 12:23, Gerd Hoffmann wrote: > Hi, > An Arm compatible PEIM instance of QemuFwCfgLib will need to be created. I'm happy to look into it, but I don't want to hang up this patch series on that addition. Instead, I'll set the protection policy for ArmVirtPkg to the equ

Re: [edk2-devel] [edk2-discuss] PLDM messages via MCTP over KCS

2023-10-05 Thread Konstantin Aladyshev
I was thinking more about it and I think the right solution would be to move these checks to the EDKII_PLDM_SMBIOS_TRANSFER_PROTOCOL code (i.e. https://github.com/changab/edk2-platforms/blob/MCTP_OVER_KCS_UPDATE/Features/ManageabilityPkg/Universal/PldmSmbiosTransferDxe/PldmSmbiosTransferDxe.c) Be

Re: [edk2-devel] [edk2-discuss] PLDM messages via MCTP over KCS

2023-10-05 Thread Konstantin Aladyshev
Also I see that the 'PldmProtocolCommon' code contains array of expected response sizes for every supported PLDM command: https://github.com/changab/edk2-platforms/blob/5af7ca1555863288bd2887ca465ad07d74b9868e/Features/ManageabilityPkg/Universal/PldmProtocol/Common/PldmProtocolCommon.c#L24 I'm not

Re: [edk2-devel] [PATCH v3 2/2] StandaloneMmPkg: Arm: Update to use the new StandaloneMmCpu driver

2023-10-05 Thread Sami Mujawar
Hi Tuan, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 28/09/2023 10:14 pm, Tuan Phan wrote: Update entry point library for Arm to use the new architecture independent StandaloneMmCpu driver. Signed-off-by: Tuan Phan Reviewed-

Re: [edk2-devel] [PATCH v1 2/2] MdeModulePkg/Bus/Usb/UsbMouseDxe: Fix MISSING_BREAK Coverity issues

2023-10-05 Thread Leif Lindholm
On Wed, Oct 04, 2023 at 18:46:58 +, Michael D Kinney wrote: > I do not prefer special comments for one static analyzer. > > Is there an alternative design/implementation of this code > to make it more readable and not trigger any static analysis > false positives? Not the tidiest, but could r

Re: [edk2-devel] [PATCH v4 20/28] MdeModulePkg: Add Additional Profiles to SetMemoryProtectionsLib

2023-10-05 Thread Gerd Hoffmann
Hi, > > > An Arm compatible PEIM instance of QemuFwCfgLib will need to be created. > > > I'm happy to look into it, but I don't want to hang up this patch series > > > on > > > that addition. Instead, I'll set the protection policy for ArmVirtPkg to > > > the equivalent of the new GrubCompat pr

Re: [edk2-devel] [PATCH 1/1] ArmPkg: Add Pcd to disable EFI_MEMORY_ATTRIBUTE_PROTOCOL

2023-10-05 Thread Gerd Hoffmann
On Thu, Oct 05, 2023 at 10:23:25AM +0200, Laszlo Ersek wrote: > On 10/5/23 08:31, Nhi Pham via groups.io wrote: > > Hi Ard, Oliver, > > > > I'm investigating the crash on grub2/shim loader due to the added > > EFI_MEMORY_ATTRIBUTE_PROTOCOL when rebasing. I found this interesting > > patch and went

Re: [edk2-devel] [edk2-discuss] PLDM messages via MCTP over KCS

2023-10-05 Thread Konstantin Aladyshev
Shouldn't we update the PLDM protocol's 'PldmSubmit' function to receive 'MctpSrcEID'/'MctpDestEID' as incoming parameters? Or maybe add some 'PldmInit' function to set those parameters for further PLDM communication? Because right now the MCTP EIDs are fixed to PCDs with no flexibility https://git

Re: [edk2-devel] [PATCH v4 20/28] MdeModulePkg: Add Additional Profiles to SetMemoryProtectionsLib

2023-10-05 Thread Gerd Hoffmann
Hi, > On x86, PEI can use IO ports (no page tables), but that's not available > on ARM. I don't recall off-hand where / when exactly page tables are set > up during ArmVirtQemu boot. It also changed roughly one year ago, Ard updated the arm platform setup to turn on paging much earlier (for w^x

Re: [edk2-devel] [PATCH 1/1] ArmPkg: Add Pcd to disable EFI_MEMORY_ATTRIBUTE_PROTOCOL

2023-10-05 Thread Laszlo Ersek
On 10/5/23 08:31, Nhi Pham via groups.io wrote: > Hi Ard, Oliver, > > I'm investigating the crash on grub2/shim loader due to the added > EFI_MEMORY_ATTRIBUTE_PROTOCOL when rebasing. I found this interesting > patch and went through on the discussion, I am still not sure the > conclusion on this p

Re: [edk2-devel] [PATCH v4 20/28] MdeModulePkg: Add Additional Profiles to SetMemoryProtectionsLib

2023-10-05 Thread Laszlo Ersek
On 10/4/23 18:31, Taylor Beebe wrote: > > On 10/4/23 1:46 AM, Gerd Hoffmann wrote: >> On Fri, Sep 29, 2023 at 12:52:35PM -0700, Taylor Beebe wrote: >>> I can also update ArmVirtPkg to disable execution protection >>> for EfiLoaderData by default until fw_cfg parsing >>> support is added to ArmVirt