__builtin_return_address returns a pointer, not a string. Fix the STACK
FAULT message in BaseStackCheckLib appropriately.
Signed-off-by: Jake Garver <j...@nvidia.com>
---
MdePkg/Library/BaseStackCheckLib/BaseStackCheckGcc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/MdePkg/Library/BaseStackCheckLib/BaseStackCheckGcc.c
b/MdePkg/Library/BaseStackCheckLib/BaseStackCheckGcc.c
index 0d2918668e..ea168841b6 100644
--- a/MdePkg/Library/BaseStackCheckLib/BaseStackCheckGcc.c
+++ b/MdePkg/Library/BaseStackCheckLib/BaseStackCheckGcc.c
@@ -6,6 +6,7 @@
to exiting the function. If the "canary" is overwritten __stack_chk_fail()
is called. This is GCC specific code.
+ Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
Copyright (c) 2012, Apple Inc. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -34,7 +35,7 @@ __stack_chk_fail (
{
UINT8 DebugPropertyMask;
- DEBUG ((DEBUG_ERROR, "STACK FAULT: Buffer Overflow in function %a.\n",
__builtin_return_address (0)));
+ DEBUG ((DEBUG_ERROR, "STACK FAULT: Buffer Overflow at 0x%p.\n",
RETURN_ADDRESS (0)));
//
// Generate a Breakpoint, DeadLoop, or NOP based on PCD settings even if
--
2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109359): https://edk2.groups.io/g/devel/message/109359
Mute This Topic: https://groups.io/mt/101779895/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
