On Wed, Oct 04, 2023 at 18:46:58 +0000, Michael D Kinney wrote:
> I do not prefer special comments for one static analyzer.
>
> Is there an alternative design/implementation of this code
> to make it more readable and not trigger any static analysis
> false positives?
Not the tidiest, but could rewrite as:
case 1:
case 2:
if (HidItem->Size == 1) {
<1 block>
}
<2 block>
That way we're making the code more expressive rather than keeping it
convoluted and adding a comment saying "code is convoluted".
Regards,
Leif
> > -----Original Message-----
> > From: [email protected] <[email protected]> On Behalf Of Ranbir
> > Singh
> > Sent: Tuesday, October 3, 2023 10:48 PM
> > To: [email protected]; [email protected]
> > Cc: Wu, Hao A <[email protected]>; Ni, Ray <[email protected]>;
> > Veeresh Sangolli <[email protected]>
> > Subject: [edk2-devel] [PATCH v1 2/2] MdeModulePkg/Bus/Usb/UsbMouseDxe:
> > Fix MISSING_BREAK Coverity issues
> >
> > From: Ranbir Singh <[email protected]>
> >
> > The function GetNextHidItem has a switch-case code in which the
> > case 1: falls through to case 2: and then case 2: falls through
> > to case 3: in the block.
> >
> > While this may be intentional, it is not evident to any general
> > code reader as well as any static analyzer tool. Just adding
> >
> > // No break; here as this is an intentional fallthrough.
> >
> > as comment in between makes a reader as well as Coverity happy.
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4222
> >
> > Cc: Hao A Wu <[email protected]>
> > Cc: Ray Ni <[email protected]>
> > Co-authored-by: Veeresh Sangolli <[email protected]>
> > Signed-off-by: Ranbir Singh <[email protected]>
> > Signed-off-by: Ranbir Singh <[email protected]>
> > ---
> > MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c
> > b/MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c
> > index acc19acd98e0..bc9a4824208b 100644
> > --- a/MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c
> > +++ b/MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c
> > @@ -89,6 +89,10 @@ GetNextHidItem (
> > return StartPos;
> >
> > }
> >
> >
> >
> > + //
> >
> > + // No break; here as this is an intentional fallthrough
> >
> > + //
> >
> > +
> >
> > case 2:
> >
> > //
> >
> > // 2-byte data
> >
> > @@ -99,6 +103,10 @@ GetNextHidItem (
> > return StartPos;
> >
> > }
> >
> >
> >
> > + //
> >
> > + // No break; here as this is an intentional fallthrough
> >
> > + //
> >
> > +
> >
> > case 3:
> >
> > //
> >
> > // 4-byte data, adjust size
> >
> > --
> > 2.34.1
> >
> >
> >
> > -=-=-=-=-=-=
> > Groups.io Links: You receive all messages sent to this group.
> > View/Reply Online (#109309):
> > https://edk2.groups.io/g/devel/message/109309
> > Mute This Topic: https://groups.io/mt/101750274/1643496
> > Group Owner: [email protected]
> > Unsubscribe: https://edk2.groups.io/g/devel/unsub
> > [[email protected]]
> > -=-=-=-=-=-=
> >
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109350): https://edk2.groups.io/g/devel/message/109350
Mute This Topic: https://groups.io/mt/101750274/21656
Group Owner: [email protected]
Unsubscribe:
https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
