From: Ray Ni
Old implementation of RefreshMemoryAttributesFromMtrr directly
retrieves the MTRR register content and applies the MTRR cache type
to GCD database following the precedence order defined by SDM.
The code can updated to simply get all the memory cache types for all
memory through newl
Add Unit test of trrGetMemoryAttributesInMtrrSettings and
MtrrSetMemoryAttributesInMtrrSettings.
Signed-off-by: Ray Ni
Signed-off-by: Yuanhao Xie
Cc: Eric Dong
Cc: Rahul Kumar
Cc: Gerd Hoffmann
---
UefiCpuPkg/Library/MtrrLib/UnitTest/MtrrLibUnitTest.c | 36
--
Improve MtrrDebugPrintAllMtrrsWorker by making use of
MtrrGetMemoryAttributesInMtrrSettings.
Signed-off-by: Ray Ni
Cc: Eric Dong
Cc: Rahul Kumar
Cc: Gerd Hoffmann
---
UefiCpuPkg/Library/MtrrLib/MtrrLib.c | 45
++---
1 file changed, 10 insertions(+), 35
MtrrGetMemoryAttributesInMtrrSettings parses the MTRR settings
either from hardware or from the parameter and returns an
array containing the memory cache types of all memory addresses.
This API could elinimate the needs of following APIs:
1. MtrrGetMemoryAttributeInVariableMtr
2. MtrrGetFixedMtrr
From: Ray Ni
Update APIs related to set memory attributes to handle the fixed MTRR
is not always supported.
There are 3 APIs in MtrrLib that can set memory attributes:
1. MtrrSetMemoryAttributesInMtrrSettings
2. MtrrSetMemoryAttributeInMtrrSettings
3. MtrrSetMemoryAttribute
The general idea app
Update UnitTestMtrrSetAllMtrrs() for the case that fixed MtrrLib
is not always supported.
Signed-off-by: Yuanhao Xie
Cc: Eric Dong
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Cc: Ray Ni
---
UefiCpuPkg/Library/MtrrLib/UnitTest/MtrrLibUnitTest.c | 35
---
1 file changed,
From: Ray Ni
Update MtrrSetAllMtrrs to not access fixed MTRRs if CPU doesn't
support them.
Signed-off-by: Ray Ni
Signed-off-by: Yuanhao Xie
Cc: Eric Dong
Cc: Rahul Kumar
Cc: Gerd Hoffmann
---
UefiCpuPkg/Include/Library/MtrrLib.h | 9 ++---
UefiCpuPkg/Library/MtrrLib/MtrrLib.c | 26 ++
UnitTestMtrrGetFixedMtrr updated for the case that fixed MtrrLib
is not always supported.
Signed-off-by: Yuanhao Xie
Cc: Eric Dong
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Cc: Ray Ni
---
UefiCpuPkg/Library/MtrrLib/UnitTest/MtrrLibUnitTest.c | 13 +
1 file changed, 13 insertions(+)
diff
IsMtrrSupported() return true when either fixed mtrr supported or
variable mtrr suppored. In this case, rather than checking whether
MTRR is supported or not, we should specifically check for fixed MTRR
support.
Signed-off-by: Yuanhao Xie
Cc: Eric Dong
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Cc: Ray
Update UnitTestMtrrGetAllMtrrs() for the case that fixed MtrrLib
is not always supported
Signed-off-by: Yuanhao Xie
Cc: Eric Dong
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Cc: Ray Ni
---
UefiCpuPkg/Library/MtrrLib/UnitTest/MtrrLibUnitTest.c | 99
+
From: Ray Ni
The patch fixes the following issues in the original implementation:
1. MtrrSetting contains random value if MTRR is not supported.
2. Unconditionally access fixed MTRR on CPU that may not support
fixed MTRR.
3. The maximum number of Variable MTRR entries are initialized, while
From: Ray Ni
Signed-off-by: Ray Ni
Cc: Eric Dong
Cc: Rahul Kumar
Cc: Gerd Hoffmann
---
UefiCpuPkg/Library/MtrrLib/UnitTest/MtrrLibUnitTest.c | 43
---
UefiCpuPkg/Library/MtrrLib/UnitTest/Support.c | 24
+++-
2 files change
Update UnitTestMtrrGetDefaultMemoryType for the case the when Fixed
MTRRs are not supported.
The original implementation returns FALSE when either fixed MTRR isn't
supported or the number of variable MTRRs is 0. The correct behavior
should return FALSE only when both fixed MTRR isn't supported and
Update UnitTestGetFirmwareVariableMtrrCount for the case the when
Fixed MTRRs are not supported.
The original implementation returns FALSE when either fixed MTRR isn't
supported or the number of variable MTRRs is 0. The correct behavior
should return FALSE only when both fixed MTRR isn't supported
The previous implementation returns FALSE if either fixed MTRR is
unsupported or the number of variable MTRRs is 0. The correct behavior
is to return FALSE only when both fixed MTRR is unsupported and the
number of variable MTRRs is 0.
Signed-off-by: Ray Ni
Cc: Eric Dong
Cc: Rahul Kumar
Cc: Ger
From: Ray Ni
Add internal function MtrrLibIsMtrrSupported and
update IsMtrrSupported to call the new internal function.
Signed-off-by: Ray Ni
Cc: Eric Dong
Cc: Rahul Kumar
Cc: Gerd Hoffmann
---
UefiCpuPkg/Library/MtrrLib/MtrrLib.c | 83
+
Update MtrrLib modules to handle the absense of Fixed MTRRs
Update unit test of Update for the absense of Fixed MTRRs
Ray Ni (6):
UefiCpuPkg/MtrrLib: Add internal function MtrrLibIsMtrrSupported.
UefiCpuPkg/MtrrUnitTest: Update test to cover no-fixed-mtrr cases.
UefiCpuPkg/MtrrLib: Fix MtrrG
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Liu, Linus
> Sent: Tuesday, September 12, 2023 9:42 AM
> To: devel@edk2.groups.io
> Cc: Liu, Linus ; Zhang, Qi1 ; Kumar,
> Rahul R ; Yao, Jiewen ; Chen,
> Tina ; Chen, Xiao X
> Subject: [PATCH v3] Pyrite support - Secure erase is only
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
Tuesday, September 12, 2023
6:30pm to 7:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e34
On Tue, Sep 12, 2023 at 11:55:18 +0200, Pierre Gondois wrote:
> Hello Leif,
>
> On 9/12/23 11:35, Leif Lindholm wrote:
> > > diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
> > > b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
> > > index 9210c5091548..8e24cecdd77b 100644
> > > -
Hi Jeff,
On Tue, Sep 12, 2023 at 19:04:26 +, Jeff Brasen wrote:
> Regarding the signed-off-by I wasn't sure the right way to handle
> this. Vidya was the author of this patch and applied the signed off
> on our internal repo during development. I was upstreaming it on his
> behalf. I was unsur
Reviewed-by: Igor Kulchytskyy
Regards,
Igor
-Original Message-
From: Nickle Wang
Sent: Tuesday, September 12, 2023 3:02 AM
To: devel@edk2.groups.io
Cc: Abner Chang ; Igor Kulchytskyy ; Nick
Ramirez
Subject: [EXTERNAL] [PATCH v2 1/1] RedfishPkg/RedfishPlatformConfigDxe: fix can
not se
Regarding the signed-off-by I wasn't sure the right way to handle this. Vidya
was the author of this patch and applied the signed off on our internal repo
during development. I was upstreaming it on his behalf. I was unsure if I
should just replace his as I assumed just leaving his from this wou
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2948
XhciDxe uses the timer functionality provided by the
boot services table to detect timeout conditions. This
breaks the driver's ExitBootServices call back, as
CoreExitBootServices halts the timer before signaling
the ExitBootServices event. I
Delightful! Thank you for your swift response.
Would you mind telling me if this is the appropriate mailing list for questions
like such (and maybe some help)?
After posting I noticed that perhaps I ought have tagged my topic, which led me
to believe I must have missed the participation rules.
On 9/12/2023 10:04 AM, CrossedCarpet via groups.io wrote:
Greetings,
As newer laptops start lacking Ethernet ports, I started investigating
the possibility of using *USB Tethering* as a replacement, to *allow for
internet connection at boot*.
Current attempts at employing *ifconfig* to configur
Greetings,
As newer laptops start lacking Ethernet ports, I started investigating the
possibility of using *USB Tethering* as a replacement, to *allow for internet
connection at boot*.
Current attempts at employing *ifconfig* to configure a Tether connection
failed to display anything meaningful
On 9/12/23 17:02, Yao, Jiewen wrote:
> Hello
> I do not object the size increase.
>
> I am wondering if we need to take some action to control the size.
Yes, stop implementing new edk2 features, at least in the same one
generic firmware binary. :)
> Or we just increase it, again and again? Of cou
On 2023-09-12 14:07, Rebecca Cran via groups.io wrote:
On 9/12/2023 3:58 AM, Leif Lindholm via groups.io wrote:
So, it's really good that you add "known good" versions so that if
someone runs into a problem around toolchain version compatibility,
they know what to use. But anything in edk2-plat
Update readme for below topics:
- The call flow of BIOS Redfish provisioning scenario.
- The call flow of BIOS Redfish pending settings scenario.
- The call flow of Redfish feature driver dispatch.
- Redfish foundation driver stack design.
- The design of Redfish Platform Config Protocol.
- The des
On Tue, 12 Sept 2023 at 16:11, Michael D Kinney
wrote:
>
> Reviewed-by: Michael D Kinney
>
Thanks I'll queue this up
> > -Original Message-
> > From: Ard Biesheuvel
> > Sent: Tuesday, September 12, 2023 5:36 AM
> > To: devel@edk2.groups.io
> > Cc: Sunil V L ; Ard Biesheuvel
> > ; Yao,
Hello
I do not object the size increase.
I am wondering if we need to take some action to control the size.
Or we just increase it, again and again? Of course, more feature == more size
required.
May I know if there is up-limit from VMM perspective, such as KVM?
E.g. Can we support more than 16M
On Tue, 12 Sept 2023 at 16:19, Laszlo Ersek wrote:
>
> My usual IA32X64 and X64 builds fail for the NOOPT target, using GCC5:
>
> - IA32X64:
>
> > the required fv image size 0xdef130 exceeds the set fv image size
> > 0xd0
>
> - X64:
>
> > the required fv image size 0xd8f7b8 exceeds the set fv
On Tue, 12 Sept 2023 at 16:18, Laszlo Ersek wrote:
>
> "OvmfPkg/Include/IndustryStandard/Virtio095.h" defines the macro
> VIRTIO_SUBSYSTEM_CONSOLE with value 3; other locations in the tree already
> use it (such as ArmVirtPkg/PlatformBootManagerLib,
> OvmfPkg/VirtioSerialDxe). We should use it in
On 9/12/23 16:17, Laszlo Ersek wrote:
> "OvmfPkg/Include/IndustryStandard/Virtio095.h" defines the macro
> VIRTIO_SUBSYSTEM_CONSOLE with value 3; other locations in the tree already
> use it (such as ArmVirtPkg/PlatformBootManagerLib,
> OvmfPkg/VirtioSerialDxe). We should use it in
> OvmfPkg/Platfo
Series Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of VivianNK
> Sent: Wednesday, August 16, 2023 2:15 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH v2 0/7] Uncrustify GoogleTest update
>
> v1 -> v2:
> - Update commit message
My usual IA32X64 and X64 builds fail for the NOOPT target, using GCC5:
- IA32X64:
> the required fv image size 0xdef130 exceeds the set fv image size
> 0xd0
- X64:
> the required fv image size 0xd8f7b8 exceeds the set fv image size
> 0xd0
NOOPT is important for debugging (less confusin
"OvmfPkg/Include/IndustryStandard/Virtio095.h" defines the macro
VIRTIO_SUBSYSTEM_CONSOLE with value 3; other locations in the tree already
use it (such as ArmVirtPkg/PlatformBootManagerLib,
OvmfPkg/VirtioSerialDxe). We should use it in
OvmfPkg/PlatformBootManagerLib too, rather than the naked cons
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Ard Biesheuvel
> Sent: Tuesday, September 12, 2023 5:36 AM
> To: devel@edk2.groups.io
> Cc: Sunil V L ; Ard Biesheuvel
> ; Yao, Jiewen ; Andrew Fish
> ; Leif Lindholm ; Kinney, Michael
> D
> Subject: Re: [edk2-devel] [PATCH 1/1]
On 9/12/2023 3:58 AM, Leif Lindholm via groups.io wrote:
So, it's really good that you add "known good" versions so that if
someone runs into a problem around toolchain version compatibility,
they know what to use. But anything in edk2-platform should be kept up
to date so that it builds on curr
For the change in MdeModulePkg, Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Jeff Brasen
> 发送时间: 2023年9月12日 4:39
> 收件人: devel@edk2.groups.io
> 抄送: jian.j.w...@intel.com; gaolim...@byosoft.com.cn;
> dandan...@intel.com; zhichao@intel.com
> 主题: RE: [PATCH v2 0/2] dp command without ACPI
>
On Tue, 12 Sept 2023 at 14:16, Sunil V L wrote:
>
> Since I take care of maintaining the contents in RiscVVirt, update my entry
> from R to M.
>
> Cc: Ard Biesheuvel
> Cc: Jiewen Yao
> Cc: Andrew Fish
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Signed-off-by: Sunil V L
Acked-by: Ard Bieshe
Since I take care of maintaining the contents in RiscVVirt, update my entry
from R to M.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Signed-off-by: Sunil V L
---
Maintainers.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
On Tue, 12 Sept 2023 at 12:01, Leif Lindholm wrote:
>
> On Tue, Sep 12, 2023 at 07:42:30 +, Ard Biesheuvel wrote:
> > From: Ard Biesheuvel
> >
> > Jake reports that the IS_ARM_MEMORY_REGION_ATTRIBUTES_SECURE() macro is
> > no longer accurate since commit 852227a9d52e3cb9 ("ArmPkg/Mmu: Remove
On Tue, Sep 12, 2023 at 07:42:30 +, Ard Biesheuvel wrote:
> From: Ard Biesheuvel
>
> Jake reports that the IS_ARM_MEMORY_REGION_ATTRIBUTES_SECURE() macro is
> no longer accurate since commit 852227a9d52e3cb9 ("ArmPkg/Mmu: Remove
> handling of NONSECURE memory regions").
>
> Fortunately, it o
On Mon, Sep 11, 2023 at 11:44:12 -0600, Rebecca Cran wrote:
> Improve the Readme.md in Platform/Ampere:
>
> - At this point eMAG is irrelevant, and most people are likely
> using Altra systems. Drop mention of it.
> - Instead of mentioning the 'latest' versions of CentOS and Ubuntu
> (which wi
Hello Leif,
On 9/12/23 11:35, Leif Lindholm wrote:
Hi Jeff,
On Mon, Sep 11, 2023 at 23:48:57 +, Jeff Brasen wrote:
From: Vidya Sagar
Add helper functions to generate AML Resource Data describing I/O
ranges of four words long. API AmlCodeGenRdQWordIo () is exposed.
Reviewed-by: Shanker D
I have reviewed the ShellPkg part. Did you get it reviewed in the MdeModulePkg?
If yes, you can inform the maintainers of MdeModulePkg to raise the PR and
merge it.
Thanks,
Zhichao
> -Original Message-
> From: Jeff Brasen
> Sent: Tuesday, September 12, 2023 4:39 AM
> To: devel@edk2.gro
Hi Jeff,
On Mon, Sep 11, 2023 at 23:48:57 +, Jeff Brasen wrote:
> From: Vidya Sagar
>
> Add helper functions to generate AML Resource Data describing I/O
> ranges of four words long. API AmlCodeGenRdQWordIo () is exposed.
>
> Reviewed-by: Shanker Donthineni
The above isn't really applicab
From: Ard Biesheuvel
Jake reports that the IS_ARM_MEMORY_REGION_ATTRIBUTES_SECURE() macro is
no longer accurate since commit 852227a9d52e3cb9 ("ArmPkg/Mmu: Remove
handling of NONSECURE memory regions").
Fortunately, it only affects the NS bit in level 1 short descriptors,
which is ignored when e
Hello Jeff,
I had some trouble applying PATCH [1/2], but the changes look good
to me otherwise:
Reviewed-by: Pierre Gondois
Regards,
Pierre
On 9/12/23 01:48, Jeff Brasen wrote:
Use AmlCodeGenRdQWordIo() to generate the I/O range in _CRS instead of
AmlCodeGenRdDWordIo() to cater to the scenario
On 9/12/23 08:23, Sunil V L wrote:
> On Thu, Sep 07, 2023 at 04:58:25PM +0200, Laszlo Ersek wrote:
>> Explain how users can compose their pre-OS environment purely from
>> binaries they've built themselves.
>>
>> Cc: Andrei Warkentin
>> Cc: Ard Biesheuvel
>> Cc: Gerd Hoffmann
>> Cc: Jiewen Yao
Hello Jeff,
Thanks for the new serie, I think there is still a minor issue in the error
handling in this patch,
On 9/11/23 20:07, Jeff Brasen wrote:
Add support to add Return objects via AML that pass a single integer
argument to the named method.
Bug 4063340
All the patches have this Bug id,
On Tue, Sep 12, 2023 at 08:56:19AM +0200, Ard Biesheuvel wrote:
> On Tue, 12 Sept 2023 at 08:23, Sunil V L wrote:
> >
> > On Thu, Sep 07, 2023 at 04:58:25PM +0200, Laszlo Ersek wrote:
> > > Explain how users can compose their pre-OS environment purely from
> > > binaries they've built themselves.
Hi Igor,
Version 2 is here: https://edk2.groups.io/g/devel/message/108516 Please help me
to review this while you have chance.
Thanks,
Nickle
> -Original Message-
> From: Igor Kulchytskyy
> Sent: Thursday, August 3, 2023 9:27 PM
> To: Nickle Wang ; devel@edk2.groups.io
> Cc: Abner Chan
StatementValue->Buffer is converted from ASCII to Unicode by caller
already so we don't have to convert it again.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
.../RedfishPlatformConfigDxe.c| 11 +--
1 file changed, 5 inse
56 matches
Mail list logo
