Hello I do not object the size increase. I am wondering if we need to take some action to control the size. Or we just increase it, again and again? Of course, more feature == more size required.
May I know if there is up-limit from VMM perspective, such as KVM? E.g. Can we support more than 16MiB ? More than 128MiB? Thank you Yao, Jiewen > -----Original Message----- > From: Ard Biesheuvel <a...@kernel.org> > Sent: Tuesday, September 12, 2023 10:59 PM > To: Laszlo Ersek <ler...@redhat.com> > Cc: devel@edk2.groups.io; Ard Biesheuvel <ardb+tianoc...@kernel.org>; Gerd > Hoffmann <kra...@redhat.com>; Yao, Jiewen <jiewen....@intel.com>; Justen, > Jordan L <jordan.l.jus...@intel.com> > Subject: Re: [PATCH] OvmfPkg: raise DXEFV size to 14.5 MB in the traditional > platform FDFs > > On Tue, 12 Sept 2023 at 16:19, Laszlo Ersek <ler...@redhat.com> wrote: > > > > My usual IA32X64 and X64 builds fail for the NOOPT target, using GCC5: > > > > - IA32X64: > > > > > the required fv image size 0xdef130 exceeds the set fv image size > > > 0xd00000 > > > > - X64: > > > > > the required fv image size 0xd8f7b8 exceeds the set fv image size > > > 0xd00000 > > > > NOOPT is important for debugging (less confusing behavior with gdb, and > > much less confusing disassembly). > > > > Raise the DXEFV size to 14.5 MB (14 MB would work, but cut it too close > > for IA32X64). > > > > After this patch: > > > > - IA32: > > > > > DXEFV [83%Full] 15204352 (0xe80000) total, 12718784 (0xc212c0) used, > > > 2485568 (0x25ed40) free > > > > - IA32X64: > > > > > DXEFV [96%Full] 15204352 (0xe80000) total, 14610736 (0xdef130) used, > > > 593616 (0x90ed0) free > > > > - X64: > > > > > DXEFV [93%Full] 15204352 (0xe80000) total, 14219192 (0xd8f7b8) used, > > > 985160 (0xf0848) free > > > ... > > > > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > > Cc: Gerd Hoffmann <kra...@redhat.com> > > Cc: Jiewen Yao <jiewen....@intel.com> > > Cc: Jordan Justen <jordan.l.jus...@intel.com> > > Signed-off-by: Laszlo Ersek <ler...@redhat.com> > > Acked-by: Ard Biesheuvel <a...@kernel.org> > > > --- > > OvmfPkg/OvmfPkgIa32.fdf | 6 +++--- > > OvmfPkg/OvmfPkgIa32X64.fdf | 6 +++--- > > OvmfPkg/OvmfPkgX64.fdf | 6 +++--- > > 3 files changed, 9 insertions(+), 9 deletions(-) > > > > diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf > > index 4c9be963a74d..383613e54b14 100644 > > --- a/OvmfPkg/OvmfPkgIa32.fdf > > +++ b/OvmfPkg/OvmfPkgIa32.fdf > > @@ -62,10 +62,10 @@ [FD.OVMF_CODE] > > > > [FD.MEMFD] > > BaseAddress = $(MEMFD_BASE_ADDRESS) > > -Size = 0xE00000 > > +Size = 0xF80000 > > ErasePolarity = 1 > > BlockSize = 0x10000 > > -NumBlocks = 0xE0 > > +NumBlocks = 0xF8 > > > > 0x000000|0x006000 > > > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecPageTablesBase|gUefiOvmfPkgToken > SpaceGuid.PcdOvmfSecPageTablesSize > > @@ -86,7 +86,7 @@ [FD.MEMFD] > > > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfPeiMemFvBase|gUefiOvmfPkgTokenSpa > ceGuid.PcdOvmfPeiMemFvSize > > FV = PEIFV > > > > -0x100000|0xD00000 > > +0x100000|0xE80000 > > > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfDxeMemFvBase|gUefiOvmfPkgTokenSpa > ceGuid.PcdOvmfDxeMemFvSize > > FV = DXEFV > > > > diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf > > index 7f599f15e341..3cec3d0c8790 100644 > > --- a/OvmfPkg/OvmfPkgIa32X64.fdf > > +++ b/OvmfPkg/OvmfPkgIa32X64.fdf > > @@ -62,10 +62,10 @@ [FD.OVMF_CODE] > > > > [FD.MEMFD] > > BaseAddress = $(MEMFD_BASE_ADDRESS) > > -Size = 0xE00000 > > +Size = 0xF80000 > > ErasePolarity = 1 > > BlockSize = 0x10000 > > -NumBlocks = 0xE0 > > +NumBlocks = 0xF8 > > > > 0x000000|0x006000 > > > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecPageTablesBase|gUefiOvmfPkgToken > SpaceGuid.PcdOvmfSecPageTablesSize > > @@ -86,7 +86,7 @@ [FD.MEMFD] > > > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfPeiMemFvBase|gUefiOvmfPkgTokenSpa > ceGuid.PcdOvmfPeiMemFvSize > > FV = PEIFV > > > > -0x100000|0xD00000 > > +0x100000|0xE80000 > > > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfDxeMemFvBase|gUefiOvmfPkgTokenSpa > ceGuid.PcdOvmfDxeMemFvSize > > FV = DXEFV > > > > diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf > > index 41912fc1bece..9c35b6e848a2 100644 > > --- a/OvmfPkg/OvmfPkgX64.fdf > > +++ b/OvmfPkg/OvmfPkgX64.fdf > > @@ -62,10 +62,10 @@ [FD.OVMF_CODE] > > > > [FD.MEMFD] > > BaseAddress = $(MEMFD_BASE_ADDRESS) > > -Size = 0xE00000 > > +Size = 0xF80000 > > ErasePolarity = 1 > > BlockSize = 0x10000 > > -NumBlocks = 0xE0 > > +NumBlocks = 0xF8 > > > > 0x000000|0x006000 > > > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecPageTablesBase|gUefiOvmfPkgToken > SpaceGuid.PcdOvmfSecPageTablesSize > > @@ -101,7 +101,7 @@ [FD.MEMFD] > > > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfPeiMemFvBase|gUefiOvmfPkgTokenSpa > ceGuid.PcdOvmfPeiMemFvSize > > FV = PEIFV > > > > -0x100000|0xD00000 > > +0x100000|0xE80000 > > > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfDxeMemFvBase|gUefiOvmfPkgTokenSpa > ceGuid.PcdOvmfDxeMemFvSize > > FV = DXEFV > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108541): https://edk2.groups.io/g/devel/message/108541 Mute This Topic: https://groups.io/mt/101315785/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-