Re: [edk2-devel] [PATCH] MdePkg: Code optimization to SMM InternalAllocateAlignedPages

2023-05-17 Thread Ni, Ray
Dun, I can understand what you are trying to describe in the commit message. I have some suggestions/questions that might help you refine the commit message a bit better. Code changes look good to me. Thanks, Ray > -Original Message- > From: Tan, Dun > Sent: Thursday, May 18, 2023 2:37

[edk2-devel] [PATCH] MdePkg: Code optimization to SMM InternalAllocateAlignedPages

2023-05-17 Thread duntan
This commit is code optimization to InternalAllocateAlignedPages of SmmMemoryAllocationLib which can reduce free memory fragments. Also it can reduce one pre-allocation page. Let's take a simple example: The expected pages size is 8KB, Alignment value is 8KB. In original InternalAllocateAlignedPa

Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib

2023-05-17 Thread Andrei Warkentin
Thank you, Michael, appreciate your help! > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, May 17, 2023 6:48 PM > To: Warkentin, Andrei ; > devel@edk2.groups.io; Gao, Liming > Cc: Sunil V L ; Kinney, Michael D > > Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-bac

Re: [edk2-devel] [PATCH] MdePkg Include: Fix typos

2023-05-17 Thread Michael Kubacki
The spell check CI plugin is in "AuditOnly" mode so it is not actually failing the build. https://github.com/tianocore/edk2/blob/master/MdePkg/MdePkg.ci.yaml#L166 This has more info about how to configure the plugin in each package CI YAML file - https://github.com/tianocore/edk2/tree/master/

Re: [edk2-devel] [edk2-platforms][PATCH 2/2] ManageabilityPkg/IpmiFrb: Add to ManageabilityPkg

2023-05-17 Thread Nickle Wang via groups.io
Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner > via groups.io > Sent: Saturday, May 13, 2023 8:33 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) > ; Nickle Wang > Subject: [edk

Re: [edk2-devel] [edk2-platforms][PATCH 2/2] ManageabilityPkg/IpmiBmcAcpi: Add to ManageabilityPkg

2023-05-17 Thread Nickle Wang via groups.io
Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner > via groups.io > Sent: Saturday, May 13, 2023 11:49 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) > ; Nickle Wang > Subject: [ed

Re: [edk2-devel] [edk2-platforms][PATCH 1/2] ManageabilityPkg/IpmiFrb: IPMI BMC ACPI Driver

2023-05-17 Thread Nickle Wang via groups.io
Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner > via groups.io > Sent: Saturday, May 13, 2023 11:49 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) > ; Nickle Wang ; Tinh > Nguyen

Re: [edk2-devel] [edk2-platforms][PATCH 2/2] ManageabilityPkg/IpmiSolStatus: Add to ManageabilityPkg

2023-05-17 Thread Nickle Wang via groups.io
Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner > via groups.io > Sent: Friday, May 12, 2023 3:29 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) > ; Nickle Wang > Subject: [edk2-

Re: [edk2-devel] [edk2-platforms][PATCH 1/2] ManageabilityPkg/IpmiSolStatus: IPMI Serail over Lan Driver

2023-05-17 Thread Nickle Wang via groups.io
Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner > via groups.io > Sent: Friday, May 12, 2023 3:29 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) > ; Nickle Wang ; Tinh > Nguyen >

Re: 回复: [edk2-devel] [PATCH v1 1/1] pip-requirements.txt: Update edk2 pip modules

2023-05-17 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Wednesday, May 17, 2023 5:50 PM > To: devel@edk2.groups.io; Kinney, Michael D ; > Gao, Liming ; rebe...@bsdio.com; 'Liming Gao' > > Cc: 'Sean Brogan' ; 'Andrew Fish' >

Re: 回复: [edk2-devel] [PATCH v1 1/1] pip-requirements.txt: Update edk2 pip modules

2023-05-17 Thread Michael D Kinney
Is there a PR with EDK II CI results? Mike > -Original Message- > From: Michael Kubacki > Sent: Wednesday, May 17, 2023 5:13 PM > To: devel@edk2.groups.io; Gao, Liming ; > rebe...@bsdio.com; Kinney, Michael D ; > 'Liming Gao' > Cc: 'Sean Brogan' ; 'Andrew Fish' > ; 'Leif Lindholm' > Su

Re: 回复: [edk2-devel] [PATCH v1 1/1] pip-requirements.txt: Update edk2 pip modules

2023-05-17 Thread Michael Kubacki
Thanks Liming. I haven't seen any R-b tags yet. Can I please get some reviews? On 5/16/2023 9:32 PM, gaoliming via groups.io wrote: Rebecca: I am OK for this change to catch the stable tag 202305. Thanks Liming -邮件原件- 发件人: devel@edk2.groups.io 代表 Rebecca Cran 发送时间: 2023年5月17日 1:31

Re: [edk2-devel] [edk2-stable202305 PATCH 1/1] Rename GCC5 toolchain references in docs and scripts to GCC

2023-05-17 Thread Michael D Kinney
Please add Cc lines for all package owners so it matches typical email filters. I agree this is a good cleanup to use GCC instead of GCC5 consistently. We should let each package owner provide feedback on if this change should go in before or after the stable tag. It is not a critical bug fix,

[edk2-devel] [PATCH v2 5/6] Uefipayloadpkg Enable TPM measured boot

2023-05-17 Thread Subash Lakkimsetti
From: Subash Lakkimsetti Update the packages to support TPM and measured boot in uefi payload. Measured boot can be controlled using flag MEASURED_BOOT_ENABLE. Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: Subash Lakkimsetti --- UefiPayloadPkg/UefiPayloa

[edk2-devel] [PATCH v2 4/6] UefiPayloadPkg: Add secure boot configurations

2023-05-17 Thread Subash Lakkimsetti
From: Subash Lakkimsetti Add the required modules for secure boot in UefiPayloadPkg. SECURE_BOOT_ENABLE flag added to control the secure boot feature. Security modules are added as seperate FV. Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: Subash Lakkimsett

[edk2-devel] [PATCH v2 6/6] UefiPayloadPkg: Add secure boot definitions to ci build

2023-05-17 Thread Subash Lakkimsetti
From: Subash Lakkimsetti Define the build flags for secure boot and measure boot for ci builds Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: Subash Lakkimsetti --- UefiPayloadPkg/UefiPayloadPkg.ci.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[edk2-devel] [PATCH v2 2/6] UefiPayloadPkg: Add secureboot information HOBs

2023-05-17 Thread Subash Lakkimsetti
From: Subash Lakkimsetti This patch add the HOB fpr secure and measured boot information. This is populated by bootloader phase and uefipayload pkg uses this info to sync the TPM info PCDs. Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: Subash Lakkimsetti -

[edk2-devel] [PATCH v2 3/6] UefiPayloadPkg: Uninstall the TPM2 ACPI if present

2023-05-17 Thread Subash Lakkimsetti
From: Subash Lakkimsetti Bootloader supports multiple payload and TPM2 ACPI tables are updated at bootloader phase. When UEFI is used payload these will be duplicates. The tables are to be uninstalled before updating the TCG2ACPI tables to avoid duplicates. Cc: Guo Dong Cc: Ray Ni Cc: Sean Rho

[edk2-devel] [PATCH v2 1/6] MdeModulePkg: universal payload HOB for secure boot info

2023-05-17 Thread Subash Lakkimsetti
From: Subash Lakkimsetti Add the hob structure header for universal payload for secure boot and measure boot information from bootloaders. Universal payload spec definied at https://universalscalablefirmware.github.io/documentation/2_universal_payload.html Cc: Zhiguang Liu Cc: Ray Ni Cc: Gua G

[edk2-devel] [PATCH v2 0/6] Universal payload secure boot and measured boot

2023-05-17 Thread Subash Lakkimsetti
From: Subash Lakkimsetti Support added in universal payload to enable secure boot and measured boot Hob structure header for universal payload for secure boot and measure boot information from bootloaders as per the universal payload spec defined at https://universalscalablefirmware.github.io/

Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib

2023-05-17 Thread Michael D Kinney
Merged: https://github.com/tianocore/edk2/pull/4406 > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, May 17, 2023 11:03 AM > To: Warkentin, Andrei ; devel@edk2.groups.io; > Gao, Liming > Cc: Sunil V L ; Kinney, Michael D > > Subject: RE: [edk2-devel] [PATCH v7 0/3] RI

Re: [edk2-devel] [PATCH 0/3] OvmfPkg: gigabyte page tweaks

2023-05-17 Thread Pedro Falcato
On Wed, May 17, 2023 at 11:24 AM Gerd Hoffmann wrote: > > > > Gerd Hoffmann (3): > OvmfPkg/PlatformInitLib: check PcdUse1GPageTable > OvmfPkg/OvmfPkgIa32X64: enable 1G pages > OvmfPkg/MicrovmX64: enable 1G pages > > OvmfPkg/Microvm/MicrovmX64.dsc | 3 +++ > OvmfPkg/Ovmf

[edk2-devel] [edk2-stable202305 PATCH 0/1] Rename GCC5 to GCC in filenames, scripts and documentation

2023-05-17 Thread Rebecca Cran
Rename GCC5 toolchain references in docs and scripts to GCC The GCC5 toolchain has been deprecated, and GCC should be used going forward. Update references to GCC5 in filenames, scripts and documentation. Branch: https://github.com/bcran/edk2/tree/toolchain_docs PR https://github.com/tia

[edk2-devel] [edk2-stable202305 PATCH 1/1] Rename GCC5 toolchain references in docs and scripts to GCC

2023-05-17 Thread Rebecca Cran
The GCC5 toolchain has been deprecated, and GCC should be used going forward. Update references to GCC5 in filenames, scripts and documentation. Signed-off-by: Rebecca Cran --- .azurepipelines/{Ubuntu-GCC5.yml => Ubuntu-GCC.yml}| 4 ++-- .azurepipelines/templates/platf

Re: [edk2-devel] [PATCH] MdePkg Include: Fix typos

2023-05-17 Thread Giri Mudusuru via groups.io
Hi Liming, Most of the errors except below macro are in comments. Not sure if CI SpellCheck is skipping comments? I can revert the macro fix from this patch. I noticed that it is duplicated in Acpi.h and Acpi10.h. Thanks, -Giri > On May 16, 2023, at 6:49 AM, gaoliming wrote: > > Giri: > Edk2

Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib

2023-05-17 Thread Michael D Kinney
I will take care of it today. Mike > -Original Message- > From: Warkentin, Andrei > Sent: Tuesday, May 16, 2023 10:27 PM > To: Kinney, Michael D ; devel@edk2.groups.io; > Gao, Liming > Cc: Sunil V L > Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib > > Save for th

Re: [edk2-devel] [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug print is incorrect

2023-05-17 Thread Giri Mudusuru via groups.io
> Please help to use %p for printing pointers. Thanks for approvals. To clarify the value is 64-bit capability register value. Thanks, -Giri > On May 17, 2023, at 9:49 AM, Wu, Hao A wrote: > > Thanks for the patch, inline comment below: > > >> -Original Message- >> From: Giri Mudusuru

[edk2-devel] [PATCH 2/2] ArmPkg/SmbiosMiscDxe: Remove redundant assign for SmbiosHandle

2023-05-17 Thread Minh Nguyen via groups.io
This helps to remove redundant assign for SmbiosHandle. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar Signed-off-by: Minh Nguyen --- ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/

[edk2-devel] [PATCH v1 1/1] MdeModulePkg: UsbBusDxe: Build Descriptor table after resetting port

2023-05-17 Thread brit.chesley via groups.io
From: Britton Chesley Fixed a bug which led to an ASSERT due to the USB device context being maintained after a port reset, but the underlying XHCI context was uninitialized. Added build descriptor table call in UsbIoPortReset Cc: Jian J Wang Cc: Liming Gao Cc: Hao A Wu Cc: Ray Ni Signed-off

[edk2-devel] [PATCH 1/2] ArmPkg/SmbiosMiscDxe: Fix procedure to get handle of SMBIOS records

2023-05-17 Thread Minh Nguyen via groups.io
To iterate entire SMBIOS table records for searching specific records, "SmbiosHandle" input need to be as "SMBIOS_HANDLE_PI_RESERVED". This patch helps to fix that. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar Signed-off-by: Minh Nguyen --- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Smbio

[edk2-devel] [PATCH 0/2] Fix an issue in SmbiosMiscDxe module

2023-05-17 Thread Minh Nguyen via groups.io
These patches help to fix an issue in SmbiosMiscDxe and remove redundant asign for SmbiosHandle. Minh Nguyen (2): ArmPkg/SmbiosMiscDxe: Fix procedure to get handle of SMBIOS records ArmPkg/SmbiosMiscDxe: Remove redundant assign for SmbiosHandle ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMi

[edk2-devel] [PATCH 1/1] CryptoPkg: Add new API to get PKCS7 Signature

2023-05-17 Thread Minh Nguyen via groups.io
From: Tam Chi Nguyen This patch adds a new Pkcs7GetSignature API to support extracting the signature data from PKCS7 Certificate. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Minh Nguyen --- CryptoPkg/Include/Library/BaseCryptLib.h | 29 ++

[edk2-devel] Now: UEFI Memory Map, GCD, Page Table discussion - ARM/X86 - Wednesday, May 17, 2023 #cal-notice

2023-05-17 Thread Group Notification
*UEFI Memory Map, GCD, Page Table discussion - ARM/X86* *When:* Wednesday, May 17, 2023 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_YTk4ZDU3YjItODkxZC00MTdmLTlkZmUtYThkNGQ0ZWYyMDZh%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e3

[edk2-devel] Event: UEFI Memory Map, GCD, Page Table discussion - ARM/X86 - Wednesday, May 17, 2023 #cal-reminder

2023-05-17 Thread Group Notification
*Reminder: UEFI Memory Map, GCD, Page Table discussion - ARM/X86* *When:* Wednesday, May 17, 2023 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_YTk4ZDU3YjItODkxZC00MTdmLTlkZmUtYThkNGQ0ZWYyMDZh%40thread.v2/0?context=%7b%22Tid%22%3a%224

Re: [edk2-devel] [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug print is incorrect

2023-05-17 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel > Sent: Wednesday, May 17, 2023 7:46 PM > To: devel@edk2.groups.io; Wu, Hao A > Cc: Giri Mudusuru ; Ni, Ray ; Wang, > Jian J ; Gao, Liming ; > Andrew Fish > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg SdMm

Re: [edk2-devel] [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug print is incorrect

2023-05-17 Thread Ard Biesheuvel
On Wed, 17 May 2023 at 06:19, Wu, Hao A wrote: > > Thanks for the patch, inline comment below: > > > > -Original Message- > > From: Giri Mudusuru > > Sent: Friday, May 12, 2023 5:55 PM > > To: devel@edk2.groups.io > > Cc: Giri Mudusuru ; Wu, Hao A ; Ni, > > Ray ; Wang, Jian J ; Gao, Limin

Re: [edk2-devel] [PATCH 1/1] Maintainers: add myself as reviewer for sbsa-ref

2023-05-17 Thread Leif Lindholm
On 2023-05-16 11:19, Graeme Gregory wrote: On Mon, May 15, 2023 at 04:33:52PM +0200, Marcin Juszkiewicz wrote: At Linaro I work on sbsa-ref, know direction it goes. May not get code details each time. This is probably a good idea, someone else who is actively using the machine Reviewed-by: G

[edk2-devel] [PATCH 2/3] OvmfPkg/OvmfPkgIa32X64: enable 1G pages

2023-05-17 Thread Gerd Hoffmann
Reduces the memory footprint and speeds up booting. Signed-off-by: Gerd Hoffmann --- OvmfPkg/OvmfPkgIa32X64.dsc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc index 25974230a27e..c89257a9977e 100644 --- a/OvmfPkg/OvmfPkgIa32X64.dsc

[edk2-devel] [PATCH 1/3] OvmfPkg/PlatformInitLib: check PcdUse1GPageTable

2023-05-17 Thread Gerd Hoffmann
If PcdUse1GPageTable is not enabled restrict the physical address space used to 1TB, to limit the amount of memory needed for identity mapping page tables. The same already happens in case the processor has no support for gigabyte pages. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Library/Platform

[edk2-devel] [PATCH 0/3] OvmfPkg: gigabyte page tweaks

2023-05-17 Thread Gerd Hoffmann
Gerd Hoffmann (3): OvmfPkg/PlatformInitLib: check PcdUse1GPageTable OvmfPkg/OvmfPkgIa32X64: enable 1G pages OvmfPkg/MicrovmX64: enable 1G pages OvmfPkg/Microvm/MicrovmX64.dsc | 3 +++ OvmfPkg/OvmfPkgIa32X64.dsc | 3 +++ OvmfPkg/Library/Platfo

[edk2-devel] [PATCH 3/3] OvmfPkg/MicrovmX64: enable 1G pages

2023-05-17 Thread Gerd Hoffmann
Reduces the memory footprint and speeds up booting. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Microvm/MicrovmX64.dsc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc b/OvmfPkg/Microvm/MicrovmX64.dsc index 5f671bc3840d..46f951ae058f 100644 --- a/OvmfPkg/Microvm

Re: [edk2-devel] [Patch V4 04/15] MdeModulePkg: Remove RO and NX protection when unset guard page

2023-05-17 Thread duntan
Hi Kun, When we unset a guarded page to unguarded, from page table perspective, it's to set a non-present page to present. I think it's reasonable that we should specific memory attribute to appropriate value when map non-present range to present. In smm initial page table, free page is set to

Re: [edk2-devel] [PATCH v1 1/1] ArmPkg: CpuDxe: Sync GCD Capabilities With Page Table Attributes

2023-05-17 Thread Ni, Ray
I created one event in https://edk2.groups.io/g/devel/calendar. Microsoft Teams meeting link: https://teams.microsoft.com/l/meetup-join/19%3ameeting_YTk4ZDU3YjItODkxZC00MTdmLTlkZmUtYThkNGQ0ZWYyMDZh%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-8496-4ed7712e255d%22%2c%22Oid%22%3a%2255

[edk2-devel] Event: UEFI Memory Map, GCD, Page Table discussion - ARM/X86 - Wednesday, May 17, 2023 #cal-invite

2023-05-17 Thread Group Notification
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:Asia/Shanghai LAST-MODIFIED:20230407T050750Z TZURL:https://www.tzurl.org/zoneinfo-outlook/Asia/Shanghai X-LIC-

Re: [edk2-devel] [PATCH v3 0/5] Target to enable paging from temporary RAM Done

2023-05-17 Thread Ni, Ray
Reviewed-by: Ruiyu Ni for all patches. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Wu, Jiaxin > Sent: Monday, May 15, 2023 10:16 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH v3 0/5] Target to enable paging from temporary > RAM Done > > For arch X64, sy