Thank you, Michael, appreciate your help! > -----Original Message----- > From: Kinney, Michael D <michael.d.kin...@intel.com> > Sent: Wednesday, May 17, 2023 6:48 PM > To: Warkentin, Andrei <andrei.warken...@intel.com>; > devel@edk2.groups.io; Gao, Liming <gaolim...@byosoft.com.cn> > Cc: Sunil V L <suni...@ventanamicro.com>; Kinney, Michael D > <michael.d.kin...@intel.com> > Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib > > Merged: > > https://github.com/tianocore/edk2/pull/4406 > > > > -----Original Message----- > > From: Kinney, Michael D <michael.d.kin...@intel.com> > > Sent: Wednesday, May 17, 2023 11:03 AM > > To: Warkentin, Andrei <andrei.warken...@intel.com>; > > devel@edk2.groups.io; Gao, Liming <gaolim...@byosoft.com.cn> > > Cc: Sunil V L <suni...@ventanamicro.com>; Kinney, Michael D > > <michael.d.kin...@intel.com> > > Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib > > > > I will take care of it today. > > > > Mike > > > > > -----Original Message----- > > > From: Warkentin, Andrei <andrei.warken...@intel.com> > > > Sent: Tuesday, May 16, 2023 10:27 PM > > > To: Kinney, Michael D <michael.d.kin...@intel.com>; > > devel@edk2.groups.io; > > > Gao, Liming <gaolim...@byosoft.com.cn> > > > Cc: Sunil V L <suni...@ventanamicro.com> > > > Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib > > > > > > Save for the last one from you - yes (as that reviewed-by came after > > > I resent the patch set, after the successful CI run) > > > > > > A > > > > > > > -----Original Message----- > > > > From: Kinney, Michael D <michael.d.kin...@intel.com> > > > > Sent: Wednesday, May 17, 2023 12:07 AM > > > > To: Warkentin, Andrei <andrei.warken...@intel.com>; > > > > devel@edk2.groups.io; Gao, Liming <gaolim...@byosoft.com.cn> > > > > Cc: Sunil V L <suni...@ventanamicro.com>; Kinney, Michael D > > > > <michael.d.kin...@intel.com> > > > > Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed > > > > SerialLib > > > > > > > > Are the commit messages all up to date in the PR with all Rbs? > > > > And is the correct PR > > > > > > > > https://github.com/tianocore/edk2/pull/4252 > > > > > > > > Liming, this was completed well before soft freeze and looks like low > risk. > > It > > > > should be merged for stable tag. > > > > > > > > Mike > > > > > > > > > -----Original Message----- > > > > > From: Warkentin, Andrei <andrei.warken...@intel.com> > > > > > Sent: Tuesday, May 16, 2023 9:58 PM > > > > > To: devel@edk2.groups.io; Warkentin, Andrei > > > > > <andrei.warken...@intel.com>; Kinney, Michael D > > > > > <michael.d.kin...@intel.com> > > > > > Cc: Sunil V L <suni...@ventanamicro.com> > > > > > Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed > > > > > SerialLib > > > > > > > > > > Hi folks, > > > > > > > > > > Is there a particular process that I'm not following to get a > > > > > patch set merged after all the reviews and sign-offs have been > completed? > > > > > > > > > > The SBI SerialLib patches were last updated April 7th. > > > > > > > > > > A > > > > > > > > > > > -----Original Message----- > > > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > > > > > > Andrei Warkentin > > > > > > Sent: Thursday, May 11, 2023 3:26 PM > > > > > > To: devel@edk2.groups.io; Warkentin, Andrei > > > > > > <andrei.warken...@intel.com>; Kinney, Michael D > > > > > > <michael.d.kin...@intel.com> > > > > > > Cc: Sunil V L <suni...@ventanamicro.com> > > > > > > Subject: Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed > > > > > > SerialLib > > > > > > > > > > > > Hi Michael, > > > > > > > > > > > > When can you or one of the MdePkg maintainers merge the SBI > > > > > > SerialLib patch set? > > > > > > > > > > > > A > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf > > > > > > > Of Andrei Warkentin > > > > > > > Sent: Tuesday, April 25, 2023 2:27 PM > > > > > > > To: Kinney, Michael D <michael.d.kin...@intel.com>; > > > > > > > devel@edk2.groups.io > > > > > > > Cc: Sunil V L <suni...@ventanamicro.com> > > > > > > > Subject: Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed > > > > > > > SerialLib > > > > > > > > > > > > > > Thanks for the review. I believe this patch set is ready for > > > > > > > merging. > > > > > > > Sunil had one comment on the contents of the UNI file, which > > > > > > > I clarified. Sunil, anything else you wanted from this patch > > > > > > > set or is it good > > > > > > to go? > > > > > > > > > > > > > > A > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > From: Kinney, Michael D <michael.d.kin...@intel.com> > > > > > > > > Sent: Friday, April 7, 2023 5:09 PM > > > > > > > > To: devel@edk2.groups.io; Warkentin, Andrei > > > > > > > > <andrei.warken...@intel.com> > > > > > > > > Cc: Kinney, Michael D <michael.d.kin...@intel.com> > > > > > > > > Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed > > > > > > > > SerialLib > > > > > > > > > > > > > > > > Reviewed-by: Michael D Kinney <michael.d.kin...@intel.com> > > > > > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On > > > > > > > > > Behalf > > Of > > > > > > > > > Andrei Warkentin > > > > > > > > > Sent: Friday, April 7, 2023 2:44 PM > > > > > > > > > To: devel@edk2.groups.io > > > > > > > > > Cc: Warkentin, Andrei <andrei.warken...@intel.com> > > > > > > > > > Subject: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed > > > > > > > > > SerialLib > > > > > > > > > > > > > > > > > > Hello, > > > > > > > > > > > > > > > > > > Here are three patches that provide a SerialLib backed > > > > > > > > > by SBI > > > > console. > > > > > > > > > Both legacy and DBCN mechanisms are supported in various > > > > > > > > > execution environments and have been tested with UART > > > > > > > > > and > > HTIF > > > > consoles. > > > > > > > > > > > > > > > > > > MdePkg reviewers: please review MdePkg.dsc changes. > > > > > > > > > > > > > > > > > > This is also available at > > > > > > > > > https://github.com/andreiw/edk2-rv-wip/tree/patchset-2 > > > > > > > > > > > > > > > > > > A CI run is at > > > > > > > > > https://github.com/tianocore/edk2/pull/4252 > > > > > > > > > > > > > > > > > > Compared to v6: > > > > > > > > > > > > > > > > > > - Unify the two SerialLib implementations under one > > > > > > > > > directory > > and > > > > > > > > > factor out the code somewhat. > > > > > > > > > - Sunil's feedback on correctness. > > > > > > > > > > > > > > > > > > Compared to v5: > > > > > > > > > > > > > > > > > > Rename components as per Michael Kinney's suggestions. > > > > > > > > > > > > > > > > > > Compared to v4: > > > > > > > > > > > > > > > > > > (not sent out). CC MdePkg maintainers, fix copyright > > > > > > > > > date in > > > > SecMain.c. > > > > > > > > > > > > > > > > > > Compared to v3 > > > > > > > > > > > > > > > > > > EccCheck fixes. Add MdePkg infs to DSC. > > > > > > > > > > > > > > > > > > Compared to v2: > > > > > > > > > - Probes legacy extension as well. > > > > > > > > > - Encode supported module types in the INF file. This is > > > > > > > > > done using > > > > > > > > LIBRARY_CLASS, > > > > > > > > > as MODULE_TYPE cannot encode multiple types, so > > > > MODULE_TYPE > > > > > > > > > is > > > > > > > > retained as BASE. > > > > > > > > > - Update INF version and generate brand new GUIDs > > > > > > > > > instead of editing > > > > > > > > them. > > > > > > > > > - Checked that all patches retain ^M endings. > > > > > > > > > > > > > > > > > > Andrei Warkentin (3): > > > > > > > > > MdePkg: BaseRiscVSbiLib: make more useful to consumers > > > > > > > > > MdePkg: add SBI-based SerialPortLib for RISC-V > > > > > > > > > OvmfPkg: RiscVVirt: Add missing SerialPortInitialize > > > > > > > > > to Sec > > > > > > > > > > > > > > > > > > MdePkg/MdePkg.dsc > > > > > > > > > | 2 + > > > > > > > > > > > > > > > > > > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLi > > > > > > > bRiscV > > > > > > > SbiL > > > > > > > ib.in > > > > > > > > f | 40 +++ > > > > > > > > > > > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPort > > > > > > > > LibRis > > > > > > > > cVSb > > > > > > > > iL > > > > > > > > ibRa > > > > > > > > m.inf | 37 +++ > > > > > > > > > OvmfPkg/RiscVVirt/Sec/SecMain.inf > | > > > 1 > > > > + > > > > > > > > > MdePkg/Include/Library/BaseRiscVSbiLib.h > > > | > > > > > 40 > > > > > > > ++- > > > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h > > > > > > > | > > > > > > > > 41 +++ > > > > > > > > > OvmfPkg/RiscVVirt/Sec/SecMain.h > | > > 1 > > > > + > > > > > > > > > MdePkg/Library/BaseRiscVSbiLib/BaseRiscVSbiLib.c > > > > | > > > > > > 3 > > > > > > > > +- > > > > > > > > > > > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPort > > > > > > > > LibRis > > > > > > > > cVSb > > > > > > > > iL > > > > > > > > ib.c > > > > > > > > | 208 ++++++++++++++ > > > > > > > > > > > > > > > > > > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLi > > > > > > > bRiscV > > > > > > > SbiL > > > > > > > ibRa > > > > > > > > m.c | 289 ++++++++++++++++++++ > > > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c > > > > > > > | > > > > > > > > 132 +++++++++ > > > > > > > > > OvmfPkg/RiscVVirt/Sec/SecMain.c > | > > 4 > > > > +- > > > > > > > > > > > > > > > > > > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLi > > > > > > > bRiscV > > > > > > > SbiL > > > > > > > ib.u > > > > > > > > ni | 16 ++ > > > > > > > > > 13 files changed, 808 insertions(+), 6 deletions(-) > > > > > > > > > create mode > > > > > > > > > 100644 > > > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPo > > > > > > > > > rtLibR > > > > > > > > > iscV > > > > > > > > > Sb > > > > > > > > > iL > > > > > > > > > ib.inf create mode 100644 > > > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPo > > > > > > > > > rtLibR > > > > > > > > > iscV > > > > > > > > > Sb > > > > > > > > > iL > > > > > > > > > ibRam.inf create mode 100644 > > > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h > > > > > > > > > create mode 100644 > > > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPo > > > > > > > > > rtLibR > > > > > > > > > iscV > > > > > > > > > Sb > > > > > > > > > iL > > > > > > > > > ib.c create mode 100644 > > > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPo > > > > > > > > > rtLibR > > > > > > > > > iscV > > > > > > > > > Sb > > > > > > > > > iL > > > > > > > > > ibRam.c create mode 100644 > > > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c > > > > > > > > > create mode 100644 > > > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPo > > > > > > > > > rtLibR > > > > > > > > > iscV > > > > > > > > > Sb > > > > > > > > > iL > > > > > > > > > ib.uni > > > > > > > > > > > > > > > > > > -- > > > > > > > > > 2.25.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105008): https://edk2.groups.io/g/devel/message/105008 Mute This Topic: https://groups.io/mt/98133911/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
