> -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard > Biesheuvel > Sent: Wednesday, May 17, 2023 7:46 PM > To: devel@edk2.groups.io; Wu, Hao A <hao.a...@intel.com> > Cc: Giri Mudusuru <gi...@apple.com>; Ni, Ray <ray...@intel.com>; Wang, > Jian J <jian.j.w...@intel.com>; Gao, Liming <gaolim...@byosoft.com.cn>; > Andrew Fish <af...@apple.com> > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC > capability debug print is incorrect > > On Wed, 17 May 2023 at 06:19, Wu, Hao A <hao.a...@intel.com> wrote: > > > > Thanks for the patch, inline comment below: > > > > > > > -----Original Message----- > > > From: Giri Mudusuru <gi...@apple.com> > > > Sent: Friday, May 12, 2023 5:55 PM > > > To: devel@edk2.groups.io > > > Cc: Giri Mudusuru <gi...@apple.com>; Wu, Hao A > <hao.a...@intel.com>; > > > Ni, Ray <ray...@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; > > > Gao, Liming <gaolim...@byosoft.com.cn>; Andrew Fish > > > <af...@apple.com> > > > Subject: [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability > debug > > > print is incorrect > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4394 > > > > > > Fix DumpCapabilityReg() debug log to print 64 bit capability instead > > > of 32 bit pointer > > > > > > Cc: Hao A Wu <hao.a...@intel.com> > > > Cc: Ray Ni <ray...@intel.com> > > > Cc: Jian J Wang <jian.j.w...@intel.com> > > > Cc: Liming Gao <gaolim...@byosoft.com.cn> > > > Cc: Andrew Fish <af...@apple.com> > > > Signed-off-by: Giri Mudusuru <gi...@apple.com> > > Reviewed-by: Ard Biesheuvel <a...@kernel.org> > > > > --- > > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > > > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > > > index aab6815328..2e7497a89d 100644 > > > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > > > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > > > @@ -30,7 +30,7 @@ DumpCapabilityReg ( > > > // > > > > > > // Dump Capability Data > > > > > > // > > > > > > - DEBUG ((DEBUG_INFO, " == Slot [%d] Capability is 0x%x ==\n", > > > Slot, Capability)); > > > > > > + DEBUG ((DEBUG_INFO, " == Slot [%d] Capability is 0x%llx ==\n", > > > + Slot, > > > *(UINT64 *)Capability)); > > > > > > Please help to use %p for printing pointers. > > > > Why? The point of this patch is that we are not interested in the pointer, > only > in the value that it points to.
Thanks. Reviewed-by: Hao A Wu <hao.a...@intel.com> Best Regards, Hao Wu > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104974): https://edk2.groups.io/g/devel/message/104974 Mute This Topic: https://groups.io/mt/98846217/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
