Re: [edk2-devel] [RFC] [edk2-openssl fork] Add openssl fork repo to Tianocore to support OpenSSL11_EOL

2023-04-07 Thread Yao, Jiewen
Thank you Mike. Appreciate that. Hi Yi I have created branch https://github.com/tianocore/openssl/tree/edk2-staging-openssl-3.0.8, from original openssl-3.0.8 tag. It matches what we have according to https://github.com/tianocore/edk2-staging/blob/OpenSSL11_EOL/CryptoPkg/Readme-OpenSSL3.0.md.

Re: [edk2-devel] [RFC] [edk2-openssl fork] Add openssl fork repo to Tianocore to support OpenSSL11_EOL

2023-04-07 Thread Michael D Kinney
Fork created https://github.com/tianocore/openssl I have given EDK II Maintainers write access. Let me know if there is any additional configuration required. Thanks, Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Wednesday, April 5, 2023

Re: [edk2-devel] [PATCH v7 3/3] OvmfPkg: RiscVVirt: Add missing SerialPortInitialize to Sec

2023-04-07 Thread Yao, Jiewen
Acked-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Andrei > Warkentin > Sent: Saturday, April 8, 2023 5:44 AM > To: devel@edk2.groups.io > Cc: Warkentin, Andrei ; Daniel Schaefer > ; Sunil V L > Subject: [edk2-devel] [PATCH v7 3/3] OvmfPkg: RiscVVirt: Ad

[edk2-devel] [PATCH v3 1/1] MdePkg: Add new JedecJep106Lib to fetch JEDEC JEP106 manufacturer

2023-04-07 Thread Rebecca Cran
From: Rebecca Cran Add a new library, JedecJep106Lib which provides a service to return the JEDEC JEP106 manufacturer string given the code and continuation bytes values. Signed-off-by: Rebecca Cran --- MdePkg/MdePkg.dec|3 + MdePkg/MdePkg.dsc

[edk2-devel] [PATCH v3 0/1] MdePkg: Add new JedecJep106Lib to fetch JEDEC JEP106 manufacturer

2023-04-07 Thread Rebecca Cran
MdePkg: Add new JedecJep106Lib to fetch JEDEC JEP106 manufacturer This library will be used by new SPDType17Lib that I'm working on which contstructs a SMBIOS Type17 table from SPD data from DIMMs. Changes between v2 and v3: o Added GLOBAL_REMOVE_IF_UNREFERENCED. o Removed ASSERT. o Removed func

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add new JedecJep106Lib to fetch JEDEC JEP106 manufacturer

2023-04-07 Thread Michael D Kinney
Yes. That would be good to add to as well. Mike > -Original Message- > From: Rebecca Cran > Sent: Friday, April 7, 2023 4:11 PM > To: devel@edk2.groups.io; Kinney, Michael D ; > Liu, Zhiguang ; Gao, Liming > > Cc: Rebecca Cran > Subject: Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add ne

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add new JedecJep106Lib to fetch JEDEC JEP106 manufacturer

2023-04-07 Thread Rebecca Cran
Sorry, not the struct - the array: STATIC CONST JEDEC_MANUFACTURERS *Jep106Manufacturers[] = {   Jep106ManufacturersBank1,   Jep106ManufacturersBank2,   Jep106ManufacturersBank3,   Jep106ManufacturersBank4,   Jep106ManufacturersBank5,   Jep106ManufacturersBank6,   Jep106ManufacturersBank7,   Jep

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add new JedecJep106Lib to fetch JEDEC JEP106 manufacturer

2023-04-07 Thread Michael D Kinney
Which struct? That macro only applies to global variables, not structure declarations. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Rebecca Cran > Sent: Friday, April 7, 2023 3:59 PM > To: Kinney, Michael D ; devel@edk2.groups.io; > Liu, Zhiguang ; Gao, Liming

Re: [edk2-devel] [PATCH 0/2] Support FDT library.

2023-04-07 Thread Michael D Kinney
The main advantage of the new lib is that it depends on a submodule for the FDT content so we can easily move to new releases for bug fixes or features. The FDT content in the EmbeddedPkg is a snap-shot of the code from a long time ago. We have been discouraging that approach and trying to move t

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add new JedecJep106Lib to fetch JEDEC JEP106 manufacturer

2023-04-07 Thread Rebecca Cran
I guess GLOBAL_REMOVE_IF_UNREFERENCED should be added to the struct too? On 4/7/23 4:42 PM, Rebecca Cran wrote: On 4/7/23 2:25 PM, Kinney, Michael D wrote: Comments below. Hopefully this lib would only be used by modules that get compressed. I guess so, but that's for the user to decide. M

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add new JedecJep106Lib to fetch JEDEC JEP106 manufacturer

2023-04-07 Thread Rebecca Cran
On 4/7/23 2:25 PM, Kinney, Michael D wrote: Comments below. Hopefully this lib would only be used by modules that get compressed. I guess so, but that's for the user to decide. Might add GLOBAL_REMOVE_IF_UNREFERENCED to the arrays of strings to help the optimizer remove the data that is not r

Re: [edk2-devel] [PATCH 0/2] Support FDT library.

2023-04-07 Thread Andrei Warkentin
I think in general it would be nice to understand the long term picture of a change, esp. since there is already FDT support in EDK2 in various forms (with libraries and drivers depending on the existing FdtLib). So it would really of confusing to see another FDT library in MdePkg, without a cle

[edk2-devel] [Patch v3 10/12] MdePkg/Library/BaseLib: HOST_APPLICATION IA32/X64 only

2023-04-07 Thread Michael D Kinney
Update BaseLib host-based unit test INF file to only list VALID_ARCHITECTURES of IA32 and X64 to align with all other host-based unit test INF files. The UnitTestFrameworkPkg only provides build support of host-based unit tests to OS applications for IA32 and X64. Cc: Liming Gao Cc: Zhiguang Liu

[edk2-devel] [Patch v3 11/12] MdeModulePkg: HOST_APPLICATION IA32/X64 only

2023-04-07 Thread Michael D Kinney
Update MdeModulePkg host-based unit test INF files to only list VALID_ARCHITECTURES of IA32 and X64 to align with all other host-based unit test INF files. The UnitTestFrameworkPkg only provides build support of host-based unit tests to OS applications for IA32 and X64. Cc: Jian J Wang Cc: Liming

[edk2-devel] [Patch v3 12/12] PrmPkg/Library: HOST_APPLICATION IA32/X64 only

2023-04-07 Thread Michael D Kinney
Update PrmPkg host-based unit test INF files to only list VALID_ARCHITECTURES of IA32 and X64 to align with all other host-based unit test INF files. The UnitTestFrameworkPkg only provides build support of host-based unit tests to OS applications for IA32 and X64. Cc: Michael Kubacki Cc: Nate DeS

[edk2-devel] [Patch v3 09/12] SecurityPkg/Library/SecureBootVariableLib: HOST_APPLICATION IA32/X64 only

2023-04-07 Thread Michael D Kinney
Update SecureBootVariableLib host-based unit test INF file to only list VALID_ARCHITECTURES of IA32 and X64 to align with all other host-based unit test INF files. The UnitTestFrameworkPkg only provides build support of host-based unit tests to OS applications for IA32 and X64. Cc: Jiewen Yao Cc:

[edk2-devel] [Patch v3 08/12] SecurityPkg/Library/SecureBootVariableLib: Fix VS20xx 4122 errors

2023-04-07 Thread Michael D Kinney
The unit test code for the SecureBootVariableLib is initializing local variable structures in their declaration from other local variables that are also initialized in their declaration. ANSI C does not allow this and error 4122 is generated on VS20xx compilers. The test cases are updated to init

[edk2-devel] [Patch v3 04/12] UnitTestFrameworkPkg/ReadMe.md: Add gmock documentation

2023-04-07 Thread Michael D Kinney
From: Chris Johnson REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389 Cc: Sean Brogan Cc: Michael Kubacki Cc: Michael D Kinney Signed-off-by: Chris Johnson Reviewed-by: Michael Kubacki Reviewed-by: Oliver Smith-Denny Reviewed-by: Michael D Kinney --- UnitTestFrameworkPkg/ReadMe.md

[edk2-devel] [Patch v3 07/12] SecurityPkg: Add gmock example

2023-04-07 Thread Michael D Kinney
From: Chris Johnson REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389 Cc: Jiewen Yao Cc: Jian J Wang Signed-off-by: Chris Johnson Acked-by: Jiewen Yao Reviewed-by: Oliver Smith-Denny Reviewed-by: Michael D Kinney --- .../SecureBootVariableLibGoogleTest.cpp | 174 +

[edk2-devel] [Patch v3 05/12] MdePkg: Add gmock examples

2023-04-07 Thread Michael D Kinney
From: Chris Johnson REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Chris Johnson Acked-by: Liming Gao Reviewed-by: Oliver Smith-Denny Reviewed-by: Michael D Kinney --- MdePkg/MdePkg.dec

[edk2-devel] [Patch v3 06/12] MdeModulePkg/Library/UefiSortLib: Add GoogleTestLib example

2023-04-07 Thread Michael D Kinney
From: Chris Johnson REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389 Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Chris Johnson Reviewed-by: Oliver Smith-Denny Reviewed-by: Michael D Kinney --- .../MockUefiRuntimeServicesTableLib.inf | 4 +- .../GoogleTest/UefiSortLibGoogle

[edk2-devel] [Patch v3 03/12] UnitTestFrameworkPkg: Add gmock support to GoogleTestLib

2023-04-07 Thread Michael D Kinney
From: Chris Johnson REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389 * Add gmock support to GoogleTestLib * Add FunctionMockLib library class and library instance * Add GoogleTest extension to GoogleTestLib.h for CHAR16 type * Add GoogleTest extension to GoogleTestLib.h for buffer types

[edk2-devel] [Patch v3 01/12] UnitTestFrameworkPkg: Add subhook submodule required for gmock

2023-04-07 Thread Michael D Kinney
From: Chris Johnson REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389 Add subhook submodule that is required to hook internal functions when using gmock. https://github.com/Zeex/subhook Add SubhookLib library class and SubhookLib library instance. Include the SUBHOOK_STATIC define i

[edk2-devel] [Patch v3 02/12] .pytool/CISettings.py: Add subhook submodule

2023-04-07 Thread Michael D Kinney
From: Chris Johnson REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389 Add submodule for https://github.com/Zeex/subhook This submodule is required to hook internal functions when using gmock. Cc: Sean Brogan Cc: Michael Kubacki Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Chri

[edk2-devel] [Patch v3 00/12] Add gmock support for host-based unit testing

2023-04-07 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389 PR: https://github.com/tianocore/edk2/pull/4180 Branch: https://github.com/mdkinney/edk2/tree/Bug_4389_UnitTestFrameworkPkg_AddGoogleMockSupport New in v3 == * Expand commit messages for HOST_APPLICATION only supports IA32/X64 * Up

Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib

2023-04-07 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Andrei > Warkentin > Sent: Friday, April 7, 2023 2:44 PM > To: devel@edk2.groups.io > Cc: Warkentin, Andrei > Subject: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib > > Hello, > >

[edk2-devel] [PATCH v7 2/3] MdePkg: add SBI-based SerialPortLib for RISC-V

2023-04-07 Thread Andrei Warkentin
These are implementations of SerialPortLib using SBI console services. - BaseSerialPortLibRiscVSbiLib is appropriate for SEC/PEI (XIP) environments - BaseSerialPortLibRiscVSbiLibRam is appropriate for PrePI/DXE environments Tested with: - Qemu RiscVVirt (non-DBCN case, backed by UART) - TinyEMU +

[edk2-devel] [PATCH v7 1/3] MdePkg: BaseRiscVSbiLib: make more useful to consumers

2023-04-07 Thread Andrei Warkentin
Add a few more definitions and make SbiCall and TranslateError usable (not static) by library users. Cc: Daniel Schaefer Acked-by: Gerd Hoffmann Reviewed-by: Sunil V L Signed-off-by: Andrei Warkentin --- MdePkg/Include/Library/BaseRiscVSbiLib.h | 40 ++-- MdePkg/Librar

[edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib

2023-04-07 Thread Andrei Warkentin
Hello, Here are three patches that provide a SerialLib backed by SBI console. Both legacy and DBCN mechanisms are supported in various execution environments and have been tested with UART and HTIF consoles. MdePkg reviewers: please review MdePkg.dsc changes. This is also available at https://

[edk2-devel] [PATCH v7 3/3] OvmfPkg: RiscVVirt: Add missing SerialPortInitialize to Sec

2023-04-07 Thread Andrei Warkentin
If the SerialPortLib had any initialization needed, this would be skipped in the RiscVVirt Sec. Follow the example seen elsewhere (ArmVirtPkg PrePi). Seen with BaseSerialPortLibRiscVSbiLibRam not using DBCN in Sec, yet using DBCN elsewhere. Cc: Daniel Schaefer Reviewed-by: Sunil V L Signed-off-

Re: [edk2-devel] [Patch v2 01/12] UnitTestFrameworkPkg: Add subhook submodule required for gmock

2023-04-07 Thread Michael D Kinney
One more update included below. Mike > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, April 5, 2023 2:35 PM > To: Leif Lindholm ; devel@edk2.groups.io > Cc: Johnson, Chris N ; Andrew Fish > ; Michael Kubacki ; > Sean Brogan ; Kinney, Michael D > > Subject: RE: [edk2-d

Re: [edk2-devel] [Patch v2 00/12] Add gmock support for host-based unit testing

2023-04-07 Thread Michael D Kinney
Patches 1..7 from Chris Johnson: Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael D > Kinney > Sent: Tuesday, April 4, 2023 11:22 AM > To: devel@edk2.groups.io > Cc: Michael Kubacki ; Desimone, Nathaniel L > ; Wang, Jian J > ; Gao, L

Re: [edk2-devel] [PATCH 01/18] ArmPkg: Update code to be more C11 compliant by using __func__

2023-04-07 Thread Michael D Kinney
Series Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Rebecca Cran > Sent: Thursday, April 6, 2023 3:23 PM > To: devel@edk2.groups.io; Gao, Liming ; Kinney, > Michael D ; Jiang, Guomin > ; Xu, Wei6 ; Dong, Guo > ; Ni, Ray ; Rhodes, Sean >

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/PlatformPei: Skip PlatformInitEmuVariableNvStore in SEV guest

2023-04-07 Thread Lendacky, Thomas via groups.io
On 4/6/23 20:56, Xu, Min M wrote: On Friday, April 7, 2023 4:29 AM, Tom Lendacky wrote: On 4/5/23 20:42, Xu, Min M wrote: On April 3, 2023 7:21 PM, Gerd Hoffmann wrote: I agree that the efi variable store is not secure without smm. But after 58eb8517ad7b be introduced, the -D SECURE_BOOT_ENABL

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add DDR5 SPD defs to IndustryStandard per JESD400-5A.01

2023-04-07 Thread Rebecca Cran
Could I get some reviews on this please? It was sent out back in February. I'm not sure how we should solve the CI breakage, since as I noted in the v1 revision it contains fields that begin with a lower-case letter following the style of the DDR4 header (https://github.com/tianocore/edk2/blob

[edk2-devel] [PATCH] ShellPkg: Update smbiosview type 0/4/17/41 with SMBIOS 3.5 fields v2

2023-04-07 Thread MillerX Lin
Cc: Signed-off-by: MillerX Lin Cc: Ray Ni Cc: Zhichao Gao --- .../SmbiosView/PrintInfo.c| 153 +- .../SmbiosView/SmbiosViewStrings.uni | 28 ++-- 2 files changed, 90 insertions(+), 91 deletions(-) diff --git a/ShellPkg/Library/UefiShellDebug1Comman

Re: [edk2-devel] [PATCH v6 6/6] UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family

2023-04-07 Thread Attar, AbdulLateef (Abdul Lateef) via groups.io
[AMD Official Use Only - General] Hi Ray, Please see inline. Thanks AbduL -Original Message- From: Ni, Ray Sent: 31 March 2023 13:29 To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) Cc: Attar, AbdulLateef (Abdul Lateef) ; Grimes, Paul ; Kirkendall, Garrett ; Chang,

[edk2-devel] [PATCH v2 1/1] MdePkg: Add new JedecJep106Lib to fetch JEDEC JEP106 manufacturer

2023-04-07 Thread Rebecca Cran
From: Rebecca Cran Add a new library, JedecJep106Lib which provides a service to return the JEDEC JEP106 manufacturer string given the code and continuation bytes values. Signed-off-by: Rebecca Cran --- MdePkg/MdePkg.dec|3 + MdePkg/MdePkg.dsc

[edk2-devel] [PATCH v2 0/1] MdePkg: Add new JedecJep106Lib to fetch JEDEC JEP106 manufacturer

2023-04-07 Thread Rebecca Cran
MdePkg: Add new JedecJep106Lib to fetch JEDEC JEP106 manufacturer This library will be used by new SPDType17Lib that I'm working on which contstructs a SMBIOS Type17 table from SPD data from DIMMs.. Changes between v1 and v2: o Added EFIAPI to functions. GitHub branch: https://github.com/bcran/

[edk2-devel] [PATCH v5 2/2] add ArmCpuInfo EFI application

2023-04-07 Thread Marcin Juszkiewicz
App goes through ID_AA64*_EL1 system registers and decode their values. Signed-off-by: Marcin Juszkiewicz --- ArmPkg/ArmPkg.dsc|1 + ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.inf | 38 + ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 2319 ++ 3 fi

[edk2-devel] [PATCH v5 1/2] ArmLib: add functions to read system registers

2023-04-07 Thread Marcin Juszkiewicz
ArmCpuInfo uses those to read system registers and other parts of EDK2 may find them useful. Signed-off-by: Marcin Juszkiewicz --- ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h| 48 +++ .../Library/ArmLib/AArch64/AArch64Support.S | 32 + 2 files changed, 80 inserti

[edk2-devel] [PATCH v5 0/2] add ArmCpuInfo application

2023-04-07 Thread Marcin Juszkiewicz
Changes since v4: - functions to read system registers are renamed and moved to ArmLib Marcin Juszkiewicz (2): ArmLib: add functions to read system registers add ArmCpuInfo EFI application ArmPkg/ArmPkg.dsc |1 + ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.inf |

Re: [edk2-devel] [PATCH v4] add ArmCpuInfo EFI application

2023-04-07 Thread Marcin Juszkiewicz
W dniu 7.04.2023 o 16:02, Marcin Juszkiewicz via groups.io pisze: +++ b/ArmPkg/Application/ArmCpuInfo/readregs.S @@ -0,0 +1,41 @@ +#include + +ASM_FUNC(ReadAa64Pfr0El1) +mrs x0, ID_AA64PFR0_EL1 +ret + +ASM_FUNC(ReadAa64Pfr1El1) +mrs x0, ID_AA64PFR1_EL1 +ret + +ASM

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/PlatformPei: Skip PlatformInitEmuVariableNvStore in SEV guest

2023-04-07 Thread joeyli via groups.io
Hi Min Xu, On Fri, Apr 07, 2023 at 01:56:05AM +, Min Xu via groups.io wrote: > On Friday, April 7, 2023 4:29 AM, Tom Lendacky wrote: > > On 4/5/23 20:42, Xu, Min M wrote: > > > On April 3, 2023 7:21 PM, Gerd Hoffmann wrote: > > I agree that the efi variable store is not secure without smm

[edk2-devel] [PATCH v4] add ArmCpuInfo EFI application

2023-04-07 Thread Marcin Juszkiewicz
App goes through ID_AA64*_EL1 system registers and decode their values. Signed-off-by: Marcin Juszkiewicz --- ArmPkg/ArmPkg.dsc|1 + ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.inf | 38 + ArmPkg/Application/ArmCpuInfo/readargs.h | 10 + ArmPkg/Application/Ar

Re: [edk2-devel] [PATCH v3] add ArmCpuInfo EFI application

2023-04-07 Thread Marcin Juszkiewicz
W dniu 7.04.2023 o 15:40, Pedro Falcato pisze: (+cc old CCs) (Marcin, you're dropping CC's on your replies) Oops, sorry. ASM files that require preprocessing should have a capital S here (.S vs .s) After renaming it to readregs.S (and changing in ArmCpuInfo.inf) I get: build.py... /home/m

Re: [edk2-devel] [PATCH v3] add ArmCpuInfo EFI application

2023-04-07 Thread Pedro Falcato
Oops, now I screwed up the CC's, apologies. On Fri, Apr 7, 2023 at 2:40 PM Pedro Falcato wrote: > > (+cc old CCs) > > (Marcin, you're dropping CC's on your replies) > > On Fri, Apr 7, 2023 at 2:29 PM Marcin Juszkiewicz > wrote: > > > > W dniu 7.04.2023 o 15:02, Pedro Falcato pisze: > > > > >> di

Re: [edk2-devel] [PATCH v3] add ArmCpuInfo EFI application

2023-04-07 Thread Pedro Falcato
(+cc old CCs) (Marcin, you're dropping CC's on your replies) On Fri, Apr 7, 2023 at 2:29 PM Marcin Juszkiewicz wrote: > > W dniu 7.04.2023 o 15:02, Pedro Falcato pisze: > > >> diff --git a/ArmPkg/Application/ArmCpuInfo/readregs.s > >> b/ArmPkg/Application/ArmCpuInfo/readregs.s > > > > ASM files

Re: [edk2-devel] [PATCH v3] add ArmCpuInfo EFI application

2023-04-07 Thread Marcin Juszkiewicz
W dniu 7.04.2023 o 15:02, Pedro Falcato pisze: +EFI_STATUS +EFIAPI +UefiMain ( + IN EFI_HANDLEImageHandle, + IN EFI_SYSTEM_TABLE *SystemTable + ) +{ + UINT64 aa64dfr0_el1 = read_aa64dfr0_el1 (); + UINT64 aa64dfr1_el1 = read_aa64dfr1_el1 (); + UINT64 aa64isar0_el1 = read_aa64

Re: [edk2-devel] [PATCH 0/2] Support FDT library.

2023-04-07 Thread Pedro Falcato
On Thu, Apr 6, 2023 at 5:34 PM Sheng Lean Tan wrote: > > Thanks for the nice feedback Pedro, Gerd and Andrei! Yeah it seems like a > valid concern here as Mik mentioned on edk2-libc, and it seems to fits edk2 > long term interest on this. > Can we file this as an issue in Bugzilla for tracking o

Re: [edk2-devel] [PATCH v2] add ArmCpuInfo EFI application

2023-04-07 Thread Ard Biesheuvel
On Fri, 7 Apr 2023 at 14:46, Marcin Juszkiewicz wrote: > > W dniu 7.04.2023 o 12:55, Ard Biesheuvel pisze: > > Hello Marcin, > > > > Thanks for this - it looks useful. > > Some comments below. > > Thanks. > > On Fri, 7 Apr 2023 at 12:40, Marcin Juszkiewicz > > wrote: > >> ... > >> +char*

Re: [edk2-devel] [PATCH v3] add ArmCpuInfo EFI application

2023-04-07 Thread Pedro Falcato
Forgot mentioning: STATIC vs static, CONST vs const, VOID vs void, CHAR8 vs char, etc. All fun microsoftisms you need to use here. On Fri, Apr 7, 2023 at 2:02 PM Pedro Falcato wrote: > > On Fri, Apr 7, 2023 at 1:47 PM Marcin Juszkiewicz > wrote: > > > > App goes through ID_AA64*_EL1 system regis

Re: [edk2-devel] [PATCH v3] add ArmCpuInfo EFI application

2023-04-07 Thread Pedro Falcato
On Fri, Apr 7, 2023 at 1:47 PM Marcin Juszkiewicz wrote: > > App goes through ID_AA64*_EL1 system registers and decode their values. > > Signed-off-by: Marcin Juszkiewicz > --- > ArmPkg/ArmPkg.dsc|1 + > ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.inf | 38 + > Arm

[edk2-devel] [PATCH v3] add ArmCpuInfo EFI application

2023-04-07 Thread Marcin Juszkiewicz
App goes through ID_AA64*_EL1 system registers and decode their values. Signed-off-by: Marcin Juszkiewicz --- ArmPkg/ArmPkg.dsc|1 + ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.inf | 38 + ArmPkg/Application/ArmCpuInfo/readargs.h | 12 + ArmPkg/Application/Ar

Re: [edk2-devel] [PATCH v2] add ArmCpuInfo EFI application

2023-04-07 Thread Marcin Juszkiewicz
W dniu 7.04.2023 o 12:55, Ard Biesheuvel pisze: Hello Marcin, Thanks for this - it looks useful. > Some comments below. Thanks. On Fri, 7 Apr 2023 at 12:40, Marcin Juszkiewicz wrote: App goes through ID_AA64*_EL1 system registers and decode their values. First version which does not use m

Re: [edk2-devel] [PATCH v3 0/4] Enable BTI support in memory attributes table

2023-04-07 Thread Ard Biesheuvel
On Thu, 6 Apr 2023 at 03:34, gaoliming via groups.io wrote: > > Ard: > Can you submit one BZ for this new feature? I will add it into the stable > tag feature planning. > https://bugzilla.tianocore.org/show_bug.cgi?id=4405 > For this patch set, Reviewed-by: Liming Gao > Thanks, I've queued

Re: [edk2-devel] Role of DLINK2_FLAGS and link-time option consistency

2023-04-07 Thread Ard Biesheuvel
(cc Ray) On Fri, 7 Apr 2023 at 13:05, Marvin Häuser wrote: > > > On 7. Apr 2023, at 13:02, Ard Biesheuvel wrote: > > IIRC DLINK2_FLAGS is mainly being used (in the GCC case) for passing > options that need to come after previous occurrences of the same > option with a different value, in order f

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/PlatformPei: Skip PlatformInitEmuVariableNvStore in SEV guest

2023-04-07 Thread Min Xu
On April 7, 2023 5:41 PM, joeyli wrote: > > Hi, Joeyli > > ASSERT is triggered in DEBUG version. In RELEASE version ASSERT is skipped > and an error code is returned. So system will not hang. > > So another solution is simply remove the ASSERT. Then an error message is > dumped out and system conti

[edk2-devel] [PATCH v7 2/3] UsbNetworkPkg/UsbCdcEcm: Add USB Cdc ECM devices support

2023-04-07 Thread RichardHo [何明忠] via groups . io
This driver provides UEFI driver for USB CDC ECM device Signed-off-by: Richard Ho Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc: Michael Kubacki Cc: Zhiguang Liu Cc: Liming Gao Cc: Rebecca Cran Tested-by: Tinh Nguyen Reviewed-by: Tony Lo --- UsbNetworkPkg/UsbCdcEcm/Component

[edk2-devel] [PATCH v7 3/3] UsbNetworkPkg/UsbCdcNcm: Add USB Cdc NCM devices support

2023-04-07 Thread RichardHo [何明忠] via groups . io
This driver provides UEFI driver for USB CDC NCM device Signed-off-by: Richard Ho Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc: Michael Kubacki Cc: Zhiguang Liu Cc: Liming Gao Cc: Rebecca Cran Tested-by: Tinh Nguyen Reviewed-by: Tony Lo --- UsbNetworkPkg/UsbCdcNcm/Component

Re: [edk2-devel] [PATCH 03/18] UefiCpuPkg: Update code to be more C11 compliant by using __func__

2023-04-07 Thread Sunil V L
On Thu, Apr 06, 2023 at 04:23:04PM -0600, Rebecca Cran wrote: > __FUNCTION__ is a pre-standard extension that gcc and Visual C++ among > others support, while __func__ was standardized in C99. > > Since it's more standard, replace __FUNCTION__ with __func__ throughout > UefiCpuPkg. > > Visual Stu

Re: [edk2-devel] [PATCH 04/18] OvmfPkg: Update code to be more C11 compliant by using __func__

2023-04-07 Thread Sunil V L
On Thu, Apr 06, 2023 at 04:23:05PM -0600, Rebecca Cran wrote: > __FUNCTION__ is a pre-standard extension that gcc and Visual C++ among > others support, while __func__ was standardized in C99. > > Since it's more standard, replace __FUNCTION__ with __func__ throughout > OvmfPkg. > > Visual Studio

Re: [edk2-devel] Role of DLINK2_FLAGS and link-time option consistency

2023-04-07 Thread Marvin Häuser
> On 7. Apr 2023, at 13:02, Ard Biesheuvel wrote: > > IIRC DLINK2_FLAGS is mainly being used (in the GCC case) for passing > options that need to come after previous occurrences of the same > option with a different value, in order for the DLINK2 one to take > precedence. Thanks for the quick r

Re: [edk2-devel] Role of DLINK2_FLAGS and link-time option consistency

2023-04-07 Thread Ard Biesheuvel
On Fri, 7 Apr 2023 at 12:14, Marvin Häuser wrote: > > Good day everyone, > > I've been asked to check the following patch: > https://edk2.groups.io/g/devel/message/102168 > > One thing I noticed was that -no-pie is added to DLINK2_FLAGS, not > DLINK_FLAGS. For MSVC toolchains, DLINK2_FLAGS is us

Re: [edk2-devel] [PATCH v2] add ArmCpuInfo EFI application

2023-04-07 Thread Ard Biesheuvel
Hello Marcin, Thanks for this - it looks useful. Some comments below. On Fri, 7 Apr 2023 at 12:40, Marcin Juszkiewicz wrote: > > App goes through ID_AA64*_EL1 system registers and decode their values. > > First version which does not use much of current AArch64 support code > present in EDK2. W

[edk2-devel] [PATCH v2] add ArmCpuInfo EFI application

2023-04-07 Thread Marcin Juszkiewicz
App goes through ID_AA64*_EL1 system registers and decode their values. First version which does not use much of current AArch64 support code present in EDK2. Written to check what data is there and what can be done with it. Signed-off-by: Marcin Juszkiewicz --- MdeModulePkg/MdeModulePkg.dsc

[edk2-devel] Role of DLINK2_FLAGS and link-time option consistency

2023-04-07 Thread Marvin Häuser
Good day everyone, I've been asked to check the following patch: https://edk2.groups.io/g/devel/message/102168 One thing I noticed was that -no-pie is added to DLINK2_FLAGS, not DLINK_FLAGS. For MSVC toolchains, DLINK2_FLAGS is used for a separate linker step [1] introduced by [2], which makes

Re: [edk2-devel] [PATCH 00/18] Replace pre-standard macro __FUNCTION__ with C99 __func__ throughout edk2

2023-04-07 Thread Ard Biesheuvel
On Fri, 7 Apr 2023 at 00:23, Rebecca Cran wrote: > > Following on from commit b17a3a133b18fb41493fba7d86e9b5804ea6a8cf which > updated MdePkg to be more C11 compliant by replacing the pre-standard > __FUNCTION__ with __func__ which was introduced in C99, this patch > series updates the remaining p

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/PlatformPei: Skip PlatformInitEmuVariableNvStore in SEV guest

2023-04-07 Thread joeyli via groups.io
On Mon, Apr 03, 2023 at 12:21:38AM +, Xu, Min M wrote: > On Friday, March 31, 2023 10:49 PM, Joeyli wrote: > > On Fri, Mar 31, 2023 at 10:25:09AM +0200, Gerd Hoffmann wrote: > > > On Fri, Mar 31, 2023 at 03:59:56PM +0800, joeyli wrote: > > > > Hi Gerd, > > > > > > > > On Thu, Mar 30, 2023 at 09

Re: [edk2-devel] [PATCH 07/18] EmbeddedPkg: Update code to be more C11 compliant by using __func__

2023-04-07 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Rebecca Cran > Sent: Friday, April 7, 2023 6:23 AM > To: devel@edk2.groups.io; Liming Gao ; > Michael D Kinney ; Guomin Jiang > ; Wei6 Xu ; Guo Dong > ; Ray Ni ; Sean Rhodes > ; James Lu ; Gua Guo >

Re: [edk2-devel] [PATCH 16/18] EmulatorPkg: Update code to be more C11 compliant by using __func__

2023-04-07 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Rebecca, I can only give you reviewed-by for RedfishPlatformHostInterfaceLib.c. Reviewed-by: Abner Chang > -Original Message- > From: Rebecca Cran > Sent: Friday, April 7, 2023 6:23 AM > To: devel@edk2.groups.io; Liming Gao ; > Michael D Kinney ; Gu

Re: [edk2-devel] [PATCH 17/18] UefiPayloadPkg: Update code to be more C11 compliant by using __func__

2023-04-07 Thread Lu, James
Reviewed-by: James Lu Thanks, James -Original Message- From: Rebecca Cran Sent: Friday, April 7, 2023 6:23 AM To: devel@edk2.groups.io; Gao, Liming ; Kinney, Michael D ; Jiang, Guomin ; Xu, Wei6 ; Dong, Guo ; Ni, Ray ; Rhodes, Sean ; Lu, James ; Guo, Gua ; Andrew Fish ; Wu, Hao A