[AMD Official Use Only - General] Hi Rebecca, I can only give you reviewed-by for RedfishPlatformHostInterfaceLib.c.
Reviewed-by: Abner Chang <[email protected]> > -----Original Message----- > From: Rebecca Cran <[email protected]> > Sent: Friday, April 7, 2023 6:23 AM > To: [email protected]; Liming Gao <[email protected]>; > Michael D Kinney <[email protected]>; Guomin Jiang > <[email protected]>; Wei6 Xu <[email protected]>; Guo Dong > <[email protected]>; Ray Ni <[email protected]>; Sean Rhodes > <[email protected]>; James Lu <[email protected]>; Gua Guo > <[email protected]>; Andrew Fish <[email protected]>; Hao A Wu > <[email protected]>; Maciej Rabeda <[email protected]>; > Siyuan Fu <[email protected]>; Jiewen Yao <[email protected]>; Jian > J Wang <[email protected]>; Xiaoyu Lu <[email protected]>; Ard > Biesheuvel <[email protected]>; Sami Mujawar > <[email protected]>; Supreeth Venkatesh > <[email protected]>; Michael Kubacki > <[email protected]>; Nate DeSimone > <[email protected]>; Sean Brogan > <[email protected]> > Cc: Rebecca Cran <[email protected]>; Leif Lindholm > <[email protected]>; Chang, Abner <[email protected]>; > Nickle Wang <[email protected]>; Igor Kulchytskyy <[email protected]>; > Daniel Schaefer <[email protected]>; Min Xu <[email protected]>; > Jordan Justen <[email protected]>; Gerd Hoffmann > <[email protected]>; Peter Grehan <[email protected]>; Erdem Aktas > <[email protected]>; James Bottomley <[email protected]>; > Lendacky, Thomas <[email protected]>; Roth, Michael > <[email protected]>; Sunil V L <[email protected]>; Andrei > Warkentin <[email protected]> > Subject: [PATCH 16/18] EmulatorPkg: Update code to be more C11 compliant > by using __func__ > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > __FUNCTION__ is a pre-standard extension that gcc and Visual C++ among > others support, while __func__ was standardized in C99. > > Since it's more standard, replace __FUNCTION__ with __func__ throughout > EmulatorPkg. > > Visual Studio versions before VS 2015 don't support __func__ and so will fail > to compile. A workaround is to define __func__ as __FUNCTION__ : > > #define __func__ __FUNCTION__ > > Signed-off-by: Rebecca Cran <[email protected]> > --- > > EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHostI > nterfaceLib.c | 2 +- > EmulatorPkg/Win/Host/WinPacketFilter.c > | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git > a/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHo > stInterfaceLib.c > b/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHo > stInterfaceLib.c > index 4361bd4170e3..4332caa71016 100644 > --- > a/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHo > stInterfaceLib.c > +++ b/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatfor > +++ mHostInterfaceLib.c > @@ -538,7 +538,7 @@ RedfishPlatformHostInterfaceConstructor ( > EFI_STATUS Status; > > Status = GetRedfishRecordFromVariable (&mRedfishOverIpProtocolData, > &mRedfishProtocolDataSize); > - DEBUG ((DEBUG_INFO, "%a: GetRedfishRecordFromVariable() - %r\n", > __FUNCTION__, Status)); > + DEBUG ((DEBUG_INFO, "%a: GetRedfishRecordFromVariable() - %r\n", > + __func__, Status)); > if (!EFI_ERROR (Status)) { > DumpRedfishIpProtocolData (mRedfishOverIpProtocolData, > mRedfishProtocolDataSize); > } > diff --git a/EmulatorPkg/Win/Host/WinPacketFilter.c > b/EmulatorPkg/Win/Host/WinPacketFilter.c > index 21859897c85f..a71c7e8c131b 100644 > --- a/EmulatorPkg/Win/Host/WinPacketFilter.c > +++ b/EmulatorPkg/Win/Host/WinPacketFilter.c > @@ -966,7 +966,7 @@ WintNtInitializeNetUtilityData ( > goto ErrorReturn; > } > > - DEBUG ((DEBUG_INFO, "%a, total %d interface(s) found\n", > __FUNCTION__, InterfaceCount)); > + DEBUG ((DEBUG_INFO, "%a, total %d interface(s) found\n", __func__, > + InterfaceCount)); > // > // Active interface index is set to first interface if given instance does > // not exist. > -- > 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102675): https://edk2.groups.io/g/devel/message/102675 Mute This Topic: https://groups.io/mt/98115254/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
