Reviewed-by: Jiewen Yao
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Thursday, August 25, 2022 11:48 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen ; Wang, Jian J ;
> Zhang, Qi1 ; Kumar, Rahul R ;
> Yao, Jiewen
> Subject: [PATCH v2 5/8] SecurityPkg/SmmTcg2PhysicalP
On August 23, 2022 9:07 PM, Lendacky,Thomas wrote:
> On 8/23/22 03:40, Xu, Min M wrote:
> > On August 23, 2022 3:38 PM, Gerd Hoffmann wrote:
> >>Hi,
> >>
> >>> Ah, I forget to reserve the work-area as RT_Data in below code:
> >>>BuildMemoryAllocationHob (
> >>> (EFI_PHYSICAL_AD
From: Michael Kubacki
The DEBUG macro updated in this patch previously contained 11 print
specifiers in the debug string but passeed 13 arguments. This change
attempts to update the macro to the author's intention so the number
of specifiers match the number of arguments.
Cc: Ard Biesheuvel
Cc:
From: Michael Kubacki
Removes Status argument that is not needed from DEBUG macros.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Michael Kubacki
---
NetworkPkg/TcpDxe/SockInterface.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/NetworkPkg
From: Michael Kubacki
Cc: Sami Mujawar
Cc: Alexei Fedorov
Signed-off-by: Michael Kubacki
---
DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c
From: Michael Kubacki
The debug macro modified in this change was missing a print specifier
for a debug message argument given.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Qi Zhang
Cc: Rahul Kumar
Signed-off-by: Michael Kubacki
Reviewed-by: Jiewen Yao
---
SecurityPkg/Library/SmmTcg2PhysicalPresen
From: Michael Kubacki
The debug macro argument in this change is removed since it does
have a corresponding print specifier in the debug message string.
Cc: Abner Chang
Cc: Nickle Wang
Signed-off-by: Michael Kubacki
Reviewed-by: Abner Chang
---
RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverD
From: Michael Kubacki
Updates debug macros in the package that have an imbalanced number
of print specifiers to arguments. These changes try to preserve
what was likely intended by the author. In cases information was
missing due to the bug, the specifier may be removed since it was
not previousl
From: Michael Kubacki
This debug macro should take one argument based on the number of
print specifiers defined. However, two arguments are given.
It looks like the code may have been refactored such that the
second argument was moved to a new print and this argument was
not removed. In any case
From: Michael Kubacki
These debug messages are repeated in both NorFlashBlockIoReadBlocks()
and NorFlashBlockIoWriteBlocks():
"NorFlashBlockIoWriteBlocks(MediaId=0x%x, Lba=%ld, BufferSize=0x%x"
"bytes (%d kB), BufferPtr @ 0x%08x)\n"
Although this requires 5 arguments, only 4 are provided. T
From: Michael Kubacki
After noticing a few occurrences of DEBUG macros with a mismatched
number of arguments, I wrote a script to automatically detect this.
This patch series is the result of matches found by the script.
In some cases it is not obvious what was originally intended so I
have att
In these changes:
> - @param[in] SaveData A pointer pointer that will be
updated with the address
> + @param[out] SaveData A pointer that will be updated with
the address
The text "A pointer..." became unaligned with the block. Likely due to
the extra character added when
Reviewed-by: James Lu
Thanks,
James
-Original Message-
From: devel@edk2.groups.io On Behalf Of Zhiguang Liu
Sent: Thursday, August 25, 2022 10:21 AM
To: Chen, Gang C ; devel@edk2.groups.io
Cc: Ni, Ray ; Kinney, Michael D ;
Gao, Liming
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/
The API of InitializeSeparateExceptionStacks is just changed before, and
makes the struct CPU_EXCEPTION_INIT_DATA an internal definition.
Furthermore, we can even remove the struct to make core simpler.
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Signed-off-by: Zhiguang Liu
---
.../CpuExceptionC
When switch bsp, old bsp and new bsp put CR0/CR4 into stack, and put IDT
and GDT register into a structure. After they exchange their stack, they
restore these registers. This logic is now implemented by assembly code.
This patch aims to reuse (Save/Restore)VolatileRegisters function to
replace suc
Currently, when waking up AP, IDT table of AP will be set in 16 bit code,
and assume the IDT table base is 32 bit. However, the IDT table is created
by BSP. Issue will happen if the BSP allocates memory above 4G for BSP's
IDT table. Moreover, even the IDT table location is below 4G, the handler
fun
Parallelly run the function to SeparateExceptionStacks for all CPUs and
allocate buffers together for better performance.
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Signed-off-by: Zhiguang Liu
---
UefiCpuPkg/CpuDxe/CpuMp.c | 93 ++--
UefiCpuPkg/CpuMpPei/CpuMpPei
Reviewed-by: Zhiguang Liu
> -Original Message-
> From: Chen, Gang C
> Sent: Wednesday, August 24, 2022 10:27 PM
> To: devel@edk2.groups.io
> Cc: Chen, Gang C ; Ni, Ray ;
> Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang
> Subject: [PATCH] UefiPayloadPkg/PayloadLoaderPeim: remove GCC b
Bob:
I mean this change brings the behavior change, but this patch doesn't
highlight its impact and give the suggestion to modify the impacted DSC file.
Otherwise, this impact can be raised and discussed early. Now, we are near to
create edk2-stable202208. There is no enough time to discuss th
Adbul:
Thank you! This patch is not required to be re-sent. I will merge it after the
stable tag is created.
Thanks
Liming
发件人: devel@edk2.groups.io 代表 Attar, AbdulLateef (Abdul
Lateef) via groups.io
发送时间: 2022年8月24日 16:12
收件人: gaoliming ; devel@edk2.groups.io;
zhiguang@intel.com
抄
Reviewed-by: Pierre Gondois
On 8/24/22 06:35, Jeff Brasen wrote:
Expose the UID value to GeneratePciSlots().
This is needed for some cases for example:
https://docs.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie-root-ports#identifying-externally-exposed-pcie-root-ports
Name (_DS
Hi Liming,
This commit 039bdb4d3e96f9c9264abf135b8a0eef2e2b4860 was to fix the bug that
the basetools implementation dose not follow the dsc spec and pass the edk2 CI.
The patch was send on June 30, reviewed on July 11 and pushed on July 17. I
think there was enough time to give feedback to this
Reviewed-by: Daniel Schaefer
From: devel@edk2.groups.io on behalf of Chang, Abner via
groups.io
Sent: Tuesday, August 23, 2022 13:57
To: devel@edk2.groups.io
Cc: Leif Lindholm ; Michael D Kinney
; Daniel Schaefer ; Sunil V
L
Subject: [edk2-devel] [edk2-platf
Reviewed-by: Daniel Schaefer
From: devel@edk2.groups.io on behalf of NickleLa
Sent: Tuesday, August 23, 2022 15:56
To: Sunil V L
Cc: abner.ch...@amd.com ; devel@edk2.groups.io
; Andrew Fish ; Leif Lindholm
; Michael D Kinney ;
Daniel Schaefer
Subject: Re: [
From: Minh Nguyen
In some scenarios, the information of Bios Version, Bios Release
and Embedded Controller Firmware Release are fetched during UEFI
booting. This patch supports updating those fields dynamically
when the PCDs are empty.
Signed-off-by: Nhi Pham
Reviewed-by: Rebecca Cran
Reviewed
From: Minh Nguyen
This patch removes redundant updates of "BoardManufacturerType02"
and "SerialNumberType02".
Signed-off-by: Nhi Pham
Reviewed-by: Rebecca Cran
Reviewed-by: Sami Mujawar
---
ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c
| 10 --
1
From: Minh Nguyen
This patch fixes typo from "AssertTagType02"
to "AssetTagType02".
Signed-off-by: Nhi Pham
Reviewed-by: Rebecca Cran
Reviewed-by: Sami Mujawar
---
ArmPkg/Include/Library/OemMiscLib.h
| 2 +-
ArmPkg/Universal/Smbios/SmbiosMiscDxe
This adds an API to OemMiscLib for fetching the system UUID according to
the platform.
Signed-off-by: Nhi Pham
Reviewed-by: Rebecca Cran
Reviewed-by: Sami Mujawar
---
ArmPkg/Include/Library/OemMiscLib.h
| 12
ArmPkg/Universal/Smbios/OemMi
From: Minh Nguyen
According to "SMC Calling Convention" specification, section 7.4,
return value of Arm Architecture Calls is stored at first argument of
SMC aguments (ARM_SMC_ARGS). This value can be negative values indicating
error or positive values (including zero) indicating success. Positiv
This patchset is to update the ArmPkg/SMBIOS for fixes and improvements.
Changes since v1:
+ Change PartNumber to ProcessorVersion [Sami]
Minh Nguyen (5):
ArmPkg/ProcessorSubClassDxe: Get processor version from OemMiscLib
ArmPkg: Correct return value of "SMCCC_ARCH_SOC_ID" Function ID cal
From: Minh Nguyen
In some scenarios, the processor version may be updated dynamically
from pre-UEFI firmware during booting. But the processor version is
fixed with PCD (PcdProcessorVersion), so it can not be updated it
dynamically. This patch will support setting that value both
statically and d
The warm reboot requests from OSPM are mapped to cold reboot. To handle
the warm reboot separately from a cold reboot, update
ArmSmcPsciResetSystemLib and to invoke the PSCI call with parameters
for warm reboot.
Signed-off-by: Pranav Madhu
---
ArmPkg/Include/IndustryStandard/ArmStdSmc.h
Hi Hesham,
The idea for keeping it as separate type was to abstract locator field to have
a view similar to that of its definition in the spec (MPAM ACPI 1.0, section
2.2, table 7 - Resource node.)
Something of the lines –
typedef struct {
UINT32 Identifier;
UINT8
Hi Sami,
On 8/23/2022 11:21 PM, Sami Mujawar wrote:
Hi Nhi,
Thank you for this patch.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 23/08/2022 11:59 am, Nhi Pham wrote:
From: Minh Nguyen
In some scenarios, the processor version may be updated dynamically
from pre
Hi,
I am receiving an "unknown fatal error when processing .dsc" error message,
whenever I try to build the project. The stack trace is attached to the email.
What could be the reason for the error?
Thanks,
Jakub
-
Intel Techno
[AMD Official Use Only - General]
Hi Liming, Zhiguang,
You can revert the patch, I will re-submit the patch for the next release.
Thanks
AbduL
From: gaoliming
Sent: 24 August 2022 12:50
To: devel@edk2.groups.io; zhiguang@intel.com; Attar, AbdulLateef (Abdul
Lateef)
Cc: llind...@qti.qualcom
Hello Rohit and Swatisri,
On Tue, Aug 23, 2022 at 09:11 PM, Andrew Fish wrote:
>
> [Rohit ] Shouldn't " Locator " field be 12 bytes in size, possibly a
> separate type? (MPAM ACPI 1.0, section 2.2, table 7 - Resource node and
> section 2.3.2 table 10 - locator descriptor)
I'd just go for UINT64
Fix the gcc build warning:
variable PldInfo set but not used [-Wunused-but-set-variable]
Cc: Ray Ni
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Gang Chen
---
UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/U
I really don't have much knowledge about the EDK2 build system, and was
hoping that Ard would reply - which he has!
--
Rebecca Cran
On 8/24/22 05:05, Pedro Falcato wrote:
Hi,
So, what's your suggestion? Do you want me to add that to my package
as well?
There is obviously a huge problem wit
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: pierre.gond...@arm.com
> Sent: Wednesday, August 24, 2022 12:00 AM
> To: devel@edk2.groups.io
> Cc: Pierre Gondois ; Chang, Abner
>
> Subject: [PATCH 17/24] RedfishPkg: Remove duplicated words
>
>
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: pierre.gond...@arm.com
> Sent: Wednesday, August 24, 2022 12:00 AM
> To: devel@edk2.groups.io
> Cc: Pierre Gondois ; Leif Lindholm
> ; Ard Biesheuvel ;
> Chang, Abner
> Subject: [PATCH 08/24] Embedd
On Tue, Aug 23, 2022 at 18:00:15 +0200, pierre.gond...@arm.com wrote:
> From: Pierre Gondois
>
> In an effort to clean the documentation of the above
> package, remove duplicated words.
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Abner Chang
> Signed-off-by: Pierre Gondois
Reviewed-by:
On Tue, Aug 23, 2022 at 18:00:09 +0200, pierre.gond...@arm.com wrote:
> From: Pierre Gondois
>
> In an effort to clean the documentation of the above
> package, remove duplicated words.
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Signed-off-by: Pierre Gondois
> ---
> ArmPkg/Drivers/ArmScmiD
On Tue, Aug 23, 2022 at 18:00:10 +0200, pierre.gond...@arm.com wrote:
> From: Pierre Gondois
>
> In an effort to clean the documentation of the above
> package, remove duplicated words.
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Signed-off-by: Pierre Gondois
Reviewed-by: Leif Lindholm
>
On Wed, 24 Aug 2022 at 13:05, Pedro Falcato wrote:
>
> Hi,
>
> So, what's your suggestion? Do you want me to add that to my package as well?
>
> There is obviously a huge problem with EDK2 build tools not knowing what a
> damn runtime library is.
The real problem here is that someone decided tha
Hi,
So, what's your suggestion? Do you want me to add that to my package as
well?
There is obviously a huge problem with EDK2 build tools not knowing what a
damn runtime library is. I personally don't think it's appropriate for me
to say "I want my package built with the stack protector", particu
Hi Swatisri,
I have dropped comments on the Flag's type based on Andrew's feedback.
Regards,
Rohit
> -Original Message-
> From: Rohit Mathew
> Sent: 19 August 2022 09:26
> To: devel@edk2.groups.io; usern...@nvidia.com; Sami Mujawar
> ; Alexei Fedorov ;
> michael.d.kin...@intel.com; gaoli
That makes sense, Andrew. Thanks for the info.
Regards,
Rohit
> Rohit,
>
> FYI I seem to remember when we added the bitfield verbiage to the UEFI Spec
> it was because there was lots of platform code that was using it. We did not
> really want to encourage its use it in public interfaces.
On Wed, 24 Aug 2022 at 09:49, Ard Biesheuvel wrote:
>
> On Tue, 23 Aug 2022 at 09:41, Bob Feng wrote:
> >
> > Hi Liming,
> >
> > Reverting patch may not a good idea, some platforms have done the
> > implementation based on the DSC spec, if revert, those platforms build will
> > break.
>
> Platf
On Tue, 23 Aug 2022 at 09:04, Gerd Hoffmann wrote:
>
> Hi,
>
> > > Looks good to me, but should be reflected to the other DSC files, and
> > > perhaps (see Gerd's comments) factored out to some common include snippet.
> >
> > Fair enough, although I'm not sure where to look for Gerd's comments?
On 08/22/22 18:59, Ard Biesheuvel wrote:
> On Thu, 18 Aug 2022 at 07:58, Laszlo Ersek wrote:
>>
>> On 08/17/22 17:11, Ard Biesheuvel wrote:
>>> Add a new library that can be incorporated into any driver built from
>>> source, and which permits loading of the driver to be inhibited based on
>>> the
On Tue, 23 Aug 2022 at 09:41, Bob Feng wrote:
>
> Hi Liming,
>
> Reverting patch may not a good idea, some platforms have done the
> implementation based on the DSC spec, if revert, those platforms build will
> break.
Platforms implemented against the DSC spec would have never worked if
they re
Zhiguang:
Thank you!
Abdul:
Can you give your response before tomorrow? I need to create the stable tag
on 2022-08-26
Thanks
Liming
发件人: devel@edk2.groups.io 代表 Zhiguang Liu
发送时间: 2022年8月23日 13:16
收件人: devel@edk2.groups.io; Gao, Liming ; 'Abdul
Lateef Attar'
抄送: llind...@qti.qua
Bob:
The commit 039bdb4d3e96f9c9264abf135b8a0eef2e2b4860 was merged into Edk2 on
Last month (2022 July 17th). This is very new change. It brings the behavior
change. But, it doesn't highlight its impact to collect feedback.
I suggest to revert it, because I think we need more time to discuss t
54 matches
Mail list logo
