On Tue, 23 Aug 2022 at 09:41, Bob Feng <bob.c.f...@intel.com> wrote: > > Hi Liming, > > Reverting patch may not a good idea, some platforms have done the > implementation based on the DSC spec, if revert, those platforms build will > break.
Platforms implemented against the DSC spec would have never worked if they relied on behavior that BaseTools currently does not implement. > This commit 039bdb4d3e96f9c9264abf135b8a0eef2e2b4860 make the Basetools > behavior be consistent with DSC spec so I don't think it's a regression bug. > Platforms built against the current behavior that used to work might break after this change. MdeModulePkg.dsc for ARM/AARCH64 no longer builds due to this change. Also, as I pointed out, the DSC spec is far from ambiguous. This means that platforms implemented against the spec will rely on one of several possible interpretations of that ambiguous set of rules. So let's revert this change now. Let's fix the DSC spec next, And only then, let's fix the code (assuming it still needs to be fixed) -- Ard. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92745): https://edk2.groups.io/g/devel/message/92745 Mute This Topic: https://groups.io/mt/93199761/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
