Reviewed-by: Jiewen Yao <jiewen....@intel.com> > -----Original Message----- > From: mikub...@linux.microsoft.com <mikub...@linux.microsoft.com> > Sent: Thursday, August 25, 2022 11:48 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen <jiewen....@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; > Zhang, Qi1 <qi1.zh...@intel.com>; Kumar, Rahul R <rahul.r.ku...@intel.com>; > Yao, Jiewen <jiewen....@intel.com> > Subject: [PATCH v2 5/8] SecurityPkg/SmmTcg2PhysicalPresenceLib: Add missing > debug print specifier > > From: Michael Kubacki <michael.kuba...@microsoft.com> > > The debug macro modified in this change was missing a print specifier > for a debug message argument given. > > Cc: Jiewen Yao <jiewen....@intel.com> > Cc: Jian J Wang <jian.j.w...@intel.com> > Cc: Qi Zhang <qi1.zh...@intel.com> > Cc: Rahul Kumar <rahul1.ku...@intel.com> > Signed-off-by: Michael Kubacki <michael.kuba...@microsoft.com> > Reviewed-by: Jiewen Yao <jiewen....@intel.com> > --- > > SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresenceLib > Common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresenceLi > bCommon.c > b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresenceLi > bCommon.c > index 1fbfc00547cd..f2ab4f125007 100644 > --- > a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresenceLi > bCommon.c > +++ > b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresenceLi > bCommon.c > @@ -176,7 +176,7 @@ > Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunctionEx ( > // Sync PPRQ/PPRM from PP Variable if PP submission fails > // > if (ReturnCode != TCG_PP_SUBMIT_REQUEST_TO_PREOS_SUCCESS) { > - DEBUG ((DEBUG_ERROR, "[TPM2] Submit PP Request failure! Sync > PPRQ/PPRM with PP variable.\n", Status)); > + DEBUG ((DEBUG_ERROR, "[TPM2] Submit PP Request failure! Sync > PPRQ/PPRM with PP variable. Status = %r\n", Status)); > DataSize = sizeof (EFI_TCG2_PHYSICAL_PRESENCE); > ZeroMem (&PpData, DataSize); > Status = mTcg2PpSmmVariable->SmmGetVariable ( > -- > 2.28.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92796): https://edk2.groups.io/g/devel/message/92796 Mute This Topic: https://groups.io/mt/93242251/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-