Reviewed-by: Yuwei Chen
> -Original Message-
> From: Konstantin Aladyshev
> Sent: Monday, July 18, 2022 8:56 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> ; Chen, Christine ;
> Konstantin Aladyshev
> Subject: [PATCH] BaseTools/VolInfo: Increase define for highest sectio
Reviewed-by: Yuwei Chen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> Konstantin Aladyshev
> Sent: Wednesday, July 13, 2022 9:11 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> ; Chen, Christine ;
> Konstantin Aladyshev
> Subject: [edk2-devel] [PATCH] B
Hi all,
I can generate Red1.cap capsule file from GenerateCapsule.py of edk2, and
execute CapsuleApp Red1.cap on Minnowboard to complete the process of capsule
update.
Build capsule file command:
\BaseTools\Source\Python\Capsule>GenerateCapsule.py -e -j red1.json -o red1.cap
--capflag PersistAcr
Hi Christine,
Thanks for review, and this bug is come from commit :
https://github.com/tianocore/edk2/commit/bf9230a9f3dde065c3c8b4175ccd32e44e8f0362
This commit introduce a new feature to conditional build source file in INF,
Such like: curve25519.c
|*|*|*|gEfiCryptoPkgTokenSpaceGuid.PcdO
Hi Yi,
Could you describe the bug with an example? In which scenario the dsc defined
pcd will not override the dec definition?
Thanks,
Christine
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of yi1 li
> Sent: Monday, July 11, 2022 1:48 PM
> To: devel@edk2.groups.io
> Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4003
In some environment, the directly calling for gcc is not supported.
This patch fixes the issue.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Source/C/DevicePath/GNUmakefile | 13 -
1 file changed, 8 in
Cc: Harry Han
Cc: Andrew Fish
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
Reviewed-by: Harry Han
---
Maintainers.txt | 2 --
1 file changed, 2 deletions(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index bc7caa12d8d9..0ea6b4041654 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Daniel Schaefer
Cc: Sean Rhodes
Cc: Debkumar De
Cc: Erdem Aktas
Cc: Gary Lin
Cc: Julien Grall
Signed-off-by: Michael D Kinney
Reviewed-by: Daniel Schaefer
Reviewed-by: Sean Rhodes
Reviewed-by: Debkumar De
Acked-by: Gary Lin
---
Maintainers.txt | 1
XenTimerDxe has been removed from the OvmfPkg. Remove
file pattern for XenTimerDxe reviews from Maintainers.txt.
Cc: Anthony Perard
Cc: Julien Grall
Cc: Andrew Fish
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
Acked-by: Anthony PERARD
---
Maintainers.txt | 1 -
1 file changed, 1 delet
Cc: Anthony Perard
Cc: Julien Grall
Cc: Daniel Schaefer
Cc: Sean Rhodes
Cc: Debkumar De
Cc: Erdem Aktas
Cc: Harry Han
Cc: Gary Lin
Cc: Andrew Fish
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
Michael D Kinney (3):
Maintainers.txt: Remove OvmfPkg/XenTimerDxe reference
Maintainer
Hi Mickael,
Reviewed-by: Han, Harry ;
Thanks,
-Harry
-Original Message-
From: Kinney, Michael D
Sent: Wednesday, July 20, 2022 8:15 PM
To: devel@edk2.groups.io
Cc: Han, Harry ; Andrew Fish ; Leif
Lindholm
Subject: [Patch v2 3/3] Maintainers.txt: Remove reviewer Harry Han
Cc: Harry H
Reviewed-by: Sean Rhodes
On Wed, 20 Jul 2022 at 22:58, Michael D Kinney
wrote:
> Cc: Andrew Fish
> Cc: Leif Lindholm
> Cc: Daniel Schaefer
> Cc: Sean Rhodes
> Cc: Debkumar De
> Cc: Erdem Aktas
> Signed-off-by: Michael D Kinney
> ---
> Maintainers.txt | 10 +-
> 1 file changed, 5
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
PhytiumCommonPkg platforms build.
Cc: Leif Lindholm
Cc: Peng Xie
Cc: Ling Jia
Cc: Yiqi Shu
Signed-off-by: Kun Qin
---
Note
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
DeveloperBox platforms build.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Masami Hiramatsu
Signed-off-by: Kun Qin
---
Notes:
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
SbsaQemu platform builds.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Graeme Gregory
Cc: Radoslaw Biernacki
Signed-off-by: Kun
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
AmpereAltraPkg platforms build.
Cc: Nhi Pham
Cc: Vu Nguyen
Cc: Thang Nguyen
Cc: Chuong Tran
Cc: Leif Lindholm
Signed-off-by
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
U5SeriesPkg platforms build.
Cc: Abner Chang
Cc: Gilbert Chen
Cc: Daniel Schaefer
Signed-off-by: Kun Qin
---
Notes:
v2:
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
ArmVExpress platforms build.
Cc: Ard Biesheuvel
Cc: Thomas Abraham
Cc: Sami Mujawar
Signed-off-by: Kun Qin
Reviewed-by: Sami
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
RaspberryPi platforms build.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Jeremy Linton
Signed-off-by: Kun Qin
Reviewed-by: Jere
From: Kun
This v2 series is a follow up of previously submitted patches:
https://edk2.groups.io/g/devel/message/91195
Compared to v1, v2 patches updated commit message to include Review-by
tags collected during v1 review cycle.
Patch v2 branch:https://github.com/kuqin12/edk2-platforms/tree/fix_
On 19/07/2022 14:52, Anthony Perard wrote:
> diff --git a/OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.h
> b/OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.h
> index 350b7bd309c0..67ee1899e9a8 100644
> --- a/OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.h
> +++ b/OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.h
> @@ -11,8 +11,9 @@
> #define __EFI_XEN_P
> On 20. Jul 2022, at 08:17, Savva Mitrofanov wrote:
>
> Provided support for symlink file type. Added routine which allows
> reading and following them through recursive open() call. As a security
> meausure implemented simple symlink loop check with nest level limit
> equal 8. Also this patch
Reviewed-by: Marvin Häuser
> On 20. Jul 2022, at 08:47, Savva Mitrofanov wrote:
>
> We shouldn't use direct casts, because in the future it could break
> the code, so using BASE_CR would be safe against possible structure
> changes and rearrangements
>
> Cc: Marvin Häuser
> Cc: Pedro Falcato
On 20. Jul 2022, at 07:36, Savva Mitrofanov wrote:
>
> This changes tends to improve security of code sections by fixing
> integer overflows, missing aligment checks, unsafe casts, also
> simplified some routines, fixed compiler warnings and corrected some
> code mistakes.
>
> - Set HoleLen to U
We shouldn't use direct casts, because in the future it could break
the code, so using BASE_CR would be safe against possible structure
changes and rearrangements
Cc: Marvin Häuser
Cc: Pedro Falcato
Cc: Vitaly Cheptsov
Signed-off-by: Savva Mitrofanov
---
Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h |
Set HoleLen to UINT64 to perform safe cast to UINTN in ternary operator
at WasRead assignment
Cc: Marvin Häuser
Cc: Pedro Falcato
Cc: Vitaly Cheptsov
Signed-off-by: Savva Mitrofanov
---
Features/Ext4Pkg/Ext4Dxe/Inode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Fe
We shouldn't use direct casts, because in the future it could break
the code, so using BASE_CR would be safe against possible structure
changes and rearrangements
Cc: Marvin Häuser
Cc: Pedro Falcato
Cc: Vitaly Cheptsov
Signed-off-by: Savva Mitrofanov
---
Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h |
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3677
Provided support for symlink file type. Added routine which allows
reading and following them through recursive open() call. As a security
meausure implemented simple symlink loop check with nest level limit
equal 8. Also this patch moves Ext
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3677
Hi all,
In previous patchset I forgot to mention 3677 bug dedicated to symlinks.
So in v2 I took it into account.
This patchset adds symbolic links support with simple recursion protection based
on symbolic link nest level limitation, also
Provided support for symlink file type. Added routine which allows
reading and following them through recursive open() call. As a security
meausure implemented simple symlink loop check with nest level limit
equal 8. Also this patch moves Ext4Open functionality to internal
routine.
Cc: Marvin Häus
Hi all,
This is second version of patch in which I squashed commits into one.
Here attempts to improve security of code sections by fixing integer overflows,
missing aligment checks, unsafe casts. Also I simplified some routines, fixed
compiler warnings and corrected some code mistakes.
REF:
ht
This changes tends to improve security of code sections by fixing
integer overflows, missing aligment checks, unsafe casts, also
simplified some routines, fixed compiler warnings and corrected some
code mistakes.
- Set HoleLen to UINT64 to perform safe cast to UINTN in ternary
operator at WasRead
Hi all,
This patchset adds symbolic links support with simple recursion protection based
on symbolic link nest level limitation, also I included patch which adds BASE_CR
to extract EXT4_FILE private structure to prevent possible code corruption
caused
by structure changes and rearrangements in fu
Adds 4-byte aligned check for superblock group descriptor size field
Cc: Marvin Häuser
Cc: Pedro Falcato
Cc: Vitaly Cheptsov
Signed-off-by: Savva Mitrofanov
---
Features/Ext4Pkg/Ext4Dxe/Directory.c | 2 +-
Features/Ext4Pkg/Ext4Dxe/Superblock.c | 10 +-
2 files changed, 6 insertions(
Cc: Marvin Häuser
Cc: Pedro Falcato
Cc: Vitaly Cheptsov
Signed-off-by: Savva Mitrofanov
---
Features/Ext4Pkg/Ext4Dxe/Extents.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Features/Ext4Pkg/Ext4Dxe/Extents.c
b/Features/Ext4Pkg/Ext4Dxe/Extents.c
index c5951f78aa62..80427d
First of all BASE_LIST_FOR_EACH_SAFE doesn't have any sanity checks. So
its usage isn't "safe". We can drop this loop and use just IsNodeInList
Cc: Marvin Häuser
Cc: Pedro Falcato
Cc: Vitaly Cheptsov
Signed-off-by: Savva Mitrofanov
---
Features/Ext4Pkg/Ext4Dxe/Directory.c | 16 ++-
Seems that returning maximum uintn in case of bad block was a mistake,
so return just bad block type
Cc: Marvin Häuser
Cc: Pedro Falcato
Cc: Vitaly Cheptsov
Signed-off-by: Savva Mitrofanov
---
Features/Ext4Pkg/Ext4Dxe/BlockMap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Initialize all fields in gExt4BindingProtocol. Fix comparison of integer
expressions of different signedness.
Cc: Marvin Häuser
Cc: Pedro Falcato
Cc: Vitaly Cheptsov
Signed-off-by: Savva Mitrofanov
---
Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h | 2 +-
Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c | 10 +
Field name_len has type CHAR8, while filename limit is 255
(EXT4_NAME_MAX), so because structure EXT4_DIR_ENTRY would be
unchangeable in future, we could drop this check without any
assertions
Cc: Marvin Häuser
Cc: Pedro Falcato
Cc: Vitaly Cheptsov
Signed-off-by: Savva Mitrofanov
---
Features
Replace EXT4_BLOCK_NR with 32-bit EXT2_BLOCK_NR in BlockMap, because we
consider BlockMap is 32-bit fs ext2/3 feature
Cc: Marvin Häuser
Cc: Pedro Falcato
Cc: Vitaly Cheptsov
Signed-off-by: Savva Mitrofanov
---
Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h | 1 +
Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h |
Replaced UNREACHABLE with ASSERT (FALSE) in case of new checksum
algorithms, due to it is an invariant violation rather than unreachable
path
Cc: Marvin Häuser
Cc: Pedro Falcato
Cc: Vitaly Cheptsov
Signed-off-by: Savva Mitrofanov
---
Features/Ext4Pkg/Ext4Dxe/Superblock.c | 2 +-
1 file change
Cc: Marvin Häuser
Cc: Pedro Falcato
Cc: Vitaly Cheptsov
Signed-off-by: Savva Mitrofanov
---
Features/Ext4Pkg/Ext4Dxe/Inode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Features/Ext4Pkg/Ext4Dxe/Inode.c b/Features/Ext4Pkg/Ext4Dxe/Inode.c
index 831f5946e870..142ee6e3d
Hi all,
This patchset attempts to improve security of code sections by fixing integer
overflows,
missing aligment checks, unsafe casts. Also I simplified some routines, fixed
compiler warnings and
corrected some code mistakes.
REF:
https://github.com/savvamitrofanov/edk2-platforms/commits/ext
Vktimer event Task Priority Level changed to TPL_CALLBACK from TPL_NOTIFY
to fix Virtual Keyboard touch slowness issues and touch not working issues
Cc: Dandan Bi
Cc: Liming Gao
Cc: Madhan Pethaiyan
Cc: Kathappan Esakkithevar
Cc: Madhusudhan Balaji
Signed-off-by: KalaiyarasanX Thangaraj
---
Hi Rohit,
On Wed, Jul 6, 2022 at 06:42 AM, Rohit Mathew wrote:
>
> =20
> @@ -86,6 +86,10 @@ CEntryPoint (
> ArmEnableVFP ();
> }
> =20
> + // Explicitly invoke the library constructor to resolve any library
> + // dependency.
> + ProcessLibraryConstructorList();
> +
I missed this in my previous
Hi Rebecca, Ard,
On Tue, May 3, 2022 at 12:43 AM, Ard Biesheuvel wrote:
>
>
>> // Data Cache enabled on Primary core when MMU is enabled.
>> ArmDisableDataCache ();
>> // Invalidate instruction cache
>> @@ -90,6 +95,18 @@ CEntryPoint (
>>
>> // If not primary Jump to Secondary Main
>> if (ArmP
Hi Rohit,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 06/07/2022 02:42 pm, Rohit Mathew wrote:
Invoke the constructor in the SEC phase to call into initialization
functions associated with libraries linked with this particular module.
For instance, PrePeiCore's CEnt
*TianoCore edk2-test Bug Triage Meeting*
*When:*
07/21/2022
10:00pm to 11:00pm
(UTC+08:00) Asia/Shanghai
*Where:*
https://armltd.zoom.us/j/93809865843?pwd=dU1hSzk4NHM2RGhaRDRyWWZxUzY5dz09&from=addon
*Organizer:* Edhaya Chandran edhaya.chand...@arm.com (
edhaya.chand...@arm.com?subject=Re:%20Eve
*Reminder: TianoCore edk2-test Bug Triage Meeting*
*When:*
07/21/2022
10:00pm to 11:00pm
(UTC+08:00) Asia/Shanghai
*Where:*
https://armltd.zoom.us/j/93809865843?pwd=dU1hSzk4NHM2RGhaRDRyWWZxUzY5dz09&from=addon
*Organizer:* Edhaya Chandran edhaya.chand...@arm.com (
edhaya.chand...@arm.com?subject
The current string lenght (=60) is not enough for cases where basename
is a path to Build folder.
Drop custom define and use MAX_LINE_LEN from the BaseTools codebase
instead.
Signed-off-by: Konstantin Aladyshev
---
BaseTools/Source/C/VolInfo/VolInfo.c | 4 +---
1 file changed, 1 insertion(+), 3
Currently COMPAT16 section type is not recognized and GenSec is called
without the "-s [SectionType]" argument.
Add COMPAT16 type to the SectionType dictionary to fix the issue.
Now this syntax works correctly:
```
FILE FREEFORM = {
SECTION COMPAT16 =
}
```
Signed-off-by: Konstantin Aladyshe
Hi Rohit,
Have you considered moving to use Dynamic Tables Framework? There is
just too much repetition in this series which can be easily avoided. It
will also make the code more maintainable.
Apart from this I have a comment marked inline as [SAMI].
Regards,
Sami Mujawar
On 04/07/2022 05
Hi Rohit,
These changes are fine, just too repetitive.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/07/2022 05:59 pm, Rohit Mathew wrote:
Patch 433b5b1b0f7f ("Platform/Sgi: Route logs to different sets of
consoles") assigns different address for the console UART and the debug
UART.
Hi Nishant,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 17/06/2022 07:07 am, Nishant Sharma wrote:
Isolated CPUs are those that are not to be used on the platform for
various reasons. The isolated CPU list is an array of MPID values of
[SAMI] Can you explain the us
On 7/21/22 12:42, Yao, Jiewen wrote:
Hi Pierre
Sorry, I should have given the specific comment.
[PATCH v3 12/22] SecurityPkg: Update Securitypkg.ci.yaml
Why we need ArmPkg as new dependency? I don’t think this is good idea.
Can we have a way to remove that dependency?
Thank you
Yao, Jiewen
+ CopyMem (&RNGAlgorithmList[0], gEfiRngAlgorithmSp80090Ctr256Guid, sizeof
(EFI_RNG_ALGORITHM));
Should it be &gEfiRngAlgorithmSp80090Ctr256Guid ? The dereference is missing.
Thank you
Yao Jiewen
> -Original Message-
> From: pierre.gond...@arm.com
> Sent: Wednesday, June 29, 2022 11
> + #ifdef MDE_CPU_AARCH64
> + // Check FEAT_RNG before advertising PcdCpuRngSupportedAlgorithm.
> + if (ArmHasRngExt ()) {
Usually, we don't prefer use "#ifdef" in a common code.
Instead, the general pattern is to define Architecture specific directory, and
move architecture specific doe ther
Hi Pierre
Sorry, I should have given the specific comment.
[PATCH v3 12/22] SecurityPkg: Update Securitypkg.ci.yaml
Why we need ArmPkg as new dependency? I don’t think this is good idea.
Can we have a way to remove that dependency?
Thank you
Yao, Jiewen
> -Original Message-
> From: dev
Hi Pierre
I give the feedback on interface design and dependency, esp SecurityPkg and
MdePkg.
1) Please don’t change package dependency policy.
2) For AesLib/DrbgLib/TrbgLib, I already expressed my concern on adding those
new APIs in MdePkg. Please try to avoid that.
Basically, since this is ARM
Acked-by: Gary Lin
On Wed, Jul 20, 2022 at 08:14:43PM -0700, Michael D Kinney wrote:
> Cc: Andrew Fish
> Cc: Leif Lindholm
> Cc: Daniel Schaefer
> Cc: Sean Rhodes
> Cc: Debkumar De
> Cc: Erdem Aktas
> Cc: Gary Lin
> Signed-off-by: Michael D Kinney
> ---
> Maintainers.txt | 12 ++-
Hi all,
In \FmpDevicePkg\Library\FmpDeviceLibNull\FmpDeviceLib.c
There are comments for RegisterFmpInstaller :
/**
Used to pass the FMP install function to this lib. This allows the library to
have control of the handle that the FMP instance is installed on. This allows
the library to use Dri
On Wed, Jul 20, 2022 at 02:58:26PM -0700, Michael D Kinney wrote:
> XenTimerDxe has been removed from the OvmfPkg. Remove
> file pattern for XenTimerDxe reviews from Maintainers.txt.
>
> Cc: Anthony Perard
> Cc: Julien Grall
> Cc: Andrew Fish
> Cc: Leif Lindholm
> Signed-off-by: Michael D Kin
Please try to not use AllocatePool in this library because in early part
of DxeMain, the memory service may not be available.
You could use a C array with maximum maybe 16 elements.
Then the SerialPortLib may only support up to 16 serial ports.
But I think that should be enough.
Thanks,
Ray
> --
Let DxeMain.inf consume new SerialPortLib to support multiple
channel debug message on early DXE.
Cc: Guo Dong
Cc: Ray Ni
Cc: Sean Rhodes
Cc: Gua Guo
Signed-off-by: Kavya
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/UefiPayloadPkg/UefiPayloadPkg
Add new Serial port library instance that consumes the HOB defined
in MdeModulePkg/Include/UniversalPayload/SerialPortInfo.h to support
multiple UART's.
Cc: Guo Dong
Cc: Ray Ni
Cc: Sean Rhodes
Cc: Gua Guo
Signed-off-by: Kavya
---
UefiPayloadPkg/Library/BaseSerialPortLibHob/BaseSerialPortLibH
Hi Jiewen,
On 7/20/22 18:44, Yao, Jiewen wrote:
Hey
This patch add dependency that SecurityPkg will depend on ArmPkg.
I am not sure it is good idea. As alternative, why not put all those to ArmPkg?
Then you don’t need change the package dependency.
I am not sure I understood what you want to
66 matches
Mail list logo
