Initialize all fields in gExt4BindingProtocol. Fix comparison of integer expressions of different signedness.
Cc: Marvin Häuser <mhaeu...@posteo.de> Cc: Pedro Falcato <pedro.falc...@gmail.com> Cc: Vitaly Cheptsov <vit9...@protonmail.com> Signed-off-by: Savva Mitrofanov <savva...@gmail.com> --- Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h | 2 +- Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c | 10 ++++++---- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h b/Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h index 3aef6f0e5bb4..7a19d2f79d53 100644 --- a/Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h +++ b/Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h @@ -338,7 +338,7 @@ STATIC_ASSERT ( #define EXT4_TIND_BLOCK 14 #define EXT4_NR_BLOCKS 15 -#define EXT4_GOOD_OLD_INODE_SIZE 128 +#define EXT4_GOOD_OLD_INODE_SIZE 128U typedef struct _Ext4_I_OSD2_Linux { UINT16 l_i_blocks_high; diff --git a/Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c b/Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c index 43b9340d3956..2a4f5a7bd0ef 100644 --- a/Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c +++ b/Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c @@ -260,10 +260,12 @@ Ext4Stop ( EFI_DRIVER_BINDING_PROTOCOL gExt4BindingProtocol = { - Ext4IsBindingSupported, - Ext4Bind, - Ext4Stop, - EXT4_DRIVER_VERSION + .Supported = Ext4IsBindingSupported, + .Start = Ext4Bind, + .Stop = Ext4Stop, + .Version = EXT4_DRIVER_VERSION, + .ImageHandle = NULL, + .DriverBindingHandle = NULL }; /** -- 2.37.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91651): https://edk2.groups.io/g/devel/message/91651 Mute This Topic: https://groups.io/mt/92531467/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-