On Mon, Dec 13, 2021 at 08:56:46PM +0800, Min Xu wrote:
> RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
>
> In Tdx BSP may issues commands to APs for some task, for example, to
> accept pages paralelly. BSP also need to wait until all the APs have
> done the task. TdxMailboxLib wraps th
> +++ b/OvmfPkg/Include/IndustryStandard/IntelTdx.h
> @@ -0,0 +1,76 @@
> +/** @file
> + Defines the defitions used by TDX in OvmfPkg.
Add pointer to the specs here?
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#8486
On Mon, Dec 13, 2021 at 08:56:44PM +0800, Min Xu wrote:
> RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
>
> In TDVF BSP and APs are simplified. BSP is the vCPU-0, while the others
> are treated as APs.
>
> So MP intialization is rather simple. The processor info is retrieved by
> TDCAL
On Wed, 15 Dec 2021 at 06:46, gaoliming wrote:
>
> Reviewed-by: Liming Gao
>
Merged as #2307
Thanks,
> > -邮件原件-
> > 发件人: devel@edk2.groups.io 代表 Xu, Wei6
> > 发送时间: 2021年12月9日 14:52
> > 收件人: devel@edk2.groups.io
> > 抄送: Ard Biesheuvel ; Sami Mujawar
> > ; Jiewen Yao ; Supreeth
> > Venk
On Mon, Dec 13, 2021 at 08:56:41PM +0800, Min Xu wrote:
> RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
>
> This commit supports IoRead/IoWrite for SEV/TDX/Legacy guest in one
> binary. It checks the guest type in runtime and then call corresponding
> functions.
>
> Cc: Michael D Kinne
Hi,
> +VOID
> +EFIAPI
> +IoReadFifo8 (
> + IN UINTN Port,
> + IN UINTN Count,
> + OUT VOID *Buffer
> + )
> +{
> + if (IsTdxGuest ()) {
> +TdIoReadFifo8 (Port, Count, Buffer);
> + } else {
> +SevIoReadFifo8 (Port, Count, Buffer);
> + }
> +}
Hmm, this is confusing
On Mon, Dec 13, 2021 at 08:56:39PM +0800, Min Xu wrote:
> RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
>
> TDVF access MMIO with TDG.VP.VMCALL to invoke VMM provided emulation
> functions. If the access to MMIO fails, it fall backs to the direct
> access.
>
> BaseIoLibIntrinsic.inf is
On Mon, Dec 13, 2021 at 08:56:36PM +0800, Min Xu wrote:
> RFC： https://bugzilla.tianocore.org/show_bug.cgi?id=3429
>
> The base VmgExitLib library provides a default limited interface to
> handle #VE exception. To provide full support, the OVMF version of
> VmgExitLib is extended to provide full s
On Mon, Dec 13, 2021 at 08:56:34PM +0800, Min Xu wrote:
> RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
>
> TdxLib is created with functions to perform the related Tdx operation.
> This includes functions for:
> - TdAcceptPages : Accept pending private pages and initialize the pages
On Mon, Dec 13, 2021 at 08:56:33PM +0800, Min Xu wrote:
> RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
>
> Introduce basic Tdx functions in BaseLib:
> - TdCall ()
> - TdVmCall ()
> - TdIsEnabled ()
>
> Cc: Michael D Kinney
> Cc: Liming Gao
> Cc: Zhiguang Liu
> Cc: Brijesh Singh
Rency:
I add my comments into BZ.
Thanks
Liming
发件人: devel@edk2.groups.io 代表 Yao, Jiewen
发送时间: 2021年12月15日 13:43
收件人: Reji, RencyX ; devel@edk2.groups.io
抄送: Zhang, Qi1 ; Kumar, Rahul1
; Wang, Jian J ; H,
Krishnaprasad ; Patil, Subhashini
; Krishnappa, Banuprakash
主题: Re: [edk2-devel] [P
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Xu, Wei6
> 发送时间: 2021年12月9日 14:52
> 收件人: devel@edk2.groups.io
> 抄送: Ard Biesheuvel ; Sami Mujawar
> ; Jiewen Yao ; Supreeth
> Venkatesh ; Liming Gao
>
> 主题: [edk2-devel][Patch] StandaloneMmPkg/FvLib: Support large file with
This solution does not make sense to me.
Please start a discussion with MdePkg owner at first.
Thank you
Yao Jiewen
From: Reji, RencyX
Sent: Wednesday, December 15, 2021 1:39 PM
To: devel@edk2.groups.io; Yao, Jiewen
Cc: Zhang, Qi1 ; Kumar, Rahul1 ;
Wang, Jian J ; H, Krishnaprasad
; Patil, Su
(Add more people)
Hello Mike, Liming and Star,
Do you have suggestions for the below question raised from Jeff Brasen:
" The core of the issue I am trying to solve it support variable services on a
UFS device. When the UFS blockIO is invoked from variable services it is not
allowed (which does
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Zhiguang Liu
> 发送时间: 2021年12月15日 12:32
> 收件人: Chu, Maggie ; devel@edk2.groups.io
> 抄送: Gao, Liming ; Kinney, Michael D
>
> 主题: Re: [edk2-devel] [PATCH] MdePkg: Add registers of boot partition
> feature
>
> I have checked t
Pedro:
Does Brotli fix GCC warning in the latest version?
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Pedro Falcato
> 发送时间: 2021年12月8日 18:27
> 收件人: devel@edk2.groups.io
> 主题: [edk2-devel] [PATCH v2 0/2] Update brotli to the latest commit
>
> BZ: https://bugzilla.tianocore.or
Reviewed-by: Hao A Wu
Will hold the merge a couple of days to see if comments from other reviewers.
Best Regards,
Hao Wu
> -Original Message-
> From: Ke, VincentX
> Sent: Wednesday, December 15, 2021 11:23 AM
> To: devel@edk2.groups.io
> Cc: Ke, VincentX ; Wu, Hao A
> ; Ni, Ray ; Chiu,
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Mikhail Krichanov
> 发送时间: 2021年12月8日 18:05
> 收件人: devel@edk2.groups.io
> 抄送: Bob Feng ; Liming Gao
> ; Yuwei Chen ; Vitaly
> Cheptsov ; Mikhail Krichanov
>
> 主题: [PATCH] BaseTools: Fix for NOOPT CLANG38 compilation with clang-13
>
> REF: https://
> -Original Message-
> From: Wu, Hao A
> Sent: Tuesday, December 14, 2021 8:00 PM
> To: Jeff Brasen ; devel@edk2.groups.io
> Cc: Ni, Ray
> Subject: RE: [PATCH] MdeModulePkg/ScsiDisk: Change TPL to NOTIFY
>
> External email: Use caution opening links or attachments
>
>
> > -Origi
I have checked that the change follows NVM Express 1.4 Spec
Reviewed-by: Zhiguang Liu
-Original Message-
From: Chu, Maggie
Sent: Wednesday, December 8, 2021 3:18 PM
To: devel@edk2.groups.io
Cc: Liming Gao ; Kinney, Michael D
; Liu, Zhiguang
Subject: [PATCH] MdePkg: Add registers of b
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3714
Replace with UFS_UNIT_DESC to fix response timeout problem.
Cc: Hao A Wu
Cc: Ray Ni
Cc: Ian Chiu
Cc: Maggie Chu
Signed-off-by: VincentX Ke
---
.../Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c | 20 +--
1 file changed, 9 in
Thanks, I saw one comment given in the V1 patch is not addressed in V2.
Please refer to the inline comment below:
> -Original Message-
> From: Ke, VincentX
> Sent: Wednesday, December 15, 2021 9:57 AM
> To: devel@edk2.groups.io
> Cc: Ke, VincentX ; Wu, Hao A
> ; Ni, Ray ; Chiu, Ian
> ; C
> -Original Message-
> From: Jeff Brasen
> Sent: Wednesday, December 15, 2021 1:59 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Ni, Ray ; Jeff
> Brasen
> Subject: [PATCH] MdeModulePkg/ScsiDisk: Change TPL to NOTIFY
>
> Increase TPL to TPL_NOTIFY to allow for use if caller is > TPL_CAL
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3714
Replace with UFS_UNIT_DESC to fix response timeout problem.
Cc: Hao A Wu
Cc: Ray Ni
Cc: Ian Chiu
Cc: Maggie Chu
Signed-off-by: VincentX Ke
---
.../Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c | 20 +--
1 file changed, 9 in
The ARM_CORE_INFO struct has been updated so the MPIDR is now a single
field instead of separate cluster/core fields. Update the initializer.
Signed-off-by: Rebecca Cran
---
Silicon/Qemu/SbsaQemu/Library/SbsaQemuLib/SbsaQemuLib.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
dif
The ARM_CORE_INFO struct has been updated so the MPIDR is now a single
field instead of separate cluster/core fields. Update the initializer.
Signed-off-by: Rebecca Cran
---
Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLib.c | 8
1 file changed, 4 insertions(+), 4 deletion
The ARM_CORE_INFO struct has been updated so the MPIDR is now a single
field instead of separate cluster/core fields. Update the initializer.
Signed-off-by: Rebecca Cran
---
Silicon/Socionext/SynQuacer/Library/SynQuacerLib/SynQuacer.c | 48
++--
1 file changed, 24 insertions(+),
The ARM_CORE_INFO struct has been updated so the MPIDR is now a single
field instead of separate cluster/core fields. Update the initializer.
Signed-off-by: Rebecca Cran
---
Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c | 12
++--
Platform/ARM/VExpressPkg/Library/Ar
MpInitLib is now required for all users of ArmPkg/Drivers/CpuDxe. Add
ArmPkg/Library/MpInitLib/DxeMpInitLib.inf .
Signed-off-by: Rebecca Cran
---
Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
b/Platform/Qemu/SbsaQemu/
MpInitLib is now required for all users of ArmPkg/Drivers/CpuDxe. Add
ArmPkg/Library/MpInitLib/DxeMpInitLib.inf .
Signed-off-by: Rebecca Cran
---
Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 +
Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 +
2 files change
MpInitLib is now required for all users of ArmPkg/Drivers/CpuDxe. Add
ArmPkg/Library/MpInitLib/DxeMpInitLib.inf .
Signed-off-by: Rebecca Cran
---
Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
b/Sil
MpInitLib is now required for all users of ArmPkg/Drivers/CpuDxe. Add
ArmPkg/Library/MpInitLib/DxeMpInitLib.inf .
Signed-off-by: Rebecca Cran
---
Platform/ARM/JunoPkg/ArmJuno.dsc | 1 +
Platform/ARM/Morello/MorelloPlatform.dsc.inc | 1 +
Platform/ARM/N1Sdp/N1SdpPlatform.dsc |
This patch series depends on the "Add EFI_MP_SERVICES_PROTOCOL support
for AARCH64" series which is in the process of being reviewed (I'm
sending a v2 soon).
With the addition of EFI_MP_SERVICES_PROTOCOL support for Arm, consumers
of ArmPkg/Drivers/CpuDxe now need an instance of MpInitLib. This
> The Raspberry Pi support in edk2-platforms, including ACPI, is a direct
> ancestor of the original ms-iot tree (https://github.com/ms-iot/RPi-UEFI, by
> way of https://github.com/andreiw/RaspberryPiPkg).
> The way the miniUART is described in ACPI came from Microsoft. Microsoft
> introduced DB
From: "manickavasakam karpagavinayagam via groups.io"
The list of WhiskeyLake and Whitley boards got confused at some
earlier merge. Also untabified.
Cc: Nate DeSimone
Cc: Sai Chaganty
Cc: Chasel Chiu
Signed-off-by: Isaac Oram
---
Platform/Intel/Readme.md | 35 ++--
1 file
The patch removes PciExpressLib implementation for N1Sdp as:
a) The PciSegmentLib implementation for N1Sdp makes MmioRead() calls
instead of PciRead() which makes the PciExpressLib redundant.
b) Since N1Sdp requires multiple segments to be supported, PciExpressLib
and PciLib cannot
This patch enables CCIX root complex support by updating
the root complex node info in PciHostBridge library.
The corresponding PCDs are updated.
Change-Id: I0510b1023aec16365b614d4eaf81858851d9fa28
Signed-off-by: Khasim Syed Mohammed
---
.../ConfigurationManager.c| 6 +-
..
The BasePCISegment Library in MdePkg doesn't allow configuring
multiple segments required for PCIe and CCIX root port
enumeration. Therefore, a custom PCI Segment library is adapted
from SynQuacerPciSegmentLib and ported for N1Sdp.
In addition to this, the hardware has few other limitations which
The patch series removes PciExpressLib and enables CCIX port
as PCIe root on N1SDP.
V4:
- Remove PciExpressLib and use PciSegmentLib instead. More detailed explanation
is included in the patch.
V3:
- The conditional logic in GetPciExpressAddress is made simple.
- Removed few more PCD entries th
Pushed as 9006967c8d24..38f6d78c3b62
Regards,
Sami Mujawar
On 09/12/2021 09:32 AM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
v3:
- Run uncrustify and apply the required formatting. [Pierre]
- No other change with v2. [Pierre]
v2:
- Various small fixes (change status returned, reset
Hi Pierre,
Thank you for this patch series.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 09/12/2021 09:32 AM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
v3:
- Run uncrustify and apply the required formatting. [Pierre]
- No other change with v2. [Pierre]
v2:
- Various small
Increase TPL to TPL_NOTIFY to allow for use if caller is > TPL_CALLBACK.
This allows services like variable services that run at TPL_NOTIFY to
be hosted on ScsiDisks (i.e. UFS)
Aligns with the eMMC driver that also uses a higher TPL.
This change was made in 3b1d8241d0dac25c5e678c364fa2754ac1731060
Hi,
On 12/14/21 00:21, Andrei Warkentin wrote:
The Raspberry Pi support in edk2-platforms, including ACPI, is a direct
ancestor of the original ms-iot tree (https://github.com/ms-iot/RPi-UEFI, by
way of https://github.com/andreiw/RaspberryPiPkg).
The way the miniUART is described in ACPI came
Hi Chris,
Thanks for fixing this issue.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
From: Chris Jones
Date: Tuesday, 14 December 2021 at 12:38
To: devel@edk2.groups.io
Cc: ray...@intel.com , zhichao@intel.com
, rebe...@nuviainc.com , Sami
Mujawar , nd
Subject: [PATCH v1 1/1] Shel
Hi Pierre,
Thank you for this patch series.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 09/12/2021 09:31 AM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
v4:
- Run uncrustify and apply the required formatting. [Pierre]
- No other change with v3. [Pierre]
v3:
- Populate the 6
From: Michael Kubacki
Adds a step to the development process instructions to account for
code formatting since it is now a required part of the contribution
process.
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Michael Kubacki
---
Notes:
Rendered
Looks good to me.
Reviewed-by: Sunny Wang
Hi Patrick,
This patch is to address your comment below. Could you give this patch a try on
your side?
https://edk2.groups.io/g/devel/message/79766?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3Arecentpostdate%2Fsticky%2C%2CSecurityPkg%3A+Create+library+for+enrolling+Se
Hi Pierre,
> From: Pierre Gondois
>
> Hardware information parser is an optional module defined
> by the Dynamic Tables Framework. It can either parse an
> XML, a Device Tree or a Json file containing the platform
> hardware information to populate the platform information
> repository.
>
> The
Reviewed-by: Rebecca Cran
Thanks, I'm now seeing:
ERROR: On Arm based systems, all cache properties must be provided in
the cache
type structure. Missing 'Write Policy Valid' flag.
--
Rebecca Cran
On 12/14/21 5:37 AM, Chris Jones wrote:
Bugzilla: 3770 (https://bugzilla.tianocore.org/sh
On Tue, 14 Dec 2021 at 14:42, Min Xu wrote:
>
> RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
>
> There are below new functions added in EmbeddedPkg/PrePiLib.
> 1. FfsAnyFvFindFileByName
>This function is to find the file by name in the FvImage.
> 2. FfsDecompressSection
>This f
On Tue, 14 Dec 2021 at 14:42, Min Xu wrote:
>
> RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
>
> This function is a null stub to make the build success.
>
> Cc: Michael D Kinney
> Cc: Brijesh Singh
> Cc: Erdem Aktas
> Cc: James Bottomley
> Cc: Jiewen Yao
> Cc: Tom Lendacky
> Cc:
Hi Zhichao Gao, Ray Ni, Sami Mujawar,
Please review and create PR if looks good.
Thanks
AbduL
-Original Message-
From: Sami Mujawar
Sent: Monday, November 22, 2021 11:24 PM
To: Attar, AbdulLateef (Abdul Lateef) ;
devel@edk2.groups.io
Cc: Ray Ni ; Zhichao Gao ; nd
Subject: Re: [PATC
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
With the introduction of TDVF Config-B, some Tdx libs should be added
in below dsc to prevent the broken of building.
- OvmfPkg/AmdSev/AmdSevX64.dsc
- OvmfPkg/Bhyve/BhyveX64.dsc
- OvmfPkg/Microvm/MicrovmX64.dsc
- OvmfPkg/OvmfPkgX64.dsc
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
The entrypoint of DxeAcpiTimerLib checks HostBridgeDevId by reading
PcdOvmfHostBridgePciDevId. If the DevId is not set, ASSERT is
triggered. Normally this DevId is set in PlatformPei which is executed
in PEI phase. But Tdvf Config-B skips PE
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
Tdvf Config-B skip PEI phase to reduce attack surface. So instead of
jumping to SecStartupPhase2 (), TdxStartup () is called. This function
brings up Tdx guest from SEC phase to DXE phase.
Cc: Michael D Kinney
Cc: Brijesh Singh
Cc: Erdem
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
These PCDs are set in PEI phase in Config-A. But in Config-B
PEI phase is skipped. So they're set here.
Cc: Michael D Kinney
Cc: Brijesh Singh
Cc: Erdem Aktas
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc: Gerd Hoffmann
Sign
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
TdxStarupLib provides a function (TdxStartup ()) which brings up the
Tdx guest from SEC phase to DXE phase. PEI phase is skipped because most
of the components in PEI phase is not needed for Tdx guest, for example,
MP Services, TPM etc. In t
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
SecPlatformLibQemuTdx initialize the platform in Tdx guest. It sets
the HostBridgePciDevId in PlatformInfoHob which will be transferred
to DXE phase. Another task is to download QEMU configurations via fw_cfg
interface.
Cc: Michael D Kinney
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
This function is a null stub to make the build success.
Cc: Michael D Kinney
Cc: Brijesh Singh
Cc: Erdem Aktas
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc: Gerd Hoffmann
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Abner Cha
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
This library is needed by EmbeddedPkg/PrePiHobLib to set / get the
Hob list pointer.
Cc: Michael D Kinney
Cc: Brijesh Singh
Cc: Erdem Aktas
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc: Gerd Hoffmann
Signed-off-by: Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
There are below new functions added in EmbeddedPkg/PrePiLib.
1. FfsAnyFvFindFileByName
This function is to find the file by name in the FvImage.
2. FfsDecompressSection
This function is to decompress a compressed section.
3. FfsProcess
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
Intel's Trust Domain Extensions (Intel TDX) refers to an Intel technology
that extends Virtual Machines Extensions (VMX) and Multi-Key Total Memory
Encryption (MKTME) with a new kind of virutal machines guest called a
Trust Domain (TD). A TD
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
Intel's Trust Domain Extensions (Intel TDX) refers to an Intel technology
that extends Virtual Machines Extensions (VMX) and Multi-Key Total Memory
Encryption (MKTME) with a new kind of virutal machines guest called a
Trust Domain (TD). A TD
I see that DBG2/SPCR spec
(https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table)
defines 0x10 for Serial type for BCM2835:
0x0010
BCM2835
Should the spec be updated to make this more explicit? i.e. "BCM283x/BCM27xx
MiniUART"
From: devel@edk2.groups.io On
Hi Rebecca,
Thank you for reporting this. After further investigation I believe the issue
is in the PPTT parser when it tries to report an error with the cache flags it
performs an incorrect dereference of the FlagName parameter. I have filed this
in bugzilla (https://bugzilla.tianocore.org/sho
Bugzilla: 3770 (https://bugzilla.tianocore.org/show_bug.cgi?id=3770)
The PPTT parser in AcpiView incorrectly dereferences a pointer to
FlagName when trying to log an error with the PPTT cache flags, which
can lead to random crashes and other errors.
Also fix some spacing in the error message to e
Hi Abdul,
With the introduction of Uncrustify tool in the edk2 CI, I think you may have to
- rebase with latest edk2 master and resolve any conflicts
- run uncrustify on your patches
- re-submit your patches.
More information on using uncrustify can be found at
https://github.com/tianocore/tiano
On Mon, 13 Dec 2021 at 19:31, Rebecca Cran wrote:
>
> To reduce the amount of template code, introduce SMC helper
> functions. Update ArmSmcPsciResetSystemLib and Universal/Smbios to use
> them.
>
> Changes from v2 to v3:
>
> o Fixed code style issues with Uncrustify.
> o Fixed patch 2/2 subject.
Hi Rebecca,
Thank you for reporting this issue.
We will try to recreate the problem and provide a fix.
Regards,
Sami Mujawar
From: devel@edk2.groups.io on behalf of Rebecca Cran via
groups.io
Date: Tuesday, 14 December 2021 at 01:53
To: edk2-devel-groups-io , Ard Biesheuvel
, Leif Lindholm
Thanks for the patch.
Generally, the change is good to me. A couple of minor inline comments below:
> -Original Message-
> From: Ke, VincentX
> Sent: Tuesday, December 14, 2021 2:50 PM
> To: devel@edk2.groups.io
> Cc: Ke, VincentX ; Wu, Hao A
> ; Ni, Ray ; Chiu, Ian
> ; Chu, Maggie
> Su
70 matches
Mail list logo
