Hi,
> +VOID
> +EFIAPI
> +IoReadFifo8 (
> + IN UINTN Port,
> + IN UINTN Count,
> + OUT VOID *Buffer
> + )
> +{
> + if (IsTdxGuest ()) {
> + TdIoReadFifo8 (Port, Count, Buffer);
> + } else {
> + SevIoReadFifo8 (Port, Count, Buffer);
> + }
> +}
Hmm, this is confusing. IMHO handling the native case should be moved
out of SevIoReadFifo8 and the check done in this function, i.e. have
something like this here:
switch (GuestType) {
case TDX: TdIoReadFifo8(); break;
case SEV: SevIoReadFifo8(); break;
default: NativeIoReadFifo8(); break;
}
Given this is an existing issue in current sev support code:
Acked-by: Gerd Hoffmann <kra...@redhat.com>
Brijesh? Can take care please (probably best after this landed)?
thanks & take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84863): https://edk2.groups.io/g/devel/message/84863
Mute This Topic: https://groups.io/mt/87696566/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
