Hi Pierre,

Thank you for this patch series.

Reviewed-by: Sami Mujawar <sami.muja...@arm.com>

Regards,

Sami Mujawar


On 09/12/2021 09:31 AM, pierre.gond...@arm.com wrote:
From: Pierre Gondois <pierre.gond...@arm.com>

v4:
- Run uncrustify and apply the required formatting. [Pierre]
- No other change with v3. [Pierre]
v3:
- Populate the 64 bits of the MPIDR field of the GicC CmObj.
        [Sami]
- Fix typos. [Sami]
v2:
- Handle absence of Pci legacy interrupts in Pci parser. [Pierre]
- Handle Affinity3 field in GicC parser. [Sami]
- Add pl011 compatible string in serial port parser. [Sami]
- Use 16550_with_GAS ID when 16550 is detected in serial
  port parser. [Sami]
- Use ASSERT_EFI_ERROR when possible. [Sami]
- Fix typos and add comments. [Pierre]

Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=3741

The generic HwInfoParserLib provides an interface to parse hardware
information stored in certain a data type (e.g.: xml, device tree,
...) and generate objects that can be used by the DynamicTablesPkg
framework to generate another hardware description (e.g.:
SMBIOS tables, ACPI tables, ...).

This patch-set also implements a FdtHwInfoParserLib, parsing
hardware information stored in a device tree. The objects
generated by the library have been used ACPI tables.

The changes can be seen at: 
https://github.com/PierreARM/edk2/tree/1787_Implement_FdtHwInfoParser_v4

Pierre Gondois (15):
   DynamicTablesPkg: Definition for HwInfoParser interface
   DynamicTablesPkg: FdtHwInfoParser: CM Object descriptor helper
   DynamicTablesPkg: FdtHwInfoParser: Add FDT utility functions
   DynamicTablesPkg: FdtHwInfoParser: Add Boot Arch parser
   DynamicTablesPkg: FdtHwInfoParser: Generic Timer Parser
   DynamicTablesPkg: FdtHwInfoParser: Add Serial port parser
   DynamicTablesPkg: FdtHwInfoParser: Add GICC parser
   DynamicTablesPkg: FdtHwInfoParser: Add GICD parser
   DynamicTablesPkg: FdtHwInfoParser: Add MSI Frame parser
   DynamicTablesPkg: FdtHwInfoParser: Add ITS parser
   DynamicTablesPkg: FdtHwInfoParser: Add GICR parser
   DynamicTablesPkg: FdtHwInfoParser: Add GIC dispatcher
   DynamicTablesPkg: FdtHwInfoParser: Add PCI config parser
   DynamicTablesPkg: Add FdtHwInfoParser library
   DynamicTablesPkg: Handle 16550_WITH_GAS id

  DynamicTablesPkg/DynamicTablesPkg.dec         |   3 +
  DynamicTablesPkg/DynamicTablesPkg.dsc         |   3 +-
  .../Include/Library/HwInfoParserLib.h         |  99 ++
  .../SsdtSerialPortFixupLib.c                  |   5 +-
  .../BootArch/ArmBootArchParser.c              | 159 +++
  .../BootArch/ArmBootArchParser.h              |  45 +
  .../FdtHwInfoParserLib/CmObjectDescUtility.c  | 306 ++++++
  .../FdtHwInfoParserLib/CmObjectDescUtility.h  | 131 +++
  .../FdtHwInfoParserLib/FdtHwInfoParser.c      | 192 ++++
  .../FdtHwInfoParserLib/FdtHwInfoParser.h      |  63 ++
  .../FdtHwInfoParserInclude.h                  |  17 +
  .../FdtHwInfoParserLib/FdtHwInfoParserLib.inf |  56 ++
  .../Library/FdtHwInfoParserLib/FdtUtility.c   | 923 ++++++++++++++++++
  .../Library/FdtHwInfoParserLib/FdtUtility.h   | 458 +++++++++
  .../GenericTimer/ArmGenericTimerParser.c      | 258 +++++
  .../GenericTimer/ArmGenericTimerParser.h      |  66 ++
  .../FdtHwInfoParserLib/Gic/ArmGicCParser.c    | 777 +++++++++++++++
  .../FdtHwInfoParserLib/Gic/ArmGicCParser.h    |  67 ++
  .../FdtHwInfoParserLib/Gic/ArmGicDParser.c    | 171 ++++
  .../FdtHwInfoParserLib/Gic/ArmGicDParser.h    |  50 +
  .../FdtHwInfoParserLib/Gic/ArmGicDispatcher.c | 218 +++++
  .../FdtHwInfoParserLib/Gic/ArmGicDispatcher.h |  72 ++
  .../FdtHwInfoParserLib/Gic/ArmGicItsParser.c  | 218 +++++
  .../FdtHwInfoParserLib/Gic/ArmGicItsParser.h  |  48 +
  .../Gic/ArmGicMsiFrameParser.c                | 217 ++++
  .../Gic/ArmGicMsiFrameParser.h                |  50 +
  .../FdtHwInfoParserLib/Gic/ArmGicRParser.c    | 238 +++++
  .../FdtHwInfoParserLib/Gic/ArmGicRParser.h    |  47 +
  .../Pci/ArmPciConfigSpaceParser.c             | 813 +++++++++++++++
  .../Pci/ArmPciConfigSpaceParser.h             | 143 +++
  .../Serial/ArmSerialPortParser.c              | 633 ++++++++++++
  .../Serial/ArmSerialPortParser.h              |  47 +
  32 files changed, 6591 insertions(+), 2 deletions(-)
  create mode 100644 DynamicTablesPkg/Include/Library/HwInfoParserLib.h
  create mode 100644 
DynamicTablesPkg/Library/FdtHwInfoParserLib/BootArch/ArmBootArchParser.c
  create mode 100644 
DynamicTablesPkg/Library/FdtHwInfoParserLib/BootArch/ArmBootArchParser.h
  create mode 100644 
DynamicTablesPkg/Library/FdtHwInfoParserLib/CmObjectDescUtility.c
  create mode 100644 
DynamicTablesPkg/Library/FdtHwInfoParserLib/CmObjectDescUtility.h
  create mode 100644 
DynamicTablesPkg/Library/FdtHwInfoParserLib/FdtHwInfoParser.c
  create mode 100644 
DynamicTablesPkg/Library/FdtHwInfoParserLib/FdtHwInfoParser.h
  create mode 100644 
DynamicTablesPkg/Library/FdtHwInfoParserLib/FdtHwInfoParserInclude.h
  create mode 100644 
DynamicTablesPkg/Library/FdtHwInfoParserLib/FdtHwInfoParserLib.inf
  create mode 100644 DynamicTablesPkg/Library/FdtHwInfoParserLib/FdtUtility.c
  create mode 100644 DynamicTablesPkg/Library/FdtHwInfoParserLib/FdtUtility.h
  create mode 100644 
DynamicTablesPkg/Library/FdtHwInfoParserLib/GenericTimer/ArmGenericTimerParser.c
  create mode 100644 
DynamicTablesPkg/Library/FdtHwInfoParserLib/GenericTimer/ArmGenericTimerParser.h
  create mode 100644 
DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
  create mode 100644 
DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.h
  create mode 100644 
DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDParser.c
  create mode 100644 
DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDParser.h
  create mode 100644 
DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.c
  create mode 100644 
DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.h
  create mode 100644 
DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicItsParser.c
  create mode 100644 
DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicItsParser.h
  create mode 100644 
DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicMsiFrameParser.c
  create mode 100644 
DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicMsiFrameParser.h
  create mode 100644 
DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicRParser.c
  create mode 100644 
DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicRParser.h
  create mode 100644 
DynamicTablesPkg/Library/FdtHwInfoParserLib/Pci/ArmPciConfigSpaceParser.c
  create mode 100644 
DynamicTablesPkg/Library/FdtHwInfoParserLib/Pci/ArmPciConfigSpaceParser.h
  create mode 100644 
DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c
  create mode 100644 
DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.h

--
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84823): https://edk2.groups.io/g/devel/message/84823
Mute This Topic: https://groups.io/mt/87608900/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to