Thank you Rebecca.
I have submitted the updated patch for review.
Regards,
JP
-Original Message-
From: Rebecca Cran
Sent: 23 September 2021 06:59
To: Jayaprakash, N ; devel@edk2.groups.io
Cc: Kinney, Michael D
Subject: Re: [edk2-devel] [edk2-libc Patch 1/1]
AppPkg/Applications/Python/
Hi Liming,
Yes. Because the design of the BM app is not aimed to display the boot option
over one line. And it is not using the setup browser engine.
That would cause the difference.
If we want to make them align, there are two options:
1. BM app to use the setup browser engine
2. add scroll bar
The definition of MigrateGdt has been moved to SecMain since
commit f6ec1dd3, so also remove declaration of MigrateGdt left
in CpuMpPei.
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Signed-off-by: Wenyi Xie
---
UefiCpuPkg/CpuMpPei/CpuMpPei.h | 12
1 file changed, 12 deletions(-)
dif
Main Changes :
1.remove declaration of MigrateGdt
Wenyi Xie (1):
UefiCpuPkg/CpuMpPei: Remove MigrateGdt declaration
UefiCpuPkg/CpuMpPei/CpuMpPei.h | 12
1 file changed, 12 deletions(-)
--
2.20.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent
On 22.09.21 18:19, Ard Biesheuvel wrote:
> We never run any code at EL0, and so it would seem that any access
> permissions set for EL0 (via the AP[1] attribute in the page tables) are
> irrelevant. We currently set EL0 and EL1 permissions to the same value
> arbitrarily.
>
> However, this causes
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3646
According to latest TCG PFP spec 1.05 revision 23,
(https://trustedcomputinggroup.org/resource/pc-client-specific
-platform-firmware-profile-specification/),
10.2.7 DEVICE_SECURITY_EVENT_DATA Structure,
the version should be 1.
Signed-off-b
On Wed, Sep 22, 2021 at 09:55:58AM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > +; If SEV-SNP is enabled, use the CPUID page to handle the CPUID
> > +; instruction.
> > +mov ecx, SEV_STATUS_MSR
> > +rdmsr
> > +bt eax, 2
> > +jc SnpCpuidLookup
>
> Maybe check SNP
Zhichao:
With this change, the same boot option will be displayed differently in
BootManagerApp and BootManager Page. Is it the designed behavior?
Besides, please remove change-id from the commit message.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Gao, Zhichao
> 发送时间: 202
Shengfeng:
Please update the patch title as PackageName ModuleName: Description.
And, please run BaseTools\Scripts\PatchCheck.py to check the patch format.
For this patch, I don't review the code change. Please remove my
reviewed-by.
Thanks
Liming
> -邮件原件-
> 发件人: xueshengfeng
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: yi1 li
> 发送时间: 2021年9月23日 10:03
> 收件人: devel@edk2.groups.io
> 抄送: yi1 li ; Jiewen Yao ;
Michael
> D Kinney ; Liming Gao
> ; Zhiguang Liu
> 主题: [PATCH 1/1] MdePkg: Fix DEVICE_SECURITY_EVENT_DATA_HEADER
> version definition
>
> REF: https://bugzill
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Li, Yi1
> Sent: Thursday, September 23, 2021 10:03 AM
> To: devel@edk2.groups.io
> Cc: Li, Yi1 ; Yao, Jiewen ; Kinney,
> Michael D ; Liming Gao
> ; Liu, Zhiguang
> Subject: [PATCH 1/1] MdePkg: Fix DEVICE_SECURITY_EVENT_DATA_HEADER
> v
You should be able to use the same branch.
--
Rebecca Cran
On 9/21/21 8:33 PM, Jayaprakash, N wrote:
Hi Rebecca,
Can I resubmit the patch after making these changes in the same development
branch or does it require creating a new branch?
Regards,
JP
-Original Message-
From: devel@
From: Rebecca Cran
Linaro no longer do gcc releases - they're done by Arm now.
Update gcc_aarch64_linux_ext_dep.yaml to fetch the latest AARCH64 gcc
release (10.3-2021.07) from their site.
Signed-off-by: Rebecca Cran
---
BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml | 10 +
From: Rebecca Cran
Linaro no longer do gcc releases - they're done by Arm now.
Update gcc_arm_linux_ext_dep.yaml to fetch the latest ARM gcc release
(10.3-2021.07) from their site.
Signed-off-by: Rebecca Cran
---
BaseTools/Bin/gcc_arm_linux_ext_dep.yaml | 10 +-
BaseTo
BaseTools/Bin/gcc_[arm,aarch64]_linux_ext_dep.yaml downloads GCC releases
from https://releases.linaro.org/components/toolchain/binaries/7.4-2019.02 .
As indicated in the URL, those builds are from 2019 because Linaro no
longer do GCC releases, with that task having moved to Arm.
The Arm GCC pa
On September 22, 2021 3:49 PM, Gerd Hoffmann wrote:
> Hi,
>
> > +%ifdef ARCH_X64
> > +;
> > +; TDX Metadata offset block
> > +;
> > +; TdxMetadata.asm is included in ARCH_X64 because Inte TDX is only ;
> > +available in ARCH_X64. Below block describes the offset of ;
> > +TdxMetadata block in Ov
Add DXE_RUNTIME_DRIVER to the list of module types supported.
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Guomin Jiang
Cc: Wei6 Xu
Signed-off-by: Bob Morgan
---
FmpDevicePkg/Library/FmpDeviceLibNull/FmpDeviceLibNull.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/FmpDevic
Adds a runtime version of FmpDxe driver to allow firmware updates
after ExitBootServices() is called and enables DXE_RUNTIME_DRIVER
module type for associated FMP libraries.
Bob Morgan (5):
FmpDevicePkg/FmpDeviceLibNull: Add DXE_RUNTIME_DRIVER support
FmpDevicePkg/FmpPayloadHeaderLibV1: Add DX
Add DXE_RUNTIME_DRIVER to the list of module types supported.
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Guomin Jiang
Cc: Wei6 Xu
Signed-off-by: Bob Morgan
---
.../FmpDependencyCheckLibNull/FmpDependencyCheckLibNull.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/Fm
Adds a runtime version of FmpDxe driver to allow firmware updates after
ExitBootServices() is called.
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Guomin Jiang
Cc: Wei6 Xu
Signed-off-by: Bob Morgan
---
FmpDevicePkg/FmpDevicePkg.dsc | 29
FmpDevicePkg/FmpDxe/FmpDxe.c | 34 +
Add DXE_RUNTIME_DRIVER to the list of module types supported.
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Guomin Jiang
Cc: Wei6 Xu
Signed-off-by: Bob Morgan
---
.../FmpDependencyDeviceLibNull/FmpDependencyDeviceLibNull.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/Fm
Add DXE_RUNTIME_DRIVER to the list of module types supported.
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Guomin Jiang
Cc: Wei6 Xu
Signed-off-by: Bob Morgan
---
.../Library/FmpPayloadHeaderLibV1/FmpPayloadHeaderLibV1.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/Fm
Set the DSDT revision value to 2 by using the define from Acpi60.h
EFI_ACPI_6_0_DIFFERENTIATED_SYSTEM_DESCRIPTION_TABLE_REVISION. This
causes the AML interpreter to use full 64-bit integers and math.
Signed-off-by: Rebecca Cran
---
Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 6 --
1 file cha
Implements VT-D DMAR table functionality.
VT-D is currently implemented as an OpenBoardPkg feature.
More work would be needed to promote to an Advanced Feature.
Specifically reducing dependencies and improving API and integration
with OpenBoardPkg ACPI implementation.
Cc: Nate DeSimone
Cc: Chasel
Fix issue with missing debug messages on ESPI_ENABLE configuration.
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Isaac Oram
---
Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/PlatformHooks.c |
8
1 file changed, 8 insertions(+)
diff --git
a/Platform/Intel/WhitleyOp
On Wed, Sep 22, 2021 at 18:19:54 +0200, Ard Biesheuvel wrote:
> We never run any code at EL0, and so it would seem that any access
> permissions set for EL0 (via the AP[1] attribute in the page tables) are
> irrelevant. We currently set EL0 and EL1 permissions to the same value
> arbitrarily.
>
>
Thanks Chasel!
Best Regards,
Xiaoqiang Zhang
-Original Message-
From: Chiu, Chasel
Sent: Wednesday, September 22, 2021 4:39 PM
To: Zhang, Xiaoqiang ; devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Zeng, Star
Subject: RE: [PATCH v1] IntelFsp2WrapperPkg: Make PcdFspModeSelection dynam
From: Stefan Berger
Disable the TPM2 platform hierarchy by directly calling
ConfigureTpmPlatformHierarchy().
Per the TCG firmware specification "TCG PC Client Platform Firmware Profile
Specification" the TPM 2 platform hierarchy needs to be disabled or a
random password set and discarded before
From: Stefan Berger
Add a NULL implementation of the library class TpmPlatformHierarchyLib.
Link: https://bugzilla.tianocore.org/show_bug.cgi?id=3510
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Gerd Hoffmann
Signed-off-by: Stefan Berger
---
.../PeiDxeTpmPlatformHierarchyLib.c
From: Stefan Berger
We just added the same functionality to the OvmfPkg. However, on x86, we
could use the notification mechanism around
gEfiDxeSmmReadyToLockProtocolGuid to indirectly invoke
ConfigureTpmPlatformHierarchy(). Since ARM does not have an SMM mode, we
have to use direct invocation of
This series of patches disables the TPM 2 platform hierarchy.
We just added the same functionality to the OvmfPkg. However, on x86, we
could use the notification mechanism around gEfiDxeSmmReadyToLockProtocolGuid
to indirectly invoke ConfigureTpmPlatformHierarchy(). Since ARM does not
have an SMM m
On 9/22/21 7:39 AM, Ard Biesheuvel wrote:
+[Defines]
+ INF_VERSION= 0x00010005
1.27
Originally all comes from this file here:
https://github.com/tianocore/edk2/blob/master/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.inf#L16
Doesn't m
We never run any code at EL0, and so it would seem that any access
permissions set for EL0 (via the AP[1] attribute in the page tables) are
irrelevant. We currently set EL0 and EL1 permissions to the same value
arbitrarily.
However, this causes problems on hardware like the Apple M1 running the
hy
Hi Pierre,
Thank you for this patch.
These updates look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#80980): https://edk2.groups.io/g/devel/message/80980
Mute This Topic:
Hi Pierre,
Thank you for this patch.
On Wed, Jun 23, 2021 at 04:05 AM, PierreGondois wrote:
>
> - Create aliases having of the 'Crs' function prototypes. These
> aliases are available when DISABLE_NEW_DEPRECATED_INTERFACES
> is not defined. They will be deprecated in a near future.
Is it possi
Hi Pierre,
On Wed, Jun 23, 2021 at 04:05 AM, PierreGondois wrote:
>
> 2- Disable the Ecc check 8003 for the following keyword:
> "DISABLE_NEW_DEPRECATED_INTERFACES"
> Indeed, this error has been corrected on the latest version of
> BaseTools, but is still triggered when using the older python
>
Hi Pierre,
This change looks good to me.
Reviewed-by: Sami Mujawar
Thanks,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#80977): https://edk2.groups.io/g/devel/message/80977
Mute This Topic: https://groups.io/mt/8373519
Hi Pierre,
This patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#80976): https://edk2.groups.io/g/devel/message/80976
Mute This Topic: https://groups.io/mt/8373518
Hi Pierre,
Thank you for this patch.
On Wed, Jun 23, 2021 at 04:05 AM, PierreGondois wrote:
>
> + @return The corresponding integer (between 0-16).
I have a minor suggestion to update the documentation for the value returned in
error scenario. Other than that this patch looks good to me.
With
Hi Pierre,
Thank you for this patch.
I have a minor comment.
On Wed, Jun 23, 2021 at 04:05 AM, PierreGondois wrote:
>
> @return The ASCII code corresponding to x.
Can you update the documentation for the value returned, please? Also, describe
the value that would be returned in an error scen
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#80973): https://edk2.groups.io/g/devel/message/80973
Mute This Topic: https://groups.io/mt/83735184/2
Hi Pierre,
Thank you for this patch.
On Wed, Jun 23, 2021 at 04:05 AM, PierreGondois wrote:
>
> To allow using these generic functions without including
> DynamicTablesPkg definitions, move them to a new AcpiTableHelperLib
> library.
I think you mean AcpiHelperLib not AcpiTableHelperLib here,
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3642
when the module is not building in IA32 mode which will lead to
building error. when a module built-in X64 function pointer will be the
size of 64bit width which cannot be fit in 32bit address which will lead
to error. to overcome this issue i
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3642
when the module is not building in IA32 mode which will lead to
building error. when a module built-in X64 function pointer will be the
size of 64bit width which cannot be fit in 32bit address which will lead
to error. to overcome this issue i
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3642
when the module is not building in IA32 mode which will lead to
building error. when a module built-in X64 function pointer will be the
size of 64bit width which cannot be fit in 32bit address which will lead
to error. to overcome this issue i
Hi Rebecca,
I have resubmitted the patch with the changes suggested.
Thank you,
JP
-Original Message-
From: devel@edk2.groups.io On Behalf Of Jayaprakash, N
Sent: 22 September 2021 08:03
To: devel@edk2.groups.io; rebe...@nuviainc.com
Cc: Kinney, Michael D
Subject: Re: [edk2-devel] [edk
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3642
when the module is not building in IA32 mode which will lead to
building error. when a module built-in X64 function pointer will be the
size of 64bit width which cannot be fit in 32bit address which will lead
to error. to overcome this issue i
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3638
This change is to add IA32 support into py3 EFI package
creation batch script. Enhanced the script take Architecture
as an additional parameter. With this the script can be used
to create deployable Python 3.6.8 EFI package from X64 and IA32
Jayaprakash Nevara (1):
AppPkg/Applications/Python/Python3.6.8: add IA32 support for py3
package creation batch script
.../Python-3.6.8/create_python368_pkg.bat | 62 ---
1 file changed, 39 insertions(+), 23 deletions(-)
--
2.32.0.windows.2
-=-=-=-=-=-=-=-=-=-=-=-
On Wed, Sep 22, 2021 at 14:20:31 +0200, Ard Biesheuvel wrote:
> On Wed, 22 Sept 2021 at 14:14, Leif Lindholm wrote:
> >
> > On Wed, Sep 22, 2021 at 13:24:07 +0200, Ard Biesheuvel wrote:
> > > On Tue, 21 Sept 2021 at 13:02, Marcin Wojtas wrote:
> > > >
> > > > Hi,
> > > >
> > > > This short patchs
Hi Ard, Leif,
śr., 22 wrz 2021 o 14:20 Ard Biesheuvel napisał(a):
>
> On Wed, 22 Sept 2021 at 14:14, Leif Lindholm wrote:
> >
> > On Wed, Sep 22, 2021 at 13:24:07 +0200, Ard Biesheuvel wrote:
> > > On Tue, 21 Sept 2021 at 13:02, Marcin Wojtas wrote:
> > > >
> > > > Hi,
> > > >
> > > > This shor
On Wed, 22 Sept 2021 at 14:14, Leif Lindholm wrote:
>
> On Wed, Sep 22, 2021 at 13:24:07 +0200, Ard Biesheuvel wrote:
> > On Tue, 21 Sept 2021 at 13:02, Marcin Wojtas wrote:
> > >
> > > Hi,
> > >
> > > This short patchset adds README files for the platforms
> > > based on Marvell SoC's, which hav
On Wed, Sep 22, 2021 at 13:24:07 +0200, Ard Biesheuvel wrote:
> On Tue, 21 Sept 2021 at 13:02, Marcin Wojtas wrote:
> >
> > Hi,
> >
> > This short patchset adds README files for the platforms
> > based on Marvell SoC's, which have already been
> > SystemReady ES certified. It also bumps the firmwa
Hi Ard,
I will review the series this week.
Regards,
Sami Mujawar
On 22/09/2021, 12:47, "Ard Biesheuvel" wrote:
On Fri, 3 Sept 2021 at 15:39, Omkar Kulkarni wrote:
>
> Gentle reminder, to review this patch series.
>
Sami, would you mind taking this one?
>
> >
On Tue, 7 Sept 2021 at 05:40, Nhi Pham wrote:
>
> LinuxBoot is a firmware that replaces specific firmware functionality
> like the UEFI DXE phase with a Linux kernel and runtime. It is built-in
> UEFI image like an application, which is executed at the end of DXE
> phase.
>
> To achieve the LinuxB
On Fri, 3 Sept 2021 at 15:39, Omkar Kulkarni wrote:
>
> Gentle reminder, to review this patch series.
>
Sami, would you mind taking this one?
>
> > On August 24, 2021 11:30 AM, Omkar Kulkarni wrote:
> > Changes since v2:
> > - Rebased to the latest upstream code.
> >
> > This patch series intro
On Sat, 18 Sept 2021 at 13:54, Stefan Berger wrote:
>
>
> On 9/18/21 3:55 AM, Ard Biesheuvel wrote:
> > On Thu, 16 Sept 2021 at 23:18, Stefan Berger wrote:
> >> From: Stefan Berger
> >>
> >> Add a NULL implementation of the library class TpmPlatformHierarchyLib.
> >>
> > This patch introduces bo
On Tue, 21 Sept 2021 at 13:02, Marcin Wojtas wrote:
>
> Hi,
>
> This short patchset adds README files for the platforms
> based on Marvell SoC's, which have already been
> SystemReady ES certified. It also bumps the firmware
> revision after the PCI / IcuLib rework and addition of
> the CN913x CEx
On Wed, 22 Sept 2021 at 13:20, Ard Biesheuvel wrote:
>
> On Tue, 14 Sept 2021 at 16:39, Leif Lindholm wrote:
> >
> > Ard, I think you were the one who converted the old crazy header stuff
> > to what we have now. Do you remember how this all fits together?
> >
>
> I had to page it in (edk2:a11232
On Tue, 14 Sept 2021 at 16:39, Leif Lindholm wrote:
>
> Ard, I think you were the one who converted the old crazy header stuff
> to what we have now. Do you remember how this all fits together?
>
I had to page it in (edk2:a1123292a80608a69df89b6dd264c4656b618aec)
but given that I never used a Bea
Patch pushed:
https://github.com/tianocore/edk2/commit/f334c5a41dc4702b1c767c6614025aa2f802f9a4
Thanks,
Chasel
> -Original Message-
> From: Zhang, Xiaoqiang
> Sent: Thursday, September 16, 2021 11:45 AM
> To: devel@edk2.groups.io
> Cc: Zhang, Xiaoqiang ; Chiu, Chasel
> ; Desimone, Na
On Mon, Sep 20, 2021 at 01:45:49PM -0500, Brijesh Singh wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
>
> The initial page built during the SEC phase is used by the
> MemEncryptSevSnpValidateSystemRam() for the system RAM validation. The
> page validation process requires using
Hi,
> STATIC BOOLEAN mSevStatus = FALSE;
> STATIC BOOLEAN mSevEsStatus = FALSE;
> +STATIC BOOLEAN mSevSnpStatus = FALSE;
> STATIC BOOLEAN mSevStatusChecked = FALSE;
Better use the new PcdConfidentialComputingAttr instead?
At least in Dxe Phase, maybe Pei too (not sure what the initialization
Hi,
> +; If SEV-SNP is enabled, use the CPUID page to handle the CPUID
> +; instruction.
> +mov ecx, SEV_STATUS_MSR
> +rdmsr
> +bt eax, 2
> +jc SnpCpuidLookup
Maybe check SNP_CPUID_COUNT instead, so the cpuid page can also be used
without SEV-SNP ?
take ca
Hi,
> +%ifdef ARCH_X64
> +;
> +; TDX Metadata offset block
> +;
> +; TdxMetadata.asm is included in ARCH_X64 because Inte TDX is only
> +; available in ARCH_X64. Below block describes the offset of
> +; TdxMetadata block in Ovmf image
> +;
> +; GUID : e47a6535-984a-4798-865e-4685a7bf8ec2
> +;
>
Hi Jeff,
I do not ever work on EDK soon after this patch set was merged. It is
long time since then.
I am sorry that I have no comments other than no objections on your patch.
Regards,
Jun
Jeff Brasen 于2021年9月22日周三 上午12:33写道：
>
> Jun/Others,
>
> Any additional comments on this patch series?
66 matches
Mail list logo
