Hi, > +%ifdef ARCH_X64 > +; > +; TDX Metadata offset block > +; > +; TdxMetadata.asm is included in ARCH_X64 because Inte TDX is only > +; available in ARCH_X64. Below block describes the offset of > +; TdxMetadata block in Ovmf image > +; > +; GUID : e47a6535-984a-4798-865e-4685a7bf8ec2 > +; > +tdxMetadataOffsetStart: > + DD tdxMetadataOffsetStart - TdxMetadataGuid - 16 > + DW tdxMetadataOffsetEnd - tdxMetadataOffsetStart > + DB 0x35, 0x65, 0x7a, 0xe4, 0x4a, 0x98, 0x98, 0x47 > + DB 0x86, 0x5e, 0x46, 0x85, 0xa7, 0xbf, 0x8e, 0xc2 > +tdxMetadataOffsetEnd: > + > +%endif
This should be switched to common ovmf metadata (see patches 4-7 of the SEV-SNP series). Min: please have a look at these patches. Brijesh: It might be useful to post the metadata patches as separate series. > +; Load the GDT and set the CR0, then jump to Flat 32 protected mode. That comment isn't correct, you are already in 32-bit mode. > +; Modified: EAX, EBX, CR0, CR4, DS, ES, FS, GS, SS CS too ... > + jmp LINEAR_CODE_SEL:dword ADDR_OF(jumpToFlat32BitAndLandHere) > +jumpToFlat32BitAndLandHere: ... right here. > --- /dev/null > +++ b/OvmfPkg/ResetVector/Main.asm Can you add a separate patch for "copy Main.asm from UefiCpuPkg unmodified" please? Having the changes for TDX separately is helpful for review. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#80949): https://edk2.groups.io/g/devel/message/80949 Mute This Topic: https://groups.io/mt/85761661/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
