Re: [edk2-devel] [PATCH 05/23] MdePkg: Add TdxProbeLib to probe Intel Tdx

2021-09-12 Thread Min Xu
On September 11, 2021 9:15 AM, Erden Aktas wrote: > On Thu, Aug 12, 2021 at 2:57 PM Min Xu wrote: > > + > > +#include > > +#include "InternalTdxProbe.h" > > + > > +/** > > + TDX only works in X64. So allways return -1 to indicate Non-Td. > s/allways/always > > Also, -1 or 1? PROBE_NOT_TD_GUEST

Re: [edk2-devel] [PATCH 03/23] OvmfPkg/ResetVector: Enable Intel TDX in ResetVector of Ovmf

2021-09-12 Thread Min Xu
On September 11, 2021 9:14 AM, Erdem Aktas wrote: > > On Thu, Aug 12, 2021 at 2:57 PM Min Xu wrote: > > > > +; > > +; Check if it is Intel Tdx > > +; > > +; Modified: EAX, EBX, ECX, EDX > > +; > > +; If it is Intel Tdx, EAX is zero > > +; If it is not Intel Tdx, EAX is non-zero ; > > +IsTdx: > Is

Re: [edk2-devel] [PATCH] SecurityPkg: Add debug log for indicating IBB verified OBB successfully

2021-09-12 Thread Min Xu
Reviewed-by: Min Xu > -Original Message- > From: Yang, Longlong > Sent: Monday, September 13, 2021 11:17 AM > To: devel@edk2.groups.io > Cc: Yang, Longlong ; Yao, Jiewen > ; Wang, Jian J ; Xu, Min M > ; Zhang, Qi1 > Subject: [PATCH] SecurityPkg: Add debug log for indicating IBB verified

[edk2-devel] [PATCH 2/2] OvmfPkg: Transfer PlatformBootManager library to driver

2021-09-12 Thread thiyagukb
Signed-off-by: Zhiguang Liu --- OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 21 + OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h | 1 + OvmfPkg/QemuUniversalPayload/PlatformBootManagerDriver/Bd

[edk2-devel] [PATCH 1/2] UefiPayloadPkg: Remove ACPI board Hob.

2021-09-12 Thread thiyagukb
BlSupportDxe would parse ACPI table and set PCDs. Updated other modules to consume dynamic PCDs instead of HOBs. Tested boot to shell with both SBL (universal and SblOpen) Signed-off-by: Guo Dong --- UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c | 174

[edk2-devel] [Patch V2 1/2] UefiPayloadPkg:Use universal spec defined GUID SystemTableInfo is SBL and CBL specific. so move it to SBL and CBL parse lib.

2021-09-12 Thread thiyagukb
Signed-off-by: Guo Dong --- UefiPayloadPkg/Include/Library/BlParseLib.h| 25 + UefiPayloadPkg/Library/CbParseLib/CbParseLib.c | 35 --- UefiPayloadPkg/Library/SblParseLib/SblParseLib.c | 39 ++

[edk2-devel] [Patch V2 2/2] UefiPayloadPkg: Remove ACPI board Hob.

2021-09-12 Thread thiyagukb
ACPI board Hob is not spec defined guid HOB, and the information it contains can be found in ACPI table. So remove it, and in BlSupportDxe to parse ACPI table and set PCDs. Updated other modules to consume dynamic PCDs instead of HOBs. Signed-off-by: Guo Dong --- UefiPayloadPkg/BlSupportDxe/BlSu

Re: [edk2-devel] [PATCH 02/23] OvmfPkg/Sec: Update the check logic in SevEsIsEnabled

2021-09-12 Thread Min Xu
On September 11, 2021 9:14 AM, Erdem Aktas wrote: > > > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > > > SevEsIsEnabled return TRUE if SevEsWorkArea->SevEsEnabled is non-zero. > s/return/returns > > > It is correct when SevEsWorkArea is only used by SEV. After Intel TDX > > is en

[edk2-devel] [PATCH] IntelSiliconPkg/VTd: Fix typos in Vtd core drivers

2021-09-12 Thread Sheng Wei
It is DMA Remapping Hardware Unit Definition (DRHD). The abbreviation is "DRHD". REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3622 Change-Id: Ia214c05b122b90fd58889763561165f3fa57b186 Signed-off-by: Sheng Wei Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Kowalewski Robert Cc: Jenny Huang ---

Re: [edk2-devel] [PATCH v6 00/29] Add AMD Secure Nested Paging (SEV-SNP) support

2021-09-12 Thread Yao, Jiewen
Hi Brijesh I think it is OK to leave MpFunc.nasm in this series. We can revisit later. Thank you Yao Jiewen > -Original Message- > From: Brijesh Singh > Sent: Monday, September 13, 2021 6:56 AM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: James Bottomley ; Xu, Min M ; > Tom Lendacky ;

Re: [edk2-devel] [PATCH v6 00/29] Add AMD Secure Nested Paging (SEV-SNP) support

2021-09-12 Thread Brijesh Singh via groups.io
Hi Yao, I am going through implementing your feedback. I have covered most of it. But your comment on moving some of the changes from MpFunc.nasm to Sev.nasm may make code harder to read. It is mainly because the GPA registration and Topo check are not self-contained routines. They depend on some

Re: [edk2-devel] [PATCH v3 1/2] Ext4Pkg: Improve Ext4IsBindingSupported() behavior

2021-09-12 Thread Marvin Häuser
On 11/09/2021 00:11, Jeff Brasen via groups.io wrote: A couple of improvements to improve performance. Add check to return ACCESS_DENIED if already connected Add check to verify superblock magic during supported to reduce start calls Signed-off-by: Jeff Brasen --- Features/Ext4Pkg/Ext4Dxe/Ext

Re: [edk2-devel] Question about EDK2 and commit signing

2021-09-12 Thread Marvin Häuser
Hey, Just my 2 cents... Contributors: Git's stance is the author doesn't really matter as long as the code is acceptable. For most people, you will not know them anyway and it does not buy you much to know they own GitHub account XY. If someone is impersonating a maintainer (who would push th