[edk2-devel] 回复: [PATCH RESEND v1 00/13] Add ACPI 6.4 header file

Chris: This patch set is good. I have only one minor comments for struct EFI_ACPI_6_4_GIC_STRUCTURE. I suggest to keep the same field name to EFI_ACPI_6_3_GIC_STRUCTURE. We can ignore ECC issue in MdePkg.ci.yaml IgnoreFiles list. Thanks Liming > -邮件原件- > 发件人: Chris Jones > 发送时间: 2021

Re: [edk2-devel] [PATCH v1 6/6] UefiPayloadPkg: LinuxBoot: use a text format for the configuration block.

Please run BaseTools\Scripts\PatchCheck.py to make sure it passed the check. Update LbParseLib.c following https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/. current code is more like Linux style. E.g. +static uint64_t parse_int(const char* s, char** end) { + UINT64 x; Remo

Re: [edk2-devel] [PATCH v1 2/6] UefiPayloadPkg: Use legacy timer in Linuxboot payload

A typo copy, should be: Reviewed-by: Guo Dong -Original Message- From: devel@edk2.groups.io On Behalf Of Guo Dong Sent: Tuesday, August 3, 2021 7:22 PM To: devel@edk2.groups.io; chengch...@google.com Subject: Re: [edk2-devel] [PATCH v1 2/6] UefiPayloadPkg: Use legacy timer in Linuxboot

Re: [edk2-devel] [PATCH v1 3/6] UefiPayloadPkg: Update maximum logic processor to 256

A typo copy, should be: Reviewed-by: Guo Dong -Original Message- From: devel@edk2.groups.io On Behalf Of Guo Dong Sent: Tuesday, August 3, 2021 7:22 PM To: devel@edk2.groups.io; chengch...@google.com Subject: Re: [edk2-devel] [PATCH v1 3/6] UefiPayloadPkg: Update maximum logic processo

Re: [edk2-devel] [PATCH v1 4/6] UefiPayloadPkg: Reserve Payload config in runtime services data

why build runtime memory allocation hob here? The PayloadEntry should already got the information and build a new HOB list to DXE core, will anyone access these region late? If yes, maybe you need add LINUXBOOT_PAYLOAD flag for this code, and update commit message on this. Thanks, Guo -Or

Re: [edk2-devel] [PATCH v1 1/6] UefiPayloadPkg: Add LINUXBOOT payload target

Move Linuxboot.h under UefiPayloadPkg/Library/LbParseLib since this header file is only used by this library. Update LbParseLib.c following https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/ e.g. + UefiPayloadConfig* config; + int i; Change to: + UefiPayloadConfig *Confi

Re: [edk2-devel] [PATCH v1 2/6] UefiPayloadPkg: Use legacy timer in Linuxboot payload

Signed-off-by: Guo Dong -Original Message- From: devel@edk2.groups.io On Behalf Of Cheng-Chieh Huang via groups.io Sent: Wednesday, July 21, 2021 6:23 AM To: devel@edk2.groups.io Cc: Cheng-Chieh Huang Subject: [edk2-devel] [PATCH v1 2/6] UefiPayloadPkg: Use legacy timer in Linuxboot

Re: [edk2-devel] [PATCH v1 3/6] UefiPayloadPkg: Update maximum logic processor to 256

Signed-off-by: Guo Dong -Original Message- From: devel@edk2.groups.io On Behalf Of Cheng-Chieh Huang via groups.io Sent: Wednesday, July 21, 2021 6:23 AM To: devel@edk2.groups.io Cc: Cheng-Chieh Huang Subject: [edk2-devel] [PATCH v1 3/6] UefiPayloadPkg: Update maximum logic processor

[edk2-devel] 回复: [edk2-platforms PATCH v6 0/4] Secure Boot default keys

Sunny: I am OK to merge the reviewed patched first. Thanks Liming > -邮件原件- > 发件人: Sunny Wang > 发送时间: 2021年8月3日 22:11 > 收件人: Grzegorz Bernacki ; devel@edk2.groups.io; > ardb+tianoc...@kernel.org > 抄送: l...@nuviainc.com; Samer El-Haj-Mahmoud > ; m...@semihalf.com; > upstr...@semihalf.com

Re: [edk2-devel] [edk2-platforms PATCH v1 1/1] Platform/Intel/SimicsOpenBoardPkg: Fix PCD type of PcdVideo*Resolution

Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Takuto Naito > Sent: Thursday, July 29, 2021 7:54 AM > To: devel@edk2.groups.io > Cc: Takuto Naito ; Agyeman, Prince > > Subject: [edk2-devel] [edk2-platforms PATCH v1 1/1] > Platform/Intel/Si

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 08/03/2021 #cal-reminder

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT TZNAME:

Re: [edk2-devel] [PATCH V4 2/3] OvmfPkg/Sec: Update the check logic in SevEsIsEnabled

On August 4, 2021 3:24 AM, Brijesh Singh wrote: > Hi Min, > > On 8/2/21 8:18 PM, Min Xu wrote: > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > > > SevEsIsEnabled return TRUE if SevEsWorkArea->SevEsEnabled is non-zero. > > It is correct when SevEsWorkArea is only used by SEV. After

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Update page alignment calculations

Reviewed-By: Tuan Phan > On Jul 19, 2021, at 1:07 AM, Sunny Wang via groups.io > wrote: > > This is to fix the SCT BS.AllocatePages failures (not found) with the > case that the Start address is not aligned to 64k. > For example, > The following is available memory region for testing: >00

Re: [edk2-devel] [PATCH V4 3/3] OvmfPkg/ResetVector: Enable Intel TDX in ResetVector of Ovmf

On 8/2/21 8:18 PM, Min Xu wrote: RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Intel's Trust Domain Extensions (Intel TDX) refers to an Intel technology that extends Virtual Machines Extensions (VMX) and Multi-Key Total Memory Encryption (MKTME) with a new kind of virutal machines

Re: [edk2-devel] [PATCH V4 2/3] OvmfPkg/Sec: Update the check logic in SevEsIsEnabled

Hi Min, On 8/2/21 8:18 PM, Min Xu wrote: RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 SevEsIsEnabled return TRUE if SevEsWorkArea->SevEsEnabled is non-zero. It is correct when SevEsWorkArea is only used by SEV. After Intel TDX is enabled in Ovmf, the SevEsWorkArea is shared by TDX a

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID

Mike, do the comments in this patch work for you? Would be nice to get this in prior to the 8/9 freeze if possible. Thanks, Jeff From: Ard Biesheuvel Sent: Tuesday, July 27, 2021 10:48 AM To: Jeff Brasen Cc: edk2-devel-groups-io ; Ard Biesheuvel ; Michael Ki

Re: [edk2-devel] [edk2][PATCH v1 1/1] StandaloneMmPkg: add support to populate StMM boot data from device tree

Hi, Please find my response inline. Regards, Sayanta >-Original Message- >From: Ard Biesheuvel >Sent: Sunday, August 1, 2021 10:08 PM >To: Sayanta Pattanayak >Cc: edk2-devel-groups-io ; Sami Mujawar >; Achin Gupta ; Bret >Barkelew ; Jiewen Yao >; Andrew Fish >Subject: Re: [edk2][PATCH

Re: [edk2-devel] [edk2-platforms PATCH v5 1/2] Platform/RaspberryPi: Enable Boot Discovery Policy.

On Tue, 3 Aug 2021 at 15:10, Ard Biesheuvel wrote: > > On Tue, 3 Aug 2021 at 15:08, Pete Batard wrote: > > > > Hi Ard, > > > > I thought the R-b from Sunny was enough. > > > > For what is worth, I briefly tested these changes for v4. > > Thus: > > > > On 2021.08.03 14:03, Ard Biesheuvel wrote: >

Re: [edk2-devel] Proposing a new area of the edk2-test repository

Yeah, go for the patch. - Bret From: Samer El-Haj-Mahmoud via groups.io Sent: Tuesday, August 3, 2021 6:10 AM To: Nelson, Eric; Bret Barkelew; devel@edk2.groups.io

Re: [edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: correct print code for EFI_MEMORY_TYPE

Reviewed-by: Samer El-Haj-Mahmoud > -Original Message- > From: devel@edk2.groups.io On Behalf Of Heinrich > Schuchardt via groups.io > Sent: Friday, April 30, 2021 3:40 PM > To: EDK II Development > Cc: Eric Jin ; G Edhaya Chandran > ; Barton Gao ; Arvin > Chen ; Samer El-Haj-Mahmoud m

Re: [edk2-devel] [PATCH v2 0/4] ArmPlatformPkg: Add support to generate HEST ACPI table

Hi Omkar, How did you check that the HEST table is populated correctly? There is no HEST parser in Acpiview at the moment. Do you plan to add an HEST parser to Acpiview? Regards, Sami Mujawar On 02/08/2021 01:49 PM, Sami Mujawar wrote: Hi Omkar, Thank you for this patch series and for th

Re: [edk2-devel] [RFC PATCH v5 07/28] OvmfPkg/ResetVector: pre-validate the data pages used in SEC phase

On 7/31/21 3:44 AM, Erdem Aktas wrote: On Wed, Jun 30, 2021 at 5:54 AM Brijesh Singh wrote: a) Enhance the OVMF reset vector code to validate the pages as described above (go through step 2 - 3). OR b) Validate the pages during the guest creation time. The SEV firmware provides a co

Re: [edk2-devel] [PATCH v2 4/4] ArmPlatformPkg: Add helpers for HEST table generation

Hi Omkar, Thank you for this patch. I have a minor suggestion marked inline as [SAMI], other than that this patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 10/07/2021 05:18 PM, Omkar Anand Kulkarni wrote: Add helper macros for the generation of the HEST ACPI ta

Re: [edk2-devel] [edk2-platforms][PATCH v5 21/46] KabylakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib

Yes, patches were missing because the mailing list chose to unsort and retain non-consecutive patches (they were sent in order) after they exceeded the autoresponder mail loop guard of 40 messages. The following were missing: 0, 10, 11, 15, 23, 32, 43 I sent the missing patches a few minutes

[edk2-devel] [edk2-platforms][PATCH v5 43/46] KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash: Update for new SPI PPI API

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Updates usage of gPchSpiPpiGuid to use the new interface that identifies SPI flash regions by GUID. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Michael Kubacki --- Platform/Intel/KabylakeOpenBoardPkg/Library

[edk2-devel] [edk2-platforms][PATCH v5 32/46] MinPlatformPkg: Remove SpiFlashCommonLibNull

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 The library instance has moved to IntelSiliconPkg. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone Reviewed-by: Chasel Chiu --- Platfor

[edk2-devel] [edk2-platforms][PATCH v5 23/46] TigerlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Updates TigerlakeOpenBoardPkg to use the SmmSpiFlashCommonLib instance in IntelSiliconPkg and the SpiFvbServiceSmm driver in IntelSiliconPkg. Cc: Sai Chaganty Cc: Nate DeSimone Cc: Heng Luo Signed-off-by: Michael K

Re: [edk2-devel] [RFC PATCH v4 00/27] Add AMD Secure Nested Paging (SEV-SNP) support

On 7/28/21 9:22 PM, Yao, Jiewen wrote: Hi Brijesh Thanks for the patient. Most of my comment focus on the *common* part, and *interface* between SEV and common code. I will leave you to decide the detailed SEV specific implementation. Thank you Jiewen for your feedback. I will try to addre

[edk2-devel] [edk2-platforms][PATCH v5 15/46] WhiskeylakeOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Updates PCDs to use the IntelSiliconPkg PCD tokenspace now that the PCDs are declared in IntelSiliconPkg.dec. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone Reviewed-by

[edk2-devel] [edk2-platforms][PATCH v5 11/46] CometlakeOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Updates PCDs to use the IntelSiliconPkg PCD tokenspace now that the PCDs are declared in IntelSiliconPkg.dec. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Rangasai V Chaganty Cc: Deepika Kethi Reddy Cc: Kathappan Esakkit

[edk2-devel] [edk2-platforms][PATCH v5 10/46] IntelSiliconPkg: Add MM SPI FVB services

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Adds a Traditional MM and Standalone MM SPI FVB Service driver to IntelSiliconPkg. These drivers produce the firmware volume block protocol for SPI flash devices compliant with the Intel Serial Flash Interface Compatib

[edk2-devel] [edk2-platforms][PATCH v5 00/46] Consolidate SpiFlashCommonLib instances

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 SpiFlashCommonLib is duplicated in multiple places across the MinPlatform design in edk2-platforms. I'm planning to build some additional functionality on top of SpiFlashCommonLib and, ideally, this duplication will be

Re: [edk2-devel] [PATCH v2 3/4] ArmPlatformPkg: retreive error source descriptors from MM

Hi Omkar, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 10/07/2021 05:18 PM, Omkar Anand Kulkarni wrote: Add a driver that retreives error source descriptors from MM and populates those into the HEST ACPI table. The error source descriptors that are available from th

Re: [edk2-devel] [PATCH v2 2/4] ArmPlatformPkg: add definition for MM_HEST_ERROR_SOURCE_DESC_PROTOCOL

Hi Omkar, Please find my response below marked [SAMI] Regards, Sami Mujawar On 10/07/2021 05:18 PM, Omkar Anand Kulkarni wrote: Add the protocol definition of the MM_HEST_ERROR_SOURCE_DESC_PROTOCOL protocol. This protocol can be implemented by MM drivers to publish error source descriptors tha

Re: [edk2-devel] [edk2-platforms PATCH v6 0/4] Secure Boot default keys

Hi Ard and Maintainers, For this patchset, 1/4 - Intel Platforms: add SecureBootVariableLib class resolution 2/4 - ARM Silicon and Platforms: add SecureBootVariableLib class resolution 3/4 - RISC-V Platforms: add SecureBootVariableLib class resolution 4/4 - Platform/RaspberryPi: Enable default

Re: [edk2-devel] [staging/edk2-redfish-client PATCH v2 2/2] edk2: Update Maintainers.txt

Thanks Leif, I remove the description from the package name. Abner > -Original Message- > From: Leif Lindholm [mailto:l...@nuviainc.com] > Sent: Tuesday, August 3, 2021 7:16 PM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Cc: Wang, Nickle (HPS SW) ; Liming Gao >

Re: [edk2-devel] [edk2-platforms PATCH v5 1/2] Platform/RaspberryPi: Enable Boot Discovery Policy.

On Tue, 3 Aug 2021 at 15:08, Pete Batard wrote: > > Hi Ard, > > I thought the R-b from Sunny was enough. > > For what is worth, I briefly tested these changes for v4. > Thus: > > On 2021.08.03 14:03, Ard Biesheuvel wrote: > > On Tue, 3 Aug 2021 at 15:00, Samer El-Haj-Mahmoud > > wrote: > >> > >>

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Update page alignment calculations

+Heinrich > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sunny > Wang via groups.io > Sent: Monday, July 19, 2021 4:08 AM > To: devel@edk2.groups.io > Cc: Sunny Wang ; Samer El-Haj-Mahmoud > ; G Edhaya Chandran > ; Barton Gao ; > Sunny Wang > Subject: [edk2-devel] [edk2-t

Re: [edk2-devel] Proposing a new area of the edk2-test repository

I would think just sending the code contribution patch is sufficient. From: Nelson, Eric Sent: Wednesday, July 28, 2021 3:05 PM To: Samer El-Haj-Mahmoud ; Bret Barkelew ; devel@edk2.groups.io; G Edhaya Chandran ; gao...@byosoft.com.cn; Kinney, Michael D Subject: RE: Proposing a new area of t

Re: [edk2-devel] [edk2-platforms PATCH v5 1/2] Platform/RaspberryPi: Enable Boot Discovery Policy.

Hi Ard, I thought the R-b from Sunny was enough. For what is worth, I briefly tested these changes for v4. Thus: On 2021.08.03 14:03, Ard Biesheuvel wrote: On Tue, 3 Aug 2021 at 15:00, Samer El-Haj-Mahmoud wrote: Ard, Now that the EDK2 changes are merged (aaecef38b9440a65809cbdaf9d97029f4e

Re: [edk2-devel] [edk2-platforms PATCH v5 1/2] Platform/RaspberryPi: Enable Boot Discovery Policy.

On Tue, 3 Aug 2021 at 15:00, Samer El-Haj-Mahmoud wrote: > > Ard, > > Now that the EDK2 changes are merged (aaecef38b9440a65809cbdaf9d97029f4eeb), > I think these RPi specific changes are ready to be merged as well. > I only see acks from Sunny though. This is why I asked Pete and Andrei to chim

Re: [edk2-devel] [edk2-platforms PATCH v5 1/2] Platform/RaspberryPi: Enable Boot Discovery Policy.

Ard, Now that the EDK2 changes are merged (aaecef38b9440a65809cbdaf9d97029f4eeb), I think these RPi specific changes are ready to be merged as well. > -Original Message- > From: Grzegorz Bernacki > Sent: Monday, August 2, 2021 8:19 AM > To: devel@edk2.groups.io > Cc: l...@nuviainc.com;

Re: [edk2-devel] [staging/edk2-redfish-client PATCH v2 2/2] edk2: Update Maintainers.txt

On Tue, Jul 20, 2021 at 11:53:58 +0800, Abner Chang wrote: > Add maintainer and reviewer to RedfishClinetPkg. > > Signed-off-by: Abner Chang > Cc: Nickle Wang > Cc: Liming Gao > Cc: Andrew Fish > Cc: Leif Lindholm > Cc: Michael D Kinney > --- > Maintainers.txt | 5 + > 1 file changed, 5

Re: [edk2-devel] [Patch V2 3/3] Maintainers.txt: Add GitHub IDs

On Thu, Jul 08, 2021 at 12:50:47 -0700, Michael D Kinney wrote: > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Signed-off-by: Michael D Kinney Reviewed-by: Leif Lindholm Apologies for tardiness. > --- > Maintainers.txt | 282 > 1

Re: [edk2-devel] [edk2-platforms][PATCH v5 21/46] KabylakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib

Please see my comments below inline. Thanks, Chasel > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Tuesday, August 3, 2021 10:39 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Jeremy Soller > Subject: [edk2-platforms][PATCH v5 21/46] K

Re: [edk2-devel] [edk2-platforms PATCH 3/6] Marvell: Armada7k8kPciHostBridgeLib: Remove ECAM base limitation

wt., 3 sie 2021 o 08:53 Ard Biesheuvel napisał(a): > > On Mon, 2 Aug 2021 at 19:00, Marcin Wojtas wrote: > > > > Hi Ard, > > > > pon., 2 sie 2021 o 10:43 Ard Biesheuvel napisał(a): > > > > > > On Mon, 2 Aug 2021 at 07:01, Marcin Wojtas wrote: > > > > > > > > On CN913x-based platforms it is poss

Re: [edk2-devel] [PATCH v8 00/11] Secure Boot default keys

On Mon, 2 Aug 2021 at 12:47, Grzegorz Bernacki wrote: > > This patchset adds support for initialization of default > Secure Boot variables based on keys content embedded in > flash binary. This feature is active only if Secure Boot > is enabled and DEFAULT_KEY is defined. The patchset > consist al

Re: [edk2-devel] [edk2-platforms PATCH 0/6] Marvell multiple PCIE support

On Mon, 2 Aug 2021 at 07:01, Marcin Wojtas wrote: > > This patchset is a preparation for adding a new platform > (CN913x CEx7 Evaluation Board). It modifies a common > Marvell code in order to enable multiple PCIE controllers. > Moreover a default interrupt map is reworked, so that to > support al