Reviewed-by: Michael D Kinney <michael.d.kin...@intel.com> > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Takuto Naito > Sent: Thursday, July 29, 2021 7:54 AM > To: devel@edk2.groups.io > Cc: Takuto Naito <nait...@gmail.com>; Agyeman, Prince > <prince.agye...@intel.com> > Subject: [edk2-devel] [edk2-platforms PATCH v1 1/1] > Platform/Intel/SimicsOpenBoardPkg: Fix PCD type of PcdVideo*Resolution > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3514 > > PcdVideoHorizontalResolution and PcdVideoVerticalResolutio are set in > the SimicsDxe module and consumed by the other module GraphicsConsoleDxe. > In this case, the type of these PCDs should be Dynamic. > > Cc: Agyeman Prince <prince.agye...@intel.com> > Signed-off-by: Takuto Naito <nait...@gmail.com> > --- > .../SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc > index 251f46f812..88009b8f10 100644 > --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc > +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc > @@ -221,8 +221,6 @@ > gEfiMdeModulePkgTokenSpaceGuid.PcdSmiHandlerProfilePropertyMask|0x1 > !endif > gEfiMdeModulePkgTokenSpaceGuid.PcdUse1GPageTable|TRUE > - gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|1024 > - gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|600 > gPcAtChipsetPkgTokenSpaceGuid.PcdHpetBaseAddress|0xFED00000 > > ###################################### > @@ -238,6 +236,8 @@ > gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiS3Enable|FALSE > gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvStoreReserved|0 > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64|0 > + gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|1024 > + gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|600 > > ###################################### > # Board Configuration > -- > 2.25.1 > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78622): https://edk2.groups.io/g/devel/message/78622 Mute This Topic: https://groups.io/mt/84529697/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-