Chris: This patch set is good. I have only one minor comments for struct EFI_ACPI_6_4_GIC_STRUCTURE. I suggest to keep the same field name to EFI_ACPI_6_3_GIC_STRUCTURE. We can ignore ECC issue in MdePkg.ci.yaml IgnoreFiles list.
Thanks Liming > -----邮件原件----- > 发件人: Chris Jones <christopher.jo...@arm.com> > 发送时间: 2021年7月30日 18:22 > 收件人: devel@edk2.groups.io > 抄送: sami.muja...@arm.com; akanksha.ja...@arm.com; > ben.adder...@arm.com; michael.d.kin...@intel.com; > gaolim...@byosoft.com.cn; zhiguang....@intel.com; > matteo.carl...@arm.com; n...@arm.com > 主题: [PATCH RESEND v1 00/13] Add ACPI 6.4 header file > > Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) > > This patch series introduces a header file for the latest version of the > ACPI 6.4 specification, January 2021. This header contains all updates > to the ACPI specification in addition to addressing a few small errors > from the previous ACPI header files. > > The patches have been resent to include the bugzilla id, no code has > been changed. > > The changes can be seen at: > https://github.com/chris-jones-arm/edk2/tree/1661_add_acpi_64_header_v > 1 > > Chris Jones (13): > MdePkg: Add ACPI 6.4 header file > MdePkg: Increment FADT version > MdePkg: Rename SBSA Generic Watchdog to Arm Generic Watchdog > MdePkg: Update PMTT to ACPI 6.4 > MdePkg: Add SPA Location Cookie field to SPA Range structure > MdePkg: Remove DPPT table > MdePkg: Add flags and MinTransferSize to Generic Initiator > MdePkg: Add 'Type 5' PCC structure > MdePkg: Add Multiprocessor Wakeup structure > MdePkg: Add the Platform Health Assessment Table (PHAT) > MdePkg: Add Secure Access Components in the SDEV table > MdePkg: Add Cache ID to PPTT > MdePkg: Fix broken coding style in Acpi64.h > > MdePkg/Include/IndustryStandard/Acpi.h | 4 +- > MdePkg/Include/IndustryStandard/Acpi64.h | 3148 > ++++++++++++++++++++ > 2 files changed, 3150 insertions(+), 2 deletions(-) > create mode 100644 MdePkg/Include/IndustryStandard/Acpi64.h > > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78631): https://edk2.groups.io/g/devel/message/78631 Mute This Topic: https://groups.io/mt/84655041/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
