Re: [edk2-devel] [PATCH v3 8/8] MdeModulePkg: Use SecureBootVariableLib in PlatformVarCleanupLib.

2021-06-24 Thread Grzegorz Bernacki
Hi Liming, Adding support for DXE_DRIVER and UEFI_APPLICATION to AuthVariableLib causes problem with PlatformSecureLib and VariablePolicyLib which does not support that modules. I don't want to change to many modules just to remove one function in PlatformVarCleanupLib. As I wrote before I think th

Re: [edk2-devel] [PATCH] BaseTools: Reset ERRORLEVEL in toolsetup.bat after edk2basetools check

2021-06-24 Thread Bob Feng
Merged. -Original Message- From: devel@edk2.groups.io On Behalf Of Bob Feng Sent: Friday, June 25, 2021 9:53 AM To: devel@edk2.groups.io; rebe...@bsdio.com; Liming Gao ; Chen, Christine Subject: Re: [edk2-devel] [PATCH] BaseTools: Reset ERRORLEVEL in toolsetup.bat after edk2basetools c

Re: [edk2-devel] [PATCH] BaseTools: Fix spelling of "overwrite" and "overwriting" in toolset.bat

2021-06-24 Thread Bob Feng
Merged. -Original Message- From: devel@edk2.groups.io On Behalf Of Bob Feng Sent: Friday, June 25, 2021 9:54 AM To: Rebecca Cran ; Liming Gao ; Chen, Christine Cc: devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH] BaseTools: Fix spelling of "overwrite" and "overwriting" in toolset

Re: [edk2-devel] [PATCH] BaseTools: Remove check for Split.exe in toolset.bat

2021-06-24 Thread Bob Feng
Created the PR https://github.com/tianocore/edk2/pull/1761 Thanks, BOb -Original Message- From: devel@edk2.groups.io On Behalf Of Bob Feng Sent: Thursday, June 17, 2021 11:05 AM To: gaoliming ; devel@edk2.groups.io; rebe...@bsdio.com; Chen, Christine Subject: Re: [edk2-devel] [PATCH] B

Re: [edk2-devel] [edk2-platforms][PATCH v3 06/41] IntelSiliconPkg: Add PCH SPI PPI

2021-06-24 Thread Michael Kubacki
Hi Sai, That sounds fine to me. I'll send it in a v4 soon. Thanks, Michael On 6/24/2021 5:56 PM, Chaganty, Rangasai V wrote: Hi Michael, Since there is a change in SPI protocol/PPI services (enum to EFI_GUID type for Flash region types), perhaps defining a new GUID would be better, just to ma

Re: [edk2-devel] [PATCH] BaseTools: Fix spelling of "overwrite" and "overwriting" in toolset.bat

2021-06-24 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Rebecca Cran Sent: Sunday, June 13, 2021 11:56 AM To: Feng, Bob C ; Liming Gao ; Chen, Christine Cc: Rebecca Cran ; devel@edk2.groups.io Subject: [PATCH] BaseTools: Fix spelling of "overwrite" and "overwriting" in toolset.bat The words

Re: [edk2-devel] [PATCH] BaseTools: Reset ERRORLEVEL in toolsetup.bat after edk2basetools check

2021-06-24 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io On Behalf Of Rebecca Cran Sent: Sunday, June 13, 2021 11:43 AM To: Feng, Bob C ; Liming Gao ; Chen, Christine Cc: Rebecca Cran ; devel@edk2.groups.io Subject: [edk2-devel] [PATCH] BaseTools: Reset ERRORLEVEL in toolset

[edk2-devel] Happening Now: TianoCore Design Meeting - APAC/NAMO - 06/25/2021 #cal-notice

2021-06-24 Thread devel@edk2.groups.io Calendar
*TianoCore Design Meeting - APAC/NAMO* *When:* 06/25/2021 9:30am to 10:30am (UTC+08:00) Asia/Shanghai *Where:* Microsoft Teams *Organizer:* Ray Ni ray...@intel.com ( ray...@intel.com?subject=Re:%20Event:%20TianoCore%20Design%20Meeting%20-%20APAC%2FNAMO ) View Event ( https://edk2.groups.io/g/

[edk2-devel] Event: TianoCore Design Meeting - APAC/NAMO - 06/25/2021 #cal-reminder

2021-06-24 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:Asia/Shanghai LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai X-LIC-LOCATION:Asia/Shanghai BEGIN:STANDARD TZNAME:CST TZOFFSETFROM:+

Re: [edk2-devel] [edk2-platforms][PATCH v3 06/41] IntelSiliconPkg: Add PCH SPI PPI

2021-06-24 Thread Chaganty, Rangasai V
Hi Michael, Since there is a change in SPI protocol/PPI services (enum to EFI_GUID type for Flash region types), perhaps defining a new GUID would be better, just to make sure there are no collisions. Do you see any downside to it? Regards, Sai -Original Message- From: mikub...@linux.

Re: [edk2-devel] [edk2-platforms][PATCH v3 04/41] IntelSiliconPkg: Add BIOS area base address and size PCDs

2021-06-24 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: mikub...@linux.microsoft.com Sent: Thursday, June 17, 2021 7:07 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [edk2-platforms][PATCH v3 04/41] IntelSiliconPkg: Add BIOS area base add

Re: [edk2-devel] [PATCH v2 3/3] OvmfPkg/X86QemuLoadImageLib: State fw_cfg dependency in file header

2021-06-24 Thread Laszlo Ersek
On 06/17/21 14:17, Dov Murik wrote: > Make it clear that X86QemuLoadImageLib relies on fw_cfg; prepare the > ground to add a warning about the incompatibility with boot verification > process. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: James Bottomley > Cc: Tobin Feldm

Re: [edk2-devel] [PATCH v2 2/3] OvmfPkg/GenericQemuLoadImageLib: Read cmdline from QemuKernelLoaderFs

2021-06-24 Thread Laszlo Ersek
Hi Dov, On 06/17/21 14:16, Dov Murik wrote: > Remove the QemuFwCfgLib interface used to read the QEMU cmdline > (-append argument) and the initrd size. Instead, use the synthetic > filesystem QemuKernelLoaderFs which has three files: "kernel", "initrd", > and "cmdline". > > Cc: Laszlo Ersek > Cc

Re: [edk2-devel] [PATCH v4 4/4] OvmfPkg/PlatformDxe: Add support for SEV live migration.

2021-06-24 Thread Ashish Kalra via groups.io
Hello Tom, On Tue, Jun 22, 2021 at 06:06:24PM -0500, Tom Lendacky wrote: > > + > > +/** > > + Figures out if we are running inside KVM HVM and > > + KVM HVM supports SEV Live Migration feature. > > + > > + @retval TRUE KVM was detected and Live Migration supported > > + @retval FALSE KVM wa

Re: [edk2-devel] [PATCH v1 0/5] EDK2 Code First: PI Specification: Update EFI_MM_COMMUNICATE_HEADER

2021-06-24 Thread Michael D Kinney
Hello, Flexible array members are supported and should be used. The old style of adding an array of size [1] at the end of a structure was used at a time flexible array members were not supported by all compilers (late 1990's). The workarounds used to handle the array of size [1] are very confusi

[edk2-devel] [PATCH v2] NetworkPkg:UEFIPXEBC

2021-06-24 Thread INDIA\sivaramann
Issue on the PxeBcDhcp4CallBack() functions of UEFIPXEBC Driver. In this function any non allowed events are recieved as input it will exit in beginning itself. But the switch case handling the default and Dhcp4SendRequest which is not reachable. Signed-off-by: Sivaraman --- NetworkPkg/UefiPxeBc

Re: [edk2-devel] [PATCH v2 1/3] Revert "OvmfPkg/QemuKernelLoaderFsDxe: don't expose kernel command line"

2021-06-24 Thread Laszlo Ersek
On 06/17/21 14:16, Dov Murik wrote: > This reverts commit efc52d67e1573ce174d301b52fa1577d552c8441. > > Manually fixed conflicts in: > OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.c > > Note that besides re-exposing the kernel command line as a file in the > synthetic filesystem, we also

[edk2-devel] [PATCH v4] BaseTools GenFw: Add support for RISCV GOT/PLT relocations

2021-06-24 Thread Sunil V L
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3096 This patch adds support for R_RISCV_CALL_PLT and R_RISCV_GOT_HI20 relocations generated by PIE enabled compiler. This also needed changes to R_RISCV_32 and R_RISCV_64 relocations as explained in https://github.com/riscv/riscv-gnu-toolchain/i

Re: [edk2-devel] [PATCH v1 5/5] ArmVirtPkg: Enable Acpiview for ArmVirtPkg

2021-06-24 Thread Laszlo Ersek
On 06/24/21 14:59, Laszlo Ersek wrote: > On 06/23/21 16:06, PierreGondois wrote: >> From: Sami Mujawar >> >> Acpiview is a command line tool allowing to display, dump, or >> check installed ACPI tables. Add the tool to ArmVirt platforms. >> >> Signed-off-by: Sami Mujawar >> Signed-off-by: Pierre

Re: [edk2-devel] [PATCH v1 0/5] Add ACPI support for Kvmtool

2021-06-24 Thread Laszlo Ersek
On 06/23/21 16:06, PierreGondois wrote: > Pierre Gondois (1): > ArmVirtPkg: Add cspell exceptions > > Sami Mujawar (4): > ArmVirtPkg: Add DSDT ACPI table for Kvmtool firmware > ArmVirtPkg: Add Configuration Manager for Kvmtool firmware > ArmVirtPkg: Enable ACPI support for Kvmtool > Arm

Re: [edk2-devel] [PATCH v1 5/5] ArmVirtPkg: Enable Acpiview for ArmVirtPkg

2021-06-24 Thread Laszlo Ersek
On 06/23/21 16:06, PierreGondois wrote: > From: Sami Mujawar > > Acpiview is a command line tool allowing to display, dump, or > check installed ACPI tables. Add the tool to ArmVirt platforms. > > Signed-off-by: Sami Mujawar > Signed-off-by: Pierre Gondois > --- > ArmVirtPkg/ArmVirt.dsc.inc |

Re: [edk2-devel] [PATCH v1 4/5] ArmVirtPkg: Enable ACPI support for Kvmtool

2021-06-24 Thread Laszlo Ersek
On 06/23/21 16:06, PierreGondois wrote: > From: Sami Mujawar > > A Configuration Manager that uses the Dynamic Tables framework > to generate ACPI tables for Kvmtool Guests has been provided. > This Configuration Manager uses the FdtHwInfoParser module to > parse the Kvmtool Device Tree and gener

Re: [edk2-devel] [PATCH v1 3/5] ArmVirtPkg: Add Configuration Manager for Kvmtool firmware

2021-06-24 Thread Laszlo Ersek
On 06/23/21 16:06, PierreGondois wrote: > diff --git a/ArmVirtPkg/KvmtoolCfgMgrDxe/ConfigurationManagerDxe.inf > b/ArmVirtPkg/KvmtoolCfgMgrDxe/ConfigurationManagerDxe.inf > new file mode 100644 > index ..9f0bf72fce2d > --- /dev/null > +++ b/ArmVirtPkg/KvmtoolCfgMgrDxe/ConfigurationMan

Re: [edk2-devel] [PATCH v1 3/5] ArmVirtPkg: Add Configuration Manager for Kvmtool firmware

2021-06-24 Thread Laszlo Ersek
On 06/23/21 16:06, PierreGondois wrote: > From: Sami Mujawar > > Add Configuration Manager to enable ACPI tables for Kvmtool > firmware. The Configuration Manager for Kvmtool uses the DT > Hardware Information Parser module (FdtHwInfoParser) to parse > the DT provided by Kvmtool. The FdtHwInfoPar

Re: [edk2-devel] [PATCH v1 0/5] Add ACPI support for Kvmtool

2021-06-24 Thread Laszlo Ersek
On 06/23/21 16:06, PierreGondois wrote: > From: Pierre Gondois > > Kvmtool dynamically generates a device tree describing the platform > to boot on. Using the patch-sets listed below, the DynamicTables > framework generates ACPI tables describing a similar platform. > > This patch-set: > - adds

Re: [edk2-devel] [PATCH v1 2/5] ArmVirtPkg: Add DSDT ACPI table for Kvmtool firmware

2021-06-24 Thread Laszlo Ersek
On 06/23/21 16:06, PierreGondois wrote: > From: Sami Mujawar > > Most ACPI tables for Kvmtool firmware are dynamically > generated. The AML code is also generated at runtime > for most components in appropriate SSDTs. > > Although there may not be much to describe in the DSDT, > the DSDT table i

Re: [edk2-devel] [PATCH v1 1/5] ArmVirtPkg: Add cspell exceptions

2021-06-24 Thread Laszlo Ersek
On 06/23/21 16:06, PierreGondois wrote: > From: Pierre Gondois > > The cpsell tool checks for unknown words in the upstream CI. > Add some new words to the list of exceptions. > > Signed-off-by: Pierre Gondois > --- > ArmVirtPkg/ArmVirtPkg.ci.yaml | 3 +++ > 1 file changed, 3 insertions(+) >

Re: [edk2-devel] [PATCH] OvmfPkg/Bhyve: clean up TPM_ENABLE remnants

2021-06-24 Thread Laszlo Ersek
On 06/12/21 22:43, Rebecca Cran wrote: > TPM support hasn't been tested and any lines in the .dsc and .fdf files > that appear to show support are bogus. Remove them. > > This fixes https://bugzilla.tianocore.org/show_bug.cgi?id=3354 . > > Signed-off-by: Rebecca Cran > --- > OvmfPkg/Bhyve/Bhyve

Re: [edk2-devel] [PATCH v1 0/5] EDK2 Code First: PI Specification: Update EFI_MM_COMMUNICATE_HEADER

2021-06-24 Thread Marvin Häuser
Hey Kun, Why would you rely on undefined behaviours? The OFFSET_OF macro is well-defined for GCC and Clang as it's implemented by an intrinsic, and while the expression for the MSVC compiler is undefined behaviour as per the C standard, it is well-defined for MSVC due to their own implementat

Re: [edk2-devel] [PATCH] OvmfPkg/Bhyve: clean up TPM_ENABLE remnants

2021-06-24 Thread Laszlo Ersek
On 06/12/21 22:43, Rebecca Cran wrote: > TPM support hasn't been tested and any lines in the .dsc and .fdf files > that appear to show support are bogus. Remove them. > > This fixes https://bugzilla.tianocore.org/show_bug.cgi?id=3354 . > > Signed-off-by: Rebecca Cran > --- > OvmfPkg/Bhyve/Bhyve