On 06/17/21 14:17, Dov Murik wrote: > Make it clear that X86QemuLoadImageLib relies on fw_cfg; prepare the > ground to add a warning about the incompatibility with boot verification > process. > > Cc: Laszlo Ersek <ler...@redhat.com> > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: James Bottomley <j...@linux.ibm.com> > Cc: Tobin Feldman-Fitzthum <to...@linux.ibm.com> > Signed-off-by: Dov Murik <dovmu...@linux.ibm.com> > --- > OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.inf | 3 +++ > OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c | 3 +++ > 2 files changed, 6 insertions(+)
(1) The bugzilla ticket should be referenced in the commit message, above your signoff: Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3457 With that update: Reviewed-by: Laszlo Ersek <ler...@redhat.com> Thanks, Laszlo > > diff --git a/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.inf > b/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.inf > index e1615badd2ba..c7ec041cb706 100644 > --- a/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.inf > +++ b/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.inf > @@ -2,6 +2,9 @@ > # X86 specific implementation of QemuLoadImageLib library class interface > # with support for loading mixed mode images and non-EFI stub images > # > +# Note that this implementation reads the cmdline (and possibly kernel, > setup > +# data, and initrd in the legacy boot mode) from fw_cfg directly. > +# > # Copyright (c) 2020, ARM Ltd. All rights reserved.<BR> > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > diff --git a/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c > b/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c > index 1177582ab051..dc9018f4333b 100644 > --- a/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c > +++ b/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c > @@ -2,6 +2,9 @@ > X86 specific implementation of QemuLoadImageLib library class interface > with support for loading mixed mode images and non-EFI stub images > > + Note that this implementation reads the cmdline (and possibly kernel, setup > + data, and initrd in the legacy boot mode) from fw_cfg directly. > + > Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR> > Copyright (c) 2020, ARM Ltd. All rights reserved.<BR> > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77069): https://edk2.groups.io/g/devel/message/77069 Mute This Topic: https://groups.io/mt/83602586/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
