Created the PR https://github.com/tianocore/edk2/pull/1761
Thanks, BOb -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bob Feng Sent: Thursday, June 17, 2021 11:05 AM To: gaoliming <gaolim...@byosoft.com.cn>; devel@edk2.groups.io; rebe...@bsdio.com; Chen, Christine <yuwei.c...@intel.com> Subject: Re: [edk2-devel] [PATCH] BaseTools: Remove check for Split.exe in toolset.bat Reviewed-by: Bob Feng <bob.c.f...@intel.com> -----Original Message----- From: gaoliming <gaolim...@byosoft.com.cn> Sent: Thursday, June 17, 2021 9:36 AM To: devel@edk2.groups.io; rebe...@bsdio.com; Feng, Bob C <bob.c.f...@intel.com>; Chen, Christine <yuwei.c...@intel.com> Subject: 回复: [edk2-devel] [PATCH] BaseTools: Remove check for Split.exe in toolset.bat Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn> > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Rebecca Cran > 发送时间: 2021年6月13日 11:35 > 收件人: Bob Feng <bob.c.f...@intel.com>; Liming Gao > <gaolim...@byosoft.com.cn>; Yuwei Chen <yuwei.c...@intel.com> > 抄送: Rebecca Cran <rebe...@bsdio.com>; devel@edk2.groups.io > 主题: [edk2-devel] [PATCH] BaseTools: Remove check for Split.exe in > toolset.bat > > Split is now a Python tool, so BaseTools\Bin\Win32\Split.exe no longer > exists. Remove the check for it from toolsetup.bat to prevent the > erroneous claim that the binary C tools are missing. > > Signed-off-by: Rebecca Cran <rebe...@bsdio.com> > --- > BaseTools/toolsetup.bat | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat index > 4b5256ab6e..a766a69f08 100755 > --- a/BaseTools/toolsetup.bat > +++ b/BaseTools/toolsetup.bat > @@ -299,7 +299,6 @@ IF NOT EXIST "%EDK_TOOLS_BIN%\GenFfs.exe" goto > check_c_tools IF NOT EXIST "%EDK_TOOLS_BIN%\GenFv.exe" goto > check_c_tools > > IF NOT EXIST "%EDK_TOOLS_BIN%\GenFw.exe" goto check_c_tools > > IF NOT EXIST "%EDK_TOOLS_BIN%\GenSec.exe" goto check_c_tools > > -IF NOT EXIST "%EDK_TOOLS_BIN%\Split.exe" goto check_c_tools > > IF NOT EXIST "%EDK_TOOLS_BIN%\TianoCompress.exe" goto check_c_tools > > IF NOT EXIST "%EDK_TOOLS_BIN%\VfrCompile.exe" goto check_c_tools > > IF NOT EXIST "%EDK_TOOLS_BIN%\VolInfo.exe" goto check_c_tools > > -- > 2.32.0 > > > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#76441): > https://edk2.groups.io/g/devel/message/76441 > Mute This Topic: https://groups.io/mt/83503018/4905953 > Group Owner: devel+ow...@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [gaolim...@byosoft.com.cn] > -=-=-=-=-=-= > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77078): https://edk2.groups.io/g/devel/message/77078 Mute This Topic: https://groups.io/mt/83775635/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
