Re: [edk2-devel] [PATCH] OvmfPkg/Bhyve: clean up TPM_ENABLE remnants

Hi, I have checked in a new Mergify configuration file into edk2-codereview. Have not had a chance to test it yet, but I think it has all the updates that have been discussed: 1) Allows non EDK II Maintainers to open a PR and for an EDK II Maintainers to set labels. 2) Removed status check na

[edk2-devel] [PATCH v2 1/2] OvmfPkg/Bhyve: add USB support

An USB driver is required to use a keyboard or mouse while installing an OS or while in a bootloader menu like grub when using GPU + USB Passthrough. --- OvmfPkg/Bhyve/BhyveX64.dsc | 11 +++ OvmfPkg/Bhyve/BhyveX64.fdf | 10 ++ 2 files changed, 21 insertions(+) diff --git a/Ovmf

[edk2-devel] [PATCH v2 2/2] OvmfPkg/Bhyve: use static PCI32Base address

It's neccessary to allocate a Graphics Stolen Memory area to enable GPU-Passthrough for integrated Intel GPUs. Therefore, use a new memory layout with a static Pci32Baseaddress. Old layout: [..., lowmemlimit] RAM [lowmemlimit, 0xE000 ] PCI Space New layout: [

[edk2-devel] [PATCH v2 0/2] Prepare bhyve for GPU-Passthrough

Hi, these patches could be merged to improve GPU-Passthrough support. If I get an agreement with Peter about BusEnumeration, I'll create a new patch series Best Regards Corvin Corvin Köhne (2): OvmfPkg/Bhyve: add USB support OvmfPkg/Bhyve: use static PCI32Base address OvmfPkg/Bhyve/Bh

Re: [edk2-devel] 回复: Need help with CI/CD failure for the PR

Thanks a lot Mike and Liming. This is very helpful. Let me fix this issue and send the next version. Thanks! Sunil On Thu, Jun 24, 2021 at 11:45:07AM +0800, gaoliming wrote: > Mike: > Thanks for your help. I can download build log and see the real issue. > > Thanks > Liming > > -邮件原件-

Re: [edk2-devel] Proposing a new area of the edk2-test repository

Fun fact! Mu also has a number of apps and things that we could work on moving to EDK2 if there were a suitable location. Right now, many of them are here: mu_plus/UefiTestingPkg at release/202102 · microsoft/mu_plus (github.com)

Re: [edk2-devel] [Patch V2 1/2] UefiPayloadPkg: Add new structure for BootManagerMenuFile HOB

Reviewed-by: Guo Dong > -Original Message- > From: Tan, Dun > Sent: Tuesday, June 22, 2021 8:04 PM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo > ; You, Benjamin ; Tan, > Dun > Subject: [Patch V2 1/2] UefiPayloadPkg: Add new structure for > BootManagerMenuFile HOB > > Add

Re: [edk2-devel] [Patch V2 2/2] UefiPayloadPkg: consume the BootManagerMenuFile HOB

Reviewed-by: Guo Dong > -Original Message- > From: Tan, Dun > Sent: Tuesday, June 22, 2021 8:04 PM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo > ; You, Benjamin ; Tan, > Dun > Subject: [Patch V2 2/2] UefiPayloadPkg: consume the BootManagerMenuFile > HOB > > Consume the B

[edk2-devel] 回复: Need help with CI/CD failure for the PR

Mike: Thanks for your help. I can download build log and see the real issue. Thanks Liming > -邮件原件- > 发件人: Kinney, Michael D > 发送时间: 2021年6月24日 11:16 > 收件人: gaoliming ; 'Sunil V L' > ; devel@edk2.groups.io; 'Sean Brogan' > ; Kinney, Michael D > > 抄送: 'Chang, Abner (HPS SW/FW Technolog

[edk2-devel] [PATCH v2 2/2] MdePkg: MmConfiguration: Added definition of MM Configuration PPI

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3440 MM Configuration PPI was defined in PI Specification since v1.5. This change added definition of such PPI and related GUIDs into MdePkg. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Michael Kubacki Signed-off-by: Kun Qin -

[edk2-devel] [PATCH v2 1/2] MdePkg: MmConfiguration: Move definition of EFI_MM_RESERVED_MMRAM_REGION

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3440 The definition of EFI_MM_RESERVED_MMRAM_REGION, according to PI Spec 1.5 is also referenced in EFI_PEI_MM_CONFIGURATION_PPI. Defining this structure as is will enforce any potential usage of MM Configuration PPI interface to include . This

[edk2-devel] [PATCH v2 0/2] Add MM Configuration PPI definition to MdePkg

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3440 This patch series is a follow up of previous submission: https://edk2.groups.io/g/devel/message/76748 v2 patches mainly focus on feedback for commits submitted in v1 patches: a. Moved EFI_MM_RESERVED_MMRAM_REGION from PiMmCis to PiMultiPhas

Re: [EXTERNAL] Re: [edk2-devel] [PATCH v1 1/5] EDK2 Code First: PI Specification: EFI_MM_COMMUNICATE_HEADER Update

Yeah, the only other thought I had for moving forwards quickly (i.e. hackily) is to define a new GUID that just means “I use an updated header configuration” since the EFI_GUID field comes first and is a well-understood size. I would prefer the “deprecate, break builds, fix code, move forward” a

Re: [edk2-devel] Need help with CI/CD failure for the PR

Liming, Looks like it failed to build BaseTools: https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=24448&view=logs&jobId=4a97f94c-8e1f-5e76-68ba-50872604dd63&j=2640d2b2-7c53-5a2b-80c7-040377c664fd&t=9d40d6fd-f2ec-5369-fb67-2d935d8d6b47 This PR modified GenFw, so it is likely related

Re: [edk2-devel] [PATCHV2] CryptoPkg/BaseCryptLib: Enabled CryptSha512 for Smm/Runtime drivers

Pushed at eba32695ee6979137c86c3d20d0711d49d5c3ba8 Regards, Jian > -Original Message- > From: Yao, Jiewen > Sent: Thursday, June 24, 2021 10:06 AM > To: devel@edk2.groups.io; gaolim...@byosoft.com.cn; Xue, Shengfeng > ; Wang, Jian J > Cc: Xue, ShengfengX > Subject: RE: [edk2-devel] [PA

Re: [edk2-devel] [PATCHV2] CryptoPkg/BaseCryptLib: Enabled CryptSha512 for Smm/Runtime drivers

Ah. Yes. I think so. Hi Jian Can you help on that? > -Original Message- > From: devel@edk2.groups.io On Behalf Of gaoliming > Sent: Thursday, June 24, 2021 9:30 AM > To: devel@edk2.groups.io; Yao, Jiewen ; Xue, > Shengfeng ; Wang, Jian J > > Cc: Xue, ShengfengX > Subject: 回复: [edk2-dev

[edk2-devel] 回复: [PATCH v1 4/4] .pytool/EccCheck: Set PACKAGES_PATH env var in Ecc

Pierre: > -邮件原件- > 发件人: pierre.gond...@arm.com > 发送时间: 2021年6月23日 15:23 > 收件人: devel@edk2.groups.io; Sean Brogan ; > Bret Barkelew ; Michael D Kinney > ; Liming Gao ; > Sami Mujawar > 主题: [PATCH v1 4/4] .pytool/EccCheck: Set PACKAGES_PATH env var in Ecc > > From: Pierre Gondois > > Wh

[edk2-devel] 回复: Need help with CI/CD failure for the PR

Mike and Sean: Have you any idea on how to find the error message in PR failure report? For this PR https://github.com/tianocore/edk2/pull/1738, I don't find the real error message. Thanks Liming > -邮件原件- > 发件人: Sunil V L > 发送时间: 2021年6月22日 18:53 > 收件人: devel@edk2.groups.io > 抄送:

回复: [edk2-devel] [PATCHV2] CryptoPkg/BaseCryptLib: Enabled CryptSha512 for Smm/Runtime drivers

So far, there is no objection for this patch. How about merge it? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Yao, Jiewen > 发送时间: 2021年6月9日 11:08 > 收件人: Xue, Shengfeng ; > devel@edk2.groups.io; Wang, Jian J > 抄送: Xue, ShengfengX > 主题: Re: [edk2-devel] [PATCHV2] CryptoPkg/Base

Re: [edk2-devel] [PATCH] OvmfPkg/Bhyve: clean up TPM_ENABLE remnants

Liming, Yes. I am working on a configuration with will keep the current 'push' behavior and add the 'auto-rebase' option. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of gaoliming > Sent: Wednesday, June 23, 2021 6:10 PM > To: devel@edk2.groups.io; Kinney, Michael D

回复: [edk2-devel] [PATCH] OvmfPkg/Bhyve: clean up TPM_ENABLE remnants

Mike: If 'auto-rebase' label is not set, the behavior is still same to current one. Right? If yes, I agree this proposal. The maintainer can optionally set 'auto-rebase'. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Michael D > Kinney > 发送时间: 2021年6月24日 6:08 > 收件人: devel@e

回复: [edk2-devel] [PATCH v3 8/8] MdeModulePkg: Use SecureBootVariableLib in PlatformVarCleanupLib.

I agree that AuthVariableLib can support UEFI_DRIVER, DXE_DRIVER and UEFI_APPLICATION. There is no limitation for this library. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Grzegorz > Bernacki > 发送时间: 2021年6月23日 18:39 > 收件人: devel@edk2.groups.io; Sunny Wang > 抄送: gaolim...@byo

Re: [edk2-rfc] [edk2-devel] RFC: design review for TDVF in OVMF

On 06/24/2021 8:36 AM, James Bottomley wrote: > On Thu, 2021-06-24 at 00:24 +, Min Xu wrote: > > On 06/22/2021 9:39 PM, Laszlo wrote: > > > I should clarify: the relevant part of my preference is not that > > > "IntelTdx.dsc" > > > contain the *complete* TDVF feature set. The relevant part (fo

Re: 回复: [edk2-devel] [PATCH v1 1/2] MdePkg: MmConfiguration: Moved EFI_MM_RESERVED_MMRAM_REGION to PiMmCis.h

Hi Liming, Thanks for pointing it out. I will updated the patches shortly. Regards, Kun On 06/20/2021 18:22, gaoliming wrote: Kun: There is one header file edk2\MdePkg\Include\PiMultiPhase.h for this purpose. Can you place the common definition to it? Thanks Liming -邮件原件- 发件人: dev

回复: [edk2-devel] 回复: [edk2][PATCH V3] MdePkg : Add IPMI Macro and Structure Defintions to resolve build errors

AbduL: This is same to the definition of UINT8 CompletionCode without bitfield. Thanks Liming 发件人: devel@edk2.groups.io 代表 AbduL Lateef 发送时间: 2021年6月23日 19:43 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn 抄送: manickavasakam karpagavinayagam ; isaac.w.o...@intel.com; nathaniel.l.desi

Re: [edk2-devel] [PATCH v1 1/5] EDK2 Code First: PI Specification: EFI_MM_COMMUNICATE_HEADER Update

Hi Hao, We have been circulating different ideas internally about how to enforce a warning around this change. There is an idea of deprecating the old structure and replacing it with a newly defined EFI_MM_COMMUNICATE_HEADER_V2. That way all consumers will be enforced to update their impleme

Re: [edk2-rfc] [edk2-devel] RFC: design review for TDVF in OVMF

On Thu, 2021-06-24 at 00:24 +, Min Xu wrote: > On 06/22/2021 9:39 PM, Laszlo wrote: > > I should clarify: the relevant part of my preference is not that > > "IntelTdx.dsc" > > contain the *complete* TDVF feature set. The relevant part (for me) > > is that > > "OvmfPkgX64.dsc" *not* be over-comp

Re: [edk2-devel] SIMPLE_TEXT_OUTPUT_PROTOCOL and Video Resolution

It would be nice to just update the specs to say, when a text mode is chosen the resolution shall be set to the lowest resolution that supports the cols and rows of the given text mode. Then over time all the systems will handle it. On Wed, Jun 23, 2021 at 3:24 AM Laszlo Ersek wrote: > > On 06/1

Re: [edk2-devel] [PATCH v2 1/6] EDK2 Code First: PI Specification: EFI_MM_COMMUNICATE_HEADER Update

I can place this file under "CodeFirst" folder on the next round of patch series. It would be helpful to update the code-first process page so that others can be consistent on the process next time. Thanks, Kun On 06/23/2021 03:02, Laszlo Ersek wrote: On 06/18/21 11:02, Kun Qin wrote: REF:

Re: [edk2-devel] [PATCH v1 0/5] EDK2 Code First: PI Specification: Update EFI_MM_COMMUNICATE_HEADER

Hi Marvin, I would prefer not to rely on undefined behaviors from different compilers. Instead of using flexible arrays, is it better to remove the `Data` field, pack the structure and follow "VARIABLE_LOCK_ON_VAR_STATE_POLICY" pattern? In that case, OFFSET_OF will be forced to change to siz

Re: [edk2-rfc] [edk2-devel] RFC: design review for TDVF in OVMF

On 06/22/2021 9:39 PM, Laszlo wrote: > > I should clarify: the relevant part of my preference is not that > "IntelTdx.dsc" > contain the *complete* TDVF feature set. The relevant part (for me) is that > "OvmfPkgX64.dsc" *not* be over-complicated for the sake of TDX, even > considering only the "b

Re: [edk2-devel] [Patch V2 10/12] UefiPayloadPkg: Add macro to disable some drivers

Please update the MACRO as below. > + DEFINE EMU_VARIABLE_ENABLE = FALSE Change to: DEFINE EMU_VARIABLE_ENABLE = TRUE > +!if $(EMU_VARIABLE_ENABLE) == FALSE Change to +!if $(EMU_VARIABLE_ENABLE) == TRUE With that: Reviewed-by: Guo Dong > -Original Message- > From: L

Re: [edk2-devel] [Patch V2 01/12] UefiPayloadPkg: Add HobLib for UniversalPayload

Reviewed-by: Guo Dong > -Original Message- > From: Liu, Zhiguang > Sent: Tuesday, June 22, 2021 7:52 PM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo > ; You, Benjamin ; Ni, Ray > > Subject: [Patch V2 01/12] UefiPayloadPkg: Add HobLib for UniversalPayload > > V1: > For pay

Re: [edk2-devel] [Patch V2 07/12] UefiPayloadPkg: Fix up UPL Pcd database

Reviewed-by: Guo Dong > -Original Message- > From: Liu, Zhiguang > Sent: Tuesday, June 22, 2021 7:53 PM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo > ; You, Benjamin > Subject: [Patch V2 07/12] UefiPayloadPkg: Fix up UPL Pcd database > > V1: > Edk2 bootloader will pass th

Re: [edk2-devel] 回复: [edk2][PATCH V3] MdePkg : Add IPMI Macro and Structure Defintions to resolve build errors

whats the use of bitfield:8 for UINT8 variable type? +typedef struct { *+ UINT8 CompletionCode:8;* +} IPMI_SET_BOOT_OPTIONS_RESPONSE; Thanks AbduL On Mon, Jun 21, 2021 at 7:19 AM gaoliming wrote: > Thanks for you update. > > Reviewed-by: Liming Gao > > Thanks > Liming > > -邮件原件- > > 发件

Re: [edk2-devel] Proposing a new area of the edk2-test repository

I have created a few other internal apps that build under WinTestPkg, although ResumeOK.efi is the only one I have received permissions to release sources for at this time. And yes, they are primarily intended for validating Windows requirements. I had some issues with my apps, needing to use di

Re: [edk2-devel] [PATCH] OvmfPkg/Bhyve: clean up TPM_ENABLE remnants

Hi Laszlo, I understand your point. I am trying to balance the ease of use for developers, reducing overhead for maintainers, and prevent bad commits. I think you are saying that you want to make sure a maintainer carefully reviews changes across multiple PRs that are in the same area of code

[edk2-devel] NetworkPkg: Unexpected DHCP RELEASE after PXE server reply on IPv6

Hi all! Trying to track down an unexpected behavior for one of our teams here: “We tried to PXEBoot a VM using IPv6 and even though the server replied with all requested boot options, the firmware for some reason did a DHCPv6 release instead of going for a network boot.” The team dug in with so

Re: [edk2-devel] Proposing a new area of the edk2-test repository

+edk2 list I am not against adding additional test tools to edk2-test. Just feel like there is a need to organize and have a strategy, rather than just use edk2-test as a dumping group of miscellaneous tools. There is already a place for apps under https://github.com/tianocore/edk2/tree/master

Re: [edk2-devel] [PATCH] OvmfPkg/Bhyve: clean up TPM_ENABLE remnants

On 06/23/21 20:44, Kinney, Michael D wrote: > > Hi Laszlo, > > Thank you for the test case. > > I created 2 PRs against edk2-codereview using your patches. > I made minor update to commit messages to pass patch check. > > https://github.com/tianocore/edk2-codereview/pull/18 > https://github

Re: [edk2-devel] SIMPLE_TEXT_OUTPUT_PROTOCOL and Video Resolution

On 06/23/21 18:57, Andrew Fish wrote: > > >> On Jun 23, 2021, at 3:24 AM, Laszlo Ersek wrote: >> >> On 06/17/21 01:22, Andrew Fish via groups.io wrote: >>> >>> On Jun 16, 2021, at 2:45 PM, David F. wrote: Also, I found if there are 2 GOP handles and you change

Re: [edk2-devel] [PATCH] OvmfPkg/Bhyve: clean up TPM_ENABLE remnants

Hi Laszlo, Thank you for the test case. I created 2 PRs against edk2-codereview using your patches. I made minor update to commit messages to pass patch check. https://github.com/tianocore/edk2-codereview/pull/18 https://github.com/tianocore/edk2-codereview/pull/19 Found another issu

Re: [edk2-rfc] [edk2-devel] RFC: design review for TDVF in OVMF

On 06/23/21 04:44, Xu, Min M wrote: > On 06/22/2021 9:35 PM, Laszlo wrote: >> >> For example, as I stated earlier, "OvmfPkg/AcpiPlatformDxe" is a >> driver where I'd like to see zero changes, for either SEV or TDX. If >> the TD Mailbox location has to be reported to the OS via the MADT, >> and QEMU

Re: [edk2-devel] Help with debugging

Thanks for that tip! Unfortunately, the EFI shell (or, more accurately, the way that the EFI console handles input) makes the way I use it a bit difficult. Since I use a screen reader, I use -nographic with qemu, and the EFI console doesn't seem to work well with my terminal; if I for example type

Re: [edk2-devel] [PATCH v4 0/4] SEV Live Migration support for OVMF.

Hello Laszlo, Yes i will file a TianoCore Feature Request BZ for this and i am working on a v5 for this patch-set. Thanks, Ashish On Wed, Jun 23, 2021 at 06:49:06PM +0200, Laszlo Ersek wrote: > On 06/23/21 18:42, Laszlo Ersek wrote: > > On 06/22/21 19:46, Ashish Kalra wrote: > > >> Please find

Re: [edk2-devel] SIMPLE_TEXT_OUTPUT_PROTOCOL and Video Resolution

> On Jun 23, 2021, at 3:24 AM, Laszlo Ersek wrote: > > On 06/17/21 01:22, Andrew Fish via groups.io wrote: >> >> >>> On Jun 16, 2021, at 2:45 PM, David F. wrote: >>> >>> Also, I found if there are 2 GOP handles and you change the mode of >>> one, the other one doesn't re

Re: [edk2-devel] [PATCH v4 0/4] SEV Live Migration support for OVMF.

On 06/23/21 18:42, Laszlo Ersek wrote: > On 06/22/21 19:46, Ashish Kalra wrote: >> Please find below your reply on v3 of this patch-set : >> >> Please include such a patch in v4 -- if Tom and Brijesh agree, I'd like to >> put the new lib explicitly under their reviewership. >> >> Also, I plan to

Re: [edk2-devel] [PATCH v4 0/4] SEV Live Migration support for OVMF.

On 06/22/21 19:46, Ashish Kalra wrote: > Hello Laszlo, > > Please see my replies below : > > On Tue, Jun 22, 2021 at 07:20:53PM +0200, Laszlo Ersek wrote: >> Hi Ashish, >> >> (+Dave, +Paolo) >> >> On 06/21/21 15:56, Ashish Kalra wrote: >>> From: Ashish Kalra >>> >>> By default all the SEV guest

Re: [edk2-devel] [PATCH v1 0/5] EDK2 Code First: PI Specification: Update EFI_MM_COMMUNICATE_HEADER

On 06/23/21 08:54, Marvin Häuser wrote: > On 22.06.21 17:34, Laszlo Ersek wrote: >> On 06/18/21 11:37, Marvin Häuser wrote: >>> On 16.06.21 22:58, Kun Qin wrote: On 06/16/2021 00:02, Marvin Häuser wrote: > 2) Is it feasible yet with the current set of supported compilers to > support f

Re: [edk2-devel] [PATCH] OvmfPkg/Bhyve: clean up TPM_ENABLE remnants

On 06/22/21 17:38, Kinney, Michael D wrote: > Hi Laszlo, > > I am trying the following configuration that is very conservative: > > actions: > queue: > method: rebase > rebase_fallback: none > name: default > > The auto rebase only attempts a strict rebase. If tha

Re: [edk2-devel] [PATCH v4 1/4] OvmfPkg/MemEncryptHypercallLib: add library to support SEV hypercalls.

Hello Tom, Brijesh, Thanks for your comments and feedback on this patch-set. With reference to those, i will remove the new library and add the hypercall function inside BaseMemEncryptSevLib library. Also i will let the hypercall handling for SEV-ES be done as part of #VC exception handling in

[edk2-devel] [PATCH v1 3/5] ArmVirtPkg: Add Configuration Manager for Kvmtool firmware

From: Sami Mujawar Add Configuration Manager to enable ACPI tables for Kvmtool firmware. The Configuration Manager for Kvmtool uses the DT Hardware Information Parser module (FdtHwInfoParser) to parse the DT provided by Kvmtool. The FdtHwInfoParser parses the DT and invokes the callback function

[edk2-devel] [PATCH v1 5/5] ArmVirtPkg: Enable Acpiview for ArmVirtPkg

From: Sami Mujawar Acpiview is a command line tool allowing to display, dump, or check installed ACPI tables. Add the tool to ArmVirt platforms. Signed-off-by: Sami Mujawar Signed-off-by: Pierre Gondois --- ArmVirtPkg/ArmVirt.dsc.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) di

[edk2-devel] [PATCH v1 4/5] ArmVirtPkg: Enable ACPI support for Kvmtool

From: Sami Mujawar A Configuration Manager that uses the Dynamic Tables framework to generate ACPI tables for Kvmtool Guests has been provided. This Configuration Manager uses the FdtHwInfoParser module to parse the Kvmtool Device Tree and generate the required Configuration Manager objects for g

[edk2-devel] [PATCH v1 2/5] ArmVirtPkg: Add DSDT ACPI table for Kvmtool firmware

From: Sami Mujawar Most ACPI tables for Kvmtool firmware are dynamically generated. The AML code is also generated at runtime for most components in appropriate SSDTs. Although there may not be much to describe in the DSDT, the DSDT table is mandatory. Therefore, add an empty stub for DSDT. Si

[edk2-devel] [PATCH v1 1/5] ArmVirtPkg: Add cspell exceptions

From: Pierre Gondois The cpsell tool checks for unknown words in the upstream CI. Add some new words to the list of exceptions. Signed-off-by: Pierre Gondois --- ArmVirtPkg/ArmVirtPkg.ci.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml b/ArmVirtPkg/ArmV

[edk2-devel] [PATCH v1 0/5] Add ACPI support for Kvmtool

From: Pierre Gondois Kvmtool dynamically generates a device tree describing the platform to boot on. Using the patch-sets listed below, the DynamicTables framework generates ACPI tables describing a similar platform. This patch-set: - adds a ConfigurationManager allowing to generate ACPI tables

[edk2-devel] [PATCH v1 3/5] DynamicTablesPkg: DynamicPlatRepo: Add TokenFixer

From: Pierre Gondois The DynamicPlatRepo library allows to handle dynamically created CmObj. The dynamic platform repository can be in the following states: 1 - Non-initialised 2 - Transient: Possibility to add CmObj to the platform, but not to query them. 3 - Finalised: Possibility to qu

[edk2-devel] [PATCH v1 5/5] DynamicTablesPkg: Add DynamicPlatRepo library

From: Pierre Gondois The DynamicPlatRepo library allows to handle dynamically created CmObj. The dynamic platform repository can be in the following states: 1 - Non-initialised 2 - Transient: Possibility to add CmObj to the platform, but not to query them. 3 - Finalised: Possibility to qu

[edk2-devel] [PATCH v1 2/5] DynamicTablesPkg: DynamicPlatRepo: Add TokenGenerator

From: Pierre Gondois The DynamicPlatRepo library allows to handle dynamically created CmObj. The dynamic platform repository can be in the following states: 1 - Non-initialised 2 - Transient: Possibility to add CmObj to the platform, but not to query them. 3 - Finalised: Possibility to qu

[edk2-devel] [PATCH v1 4/5] DynamicTablesPkg: DynamicPlatRepo: Add TokenMapper

From: Pierre Gondois The DynamicPlatRepo library allows to handle dynamically created CmObj. The dynamic platform repository can be in the following states: 1 - Non-initialised 2 - Transient: Possibility to add CmObj to the platform, but not to query them. 3 - Finalised: Possibility to qu

[edk2-devel] [PATCH v1 0/5] Add DynamicPlatRepoLib

From: Pierre Gondois The DynamicPlatRepoLib is library allowing to receive and then give Configuration Manager (CM) objects. After being initialized, a dynamic platform repository can receive CMObjects. The library generates a token to uniquely identify the CMObject in the repository. The dynamic

[edk2-devel] [PATCH v1 1/5] DynamicTablesPkg: Definition for DynamicPlatRepoLib interface

From: Pierre Gondois The DynamicPlatRepoLib library allows to handle dynamically created CmObj. The dynamic platform repository can be in the following states: 1 - Non-initialised 2 - Transient: Possibility to add CmObj to the platform, but not to query them. 3 - Finalised: Possibility to

Re: [edk2-devel] [PATCH v4 0/4] SEV Live Migration support for OVMF.

+cc Tobin On 22/06/2021 20:46, Ashish Kalra via groups.io wrote: > Hello Laszlo, > > Please see my replies below : > > On Tue, Jun 22, 2021 at 07:20:53PM +0200, Laszlo Ersek wrote: -snip- > >> Anyway, where I'm particularly lost is that I (very vaguely) recall >> conflicting approaches fro

Re: [edk2-devel] [PATCH v6 0/2] CryptoPkg/OpensslLib: Add native instruction support for X64

Hi Christopher Thank you very much to resume this work. :-) I have no problem to approve CryptoPkg. (I believe I already did that in last year). But since you updated base tool. We need base tool package maintainer to approve that change. A good practice is to split the patch from package leve

[edk2-devel] [PATCH v1 13/14] DynamicTablesPkg: FdtHwInfoParser: Add PCI config parser

From: Pierre Gondois On platforms that implement PCIe, the PCIe configuration space information must be described to a standards-based operating system in the Memory mapped configuration space base address Description (MCFG) table. The PCIe information is described in the platform Device Tree, t

[edk2-devel] [PATCH v1 12/14] DynamicTablesPkg: FdtHwInfoParser: Add GIC dispatcher

From: Pierre Gondois The GIC Dispatcher is the top-level component that is responsible for invoking the respective parsers for GICC, GICD, GIC MSI Frame, GIC ITS and the GICR. Signed-off-by: Pierre Gondois Signed-off-by: Sami Mujawar --- .../FdtHwInfoParserLib/Gic/ArmGicDispatcher.c | 212 +++

[edk2-devel] [PATCH v1 11/14] DynamicTablesPkg: FdtHwInfoParser: Add GICR parser

From: Pierre Gondois The GIC Redistributor (GICR) structure is part of the Multiple APIC Description Table (MADT) that enables the discovery of GIC Redistributor base addresses by providing the Physical Base Address of a page range containing the GIC Redistributors. More than one GICR Structure m

[edk2-devel] [PATCH v1 14/14] DynamicTablesPkg: Add FdtHwInfoParser library

From: Pierre Gondois Hardware information parser is an optional module defined by the Dynamic Tables Framework. It can either parse an XML, a Device Tree or a Json file containing the platform hardware information to populate the platform information repository. FdtHwInfoParser library is an ins

[edk2-devel] [PATCH v1 10/14] DynamicTablesPkg: FdtHwInfoParser: Add ITS parser

From: Pierre Gondois Arm GIC v3/v4 optionally includes support for GIC Interrupt Translation Service (ITS). The GIC ITS Structure is part of the Multiple APIC Description Table (MADT) that describes the GIC Interrupt Translation service to the OS. The GIC Interrupt Translation Service informatio

[edk2-devel] [PATCH v1 08/14] DynamicTablesPkg: FdtHwInfoParser: Add GICD parser

From: Pierre Gondois On ARM-based systems the Generic Interrupt Controller (GIC) manages interrupts on the system. Each interrupt is identified in the GIC by an interrupt identifier (INTID). ACPI GSIVs map one to one to GIC INTIDs for peripheral interrupts, whether shared (SPI) or private (PPI).

[edk2-devel] [PATCH v1 07/14] DynamicTablesPkg: FdtHwInfoParser: Add GICC parser

From: Pierre Gondois The GIC CPU Interface (GICC) structure is part of the Multiple APIC Description Table (MADT) that describes the interrupt model for the platform. The MADT table is a mandatory table required for booting a standards-based operating system. Arm requires the GIC interrupt model

[edk2-devel] [PATCH v1 09/14] DynamicTablesPkg: FdtHwInfoParser: Add MSI Frame parser

From: Pierre Gondois Arm GIC version 2 systems that support Message Signalled Interrupts implement GICv2m MSI frame(s). Each GICv2m MSI frame consists of a 4k page which includes registers to generate message signalled interrupts to an associated GIC distributor. The frame also includes registers

[edk2-devel] [PATCH v1 04/14] DynamicTablesPkg: FdtHwInfoParser: Add Boot Arch parser

From: Pierre Gondois The Fixed ACPI Description Table (FADT) is a mandatory table required for booting a standards-based operating system. The FADT table has an 'ARM Boot Architecture Flags' field that is used by an OS at boot time to determine the code path during boot. This field is used to spe

[edk2-devel] [PATCH v1 06/14] DynamicTablesPkg: FdtHwInfoParser: Add Serial port parser

From: Pierre Gondois The Microsoft Debug Port Table 2 (DBG2), the Serial Port Console Redirector (SPCR) table are mandatory tables required for booting a standards-based operating system. The DBG2 table is used by the OS debugger while the SPCR table is used to configure the serial terminal. Addi

[edk2-devel] [PATCH v1 03/14] DynamicTablesPkg: FdtHwInfoParser: Add FDT utility functions

From: Pierre Gondois The FdtHwInfoParser parses a platform Device Tree and populates the Platform Information repository with Configuration Manager objects. Therefore, add a set of helper functions to simplify parsing of the platform Device Tree. Signed-off-by: Pierre Gondois Signed-off-by: Sa

[edk2-devel] [PATCH v1 02/14] DynamicTablesPkg: FdtHwInfoParser: CM Object descriptor helper

From: Pierre Gondois FdtHwInfoParserLib is an instance of the HwInfoParser. The FdtHwInfoParser parses a platform Device Tree and populates the Platform Information repository with Configuration Manager objects that describe the platform hardware. These Configuration Manager objects are encapsula

[edk2-devel] [PATCH v1 05/14] DynamicTablesPkg: FdtHwInfoParser: Generic Timer Parser

From: Pierre Gondois The Generic Timer Description Table (GTDT) is a mandatory table required for booting a standards-based operating system. It provides an OSPM with information about a system’s Generic Timer configuration. The Generic Timer (GT) is a standard timer interface implemented on ARM

[edk2-devel] [PATCH v1 01/14] DynamicTablesPkg: Definition for HwInfoParser interface

From: Pierre Gondois Hardware information parser is an optional module defined by the Dynamic Tables Framework. It can either parse an XML, a Device Tree or a Json file containing the platform hardware information to populate the platform information repository. The Configuration Manager can the

[edk2-devel] [PATCH v1 00/14] Implement a FdtHwInfoParserLib

From: Pierre Gondois The generic HwInfoParserLib provides an interface to parse hardware information stored in certain a data type (e.g.: xml, device tree, ...) and generate objects that can be used by the DynamicTablesPkg framework to generate another hardware description (e.g.: SMBIOS tables, A

Re: [EXTERNAL] Re: [edk2-devel] [PATCH] NetworkPkg: Addressed static code analyzer issues

Hi Lazlo: case Dhcp4SendRequest: if (Packet->Length > PXEBC_DHCP4_PACKET_MAX_SIZE) { // // If the to be sent packet exceeds the maximum length, abort the DHCP process. // Status = EFI_ABORTED; break; } The same packet Length check already taken care on case

[edk2-devel] [PATCH v1 7/7] DynamicTablesPkg: SSDT Pci express generator

From: Pierre Gondois This generator allows to generate a SSDT table describing a Pci express Bus. It uses the following CmObj: - EArmObjCmRef - EArmObjPciConfigSpaceInfo - EArmObjPciAddressMapInfo - EArmObjPciInterruptMapInfo Signed-off-by: Pierre Gondois --- DynamicTablesPkg/DynamicTables.dsc

[edk2-devel] [PATCH v1 5/7] DynamicTablesPkg: Add AmlAttachNode()

From: Pierre Gondois This function allows to add a node as the last node of a parent node in an AML tree. For instance, ASL code corresponding to NewNode: Name (_UID, 0) ASL code corresponding to ParentNode: Device (PCI0) { Name(_HID, EISAID("PNP0A08")) } "AmlAttachNode (ParentNode, N

[edk2-devel] [PATCH v1 4/7] DynamicTablesPkg: AML Code generation to add _PRT entries

From: Pierre Gondois _PRT entries can describe interrupt mapping for Pci devices. The object is described in ACPI 6.4 s6.2.13 "_PRT (PCI Routing Table)". Add AmlCodeGenPrtEntry() helper function to add _PRT entries to an existing _PRT object. Signed-off-by: Pierre Gondois --- .../Include/Libr

[edk2-devel] [PATCH v1 6/7] DynamicTablesPkg: Add Pci related objects

From: Pierre Gondois Introduce the following CmObj in the ArmNameSpaceObjects: - CM_ARM_PCI_ADDRESS_MAP_INFO - CM_ARM_PCI_INTERRUPT_MAP_INFO These objects allow to describe address range mapping of Pci busses and interrupt mapping of Pci devices. Signed-off-by: Pierre Gondois --- .../Includ

[edk2-devel] [PATCH v1 3/7] DynamicTablesPkg: AML Code generation to create a named ResourceTemplate()

From: Pierre Gondois Add AmlCodeGenNameResourceTemplate() to generate code for a ResourceTemplate(). AmlCodeGenNameResourceTemplate ("REST", ParentNode, NewObjectNode) is equivalent of the following ASL code: Name(REST, ResourceTemplate () {}) Signed-off-by: Pierre Gondois --- .../Include/L

[edk2-devel] [PATCH v1 1/7] DynamicTablesPkg: AML Code generation for memory ranges

From: Pierre Gondois Add helper functions to generate AML Resource Data describing memory ranges. Memory ranges can be one, double or four words long. They can be of 'normal', IO or bus number memory type. The following APIs are exposed: - AmlCodeGenRdDWordIo () - AmlCodeGenRdDWordMemory () -

[edk2-devel] [PATCH v1 0/7] Create a SSDT PCIe generator

From: Pierre Gondois As part of the DynamicTablesPkg, add a generator creating a SSDT table describing a PCIe bus. This patch-set also adds new functions to generate AML bytecode in the AmlLib. The changes can be seen at: https://github.com/PierreARM/edk2/tree/1781_Create_ssdt_pcie_generator_v1

[edk2-devel] [PATCH v1 2/7] DynamicTablesPkg: AML Code generation to create a named Package()

From: Pierre Gondois Add AmlCodeGenNamePackage() to generate code for a Package(). AmlCodeGenNamePackage ("PACK", ParentNode, NewObjectNode) is equivalent of the following ASL code: Name(PACK, Package () {}) Signed-off-by: Pierre Gondois --- .../Include/Library/AmlLib/AmlLib.h |

Re: [edk2-rfc] [edk2-devel] RFC: design review for TDVF in OVMF

On 06/22/2021 9:35 PM, Laszlo wrote: > Hi, > > On 06/11/21 08:37, Xu, Min M wrote: > > In today's TianoCore Design Meeting we reviewed the Overview Section > (from slide 1 to 20). Thanks much for the valuable feedbacks and comments. > The meeting minutes will be sent out soon. > > > > To address t

Re: [edk2-devel] [PATCH v1 09/13] DynamicTablesPkg: AML code generation to create a Method returning a NS

This patch is a duplicate of: [PATCH v1 09/13] DynamicTablesPkg: AML code generation for a Method returning a NS at https://edk2.groups.io/g/devel/message/76950. Please ignore it. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#76956): ht

[edk2-devel] [PATCH v1 13/13] DynamicTablesPkg: SSDT CPU topology and LPI state generator

From: Pierre Gondois In the GIC interrupt model, logical processors are required to have a Processor Device object in the DSDT and must convey each processor's GIC information to the OS using the GICC structure. Additionally, _LPI objects may be needed as they provide a method to describe Low Pow

[edk2-devel] [PATCH v1 10/13] DynamicTablesPkg: AML code generation for a _LPI object

From: Pierre Gondois _LPI object provides a method to describe Low Power Idle states that define the local power states for each node in a hierarchical processor topology. Therefore, add AmlCreateLpiNode() to generate code for a _LPI object. AmlCreateLpiNode ("_LPI", 0, 1, ParentNode, &LpiNode)

[edk2-devel] [PATCH v1 12/13] DynamicTablesPkg: Add CM_ARM_LPI_INFO object

From: Pierre Gondois Introduce the CM_ARM_LPI_INFO CmObj in the ArmNameSpaceObjects. This allows to describe LPI state information, as described in ACPI 6.4, s8.4.4.3 "_LPI (Low Power Idle States)". Signed-off-by: Pierre Gondois --- .../Include/ArmNameSpaceObjects.h | 68 ++

[edk2-devel] [PATCH v1 09/13] DynamicTablesPkg: AML code generation to create a Method returning a NS

From: Pierre Gondois Add AmlCodeGenMethodRetNameString() to generate AML code to create a Method returning a NameString (NS). AmlCodeGenMethodRetNameString ( "MET0", "_CRS", 1, TRUE, 3, ParentNode, NewObjectNode ); is equivalent of the following ASL code: Method(MET0, 1, Serialized, 3) { R

[edk2-devel] [PATCH v1 11/13] DynamicTablesPkg: AML code generation to add an _LPI state

From: Pierre Gondois Add AmlAddLpiState() to generates AML code to add an _LPI state to an _LPI object created using AmlCreateLpiNode(). AmlAddLpiState increments the count of LPI states in the LPI node by one, and adds the following package: Package() { MinResidency, WorstCaseWakeLate

[edk2-devel] [PATCH v1 09/13] DynamicTablesPkg: AML code generation for a Method returning a NS

From: Pierre Gondois Add AmlCodeGenMethodRetNameString() to generate AML code to create a Method returning a NameString (NS). AmlCodeGenMethodRetNameString ( "MET0", "_CRS", 1, TRUE, 3, ParentNode, NewObjectNode ); is equivalent of the following ASL code: Method(MET0, 1, Serialized, 3) { R

[edk2-devel] [PATCH v1 08/13] DynamicTablesPkg: AML code generation to Return a NameString

From: Pierre Gondois Add AmlCodeGenReturnNameString() to generate AML code for a Return object node, returning the object as a NameString. AmlCodeGenReturn ("NAM1", ParentNode, NewObjectNode) is equivalent of the following ASL code: Return(NAM1) Signed-off-by: Pierre Gondois --- .../Common/

[edk2-devel] [PATCH v1 07/13] DynamicTablesPkg: AML code generation for a Method

From: Pierre Gondois Add AmlCodeGenMethod() to generate code for a control method. AmlCodeGenMethod ("MET0", 1, TRUE, 3, ParentNode, NewObjectNode) is equivalent of the following ASL code: Method(MET0, 1, Serialized, 3) {} Signed-off-by: Pierre Gondois --- .../Common/AmlLib/CodeGen/AmlCod

[edk2-devel] [PATCH v1 06/13] DynamicTablesPkg: AML code generation for a ResourceTemplate

From: Pierre Gondois ASL provides a ResourceTemplate macro that creates a Buffer in which resource descriptor macros can be listed. The ResourceTemplate macro automatically generates an End descriptor and calculates the checksum for the resource template. Therefore, add AmlCodeGenResourceTemplat

  1   2   >