Thank you Liming.
If no more comments, I plan to submit following 2 patches firstly tomorrow.
[patch V2 01/29] MdePkg: Add RegisterFilterLib class and NULL instance
(https://edk2.groups.io/g/devel/message/73072)
[patch V2 02/29] MdePkg: Add MdeLibs.dsc.inc file to MdePkg
(https://edk2.groups.io/
> -Original Message-
> From: gaoliming [mailto:gaolim...@byosoft.com.cn]
> Sent: Thursday, March 25, 2021 10:04 AM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
>
> Cc: 'Ray Ni' ; 'Zhichao Gao' ;
> Wang, Nickle (HPS SW) ; O'Hanley, Peter (EXL)
>
> Subject: 回复: [edk2-
Move GUID definition of EFI Redfish Discover protocol
to under MdePkg. With this we don't have dependency of
RedfishPkg in ShellPkg.
Signed-off-by: Abner Chang
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Nickle Wang
Cc: Peter O'Hanley
Reviewed-by: Liming Gao
---
MdePkg/MdePkg
In v4: In UefiHandleParsingLib.c, move the changes for UEFI 2.8 to
below UEFI 2.7 section
In v3: Correct the mismatched definitions in both
RedfishDiscover.h and UEFI spec 2.8 (Refer to v2.9).
In v2: Address comments given by Liming on patch 1/2.
Add handle parsing for EFI Redfish Di
Add handle parsing for EFI Redfish Discover protocol.
Add handle parsing for EFI RestEx protocol.
Signed-off-by: Abner Chang
Cc: Ray Ni
Cc: Zhichao Gao
Cc: Nickle Wang
Cc: Peter O'Hanley
Reviewed-by: Zhichao Gao
---
.../Library/UefiHandleParsingLib/UefiHandleParsingLib.inf | 4 +++-
.../Lib
Ray,
The other option would be to define a Library Class for the AcpiTableDxe driver
to consume and have a NULL version of it in the MdeModulePkg. That would allow
more flexibility? It kind of depends if you want to make the implementation
depend on a HOB or a LibraryClass? It at least gives th
While we are talking about what toolchain targets should do I don’t understand
this [1]? Why does OVMF need to turn on —keepexceptiontable? If these
toolchains require it why don’t they turn it on? I see Mike fixed it[2]. Is
this another case of a global GENFW_FLAG breaking things? Looks like th
Liming,
I understand how the tool works, but that is not how it is used. To make it
work like other toolchains *_*_*_GENFW_FLAGS for ELF targets should pass —zero
for builds that do not contain symbols. This is how it works today [1].
The proposed fix is a global hammer ` RELEASE_*_*_GENFW_FLAG
Create PR https://github.com/tianocore/edk2/pull/1515
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 gaoliming
> 发送时间: 2021年3月22日 9:40
> 收件人: 'Ankur Arora' ; devel@edk2.groups.io
> 抄送: 'Michael D Kinney' ; 'Laszlo Ersek'
>
> 主题: [edk2-devel] 回复: [RESEND v2] MdePkg: use CpuPause()
Siva:
This question prompt string is "Save Changes and Exit". So, its behavior is
to save and exit. In Edk2 MdeModulePkg SetupBrowser, exit behavior is to
exit current page and enter into its parent page. Does your SetupBrowser
implement exit behavior to exit the whole UI?
Thanks
Liming
发件
> On Mar 24, 2021, at 11:26 AM, Laszlo Ersek wrote:
>
> On 03/24/21 16:25, Jeff Brasen wrote:
>> Some of the logo files we received for the group that makes our assets like
>> this (not sure what tool they were created with) look like they pad the BMP
>> size to 8 bytes.
>>
>> TranslateBmpTo
Is this API X64 only? Or IA32 and X64 both?
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Brijesh Singh
> 发送时间: 2021年3月24日 23:32
> 收件人: devel@edk2.groups.io
> 抄送: Brijesh Singh ; James Bottomley
> ; Min Xu ; Jiewen Yao
> ; Tom Lendacky ;
> Jordan Justen ; Ard Biesheuvel
> ; Laszlo
Andrew:
GenFw generates debug entry, and zero debug entry. Its functionality is same
to the image without debug entry. So, new option is not introduced to control
whether GenFw generates debug entry when it converts ELF image to EFI image.
Thanks
Liming
发件人: devel@edk2.groups.io 代表 Andr
Abner:
I have one comment.
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Abner Chang
> 发送时间: 2021年3月24日 13:35
> 收件人: devel@edk2.groups.io
> 抄送: Ray Ni ; Zhichao Gao ;
> Nickle Wang ; Peter O'Hanley
>
> 主题: [edk2-devel] [PATCH V3 2/2] ShellPkg/UefiHandleParsingLib: Support
> EFI Redfish prot
Importing spamReporting Tracking successful
On Fri, Mar 12, 2021 at 4:46 AM, Yao, Jiewen wrote:
Can we merge the common part between X64 and AArch64 into one Common.c?
> -Original Message-
> From: Kun Qin
> Sent: Saturday, December 19, 2020 2:50 AM
> To: devel@edk2.groups.io
> Cc: A
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Abner Chang
> 发送时间: 2021年3月24日 13:35
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu ; Nickle
> Wang ; Peter O'Hanley
> 主题: [PATCH V3 1/2] MdePkg/Include: EFI Redfish Discover protocol
>
> Move GUID definition of
On Wed, Mar 24, 2021 at 02:33 PM, Laszlo Ersek wrote:
>
>
>>
>>>
Hi all,
Would it be acceptable/feasible for AcpiTableDxe or AcpiPlatformDxe (in
MdeModulePkg) to use `EfiGetSystemConfigurationTable` to get the RSDP
and then install the tables? It's a solution that uses the
Ben,
I understand your point.
The purpose of changing the AcpiTableDxe to directly consume the HOB is to
reduce the overall system complexity.
The complexity I see with your option is:
1. platform needs to include that driver to consume the ACPI table from
bootloader
2. that driver (consume HOB a
Hi Loic,
The current edk2 RISC-V is incorporated with opensbi v0.8, please check below
link
https://github.com/riscv/riscv-uefi-edk2-docs
We have to update below library with the latest opensbi with your changes,
https://github.com/tianocore/edk2-platforms/tree/master/Silicon/RISC-V/ProcessorPkg/
This breaks some usage we have have in our fork. We have symbols turned on for
Release builds, so this change would break that.
It looks to me that the root cause of this issue might be that the GenFw is
blindly writing the debug directory entry into the PE/COFF? For native PE/COFF
I think thi
On 03/24/21 12:58, Ross Burton wrote:
> GenFw will embed a NB10 section which contains the path to the input file,
> which means the output files have build paths embedded in them. To reduce
> information leakage and ensure reproducible builds, pass --zero in release
> builds to remove this inform
On 3/24/21 10:32 AM, Brijesh Singh wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
>
> The MemEncryptSev{Set,Clear}PageEncMask() functions are used to set or
> clear the memory encryption attribute in the page table. When SEV-SNP is
> active, we also need to validate or invalidat
Hi,
On 3/24/21 4:45 AM, Sunny Wang wrote:
Merge changes in edk2-platforms-raspberrypi-pl011-bth-noflow.diff in
https://github.com/worproject/RPi-Bluetooth-Testing/ for enabling
Bluetooth and serial port (Mini UART) in Windows OS.
Testing Done:
- Successfully booted Windows 10 (20279.1) on SD
Hi,
Thanks for working on this!
Comments inline:
On 3/24/21 4:45 AM, Sunny Wang wrote:
Changes:
1. Add code to ConfigDxe driver and AcpiTables module to dynamically
build either Mini UART or PL011 UART info in ACPI. This fixes the
issue discussed in https://github.com/pftf/RPi4
On 03/24/21 16:31, Brijesh Singh wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
>
> SEV-SNP builds upon existing SEV and SEV-ES functionality while adding
> new hardware-based memory protections. SEV-SNP adds strong memory integrity
> protection to help prevent malicious hypervis
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
During the SEV-SNP guest launch sequence, two special pages need to
be inserted, the secrets page and cpuid page. The secrets page,
contain the VM platform communication keys. The guest BIOS and OS
can use this key to communicate with the SEV
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
Define the SEV-SNP MSR bits.
Cc: James Bottomley
Cc: Min Xu
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc: Jordan Justen
Cc: Ard Biesheuvel
Cc: Laszlo Ersek
Signed-off-by: Brijesh Singh
---
MdePkg/Include/Register/Amd/Fam17Msr.h | 7 ++-
1
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
The VMM launch sequence should have validated all the data pages used
in the SEC phase. Before decompressing the firmware volume, validate
the data/code pages used during the decompression steps, and any other
pages used during the PEI phase
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
The PEI phases uses MemEncryptSevSnpValidateSystemRam() to validate
the system RAM. MemEncryptSev{Set,Clear}PageEncMask() is
later used by libraries/drivers to change the page state from private
to shared and vice versa.
The AmdSevDxe driver
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
The initial page built during the SEC phase is used by the
MemEncryptSevSnpValidateSystemRam() for the system RAM validation. The
page validation process requires using the PVALIDATE instruction; the
instruction accepts a virtual address of
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
When SEV-SNP is active, the GHCB page is mapped un-encrypted in the
initial page table built by the reset vector code. Just clearing the
encryption attribute from the page table is not enough. The page also
needs to be added as shared in the
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
The PVALIDATE instruction validates or rescinds validation of a guest
page RMP entry. Upon completion, a return code is stored in EAX, rFLAGS
bits OF, ZF, AF, PF and SF are set based on this return code. If the
instruction completed succesful
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
The MemEncryptSev{Set,Clear}PageEncMask() functions are used to set or
clear the memory encryption attribute in the page table. When SEV-SNP is
active, we also need to validate or invalidate the pages and update the
RMP entry.
Before clearin
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
An SEV-SNP guest us required to perform GHCB GPA registration before
using a GHCB. See the GHCB spec section 2.5.2 for more details.
Add a library that can be called to perform the GHCB GPA registration.
Cc: James Bottomley
Cc: Min Xu
Cc:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
An SEV-SNP guest requires that private memory (aka pages mapped as
encrypted) must be validated before being accessed.
The validation process consist of the following sequence:
1) Set the memory encryption attribute in the page table (aka C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
When SEV-SNP is active, a memory region mapped encrypted in the page
table must be validated before access. There are two approaches that
can be taken to validate the system RAM detected during the PEI phase:
1) Validate on-demand
OR
2) Vali
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
Commit 85b8eac59b8c5bd9c7eb9afdb64357ce1aa2e803 added support to ensure
that MMIO is only performed against the un-encrypted memory. If MMIO
is performed against encrypted memory, a #GP is raised.
The VmgExitLib library depends on ApicTimerL
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
SEV-SNP builds upon existing SEV and SEV-ES functionality while adding
new hardware-based memory protections. SEV-SNP adds strong memory integrity
protection to help prevent malicious hypervisor-based attacks like data
replay, memory re-mappi
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
Many of the integrity guarantees of SEV-SNP are enforced through the
Reverse Map Table (RMP). Each RMP entry contains the GPA at which a
particular page of DRAM should be mapped. The guest can request the
hypervisor to add pages in the RMP ta
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
MemEncryptSevSnpValidateSystemRam() is used for validating the system
RAM. During the validation process, we must avoid double validation
cases. The double validation can lead to security issues. Extend the
MemEncryptSevSnpValidateSystemRam()
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
The Page State Change NAE exit will be used by the SEV-SNP guest to
request a page state change using the GHCB protocol. See the GHCB
spec section 4.1.6 and 2.3.1 for more detail on the structure
definitions.
Cc: James Bottomley
Cc: Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
The SEV-SNP guest requires that GHCB GPA must be registered before using.
The GHCB GPA can be registred using the GhcbGPARegister().
Cc: James Bottomley
Cc: Min Xu
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc: Jordan Justen
Cc: Ard Biesheuvel
Cc
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
An SEV-SNP guest requires that the physical address of the GHCB must
be registered with the hypervisor before using it. See the GHCB specification
for the futher detail.
Cc: James Bottomley
Cc: Min Xu
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
An SEV-SNP guest is required to perform the GHCB GPA registration. See
the GHCB specification for further details.
Cc: James Bottomley
Cc: Min Xu
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc: Jordan Justen
Cc: Ard Biesheuvel
Cc: Laszlo Ersek
Si
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
Create a function can be used to determine if VM is running as an
SEV-SNP guest.
Cc: James Bottomley
Cc: Min Xu
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc: Jordan Justen
Cc: Ard Biesheuvel
Cc: Laszlo Ersek
Signed-off-by: Brijesh Singh
---
O
On 03/24/21 17:55, Benjamin Doron wrote:
>>
>>
>>> Hi all,
>>> Would it be acceptable/feasible for AcpiTableDxe or AcpiPlatformDxe (in
>>> MdeModulePkg) to use `EfiGetSystemConfigurationTable` to get the RSDP
>>> and then install the tables? It's a solution that uses the regular
>>> UefiLib, so it
On 03/24/21 16:25, Jeff Brasen wrote:
> Some of the logo files we received for the group that makes our assets like
> this (not sure what tool they were created with) look like they pad the BMP
> size to 8 bytes.
>
> TranslateBmpToGopBlt: invalid BmpImage...
>BmpHeader->Size: 0xE1038
>Bm
>
>
>> Hi all,
>> Would it be acceptable/feasible for AcpiTableDxe or AcpiPlatformDxe (in
>> MdeModulePkg) to use `EfiGetSystemConfigurationTable` to get the RSDP
>> and then install the tables? It's a solution that uses the regular
>> UefiLib, so it avoids platform-specific quirks (and as I see
Some of the logo files we received for the group that makes our assets like
this (not sure what tool they were created with) look like they pad the BMP
size to 8 bytes.
TranslateBmpToGopBlt: invalid BmpImage...
BmpHeader->Size: 0xE1038
BmpHeader->ImageOffset: 0x36
BmpImageSize: 0xE1038
platform_ops and platform structures have older entries that don't exist
anymore on recent OpenSBI versions, so we can remove them.
Cc: Abner Chang
Cc: Daniel Schaefer
Cc: Gilbert Chen
Signed-off-by: Loic Devulder
---
.../PlatformPkg/Library/OpensbiPlatformLibNull/Platform.c | 4 +---
1
Hello all:
In the IPV4 and IPV6 Configuration Page after the changes are applied the
system proceed to boot to the boot device and its not staying in same form.
case KEY_SAVE_CHANGES:
Status = Ip6ConvertIfrNvDataToConfigNvDataGeneral (IfrNvData, Instance);
if (EFI_ERROR (Status)) {
Hi Sunny,
I understand that you are going to re-send these patches due to e-mail
mangling, but let me add a few of notes that might help you as you are
doing that.
First of all, your patch series was missing a cover letter (there should
have been a [PATCH v2 0/2]), that doesn't get applied,
Hi all,
Would it be acceptable/feasible for AcpiTableDxe or AcpiPlatformDxe (in
MdeModulePkg) to use `EfiGetSystemConfigurationTable` to get the RSDP and then
install the tables? It's a solution that uses the regular UefiLib, so it avoids
platform-specific quirks (and as I see it, if RSDP is in
GenFw will embed a NB10 section which contains the path to the input file,
which means the output files have build paths embedded in them. To reduce
information leakage and ensure reproducible builds, pass --zero in release
builds to remove this information.
Ref: https://bugzilla.tianocore.org/sh
On 03/23/21 18:41, Bret Barkelew via groups.io wrote:
> Is this a *good* idea?
>
> What is considered valid extra data? If it’s immaterial to the FW displaying
> the image, our policy has been to strip it off BEFORE adding it to the FW
> image.
Not counting any potential security aspects, strip
On 03/24/21 05:09, Ni, Ray wrote:
>>
>> (1) Currently, BlSupportDxe expects the ACPI content to come from
>> "SYSTEM_TABLE_INFO.AcpiTableBase"
>> [Include/Guid/SystemTableInfoGuid.h].
>> That header file is at least *moderately* documented (it's better than
>> nothing). Additionally, BlSupportDxe i
On 03/24/21 00:52, Benjamin Doron wrote:
> Hi all,
> Would it be acceptable/feasible for AcpiTableDxe or AcpiPlatformDxe (in
> MdeModulePkg) to use `EfiGetSystemConfigurationTable` to get the RSDP
> and then install the tables? It's a solution that uses the regular
> UefiLib, so it avoids platform-
Somehow my first patch got messed up. Please ignore this.
I will check the problem and send the patches again.
Best Regards,
Sunny Wang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sunny Wang via
groups.io
Sent: Wednesday, March 24, 2021 5:45 PM
To: devel@edk2.groups.io
Cc
On 03/23/21 18:15, Dong, Guo wrote:
>
> Hi Laszlo,
>
> I don't mean currently UEFI payload is already standardized and modularized.
> There are still lots of things to do and I think the AcpiTableDxe patch is
> the one it needed.
>
> More information on ideas behind could be found from
> https
Changes:
1. Add code to ConfigDxe driver and AcpiTables module to dynamically
build either Mini UART or PL011 UART info in ACPI. This fixes the
issue discussed in https://github.com/pftf/RPi4/issues/118.
2. Cleanup by moving duplicate Debug Port 2 table related defines and
struct
Merge changes in edk2-platforms-raspberrypi-pl011-bth-noflow.diff in
https://github.com/worproject/RPi-Bluetooth-Testing/ for enabling
Bluetooth and serial port (Mini UART) in Windows OS.
Testing Done:
- Successfully booted Windows 10 (20279.1) on SD (made by WOR) with
the RPi-Windows-Driver
61 matches
Mail list logo
