On 03/24/21 16:25, Jeff Brasen wrote: > Some of the logo files we received for the group that makes our assets like > this (not sure what tool they were created with) look like they pad the BMP > size to 8 bytes. > > TranslateBmpToGopBlt: invalid BmpImage... > BmpHeader->Size: 0xE1038 > BmpHeader->ImageOffset: 0x36 > BmpImageSize: 0xE1038 > DataSize: 0xE1000 > TranslateBmpToGopBlt: invalid BmpImage... > BmpHeader->Size: 0x2A3038 > BmpHeader->ImageOffset: 0x36 > BmpImageSize: 0x2A3038 > DataSize: 0x2A3000 > TranslateBmpToGopBlt: invalid BmpImage... > BmpHeader->Size: 0x5EEC38 > BmpHeader->ImageOffset: 0x36 > BmpImageSize: 0x5EEC38 > DataSize: 0x5EEC00 > > So, each of these has 2 bytes of padding at the end of the file. We could > write a tool that would do the same size recalculation in order to update the > size in the header and remove the two bytes but it seems that this is a valid > BMP file and it doesn't seem correct that UEFI is rejecting it. I can update > the commit message with more context if needed as well.
If there's a spec describing the BMP format, and edk2 is needlessly strict, and the check can be relaxed without security risks, then I think a patch would be fair. Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#73214): https://edk2.groups.io/g/devel/message/73214 Mute This Topic: https://groups.io/mt/81556871/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
