Re: [edk2-devel] [RedfishPkg PATCH v5 4/4] edk2: Add maintainers to RedfishPkg

On Tue, Oct 06, 2020 at 18:48:04 +0800, Abner Chang wrote: > Signed-off-by: Chang Abner > Cc: Nickle Wang > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > Acked-by: Laszlo Ersek No objection to this one. Acked-by: Leif Lindholm > --- > Maintainers.txt | 5

[edk2-devel] expected behaviour of WorkspaceAutoGen.py?

Hi BaseTools maintainers, Posting mostly for this to be available in the list archive, but I'm also curious as to whether this is expected behaviour, and would like confirmation of my understanding on the behaviour. We started very lazily creating a new platform port based on edk2-platforms Platf

Re: [EXTERNAL] [edk2-devel] [PATCH v5 14/15] .python/SpellCheck: Add 'XIPFLAGS' to "words" section

If it’s only used in that package, I would suggest adding it to the CryptoPkg.ci.yaml file instead. If it’s likely to be used in multiple packages, the current patch looks good. - Bret From: Sami Mujawar Sent: Tuesday, October 6, 2020 12:58 AM To: Bret Barkelew

Re: [EXTERNAL] RE: [edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg.

On 10/06/20 18:29, Leif Lindholm wrote: > Hi Abner, > > On Tue, Oct 6, 2020 at 5:20 PM Chang, Abner (HPS SW/FW Technologist) < > abner.ch...@hpe.com> wrote: diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc new file mode 100644 index 00..d5c65f68c3 --- /dev/

Re: [edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg.

Yeah, I will send another version for this. Thanks Abner Get Outlook for Android From: Leif Lindholm Sent: Wednesday, October 7, 2020 12:29:28 AM To: Chang, Abner (HPS SW/FW Technologist) Cc: devel@edk2.groups.io ; Wang, Nickle (HPS SW) ;

Re: [EXTERNAL] RE: [edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg.

Hi Abner, On Tue, Oct 6, 2020 at 5:20 PM Chang, Abner (HPS SW/FW Technologist) < abner.ch...@hpe.com> wrote: > > > diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc new > > > file mode 100644 index 00..d5c65f68c3 > > > --- /dev/null > > > +++ b/RedfishPkg/RedfishPkg.dsc >

Re: [edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg.

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Tuesday, October 6, 2020 10:37 PM > To: Chang, Abner (HPS SW/FW Technologist) > Cc: devel@edk2.groups.io; Wang, Nickle (HPS SW) ; > Andrew Fish ; Laszlo Ersek ; > Michael

Re: [EXTERNAL] [edk2-devel] fatal error edk2

Well… does that include file exist under one of those directories? 😉 - Bret From: Vicente Cortes via groups.io Sent: Tuesday, October 6, 2020 8:21 AM To: devel@edk2.groups.io Subject: [EXTERNAL] [edk2-devel] fatal error edk2

[edk2-devel] fatal error edk2

(Python 3.9.0 on win32) Traceback (most recent call last): File "C:\Users\Vicente\Documents\hackervicente\edk2-pixel3-master\edk2\BaseTools\Source\Python\build\build.py", line 2635, in Main MyBuild.Launch() File "C:\Users\Vicente\Documents\hackervicente\edk2-pixel3-master\edk2\BaseTools\Sou

Re: [EXTERNAL] [edk2-devel] VSCode EDK II Syntax Highlighting

Tools are always good and welcome. If it works well we could add a page to the wiki. > On Oct 5, 2020, at 9:25 PM, Bret Barkelew via groups.io > wrote: > >  > Some members of our team were writing one at one point in conjunction with > Surface. I don’t know if it ever saw the light of day, bu

Re: [edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg.

One comment: On Tue, Oct 06, 2020 at 18:48:01 +0800, Abner Chang wrote: > Initial version of RedfishPkg. > > Signed-off-by: Wu Jiaxin > Signed-off-by: Fu Siyuan > Signed-off-by: Wang Fan > Signed-off-by: Chang Abner > Cc: Nickle Wang > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm

Re: [edk2-devel] [RedfishPkg PATCH v5 0/4] Inital RedfishPkg

On 10/06/20 12:48, Abner Chang wrote: > Note for v5: Add reviewers's tags. > > Initial version of RedfishPkg and the CI test > on RedfishPkg. > > CI Test result: > https://github.com/tianocore/edk2/pull/982 > > There is no components in RedfishPkg in this commit, > the further edk2 Redfish compo

Re: [edk2-devel] [RedfishPkg PATCH v5 2/4] .pytool: Add CI on RedfishPkg

On 10/06/20 12:48, Abner Chang wrote: > Add RedfishPkg to CI test. > > Signed-off-by: Abner Chang > Cc: Sean Brogan > Cc: Bret Barkelew > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Nickle Wang > Reviewed-by: Bret Barkelew > --- > .pytool/CISettings.py | 3 ++- > 1 file changed, 2 insertio

[edk2-devel] [edk2-platforms] [PATCH v3-resend] SgiPkg/RdN1EdgeX2: Add missing reference to PcdChipCount

Commit e8fe2026dd79 (“Platform/ARM/SgiPkg: Use chip count constant on rdn1edgex2 platform”) used the PcdChipCount constant but did not declare its use in the ACPI table module. Fix this by listing it in the list of PCDs to be looked up. Signed-off-by: Vijayenthiran Subramaniam Reviewed-by: Thomas

Re: [edk2-devel] [edk2-platforms] [PATCH v3] SgiPkg/RdN1EdgeX2: Add missing reference to PcdChipCount

On 10/6/20 2:59 PM, Vijayenthiran Subramaniam wrote: Commit e8fe2026dd79 (“Platform/ARM/SgiPkg: Use chip count constant on rdn1edgex2 platform”) used the PcdChipCount constant but did not declare its use in the ACPI table module. Fix this by listing it in the list of PCDs to be looked up. Signed

[edk2-devel] [edk2-platforms] [PATCH v3] SgiPkg/RdN1EdgeX2: Add missing reference to PcdChipCount

Commit e8fe2026dd79 (“Platform/ARM/SgiPkg: Use chip count constant on rdn1edgex2 platform”) used the PcdChipCount constant but did not declare its use in the ACPI table module. Fix this by listing it in the list of PCDs to be looked up. Signed-off-by: Vijayenthiran Subramaniam --- Changes since

[edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build

Signed-off-by: Abner Chang Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Cc: Nickle Wang Reviewed-by: Bret Barkelew --- .azurepipelines/templates/pr-gate-build-job.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.azurepipelines/templates/pr-gate-build-job.

[edk2-devel] [RedfishPkg PATCH v5 4/4] edk2: Add maintainers to RedfishPkg

Signed-off-by: Chang Abner Cc: Nickle Wang Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Michael D Kinney Acked-by: Laszlo Ersek --- Maintainers.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 6a22a14796..cabadac177 100644 --- a/

[edk2-devel] [RedfishPkg PATCH v5 0/4] Inital RedfishPkg

Note for v5: Add reviewers's tags. Initial version of RedfishPkg and the CI test on RedfishPkg. CI Test result: https://github.com/tianocore/edk2/pull/982 There is no components in RedfishPkg in this commit, the further edk2 Redfish components will be committed base on this version. Abner Chang

[edk2-devel] [RedfishPkg PATCH v5 2/4] .pytool: Add CI on RedfishPkg

Add RedfishPkg to CI test. Signed-off-by: Abner Chang Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Cc: Nickle Wang Reviewed-by: Bret Barkelew --- .pytool/CISettings.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.pytool/CISettings.py b/.py

[edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg.

Initial version of RedfishPkg. Signed-off-by: Wu Jiaxin Signed-off-by: Fu Siyuan Signed-off-by: Wang Fan Signed-off-by: Chang Abner Cc: Nickle Wang Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Michael D Kinney Acked-by: Laszlo Ersek --- RedfishPkg/RedfishPkg.ci.yaml | 67 +

Re: [edk2-devel] Proposal to make EccCheck non-destructive

On 10/05/20 01:25, Bret Barkelew via groups.io wrote: > In regards to this bug: > 2986 – EccCheck should not revert staged and local changes > (tianocore.org) > > I have a proposal: > > 1. git diff --name-only .. > 2. Copy list of chan

Re: [edk2-devel] [PATCH] MdeModulePkg/HiiDatabase: Do not modify CONST string

On 10/05/20 23:27, Jeff Brasen wrote: > Are we looking for any other reviews on this? I don't think so; Dandan is a designated reviewer for "MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c". The MdeModulePkg maintainers should merge this patch. (Dandan seems to have no "M" access anywhere i

Re: [edk2-devel] [PATCH v5 01/15] PcAtChipsetPkg: Add MMIO Support to RTC driver

Hi Ard, On 10/05/20 12:58, Ard Biesheuvel wrote: > On 10/2/20 11:13 PM, Sami Mujawar wrote: >> Some virtual machine managers like Kvmtool emulate the MC146818 >> RTC controller in the MMIO space so that architectures that do >> not support I/O Mapped I/O can use the RTC. This patch adds MMIO >> su

Re: [edk2-devel] [RedfishPkg PATCH v4 4/4] edk2: Add maintainers to RedfishPkg

On 10/05/20 06:13, Abner Chang wrote: > Signed-off-by: Chang Abner > Cc: Nickle Wang > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > --- > Maintainers.txt | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/Maintainers.txt b/Maintainers.txt > inde

Re: [edk2-devel] [RedfishPkg PATCH v4 1/4] RedfishPkg: Initial commit of RedfishPkg.

On 10/05/20 06:13, Abner Chang wrote: > Initial version of RedfishPkg. > > Signed-off-by: Wu Jiaxin > Signed-off-by: Fu Siyuan > Signed-off-by: Wang Fan > Signed-off-by: Chang Abner > Cc: Nickle Wang > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > --- >

Re: [edk2-devel] [PATCH v1 1/1] UefipayloadPkg: Protect coreboot tables

Hi Marcello, On 10/05/20 17:34, Marcello Sylvester Bauer wrote: > On Thu, Oct 1, 2020 at 12:24 PM Laszlo Ersek wrote: > >> On 09/14/20 19:32, Guo Dong wrote: >>> >>> OK. Let me merge this patch firstly. /Guo >> >> The PR at failed 17 days >> ago and t

Re: [EXTERNAL] [edk2-devel] [PATCH v5 14/15] .python/SpellCheck: Add 'XIPFLAGS' to "words" section

Hi Bret, Please find my response inline marked [SAMI]. Regards, Sami Mujawar From: Bret Barkelew Sent: 05 October 2020 09:51 PM To: devel@edk2.groups.io; Sami Mujawar Cc: Sami Mujawar ; Ard Biesheuvel ; l...@nuviainc.com; ler...@redhat.com; Matteo Carlini ; Ben Adderson ; nd Subject: RE: [