> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Leif Lindholm
> Sent: Tuesday, October 6, 2020 10:37 PM
> To: Chang, Abner (HPS SW/FW Technologist) <abner.ch...@hpe.com>
> Cc: devel@edk2.groups.io; Wang, Nickle (HPS SW) <nickle.w...@hpe.com>;
> Andrew Fish <af...@apple.com>; Laszlo Ersek <ler...@redhat.com>;
> Michael D Kinney <michael.d.kin...@intel.com>
> Subject: Re: [edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial
> commit of RedfishPkg.
>
> One comment:
>
> On Tue, Oct 06, 2020 at 18:48:01 +0800, Abner Chang wrote:
> > Initial version of RedfishPkg.
> >
> > Signed-off-by: Wu Jiaxin <jiaxin...@intel.com>
> > Signed-off-by: Fu Siyuan <siyuan...@intel.com>
> > Signed-off-by: Wang Fan <fan.w...@intel.com>
> > Signed-off-by: Chang Abner <abner.ch...@hpe.com>
> > Cc: Nickle Wang <nickle.w...@hpe.com>
> > Cc: Andrew Fish <af...@apple.com>
> > Cc: Laszlo Ersek <ler...@redhat.com>
> > Cc: Leif Lindholm <l...@nuviainc.com>
> > Cc: Michael D Kinney <michael.d.kin...@intel.com>
> > Acked-by: Laszlo Ersek <ler...@redhat.com>
> > ---
> > RedfishPkg/RedfishPkg.ci.yaml | 67
> +++++++++++++++++++++++++++++++++++
> > RedfishPkg/RedfishPkg.dec | 18 ++++++++++
> > RedfishPkg/RedfishPkg.dsc | 40 +++++++++++++++++++++
> > 3 files changed, 125 insertions(+)
> > create mode 100644 RedfishPkg/RedfishPkg.ci.yaml create mode 100644
> > RedfishPkg/RedfishPkg.dec create mode 100644
> > RedfishPkg/RedfishPkg.dsc
> >
> > diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec new
> > file mode 100644 index 0000000000..e95ec5fe10
> > --- /dev/null
> > +++ b/RedfishPkg/RedfishPkg.dec
> > @@ -0,0 +1,18 @@
> > +## @file
> > +# Redfish Package
> > +#
> > +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> #
> > +(C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR> # #
> > +SPDX-License-Identifier: BSD-2-Clause-Patent ##
> > +
> > +[Defines]
> > + DEC_SPECIFICATION = 0x0001001b
> > + PACKAGE_NAME = RedfishPkg
> > + PACKAGE_GUID = c432b76e-5232-11e7-9010-005056c00008
> > + PACKAGE_VERSION = 1.0
> > +
> > +[Guids]
> > + gEfiRedfishPkgTokenSpaceGuid = { 0x4fdbccb7, 0xe829, 0x4b4c, { 0x88,
> 0x87, 0xb2, 0x3f, 0xd7, 0x25, 0x4b, 0x85 }}
> > +
> > diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc new
> > file mode 100644 index 0000000000..d5c65f68c3
> > --- /dev/null
> > +++ b/RedfishPkg/RedfishPkg.dsc
> > @@ -0,0 +1,40 @@
> > +## @file
> > +# Redfish Package
> > +#
> > +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> #
> > +(C) Copyright 2020 Hewlett-Packard Enterprise Development LP.
> > +#
> > +# SPDX-License-Identifier: BSD-2-Clause-Patent
> > +#
> > +##
> > +
> > +[Defines]
> > + PLATFORM_NAME = RedfishPkg
> > + PLATFORM_GUID = c4352870-5232-11e7-9522-005056c00008
> > + PLATFORM_VERSION = 1.0
> > + DSC_SPECIFICATION = 0x0001001c
> > + OUTPUT_DIRECTORY = Build/RedfishPkg
> > + SUPPORTED_ARCHITECTURES = IA32|X64|ARM|AARCH64|RISCV64
> > + BUILD_TARGETS = DEBUG|RELEASE
>
> v3 included NOOPT here. That was the version Laszlo gave his R-b for.
>
> v4 cover letter does mention NOOPT being removed, but I can see no
> conversation in which this is discussed. What have I missed?
No Leif, you did miss nothing. There was some Q/A conversations between Bret
and me about the build target of CI.
We would like to keep NO-TARGET for the non-build CI test but remove NOOPT for
now because we do not have the host-based unit test at the moment. We would
like to add NOOPT back once we have the corresponding unit test on RedfishPkg.
Abner
>
> /
> Leif
>
> > + SKUID_IDENTIFIER = DEFAULT
> > +
> > +[LibraryClasses]
> > +
> > +UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEn
> > +tryPoint.inf
> > +
> >
> +UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/Uefi
> > +BootServicesTableLib.inf
> > + UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
> > +
> >
> +UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLi
> > +b/UefiRuntimeServicesTableLib.inf
> > + UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
> > +
> >
> +MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMem
> ory
> > +AllocationLib.inf
> > +
> > +DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> > + BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
> > + BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> > +
> >
> +SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchron
> > +izationLib.inf
> > + PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> > + DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
> > +
> >
> +DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/Ba
> > +seDebugPrintErrorLevelLib.inf
> > +
> >
> +PostCodeLib|MdePkg/Library/BasePostCodeLibPort80/BasePostCodeLibPo
> rt8
> > +0.inf
> > + PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> > +
> >
> +PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/Bas
> e
> > +PeCoffGetEntryPointLib.inf
> > +
> >
> +DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTab
> > +leLib.inf
> > + DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
> > +
> >
> +ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/D
> xeRe
> > +portStatusCodeLib.inf
> > --
> > 2.17.1
> >
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65934): https://edk2.groups.io/g/devel/message/65934
Mute This Topic: https://groups.io/mt/77338595/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
