Hi Bret, Please find my response inline marked [SAMI].
Regards, Sami Mujawar From: Bret Barkelew <bret.barke...@microsoft.com> Sent: 05 October 2020 09:51 PM To: devel@edk2.groups.io; Sami Mujawar <sami.muja...@arm.com> Cc: Sami Mujawar <sami.muja...@arm.com>; Ard Biesheuvel <ard.biesheu...@arm.com>; l...@nuviainc.com; ler...@redhat.com; Matteo Carlini <matteo.carl...@arm.com>; Ben Adderson <ben.adder...@arm.com>; nd <n...@arm.com> Subject: RE: [EXTERNAL] [edk2-devel] [PATCH v5 14/15] .python/SpellCheck: Add 'XIPFLAGS' to "words" section I'm assuming this is used across multiple packages? [SAMI] This flag is also used in CryptoPkg\Library\OpensslLib. [/SAMI] If so, Reviewed-by: Bret Barkelew <bret.barke...@microsoft.com<mailto:bret.barke...@microsoft.com>> - Bret From: Sami Mujawar via groups.io<mailto:sami.mujawar=arm....@groups.io> Sent: Friday, October 2, 2020 2:14 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> Cc: Sami Mujawar<mailto:sami.muja...@arm.com>; ard.biesheu...@arm.com<mailto:ard.biesheu...@arm.com>; l...@nuviainc.com<mailto:l...@nuviainc.com>; ler...@redhat.com<mailto:ler...@redhat.com>; matteo.carl...@arm.com<mailto:matteo.carl...@arm.com>; ben.adder...@arm.com<mailto:ben.adder...@arm.com>; n...@arm.com<mailto:n...@arm.com> Subject: [EXTERNAL] [edk2-devel] [PATCH v5 14/15] .python/SpellCheck: Add 'XIPFLAGS' to "words" section The EDKII Core CI reports spelling error for XIPFLAGS. The XIPFLAGS are typically used to specify XIP options to the compiler. e.g. GCC:*_*_*_CC_XIPFLAGS = -fno-jump-tables Add 'XIPFLAGS' to "words" section in cspell.base.yaml file to avoid spelling check error. Signed-off-by: Sami Mujawar <sami.muja...@arm.com<mailto:sami.muja...@arm.com>> Acked-by: Ard Biesheuvel <ard.biesheu...@arm.com<mailto:ard.biesheu...@arm.com>> --- Notes: v5: - No code changes, resending patch with v5 series. [Sami] Ref: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F62162&data=02%7C01%7CBret.Barkelew%40microsoft.com%7C09b7528fca35489670af08d867182f71%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637372700863446978&sdata=VZm3wyCHnm9oV1HTuripLVGwPxvrLtmuXTDJk68ueCo%3D&reserved=0 .pytool/Plugin/SpellCheck/cspell.base.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.pytool/Plugin/SpellCheck/cspell.base.yaml b/.pytool/Plugin/SpellCheck/cspell.base.yaml index 1ce5f6991104b83e41e769299b23cb3fa74c46e9..ad6f7ac06ad18efcd4ab9c2346356dfd6885d827 100644 --- a/.pytool/Plugin/SpellCheck/cspell.base.yaml +++ b/.pytool/Plugin/SpellCheck/cspell.base.yaml @@ -178,5 +178,6 @@ "vcruntimed", "ucrtd", "msvcrtd", + "XIPFLAGS" ] } -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65913): https://edk2.groups.io/g/devel/message/65913 Mute This Topic: https://groups.io/mt/77328429/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
