Re: [edk2-devel] [RFC] Request to move MinPlatformPkg out of the Intel folder

2020-10-02 Thread Sean
Nate, I would actually propose you go further. In Project Mu we consume MinPlatform as its own repo. This is because it has its own lifetime and spans multiple product generations and hopefully someday multiple architectures/silicon providers. By mixing it in with all the platform code of ed

Re: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding DDR5 definitions".

2020-10-02 Thread Sean
Reviewed-by: Sean Brogan On 9/29/2020 1:09 AM, Zhiguang Liu wrote: From: "Wang, Sanyo" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2352 SMBIOS 3.4 spec adds new memory device types (DDR5, LPDDR5) Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Sanyo Wang ---

[edk2-devel] [PATCH v5 01/15] PcAtChipsetPkg: Add MMIO Support to RTC driver

2020-10-02 Thread Sami Mujawar
Some virtual machine managers like Kvmtool emulate the MC146818 RTC controller in the MMIO space so that architectures that do not support I/O Mapped I/O can use the RTC. This patch adds MMIO support to the RTC controller driver. The PCD PcdRtcUseMmio has been added to select I/O or MMIO support.

[edk2-devel] [PATCH v5 05/15] ArmVirtPkg: kvmtool platform memory map

2020-10-02 Thread Sami Mujawar
Kvmtool is a virtual machine manager that enables hosting KVM guests. Kvmtool allows to vary the hardware configuration of the virtual platform it provides to the guest partition. It provides the current hardware configuration to the firmware by handing off a device tree containing the hardware inf

[edk2-devel] [PATCH v5 00/15] Kvmtool guest firmware support for Arm

2020-10-02 Thread Sami Mujawar
Kvmtool is a virtual machine manager that can be used to launch guest partitions. Kvmtool additionally supports emulation of hardware like the RTC, CFI etc. essentially providing an emulated platform for a Guest OS to run. To boot a standards-based OS one would need UEFI. In this case it is UEFI a

[edk2-devel] [PATCH v5 14/15] .python/SpellCheck: Add 'XIPFLAGS' to "words" section

2020-10-02 Thread Sami Mujawar
The EDKII Core CI reports spelling error for XIPFLAGS. The XIPFLAGS are typically used to specify XIP options to the compiler. e.g. GCC:*_*_*_CC_XIPFLAGS = -fno-jump-tables Add 'XIPFLAGS' to "words" section in cspell.base.yaml file to avoid spelling check error. Signed-off-by: Sami Mujawar Acked

[edk2-devel] [PATCH v5 12/15] ArmVirtPkg: Package dependency for MC146818 RTC

2020-10-02 Thread Sami Mujawar
Kvmtool emulates a MC146818 RTC controller in the MMIO space. To support this the MC146818 RTC driver PcatRealTimeClockRuntimeDxe has been updated to support MMIO accesses. PCDs for RTC Index and Target register base addresses in the MMIO space have been introduced. The KvmtoolRtcFdtClientLib reads

[edk2-devel] [PATCH v5 06/15] ArmVirtPkg: Add Kvmtool NOR flash lib

2020-10-02 Thread Sami Mujawar
Kvmtool places the base address of the CFI flash in the device tree it passes to UEFI. This library parses the kvmtool device tree to read the CFI base address and initialise the PCDs use by the NOR flash driver and the variable storage. UEFI takes ownership of the CFI flash hardware, and exposes

[edk2-devel] [PATCH v5 02/15] ArmVirtPkg: Add Kvmtool RTC Fdt Client Library

2020-10-02 Thread Sami Mujawar
Add library that parses the Kvmtool device tree and updates the dynamic PCDs describing the RTC Memory map. It also maps the MMIO region used by the RTC as runtime memory so that the RTC registers are accessible post ExitBootServices. Since UEFI takes ownership of the RTC hardware disable the RTC

[edk2-devel] [PATCH v5 07/15] MdeModulePkg: Fix constructor invocation ordering

2020-10-02 Thread Sami Mujawar
The BaseSerialPortLib16550 library does not implement a constructor. This prevents the correct constructor invocation order for dependent libraries. e.g. A PlatformHookLib (for the Serial Port) may have a dependency on retrieving data from a Hob. A Hob library implementation may configure its initi

[edk2-devel] [PATCH v5 04/15] ArmVirtPkg: Add kvmtool platform driver

2020-10-02 Thread Sami Mujawar
Kvmtool is a virtual machine manager that enables hosting KVM guests. It essentially provides a virtual hardware platform for guest operating systems. Kvmtool hands of a device tree containing the current hardware configuration to the firmware. A standards-based operating system would use ACPI to

[edk2-devel] [PATCH v5 13/15] ArmVirtPkg: Add kvmtool to package dictionary

2020-10-02 Thread Sami Mujawar
Kvmtool is a virtual machine manager that can be used to launch guest VMs. Support for Kvmtool virtual platform has been added to ArmVirtPkg. Add kvmtool to the ArmVirtPkg dictionary to prevent the CI Spell check plugin from failing. Signed-off-by: Sami Mujawar Acked-by: Ard Biesheuvel --- Not

[edk2-devel] [PATCH v5 15/15] Maintainer.txt: Add Kvmtool platform reviewer

2020-10-02 Thread Sami Mujawar
Kvmtool is a virtual machine manager that can be used to launch guest partitions. It additionally emulates some hardware components e.g. RTC, CFI etc. essentially providing a virtual platform for a guest operating system (OS) to run. A standards-based OS would need UEFI firmware support for the Kv

[edk2-devel] [PATCH v5 11/15] ArmVirtPkg: Support for kvmtool virtual platform

2020-10-02 Thread Sami Mujawar
Kvmtool is a virtual machine manager that enables hosting KVM guests. Kvmtool emulates certain devices like serial port, RTC, etc. essentially providing a virtual platform. This patch adds support for kvmtool virtual platform. Following is a brief description of the firmware implementation choice

[edk2-devel] [PATCH v5 09/15] ArmVirtPkg: 16550 UART Platform hook library

2020-10-02 Thread Sami Mujawar
The BaseSerialPort16550 library invokes the PlatformHookSerialPortInitialize() implemented as part of the PlatformHook library, to perform platform specific initialization required to enable use of the 16550 device. The BaseSerialPort16550 library uses the PcdSerialRegisterBase to obtain the base a

[edk2-devel] [PATCH v5 10/15] ArmVirtPkg: Add Kvmtool Platform Pei Lib

2020-10-02 Thread Sami Mujawar
The PlatformPeim() in the PlatformPeiLib is invoked by the PrePiMain() and provides the platform an opportunity to setup the plaform specific HOBs. This PlatfromPeiLib initialises the Kvmtool platform HOBs like the Fdt, 16550BaseAddress, etc. Signed-off-by: Sami Mujawar Reviewed-by: Ard Biesheuv

[edk2-devel] [PATCH v5 08/15] ArmVirtPkg: GUID Hob for 16550 UART base address

2020-10-02 Thread Sami Mujawar
Introduce a new GUID Hob gEarly16550UartBaseAddressGuid to cache the base address of the 16550 UART, for when PCD access is not available. Signed-off-by: Sami Mujawar Reviewed-by: Ard Biesheuvel --- Notes: v5: - No code changes, resending patch with v5 series. [Sami] R

[edk2-devel] [PATCH v5 03/15] ArmPlatformPkg: Dynamic flash variable base

2020-10-02 Thread Sami Mujawar
Some virtual machine managers like kvmtool can relocate the devices in the system memory map. The information about the devices location in memory is described in the device tree. Therefore, the CFI memory region and the associated Non volatile storage variables need to be adjusted accordingly. To

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Add timing for commands

2020-10-02 Thread Nate DeSimone
I don't think we should print execution time every time. Maybe a --performance flag or something to that effect? > -Original Message- > From: Erik Bjorge > Sent: Friday, October 2, 2020 11:21 AM > To: devel@edk2.groups.io > Cc: Desimone, Ashley E ; Desimone, > Nathaniel L ; Pandya, Puja

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Add timing for commands

2020-10-02 Thread Bjorge, Erik C
Added command timing in the entry point. Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge Signed-off-by: Erik Bjorge --- edkrepo/edkrepo_entry_point.py | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git

Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Reduce reset vector memory pressure

2020-10-02 Thread Lendacky, Thomas
On 9/24/20 10:03 AM, Laszlo Ersek wrote: On 09/24/20 15:30, Tom Lendacky wrote: On 9/24/20 1:22 AM, Laszlo Ersek wrote: On 09/23/20 20:04, Tom Lendacky wrote: From: Tom Lendacky The AP reset vector stack allocation is only required if running as an SEV-ES guest. Since the reset vector alloca

Re: [edk2-devel] [PATCH v4 0/6] Extend Last Attempt Status Usage

2020-10-02 Thread Michael Kubacki
It is going on a week now and I haven't seen a response to this patch series yet. Please review it when possible. On a somewhat related note, I made the changes that should be necessary in edk2-platforms for backward compatibility in this patch: https://edk2.groups.io/g/devel/message/65821 Th

Re: [edk2-devel] [RedfishPkg PATCH v3 1/4] RedfishPkg: Initial commit of RedfishPkg.

2020-10-02 Thread Laszlo Ersek
On 10/02/20 17:24, Chang, Abner (HPS SW/FW Technologist) wrote: > > >> -Original Message- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Laszlo Ersek >> Sent: Friday, October 2, 2020 11:13 PM >> To: Chang, Abner (HPS SW/FW Technologist) ; >> devel@edk2.groups.

Re: [edk2-devel] [RedfishPkg PATCH v3 1/4] RedfishPkg: Initial commit of RedfishPkg.

2020-10-02 Thread Abner Chang
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Friday, October 2, 2020 11:13 PM > To: Chang, Abner (HPS SW/FW Technologist) ; > devel@edk2.groups.io > Cc: Wang, Nickle (HPS SW) ; Andrew Fish > ; Leif Lindholm ; Michael D

Re: [edk2-devel] [RedfishPkg PATCH v3 1/4] RedfishPkg: Initial commit of RedfishPkg.

2020-10-02 Thread Laszlo Ersek
On 10/02/20 15:48, Abner Chang wrote: > Initial version of RedfishPkg. > > Signed-off-by: Wu Jiaxin > Signed-off-by: Fu Siyuan > Signed-off-by: Wang Fan > Signed-off-by: Chang Abner > Cc: Nickle Wang > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > --- >

Re: [edk2-devel] [RedfishPkg PATCH v3 4/4] edk2: Add maintainers to RedfishPkg

2020-10-02 Thread Laszlo Ersek
On 10/02/20 15:48, Abner Chang wrote: > Signed-off-by: Chang Abner > Cc: Nickle Wang > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > --- > Maintainers.txt | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/Maintainers.txt b/Maintainers.txt > inde

Re: [edk2-devel] [PATCH 1/1] NetworkPkg: Fix possible infinite loop in HTTP msg body parser

2020-10-02 Thread Vladimir Olovyannikov via groups.io
Hi Maciej, Thank you for reviewing the patch. > -Original Message- > From: Rabeda, Maciej > Sent: Friday, October 2, 2020 5:02 AM > To: Vladimir Olovyannikov ; > devel@edk2.groups.io > Cc: Jiaxin Wu ; Siyuan Fu ; > Laszlo Ersek > Subject: Re: [edk2-devel] [PATCH 1/1] NetworkPkg: Fix pos

Re: [edk2-devel] [RedfishPkg PATCH v2 1/4] RedfishPkg: Initial commit of RedfishPkg.

2020-10-02 Thread Abner Chang
V3 sent. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Thursday, October 1, 2020 5:22 PM > To: Chang, Abner (HPS SW/FW Technologist) ; > devel@edk2.groups.io > Cc: Wang, Nickle (HPS SW) ; Andrew Fish > ; Leif Lindholm ;

[edk2-devel] [RedfishPkg PATCH v3 3/4] .azurepipelines/templates: Add RedfishPkg to target build

2020-10-02 Thread Abner Chang
Signed-off-by: Abner Chang Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Cc: Nickle Wang --- .azurepipelines/templates/pr-gate-build-job.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/temp

[edk2-devel] [RedfishPkg PATCH v3 2/4] .pytool: Add CI on RedfishPkg

2020-10-02 Thread Abner Chang
Add RedfishPkg to CI test. Signed-off-by: Abner Chang Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Cc: Nickle Wang --- .pytool/CISettings.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index 0c

[edk2-devel] [RedfishPkg PATCH v3 0/4] Inital RedfishPkg

2020-10-02 Thread Abner Chang
Initial version of RedfishPkg and the CI test on RedfishPkg. CI Test result: https://github.com/tianocore/edk2/pull/975 There is no components in RedfishPkg in this commit, the further edk2 Redfish components will be committed base on this version. Abner Chang (4): RedfishPkg: Initial commit o

[edk2-devel] [RedfishPkg PATCH v3 4/4] edk2: Add maintainers to RedfishPkg

2020-10-02 Thread Abner Chang
Signed-off-by: Chang Abner Cc: Nickle Wang Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Michael D Kinney --- Maintainers.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 6a22a14796..cabadac177 100644 --- a/Maintainers.txt +++ b/Ma

[edk2-devel] [RedfishPkg PATCH v3 1/4] RedfishPkg: Initial commit of RedfishPkg.

2020-10-02 Thread Abner Chang
Initial version of RedfishPkg. Signed-off-by: Wu Jiaxin Signed-off-by: Fu Siyuan Signed-off-by: Wang Fan Signed-off-by: Chang Abner Cc: Nickle Wang Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Michael D Kinney --- RedfishPkg/RedfishPkg.ci.yaml | 67 +

Re: [edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/ARM: TimerLib based RngLib for CryptoPkg

2020-10-02 Thread Thomas Abraham
On Fri, Oct 2, 2020 at 1:49 PM Ard Biesheuvel wrote: > > On 10/2/20 1:15 AM, Sami Mujawar wrote: > > The commit at "b5701a4c7a0f CryptoPkg: OpensslLib: Use RngLib to > > generate entropy in rand_pool" updated CryptoPkg\OpenSSL to no > > longer depend on TimerLib and instead use RngLib. This is don

Re: [edk2-devel] [PATCH v2 0/2] UEFI memmap workaround for hiding page-access caps from OSes hides SP and CRYPTO caps too

2020-10-02 Thread Malgorzata Kukiello
Liming, I am trying to enable a crypto technology, that requires handling on the OS side (implemented in the kernel.org patch), generally speaking I mark in memory map all regions that can be encrypted using the before mentioned tech. Then OS checks that attribute and decides whether or not to e

Re: [edk2-devel] [PATCH 1/1] NetworkPkg: Fix possible infinite loop in HTTP msg body parser

2020-10-02 Thread Maciej Rabeda
Hi Vladimir, Functionally the patch is fine. However, from coding standard perspective, !PortionLen is not allowed - such structure is used only for BOOLEAN type values. Reference: Table 10, https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/5_source_files/57_c_programming#5-7

[edk2-devel] [PATCH v1] NetworkPkg: Add RngLib entry to .dsc file.

2020-10-02 Thread Maciej Rabeda
Recent change to OpensslLib (b5701a4c7a0fb185e0c5b9db9525939c78664bfd) causes NetworkPkg build to fail due to lack of RngLib entry in NetworkPkg's .dsc file. Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Maciej Rabeda --- NetworkPkg/NetworkPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [edk2-devel] Cannot build due to recent change

2020-10-02 Thread Laszlo Ersek
on a tangent: On 10/01/20 12:43, Leif Lindholm wrote: > if the platform port produces EFI_RNG_PROTOCOL > from some onboard hw, you can use the approach from edk2-platforms > commit 1e09147a01ae ("Platforms/RaspberryPi: Fix RPi4 RngLib build error"). Emphasis on "onboard hw". I find it incredibl

Re: [edk2-devel] Tianocore community page on who we are - please review

2020-10-02 Thread Laszlo Ersek
(Resending; my previous attempt to post this response failed, and I even lost the original version of my response, so I'm rewriting it again from a draft. I've also cleaned up the garbage in the address list now -- I think that may have contirbuted to me failing to send the message at first.) Hell

Re: [edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/ARM: TimerLib based RngLib for CryptoPkg

2020-10-02 Thread Ard Biesheuvel
On 10/2/20 1:15 AM, Sami Mujawar wrote: The commit at "b5701a4c7a0f CryptoPkg: OpensslLib: Use RngLib to generate entropy in rand_pool" updated CryptoPkg\OpenSSL to no longer depend on TimerLib and instead use RngLib. This is done so that platforms can choose the desired entropy source. However,