On Fri, Oct 2, 2020 at 1:49 PM Ard Biesheuvel <ard.biesheu...@arm.com> wrote: > > On 10/2/20 1:15 AM, Sami Mujawar wrote: > > The commit at "b5701a4c7a0f CryptoPkg: OpensslLib: Use RngLib to > > generate entropy in rand_pool" updated CryptoPkg\OpenSSL to no > > longer depend on TimerLib and instead use RngLib. This is done so > > that platforms can choose the desired entropy source. However, this > > change breaks the builds for platforms under Platform/ARM. > > > > To fix this, update ArmVExpress.dsc.inc to use a TimerLib based > > implementation of RngLib. > > > > Note: The TimerLib based implementation of RngLib replicates past > > behavior when used with OpenSSL. However, this should not be used > > in production as a real source of entropy. > > > > Signed-off-by: Sami Mujawar <sami.muja...@arm.com> > > Reviewed-by: Ard Biesheuvel <ard.biesheu...@arm.com>
Tested for SGI/RD platforms and it resolves the build issue. Tested-by: Thomas Abraham <thomas.abra...@arm.com> > > > > --- > > > > The changes can be seen at: > > https://github.com/samimujawar/edk2-platforms/tree/1441_fix_platform_arm_build_break_v1 > > > > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > index > > bde3437b56d71be9259b18bc0501976695639c62..6f4621393a9713705e360a1c9ad019a6ad93a0a4 > > 100644 > > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > @@ -1,5 +1,5 @@ > > # > > -# Copyright (c) 2011-2019, ARM Limited. All rights reserved. > > +# Copyright (c) 2011-2020, Arm Limited. All rights reserved. > > # > > # SPDX-License-Identifier: BSD-2-Clause-Patent > > # > > @@ -138,6 +138,7 @@ [LibraryClasses.common] > > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > > IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf > > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > > + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf > > VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > > > > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65836): https://edk2.groups.io/g/devel/message/65836 Mute This Topic: https://groups.io/mt/77252312/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
