On 10/02/20 17:24, Chang, Abner (HPS SW/FW Technologist) wrote: > > >> -----Original Message----- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Laszlo Ersek >> Sent: Friday, October 2, 2020 11:13 PM >> To: Chang, Abner (HPS SW/FW Technologist) <abner.ch...@hpe.com>; >> devel@edk2.groups.io >> Cc: Wang, Nickle (HPS SW) <nickle.w...@hpe.com>; Andrew Fish >> <af...@apple.com>; Leif Lindholm <l...@nuviainc.com>; Michael D Kinney >> <michael.d.kin...@intel.com> >> Subject: Re: [edk2-devel] [RedfishPkg PATCH v3 1/4] RedfishPkg: Initial >> commit of RedfishPkg. >> >> On 10/02/20 15:48, Abner Chang wrote: >>> Initial version of RedfishPkg. >>> >>> Signed-off-by: Wu Jiaxin <jiaxin...@intel.com> >>> Signed-off-by: Fu Siyuan <siyuan...@intel.com> >>> Signed-off-by: Wang Fan <fan.w...@intel.com> >>> Signed-off-by: Chang Abner <abner.ch...@hpe.com> >>> Cc: Nickle Wang <nickle.w...@hpe.com> >>> Cc: Andrew Fish <af...@apple.com> >>> Cc: Laszlo Ersek <ler...@redhat.com> >>> Cc: Leif Lindholm <l...@nuviainc.com> >>> Cc: Michael D Kinney <michael.d.kin...@intel.com> >>> --- >>> RedfishPkg/RedfishPkg.ci.yaml | 67 >> +++++++++++++++++++++++++++++++++++ >>> RedfishPkg/RedfishPkg.dec | 18 ++++++++++ >>> RedfishPkg/RedfishPkg.dsc | 40 +++++++++++++++++++++ >>> 3 files changed, 125 insertions(+) >>> create mode 100644 RedfishPkg/RedfishPkg.ci.yaml create mode 100644 >>> RedfishPkg/RedfishPkg.dec create mode 100644 >>> RedfishPkg/RedfishPkg.dsc >>> >>> diff --git a/RedfishPkg/RedfishPkg.ci.yaml >>> b/RedfishPkg/RedfishPkg.ci.yaml new file mode 100644 index >>> 0000000000..75c3b6a8ad >>> --- /dev/null >>> +++ b/RedfishPkg/RedfishPkg.ci.yaml >>> @@ -0,0 +1,67 @@ >>> +## @file >>> +# CI configuration for NetworkPkg >>> +# >>> +# (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR> # >>> +SPDX-License-Identifier: BSD-2-Clause-Patent ## { >>> + "LicenseCheck": { >>> + "IgnoreFiles": [] >>> + }, >>> + "EccCheck": { >>> + ## Exception sample looks like below: >>> + ## "ExceptionList": [ >>> + ## "<ErrorID>", "<KeyWord>" >>> + ## ] >>> + "ExceptionList": [ >>> + ], >>> + ## Both file path and directory path are accepted. >>> + "IgnoreFiles": [ >>> + ] >>> + }, >>> + "CompilerPlugin": { >>> + "DscPath": "RedfishPkg.dsc" >>> + }, >>> + "CharEncodingCheck": { >>> + "IgnoreFiles": [] >>> + }, >>> + "DependencyCheck": { >>> + "AcceptableDependencies": [ >>> + "MdePkg/MdePkg.dec", >>> + "MdeModulePkg/MdeModulePkg.dec", >>> + "NetworkPkg/NetworkPkg.dec" >>> + ], >>> + # For host based unit tests >>> + "AcceptableDependencies-HOST_APPLICATION":[], >>> + # For UEFI shell based apps >>> + "AcceptableDependencies-UEFI_APPLICATION":[ >>> + "ShellPkg/ShellPkg.dec" >>> + ], >>> + "IgnoreInf": [] >>> + }, >>> + "DscCompleteCheck": { >>> + "DscPath": "RedfishPkg.dsc", >>> + "IgnoreInf": [] >>> + }, >>> + "GuidCheck": { >>> + "IgnoreGuidName": [], >>> + "IgnoreGuidValue": [], >>> + "IgnoreFoldersAndFiles": [] >>> + }, >>> + "LibraryClassCheck": { >>> + "IgnoreHeaderFile": [] >>> + }, >>> + >>> + ## options defined ci/Plugin/SpellCheck >>> + "SpellCheck": { >>> + "AuditOnly": True, # Fails test but run in AuditOnly >>> mode to >> collect log >>> + "IgnoreFiles": [], # use gitignore syntax to ignore >>> errors in >> matching files >>> + "ExtendWords": [], # words to extend to the dictionary >>> for this >> package >>> + "IgnoreStandardPaths": [], # Standard Plugin defined paths that >> should be ignore >>> + "AdditionalIncludePaths": [] # Additional paths to spell check >> (wildcards supported) >>> + }, >>> + >>> + "Defines": { >>> + "BLD_*_CONTINUOUS_INTEGRATION": "TRUE" >>> + } >>> +} >>> diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec new >>> file mode 100644 index 0000000000..e95ec5fe10 >>> --- /dev/null >>> +++ b/RedfishPkg/RedfishPkg.dec >>> @@ -0,0 +1,18 @@ >>> +## @file >>> +# Redfish Package >>> +# >>> +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> # >>> +(C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR> # # >>> +SPDX-License-Identifier: BSD-2-Clause-Patent ## >>> + >>> +[Defines] >>> + DEC_SPECIFICATION = 0x0001001b >>> + PACKAGE_NAME = RedfishPkg >>> + PACKAGE_GUID = c432b76e-5232-11e7-9010-005056c00008 >>> + PACKAGE_VERSION = 1.0 >>> + >>> +[Guids] >>> + gEfiRedfishPkgTokenSpaceGuid = { 0x4fdbccb7, 0xe829, 0x4b4c, { 0x88, >> 0x87, 0xb2, 0x3f, 0xd7, 0x25, 0x4b, 0x85 }} >>> + >>> diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc new >>> file mode 100644 index 0000000000..8acadddefc >>> --- /dev/null >>> +++ b/RedfishPkg/RedfishPkg.dsc >>> @@ -0,0 +1,40 @@ >>> +## @file >>> +# Redfish Package >>> +# >>> +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> # >>> +(C) Copyright 2020 Hewlett-Packard Enterprise Development LP. >>> +# >>> +# SPDX-License-Identifier: BSD-2-Clause-Patent >>> +# >>> +## >>> + >>> +[Defines] >>> + PLATFORM_NAME = RedfishPkg >>> + PLATFORM_GUID = c4352870-5232-11e7-9522-005056c00008 >>> + PLATFORM_VERSION = 1.0 >>> + DSC_SPECIFICATION = 0x0001001c >>> + OUTPUT_DIRECTORY = Build/RedfishPkg >>> + SUPPORTED_ARCHITECTURES = IA32|X64|ARM|AARCH64|RISCV64 >>> + BUILD_TARGETS = DEBUG|RELEASE|NOOPT >>> + SKUID_IDENTIFIER = DEFAULT >>> + >>> +[LibraryClasses] >>> + >>> +UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEn >>> +tryPoint.inf >>> + >>> >> +UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/Uefi >>> +BootServicesTableLib.inf >>> + UefiLib|MdePkg/Library/UefiLib/UefiLib.inf >>> + >>> >> +UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLi >>> +b/UefiRuntimeServicesTableLib.inf >>> + UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf >>> + >>> >> +MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMem >> ory >>> +AllocationLib.inf >>> + >>> +DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf >>> + BaseLib|MdePkg/Library/BaseLib/BaseLib.inf >>> + BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf >>> + >>> >> +SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchron >>> +izationLib.inf >>> + PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf >>> + DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf >>> + >>> >> +DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/Ba >>> +seDebugPrintErrorLevelLib.inf >>> + >>> >> +PostCodeLib|MdePkg/Library/BasePostCodeLibPort80/BasePostCodeLibPo >> rt8 >>> +0.inf >>> + PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf >>> + >>> >> +PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/Bas >> e >>> +PeCoffGetEntryPointLib.inf >>> + >>> >> +DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTab >>> +leLib.inf >>> + DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf >>> + >>> >> +ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/D >> xeRe >>> +portStatusCodeLib.inf >>> >> >> Acked-by: Laszlo Ersek <ler...@redhat.com> >> >> One observation: the two GUIDs in this patch look quite close to each other: >> >> c4352870-5232-11e7-9522-005056c00008 (PLATFORM_GUID) >> c432b76e-5232-11e7-9010-005056c00008 (PACKAGE_GUID) >> ^^^ ^^^^ ^^^^ ^ ^^^^^^^^^^^^ >> >> It's quite rare to see time/MAC-based GUIDs nowadays :) > Yes. It's rare... I don’t remember how those GUID came from. But I didn’t > play trick on that:) > Do you think it's better to generate a new GUID for that?
No, I don't think so. I was originally alarmed (thought you modified GUIDs manually), but then ran "uuidgen --time" a few times, and got very similarly structured GUIDs (I didn't bother to look up the actual fields though). As long as "uuidgen" is invoked for every new GUID, I think we're fine. Thanks! Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65847): https://edk2.groups.io/g/devel/message/65847 Mute This Topic: https://groups.io/mt/77262657/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
