Re: [edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Tue, 06/16/2020 6:30pm-7:30pm #cal-reminder

Few new bugs are this week. 2802 EDK2 Code michael.kuba...@microsoft.com UNCO --- Extend usage of LastAttemptStatus in FmpDxe 18:48:53 2808

[edk2-devel] [PATCH v4] Features/Intel/PostCodeDebugFeaturePkg: add it.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2478 The PostCodeDebugFeaturePkg include some useful post code debug libraries, such as get post code from status code and show it. It provide a library PostCodeStatusCodeHandlerLib used by edk2 StatusCodeHandler.efi, used to show the post code.

Re: [edk2-devel] [PATCH v3] MdePkg/BasePrintLib: avoid absolute addresses for error strings

This data is great. The change is good. Reviewed-by: Liming Gao From: Liu, Zhiguang Sent: 2020年6月15日 15:34 To: Ard Biesheuvel ; Gao, Liming ; devel@edk2.groups.io Cc: Kinney, Michael D Subject: RE: [edk2-devel] [PATCH v3] MdePkg/BasePrintLib: avoid absolute addresses for error strings Hi A

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Tue, 06/16/2020 6:30pm-7:30pm #cal-reminder

*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Tuesday, 16 June 2020, 6:30pm to 7:30pm, (GMT-07:00) America/Los Angeles *Where:* https://bluejeans.com/889357567?src=join_info View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=816012 ) *Organizer:* Brian Richardson brian.richa

[edk2-devel] [PATCH] UefiCpuPkg: Add New Memory Attributes

Add usage of EFI_MEMORY_SP and EFI_MEMORY_CPU_CRYPTO attributes introduced in UEFI 2.8 (UEFI 2.8, mantis 1919 and 1872) Signed-off-by: Oleksiy Yakovlev --- UefiCpuPkg/CpuDxe/CpuDxe.c | 2 +- UefiCpuPkg/CpuDxe/CpuDxe.h | 4 +++- UefiCpuPkg/CpuDxe/Cp

[edk2-devel] [PATCH] MdeModulePkg: Add New Memory Attributes

Add usage of EFI_MEMORY_SP and EFI_MEMORY_CPU_CRYPTO attributes introduced in UEFI 2.8 (UEFI 2.8, mantis 1919 and 1872) Signed-off-by: Oleksiy Yakovlev --- MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 3 ++- MdeModulePkg/Core/Dxe/Mem/Page.c | 6 +++--- MdeModulePkg/Core/Dxe/Misc/

[edk2-devel] [edk2-platform][PATCH v2 1/2] Platforms/RaspberryPi: Add RPi4 settings to Readme

Add a section to the the RPi4 Readme for 'Configuration Settings', with instructions on scripting from the UEFI Shell. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/RPi4/Readme.md | 74 ++

[edk2-devel] [edk2-platform][PATCH v2 0/2] Platforms/RaspberryPi: Add RPi settings to Readme

Add a section to the the RPi3/4 Readme for 'Configuration Settings', with instructions on scripting from the UEFI Shell. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Signed-off-by: Samer El-Haj-Mahmoud Samer El-Haj-Mahmoud (2): Platforms/RaspberryPi: Add RPi4 s

[edk2-devel] [edk2-platform][PATCH v2 2/2] Platforms/RaspberryPi: Add RPi3 settings to Readme

Add a section to the the RPi3 readme for 'Configuration Settings', with instructions on scripting from the UEFI Shell. Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/RPi3/Readme.md | 61 1 file changed, 61 insertions(+) diff --git a/Platform/RaspberryPi/RPi3/R

[edk2-devel] [PATCH v1 2/2] UefiCpuPkg: PiSmmCpuDxeSmm skip MSR_IA32_MISC_ENABLE manipulation on AMD

AMD does not support MSR_IA32_MISC_ENABLE. Accessing that register causes and exception on AMD processors. If Execution Disable is supported, and if the processor is an AMD processor skip manipulating MSR_IA32_MISC_ENABLE[34] XD Disable bit. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-of

[edk2-devel] [PATCH v1 1/2] UefiCpuPkg: Move StandardSignatureIsAuthenticAMD to BaseUefiCpuLib

Refactor StandardSignatureIsAuthenticAMD into BaseUefiCpuLib from separate copies in BaseXApicLib, BaseXApicX2ApicLib, and MpInitLib. This allows for future use of StandarSignatureIsAuthinticAMD without creating more instances in other modules. This function allows IA32/X64 code to determine if it

[edk2-devel] [PATCH v1 0/2] UefiCpuPkg: AMD procesor MSR_IA32_MISC_ENABLE

AMD processor does not support MSR_IA32_MISC_ENABLE register. Accessing this register on AMD causes an unhandled exception in SmmEntry.nasm and a subsequent failure to boot since this is too early in SMM path for the exception handler to be loaded. First, to distinguish between AMD and other proc

Re: [edk2-devel] [PATCH v1 0/3] Compile AML bytecode array into OBJ file

Hello Ard and Bob, I also noticed the line ending is incorrect for BaseTools/BinWrappers/PosixLike/AmlToHex. The patch "[PATCH v1 2/3] BaseTools: Rename AmlToHex script to AmlToC" is correcting the line ending. This script is generating an optional output file and doesn't prevent edk2 from buil

Re: [edk2-devel] [PATCH v1 1/3] BaseTools: Generate multiple rules when multiple output files

Hello Bob, I have locally corrected the patch. On non-arm architecture, I had previously tested it for the following configurations, but this wasn't enough apparently. I am currently testing it on more platforms and I will send you the list of the tested platforms along with the V2. Plarform="Pl

Re: [edk2-devel] [PATCH] Revert "OvmfPkg: use generic QEMU image loader for secure boot enabled builds"

On 6/15/20 4:45 PM, Laszlo Ersek wrote: > This reverts commit ced77332cab626f35fbdb36630be27303d289d79. > > The command > > virt-install --location NETWORK-URL > > downloads the vmlinuz and initrd files from the remote OS tree, and passes > them to the guest firmware via fw_cfg. > > When used

[edk2-devel] [PATCH] Revert "OvmfPkg: use generic QEMU image loader for secure boot enabled builds"

This reverts commit ced77332cab626f35fbdb36630be27303d289d79. The command virt-install --location NETWORK-URL downloads the vmlinuz and initrd files from the remote OS tree, and passes them to the guest firmware via fw_cfg. When used with IA32 / X64 guests, virt-install expects the guest firm

Re: [edk2-devel] [PATCH 5/5] StandaloneMmPkg/StandaloneMmCoreEntryPoint: relocate StMM core on the fly

On Mon, Jun 15, 2020 at 07:12 AM, Ard Biesheuvel wrote: > > >> On Wed, Jun 10, 2020 at 01:17 AM, Ard Biesheuvel wrote: >> + *ImageBase =3D ImageContext->ImageAddress;=0D >> I think the '*ImageBase = ImageContext->ImageAddress;' statement can be >> moved inside the if condition. > > No, the TE b

Re: [edk2-devel] [PATCH 5/5] StandaloneMmPkg/StandaloneMmCoreEntryPoint: relocate StMM core on the fly

On 6/15/20 3:59 PM, Sami Mujawar via Groups.Io wrote: Apologies for top replying. I am not sure if it is my setup where I see additional characters (e.g. =0D at the end of each line) which appear to confuse my email client. That must be Thunderbird playing tricks. > UpdateMmFoundationPeC

[edk2-devel] [PATCH v3 2/7] ShellPkg/AcpiView: Refactor configuration

A new file and header (AcpiViewConfig.[ch]) is created that houses the user configuration. This declutters the core code and improves modularity of the design. The module level symbols for verbosity, table selection, and highlighting are refactored into the new file. Cc: Ray Ni Cc: Zhichao Gao

[edk2-devel] [PATCH v3 5/7] ShellPkg/AcpiView: Refactor DumpAcpiTableToFile

Method is refactored into two parts. A new method is created that dumps arbitrary buffers into a newly created file. This method is called from core code after the core code determined the appropriate filename to be used. This improves the modular design. Cc: Ray Ni Cc: Zhichao Gao Signed-off-b

[edk2-devel] [PATCH v3 4/7] ShellPkg/AcpiView: Move parameter parsing

Parsing command line parameters is done in the shell command wrapper. This declutters the core code and improves modular design. Cc: Ray Ni Cc: Zhichao Gao Reviewed-by: Zhichao Gao Signed-off-by: Tomas Pilar --- .../UefiShellAcpiViewCommandLib/AcpiView.c| 205 .../UefiShe

[edk2-devel] [PATCH v3 7/7] ShellPkg/AcpiView: Add application wrapper

Simple application wrapper that invokes the shell command wrapper for 'acpiview'. This allows the AcpiView functionality to be used on platforms with older specifications of the UEFI shell or where the 'acpiview' command is not built in due to platform build configuration. Furthermore, this app c

[edk2-devel] [PATCH v3 6/7] ShellPkg: Add AcpiViewCommandLib

The UefiShellAcpiViewCommandLib is converted from NULL library to a named library so that it may be used in modules other than shell. The library interface exposes the main method for to AcpiView functionality as well as a helper method to dump a buffer to a file. The Shell module is still built b

[edk2-devel] [PATCH v3 0/7] Standalone AcpiView Application

This patchset adds a new application module to the ShellPkg with the functionality of the 'acpiview' command. The existing code is tidied and a clean boundary between the UEFI shell command wrapper and the acpiview functionality is created. Then, a new application wrapper is added. The motivatio

[edk2-devel] [PATCH v3 3/7] ShellPkg/AcpiView: Move table count reset

The table count module level symbols are now reset when executing the core method, rather than the shell command wrapper. Cc: Ray Ni Cc: Zhichao Gao Reviewed-by: Zhichao Gao Signed-off-by: Tomas Pilar --- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 8 +--- 1 file changed, 5

[edk2-devel] [PATCH v3 1/7] ShellPkg/AcpiView: Move log reset to main method

The error and warning counters are reset in the AcpiView main method. This improves reusability of the main method. Cc: Ray Ni Cc: Zhichao Gao Reviewed-by: Zhichao Gao Signed-off-by: Tomas Pilar --- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 8 1 file changed, 4 insert

Re: [edk2-devel] [PATCH 5/5] StandaloneMmPkg/StandaloneMmCoreEntryPoint: relocate StMM core on the fly

Apologies for top replying. I am not sure if it is my setup where I see additional characters (e.g. =0D at the end of each line) which appear to confuse my email client. > UpdateMmFoundationPeCoffPermissions (=0D > IN CONST PE_COFF_LOADER_IMAGE_CONTEXT *ImageContext,=0D > + IN EFI_PHYSICAL_ADDRE

Re: [edk2-devel] [PATCH 3/5] StandaloneMmPkg/Core: add missing GUID reference

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61289): https://edk2.groups.io/g/devel/message/61289 Mute This Topic: https://groups.io/mt/74792290/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH 2/5] StandaloneMmPkg/Core: fix bogus FV pointer in DEBUG string

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61288): https://edk2.groups.io/g/devel/message/61288 Mute This Topic: https://groups.io/mt/74792289/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH v2 6/6] ShellPkg/AcpiView: Add application wrapper

Thank you Zhichao, this is really useful, I was wondering how to hook into the shell help framework. Regarding the lower case const and static, I am entirely happy to change them, but I have a couple of patch series outstanding and don't want to add unnecessary merge conflicts, so I'll do a si

Re: [edk2-devel] [RFC PATCH 1/1] OvmfPkg: Introduce LSI 53C895A SCSI Controller Driver

Hello Gary, On 06/12/20 12:04, Gary Lin wrote: > This commit introduces the driver for LSI 53C895A SCSI Controller > which, so that OVMF can access the devices attached to the emulated > "lsi" SCSI controller. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Signed-off-by: Gary L

Re: [edk2-devel] [edk2-platform][PATCH v1 1/2] Platforms/RaspberryPi: Add RPi4 settings to Readme

Hi Samer, One remark inline: On 2020.06.13 14:41, Samer El-Haj-Mahmoud wrote: Add a section to the the RPi4 Readme for 'Configuration Settings', with instructions on scripting from the UEFI Shell. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Signed-off-by: Same

[edk2-devel] [PATCH v4 07/17] EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Shenglei Zhang --- EmulatorPkg/EmulatorPkg.ci.yaml | 10 ++ 1 file changed, 10 insertions(+) diff

[edk2-devel] [PATCH v4 16/17] UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Shenglei Zhang Acked-by: Laszlo Ersek --- UefiCpuPkg/UefiCpuPkg.ci.yaml | 10 ++ 1 file changed, 10

[edk2-devel] [PATCH v4 08/17] FatPkg/FatPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Ray Ni Signed-off-by: Shenglei Zhang --- FatPkg/FatPkg.ci.yaml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/FatPkg/FatPkg.ci.yaml b/FatPkg/FatPkg

[edk2-devel] [PATCH v4 11/17] NetworkPkg/NetworkPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Shenglei Zhang Reviewed-by: Maciej Rabeda --- NetworkPkg/NetworkPkg.ci.yaml | 10 ++ 1 file chan

[edk2-devel] [PATCH v4 12/17] OvmfPkg/OvmfPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Shenglei Zhang Acked-by: Laszlo Ersek --- OvmfPkg/OvmfPkg.ci.yaml | 10 ++ 1 file change

[edk2-devel] [PATCH v4 04/17] MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Shenglei Zhang --- MdeModulePkg/MdeModulePkg.ci.yaml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MdeMod

[edk2-devel] [PATCH v4 15/17] ShellPkg/ShellPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Shenglei Zhang --- ShellPkg/ShellPkg.ci.yaml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/ShellPkg/ShellPk

[edk2-devel] [PATCH v4 10/17] MdePkg/MdePkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Shenglei Zhang --- MdePkg/MdePkg.ci.yaml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MdePkg/MdeP

[edk2-devel] [PATCH v4 05/17] ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Shenglei Zhang Acked-by: Laszlo Ersek --- ArmVirtPkg/ArmVirtPkg.ci.yaml | 10 ++ 1 file

[edk2-devel] [PATCH v4 06/17] CryptoPkg/CryptoPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Jian J Wang Cc: Xiaoyu Lu Signed-off-by: Shenglei Zhang --- CryptoPkg/CryptoPkg.ci.yaml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/CryptoPkg/C

[edk2-devel] [PATCH v4 09/17] FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: Shenglei Zhang --- FmpDevicePkg/FmpDevicePkg.ci.yaml | 10 ++ 1 file changed, 10 insertions(+) diff --git a

[edk2-devel] [PATCH v4 17/17] UnitTestFrameworkPkg: Add configuration for Ecc check in yaml file

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Michael D Kinney Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Shenglei Zhang --- UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 10 ++ 1 file cha

[edk2-devel] [PATCH v4 14/17] SecurityPkg/SecurityPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Signed-off-by: Shenglei Zhang --- SecurityPkg/SecurityPkg.ci.yaml | 10 ++ 1 file changed, 10 insertions(+) dif

[edk2-devel] [PATCH v4 02/17] pip-requirements.txt: Add Ecc required lib

antlr4-python3-runtime is a lib to support Ecc run with Py3.x. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Shenglei Zhang --- pip-requirements.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/pip-requirements.txt b/pip-requirements.txt index 57

[edk2-devel] [PATCH v4 13/17] PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Ray Ni Signed-off-by: Shenglei Zhang --- PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/PcAtChipsetPkg/PcAtCh

[edk2-devel] [PATCH v4 03/17] .azurepiplines: Add a pipline to check ECC issues for commits

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606 Add a pipeline to run the ECC checks on Azure Pipelines agents for edk2 open ci. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Shenglei Zhang --- .azurepipelines/Windows-EccCheck.yml | 38

[edk2-devel] [PATCH v4 00/17] Add a pipline to check Ecc issues for edk2 on open ci

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606 As planed we will enable Ecc check for edk2 on open ci. And they are ready now, but these are V3 series. So I expect that contributors in edk2 community can try using this script when reviewing. And I appreciate receiving feedback and comment

[edk2-devel] [PATCH v4 01/17] BaseTools/Scripts: Add EccCheck.py

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606 EccCheck.py is a tool to report Ecc issues for commits, which will be run on open ci. But note not each kind of issue could be reported out. It can only handle the issues, whose line number in CSV report accurately map with their code in sour

Re: [edk2-devel] [PATCH v3] MdePkg/BasePrintLib: avoid absolute addresses for error strings

Hi Ard, I also collected the image size of OVMFX64 size building with VS2015x86. Debug Release before after After-before before after after-before sec 27664 27409 -255 13968 13968 0 pei 223016 221000 -2016 107208 106984 -224 dxe 4507000 4481336 -25664 2987064 2979384 -7680 compact 1179776 1172