Apologies for top replying. I am not sure if it is my setup where I see additional characters (e.g. =0D at the end of each line) which appear to confuse my email client.
> UpdateMmFoundationPeCoffPermissions (=0D > IN CONST PE_COFF_LOADER_IMAGE_CONTEXT *ImageContext,=0D > + IN EFI_PHYSICAL_ADDRESS ImageBase,=0D Can the function documentation for UpdateMmFoundationPeCoffPermissions() and GetStandaloneMmCorePeCoffSections() be updated to reflect the additional parameter ImageBase, please? On Wed, Jun 10, 2020 at 01:17 AM, Ard Biesheuvel wrote: > > + *ImageBase =3D ImageContext->ImageAddress;=0D I think the '*ImageBase = ImageContext->ImageAddress;' statement can be moved inside the if condition. With these changes. Reviewed-by: Sami Mujawar <sami.muja...@arm.com> Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61290): https://edk2.groups.io/g/devel/message/61290 Mute This Topic: https://groups.io/mt/74792292/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-