Re: [edk2-devel] [PATCH 3/3] OvmfwPkg: Don't exclude XCODE Modules

> On May 26, 2020, at 4:45 AM, Laszlo Ersek wrote: > > On 05/26/20 06:10, Andrew Fish wrote: >> >> >>> On May 25, 2020, at 12:31 PM, Laszlo Ersek wrote: >>> >>> Hi Andrew, >>> >>> On 05/24/20 23:20, Andrew Fish via groups.io wrote: With this BZ getting fixed we no

[edk2-devel] Please re-sync your calendar to get meeting updates

Dear community members, The groups.io calendar (https://edk2.groups.io/g/devel/calendar?calstart=2020-06-04) has shown some issues in displaying the correct meeting time. When I sync to my outlook, it is off by an hour. I figured that this is a reported bug in group.io. I worked around it and a

Re: [edk2-devel] [PATCH 0/5] ArmPkg/PlatformBootManagerLib: play nice without ConnectAll()

On 5/27/20 12:01 AM, Leif Lindholm via groups.io wrote: On Tue, May 26, 2020 at 18:13:54 +0200, Ard Biesheuvel wrote: Currently, Armpkg's PlatformBootManagerLib connects all controller to their drivers recursively, even if the active boot option does not require it. There are some historical rea

[edk2-devel] Updated Event: TianoCore Community Meeting - EMEA/NAMO #cal-invite

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VEVENT UID:sb9i.157386325130551.t...@groups.io DTSTAMP:20200527T051825Z ORGANIZER;CN=Brian Richardson:mailto:brian.richard...@intel.com DTSTART;TZID=America/Los_Angeles:20191205T0

[edk2-devel] Updated Event: TianoCore Community Meeting - APAC/NAMO #cal-invite

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VEVENT UID:gdko.1573863427728520321.j...@groups.io DTSTAMP:20200527T051839Z ORGANIZER;CN=Brian Richardson:mailto:brian.richard...@intel.com DTSTART;TZID=America/Los_Angeles:20191205T1

Re: [edk2-devel] [PATCH 1/3] BaseTools/GenFv: Add PE/COFF resource sections injection to GenFw

Hi Andrew, This patch cause building GenFw failure. cl.exe -c /nologo /Zi /c /O2 /MT /W4 /WX /D _CRT_SECURE_NO_DEPRECATE /D _CRT_NONSTDC_NO_DEPRECATE -I . -I D:\Edk2Maintain\edk2head\edk2\BaseTools\Source\C\Include -I D:\Edk2Maintain\edk2head\edk2\BaseTools\Source\C\Include\Ia32 -I D:\Edk2Ma

Re: [edk2-devel] [EXTERNAL] Re: Hard Feature Freeze starts now for edk2-stable202005

Thanks! - Bret From: devel@edk2.groups.io on behalf of Liming Gao via groups.io Sent: Tuesday, May 26, 2020 7:21:00 PM To: Bret Barkelew ; Laszlo Ersek ; devel@edk2.groups.io ; annou...@edk2.groups.io Cc: Leif Lindholm ; af...@apple.com ; Kinney, Michael D

Re: [edk2-devel] [EXTERNAL] Re: Hard Feature Freeze starts now for edk2-stable202005

I create PR https://github.com/tianocore/edk2/pull/644 for this patch. Thanks Liming From: Bret Barkelew Sent: Wednesday, May 27, 2020 6:11 AM To: Laszlo Ersek ; devel@edk2.groups.io; Gao, Liming ; annou...@edk2.groups.io Cc: Leif Lindholm ; af...@apple.com; Kinney, Michael D Subject: Re: [EXT

Re: [edk2-devel] [PATCH 1/1] BaseTools: Turn on Link Time Optimization (LTO) for XCOODE

Andrew, Would you please update the BZ status to IN_PROGRESS? And paste the patch review link to the comments? Reviewed-by: Bob Feng Thanks, Bob -Original Message- From: devel@edk2.groups.io On Behalf Of Andrew Fish via groups.io Sent: Monday, May 25, 2020 10:38 AM To: devel@edk2.gro

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Tue, 05/26/2020 6:30pm-7:30pm #cal-reminder

*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Tuesday, 26 May 2020, 6:30pm to 7:30pm, (GMT-07:00) America/Los Angeles *Where:* https://bluejeans.com/889357567?src=join_info View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=816009 ) *Organizer:* Brian Richardson brian.richar

Re: [edk2-devel] [PATCH v2 01/11] PcAtChipsetPkg: Add MMIO Support to RTC driver

I am interest with the patch, I am busy and may review it after August. > -Original Message- > From: devel@edk2.groups.io On Behalf Of André > Przywara > Sent: Friday, May 15, 2020 6:51 PM > To: Sami Mujawar ; devel@edk2.groups.io > Cc: ard.biesheu...@arm.com; l...@nuviainc.com; Ni, Ray

Re: [edk2-devel] Using debugger to debug UEFI application?

> [...]I just found the Intel UDK debugger and hopping to use it [...] I may be wrong, but I think Intel has put the Intel UDK debugger solution as End-Of-Life. I'm not sure it's worth spending any time using an end-of-life'd debugger solution. I think the main 2 alternatives to the Intel UDK solu

Re: [edk2-devel] [RFC edk2 v1 1/1] MdeModulePkg/Variable: Move FindVariable after AutoUpdateLangVariable

Hi Huangming, I will clarify it when I am free, please be patient. If it is urgent for you, I suggest that you can use your patch temporarily. Any other thing, I check your patch in the mail, it seem that not any change in code, can you double confirm it? Best Regards > -Original Message--

Re: [edk2-devel] Updating to latest EDK2 and now get NMAKE: fatal error U1073: Don't know how to make.. on some items?

Hi David, I saw the below sentence from you. I got the edk2-libc repo from GIT. The edk2 repo I still use svn update to update it. Using tortoise tools on windows. As I know, we not maintain the edk2 in svn from long ago, you can see the svn last update data to confirm it. I suggest that you

Re: [edk2-devel] Using debugger to debug UEFI application?

I will debug the UEFI application without Secure Boot in this case. Any specific reason that force you debug in Secure Boot environment? From you comment, it is need that figure out why hang in ippsEncodeLZ77DynamicHuff_8u function, I am sorry that I have no knowledge about the module and the fu

Re: [edk2-devel] [EXTERNAL] Re: Hard Feature Freeze starts now for edk2-stable202005

I just looked into it, and I think that AsciiStrCpyS() was the wrong function to call in this loop anyway. AsciiStrCpyS() will fail without copying any characters. AsciiStrnCpyS() will perform the string "slicing"/"chunking" that the loop seems to expect. The bug stands and we should try to get

Re: [edk2-devel] [PATCH 0/5] ArmPkg/PlatformBootManagerLib: play nice without ConnectAll()

On Tue, May 26, 2020 at 18:13:54 +0200, Ard Biesheuvel wrote: > Currently, Armpkg's PlatformBootManagerLib connects all controller to > their drivers recursively, even if the active boot option does not > require it. There are some historical reasons for this, some of which are > being addressed in

Re: [edk2-devel] [PATCH v8 34/46] OvmfPkg: Reserve a page in memory for the SEV-ES usage

On 5/26/20 9:28 AM, Tom Lendacky wrote: On 5/25/20 11:00 AM, Laszlo Ersek wrote: On 05/19/20 23:51, Lendacky, Thomas wrote: BZ: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2198&data=02%7C01%7Cthomas.lendacky%40amd.com%7C498df3e8

Re: [edk2-devel] [PATCH 3/5] ArmPkg/PlatformBootManagerLib: hide UEFI Shell as a regular boot option

On Tue, May 26, 2020 at 18:13:57 +0200, Ard Biesheuvel wrote: > Without ConnectAll() being called on the boot path, the UEFI shell will > be entered with no block devices or anything else connected, and so for > the novice user, this is not a very accommodating environment. Now that > we have made

Re: [edk2-devel] [PATCH 2/5] ArmPkg/PlatformBootManagerLib: fall back to the UiApp on boot failure

On Tue, May 26, 2020 at 18:13:56 +0200, Ard Biesheuvel wrote: > As a last resort, drop into the UiApp application when no active boot > options could be started. Doing so will connect all devices, and so > it will allow the user to enter the Boot Manager submenu and pick a > network or removable di

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Silicon/SynQuacer: use correct argument count for _EVT ACPI method

On Mon, May 25, 2020 at 20:24:55 +0200, Ard Biesheuvel wrote: > The _EVT method on the ACPI0013 Generic Event device takes a single > argument. Even though we are not interested in its value (given that > there is only one interrupt source), we still have to declare the > prototype correctly, or th

Re: [edk2-devel] [RFC edk2-platforms v1 3/3] Silicon/Hisilicon: Rename EthMac files

On Thu, May 21, 2020 at 22:43:04 +0800, Ming Huang wrote: > As not only update mac address feature in EthMac files, so rename > them to UpdateDsdt. > > Signed-off-by: Ming Huang > --- > Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatform.c | 2 +- > Silicon/Hisilicon/Drivers/AcpiPlatfo

Re: [edk2-devel] [RFC edk2-platforms v1 2/3] Silicon/Hisilicon/Acpi: Add update sas address feature

On Thu, May 21, 2020 at 22:43:03 +0800, Ming Huang wrote: > The updating sas address feature is similar with apdating mac address. > Modify updating dsdt flow for add this feature. > > Signed-off-by: Ming Huang > --- > Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatform.c | 2 +- > Silicon/

Re: [edk2-devel] [RFC edk2-platforms v1 0/3] Improve D0x

On trying to build the resulting output, I found the build breaks with /work/git/edk2-platforms/Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.c: In function ‘FlashFvbInitialize’: /work/git/edk2-platforms/Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.c:1231:20: error: ‘gEfiEventVirtualAddres

Re: [edk2-devel] [RFC edk2-platforms v1 1/3] Silicon/Hisilicon: Change updating dsdt in ready to boot event

Please call your patches PATCH. RFC is when a potential solution is put up for discussion, not for changing platform code. On Thu, May 21, 2020 at 22:43:02 +0800, Ming Huang wrote: > The better time for updating dsdt is in ready to boot event, > so change the updating time. The commit message sho

Re: [edk2-devel] [PATCH v8 36/46] OvmfPkg/ResetVector: Add support for a 32-bit SEV check

On 5/25/20 11:50 AM, Laszlo Ersek wrote: Tom, On 05/19/20 23:51, Lendacky, Thomas wrote: BZ: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2198&data=02%7C01%7Cthomas.lendacky%40amd.com%7C4fe7191ef9fe43793eb408d800cbbb44%7C3dd8961

Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

Samer, Have you had a chance to review Mike’s PR process? Any thoughts as comparison? - Bret From: devel@edk2.groups.io on behalf of Samer El-Haj-Mahmoud via groups.io Sent: Tuesday, May 26, 2020 7:39:55 AM To: r...@edk2.groups.io ; ler...@redhat.com ; Andrew

[edk2-devel] [PATCH 1/5] ArmPkg/PlatformBootManagerLib: register 's' as UEFI Shell hotkey

In preparation of hiding the UEFI Shell boot option as an ordinary boot option, make sure we can invoke it directly using the 's' hotkey. Without ConnectAll() having been called, this results in a shell that may have no block devices or other things connected, so don't advertise the 's' in the cons

[edk2-devel] [PATCH 5/5] ShellPkg: add BootManager library to add UEFI Shell menu option

Add a plug-in library for UiApp that creates a 'UEFI Shell' menu option at the root level which gives access to a form that allows the UEFI Shell to be launched. This gives the PlatformBootManagerLib implementation of the platform more flexibility in the way it handles boot options pointing to the

[edk2-devel] [PATCH 4/5] ArmPkg/PlatformBootManagerLib: don't connect all devices on each boot

In order to avoid boot delays from devices such as network controllers that may not even be involved in booting at all, drop the call to EfiBootManagerConnectAll () from the boot path. It will be called by UiApp, so when going through the menu, all devices will be connected as usual, but for the de

[edk2-devel] [PATCH 0/5] ArmPkg/PlatformBootManagerLib: play nice without ConnectAll()

Currently, Armpkg's PlatformBootManagerLib connects all controller to their drivers recursively, even if the active boot option does not require it. There are some historical reasons for this, some of which are being addressed in separate patches. This series addresses the way ArmPkg's PlatformBoo

[edk2-devel] [PATCH 3/5] ArmPkg/PlatformBootManagerLib: hide UEFI Shell as a regular boot option

Without ConnectAll() being called on the boot path, the UEFI shell will be entered with no block devices or anything else connected, and so for the novice user, this is not a very accommodating environment. Now that we have made the UiApp the last resort when on boot failure, and made the UEFI Shel

[edk2-devel] [PATCH 2/5] ArmPkg/PlatformBootManagerLib: fall back to the UiApp on boot failure

As a last resort, drop into the UiApp application when no active boot options could be started. Doing so will connect all devices, and so it will allow the user to enter the Boot Manager submenu and pick a network or removable disk option. With the right UiApp library added in, the UiApp also gives

Re: [edk2-devel] [PATCH v8 29/46] OvmfPkg: Create a GHCB page for use during Sec phase

On 5/26/20 10:41 AM, Tom Lendacky wrote: On 5/25/20 10:07 AM, Laszlo Ersek wrote: On 05/19/20 23:50, Lendacky, Thomas wrote: BZ: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2198&data=02%7C01%7Cthomas.lendacky%40amd.com%7C39b71c6

Re: [edk2-devel] [PATCH v8 29/46] OvmfPkg: Create a GHCB page for use during Sec phase

On 5/25/20 10:07 AM, Laszlo Ersek wrote: On 05/19/20 23:50, Lendacky, Thomas wrote: BZ: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2198&data=02%7C01%7Cthomas.lendacky%40amd.com%7C39b71c622d2d4bbf9e5b08d800bd69a5%7C3dd8961fe4884

Re: [edk2-devel] [PATCH v8 26/46] OvmfPkg/VmgExitLib: Add support for DR7 Read/Write NAE events

On 5/25/20 9:47 AM, Laszlo Ersek wrote: On 05/19/20 23:50, Lendacky, Thomas wrote: BZ: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2198&data=02%7C01%7Cthomas.lendacky%40amd.com%7C8d75a8b2107f4def062c08d800ba8795%7C3dd8961fe4884e

Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

I agree with Andrew. I also found Laszlo's "unkempt guide" very useful. In addition, there is a short page by Peter Batard that adds more details on the commits validation, patchset generation, and e-mail submission: https://gist.github.com/pbatard/ec1c9d1dd6e7144b07a09b057b1735a8 > -Origi

Re: [edk2-devel] [PATCH] MdePkg/Include: AARCH64: disable outline atomics on GCC 10.2+

On Sat, May 23, 2020 at 00:09:52 +0200, Ard Biesheuvel wrote: > > > > diff --git a/MdePkg/Include/AArch64/ProcessorBind.h > > > > b/MdePkg/Include/AArch64/ProcessorBind.h > > > > index 896bf273ac7a..a3ca8f09e51c 100644 > > > > --- a/MdePkg/Include/AArch64/ProcessorBind.h > > > > +++ b/MdePkg/Inclu

Re: [edk2-devel] [PATCH v8 34/46] OvmfPkg: Reserve a page in memory for the SEV-ES usage

On 5/25/20 11:00 AM, Laszlo Ersek wrote: On 05/19/20 23:51, Lendacky, Thomas wrote: BZ: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2198&data=02%7C01%7Cthomas.lendacky%40amd.com%7C498df3e8d335449e596508d800c4c955%7C3dd8961fe4884

Re: [edk2-devel] BuildTools Broken

On 05/26/20 15:05, Gao, Liming wrote: > To update Conf, you can type edksetup.bat Reconfig command, and then try > build again. Ah indeed, thank you for the reminder! Laszlo >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of Laszlo Ersek >> Sent: Tuesday, May 26, 2020 8:4

Re: [edk2-devel] [PATCH v8 46/46] Maintainers.txt: Add reviewers for the OvmfPkg SEV-related files

On 05/20/20 18:56, Lendacky, Thomas wrote: > Register reviewers for the SEV-related files in OvmfPkg. > > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Brijesh Singh > Signed-off-by: Tom Lendacky > --- > Maintainers.txt | 10 ++ > 1 file changed

Re: [edk2-devel] [PATCH v8 39/46] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Bypass flash detection with SEV-ES

On 05/19/20 23:51, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > The flash detection routine will attempt to determine how the flash > device behaves (e.g. ROM, RAM, Flash). But when SEV-ES is enabled and > the flash device behaves as a ROM device (meaning i

Re: [edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Tue, 05/26/2020 6:30pm-7:30pm #cal-reminder

The following BZ will be discussed this week Bug Triage meeting. 2725 EDK2 Code michael.d.kin...@intel.com UNCO --- WinHost.exe exits after launching after SEC core. 09:39:26 2767

Re: [edk2-devel] [PATCH v8 37/46] OvmfPkg/Sec: Add #VC exception handling for Sec phase

On 05/19/20 23:51, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > An SEV-ES guest will generate a #VC exception when it encounters a > non-automatic exit (NAE) event. It is expected that the #VC exception > handler will communicate with the hypervisor using t

Re: [edk2-devel] SbsaQemu: Initial support for static ACPI tables

On Mon, May 25, 2020 at 03:44:24AM +0530, Tanmay Jagdale wrote: > Add the following static ACPI tables for the SBSA Qemu platform > - DSDT > - FADT > - GTDT > - MADT Comment below on MADT > - MCFG > - SPCR > > Currently we support 4 CPUs. > > Co-authored-by: Graeme Gregory > Co-aut

Re: [edk2-devel] BuildTools Broken

To update Conf, you can type edksetup.bat Reconfig command, and then try build again. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: Tuesday, May 26, 2020 8:43 PM > To: devel@edk2.groups.io; df7...@gmail.com > Subject: Re: [edk2-devel] BuildTools Brok

Re: [edk2-devel] BuildTools Broken

On 05/25/20 18:55, David F. wrote: > Last night through the forums I sent a problem with NMAKE U1073 trying > to build. Some things built fine, but not others. I think my > original message with all the details is still awaiting moderation. > To follow up on that. I simply renamed BaseTools and

Re: [edk2-devel] [PATCH 3/3] OvmfwPkg: Don't exclude XCODE Modules

On 05/26/20 06:10, Andrew Fish wrote: > > >> On May 25, 2020, at 12:31 PM, Laszlo Ersek wrote: >> >> Hi Andrew, >> >> On 05/24/20 23:20, Andrew Fish via groups.io wrote: >>> With this BZ getting fixed we no longer need to special case XCODE. >>> >>> Cc: Ard Biesheuvel >>> Cc

Re: [edk2-devel] OVMF gdb seems to require "stone knives and bearskins" to debug code?

On 05/26/20 01:14, Andrew Fish wrote: > > >> On May 25, 2020, at 12:15 PM, Laszlo Ersek wrote: >> >> (+Rebecca, +Andrei) >> >> On 05/25/20 05:30, Andrew Fish via groups.io wrote: >>> The full Star Trek quote from Spock is: " I am endeavoring, ma'am, to >>> construct a mnemonic memory circuit u

Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

On 05/25/20 20:28, Andrew Fish wrote: > > >> On May 25, 2020, at 11:10 AM, Laszlo Ersek wrote: >> >> Hi Andrew, >> >> On 05/25/20 06:09, Andrew Fish wrote: >> >>> I also found I had to Bing/Google to find the detailed instructions I >>> needed as a developer, as the Wiki seems to assume you just

Re: [edk2-devel] [edk2][PATCH 1/1] NetworkPkg/HttpBootDxe: handle servers which may FIN after file sizing in HttpBootLoadFile

I wanted to know whether the manual change to Python's http.server I have proposed worked for you. Did it? Patch you have proposed, while being functional, is still a work-around. HttpBootDxe supports HTTP/1.1 with an assumption of TCP connections being persistent. Python HTTP server implement

Re: [edk2-devel] Updating to latest EDK2 and now get NMAKE: fatal error U1073: Don't know how to make.. on some items?

Based on the output, am I correct in assuming that the generated ABCPPSupportLib makefile does not have a rule for making ABCPPSupportLib.obj? Tom From: devel@edk2.groups.io On Behalf Of David F. via groups.io Sent: 25 May 2020 08:56 To: devel@edk2.groups.io Subject: [edk2-devel] Updating to l

Re: [edk2-devel] [PATCH edk2-platforms v2 00/16] Add PCIe Support

On 5/26/20 11:53 AM, Ard Biesheuvel wrote: On 5/26/20 10:37 AM, Wasim Khan wrote: From: Wasim Khan Add PCIe Support for NXP Layerscape SoC which supports different PCIe controllers. Use generic PCIe drivers and wire up PciHostBridgeLib, PciSegmentLib and PciCpuIo2Dxe driver for controller spec

Re: [EXTERNAL] Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

I actually agree with you, when we migrated from reviewboard to github pull requests, I was sorely disappointed with the PR functionality and ergonomics. Tomas Pilar -Original Message- From: r...@edk2.groups.io On Behalf Of Rebecca Cran via groups.io Sent: 14 May 2020 22:47 To: r...@ed

Re: [edk2-devel] [PATCH edk2-platforms v2 00/16] Add PCIe Support

On 5/26/20 10:37 AM, Wasim Khan wrote: From: Wasim Khan Add PCIe Support for NXP Layerscape SoC which supports different PCIe controllers. Use generic PCIe drivers and wire up PciHostBridgeLib, PciSegmentLib and PciCpuIo2Dxe driver for controller specific implementation. V1 Series can be refer

[edk2-devel] [PATCH edk2-platforms v2 01/16] Silicon/NXP/NxpQoriqLs.dec: Add PCIe related PCDs.

From: Wasim Khan Add PCIe related PCDs. Co-authored-by: Vabhav Sharma Co-authored-by: Wasim Khan Signed-off-by: Wasim Khan --- Notes: V2: - Removed Signed-off and added Co-authored-by for co-author - Droped PcdPciDebug Silicon/NXP/NxpQoriqLs.dec | 8 1 file changed, 8

Re: [edk2-devel] [RFC edk2 v1 1/1] MdeModulePkg/Variable: Move FindVariable after AutoUpdateLangVariable

在 2020/5/26 8:39, Jiang, Guomin 写道: > Hi Huangming, > > I am taking the bugzilla and I am sorry that I haven't provide you with > productive comment. > > I am still busy until August. > > I just want to know that: > 1. Have you verified that the symptom will disappear after invoked > FindVa

[edk2-devel] [PATCH edk2-platforms v2 11/16] Silicon/NXP: PciSegmentLib: Add support PCIe LsGen4 Controller

From: Wasim Khan PCIe Layerscape Gen4 controller is not ECAM compliant and have different PCI config space region for bus 0 (Controller space) and bus[0x1-0xff] on NXP SoCs. For config transactions for Bus0: - Config transaction address = PCIe controller address + offset For config transactio

[edk2-devel] [PATCH edk2-platforms v2 12/16] Silicon/NXP: PciSegmentLib: LsGen4Ctrl: Add Workaround for A-011264

From: Wasim Khan With PCIe LsGen4 controller, clearing the Bus Master Enable bit in Command register blocks all outbound transactions to be sent out in RC mode. According to PCI Express base specification, the Command register’s Bus Master Enable bit of a PCI Express RC controller can only contr

[edk2-devel] [PATCH edk2-platforms v2 16/16] Platform/NXP: LS1043aRdbPkg : Increase fv image size

From: Wasim Khan Increase fv image size to pass debug build. Signed-off-by: Wasim Khan Acked-by: Ard Biesheuvel --- Notes: V2: - No change Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/Platform/NXP/LS1043aRdb

[edk2-devel] [PATCH edk2-platforms v2 07/16] Silicon/NXP: PciHostBridgeLib: Dump Layerscale Gen4 ATU windows

From: Wasim Khan Dump ATU windows for PCIe LsGen4 controller. Co-authored-by: Vabhav Sharma Co-authored-by: Wasim Khan Signed-off-by: Wasim Khan --- Notes: V2: - Removed Signed-off and added Co-authored-by for co-author - Drop PcdPciDebug and use DEBUG_CODE_BEGIN/DEBUG_CODE_END

[edk2-devel] [PATCH edk2-platforms v2 06/16] Silicon/NXP: PciHostBridgeLib: add Workaround for A-011451

From: Wasim Khan When PCIe Layerscape Gen4 controller is sending multiple split completions and ACK latency expires indicating that ACK should be send at priority. But because of large number of split completions and FC update DLLP,the controller does not give priority to ACK transmission. This r

[edk2-devel] [PATCH edk2-platforms v2 03/16] Silicon/NXP: Implement PciHostBridgeLib support

From: Wasim Khan Implement PciHostBridgeLib that exposes the PCIe root complexes to the generic PCI host bridge driver. Setup PCIe Layerscape Controller and setup CFG, IO, MMIO and MMIO64 iATU windows. Co-authored-by: Vabhav Sharma Co-authored-by: Wasim Khan Signed-off-by: Wasim Khan --- No

[edk2-devel] [PATCH edk2-platforms v2 00/16] Add PCIe Support

From: Wasim Khan Add PCIe Support for NXP Layerscape SoC which supports different PCIe controllers. Use generic PCIe drivers and wire up PciHostBridgeLib, PciSegmentLib and PciCpuIo2Dxe driver for controller specific implementation. V1 Series can be referred here: https://edk2.groups.io/g/devel/

[edk2-devel] [PATCH edk2-platforms v2 02/16] Silicon/NXP: LS1043A: Define PCIe related PCDs

From: Wasim Khan Define PCIe related PCDs for LS1043A. Co-authored-by: Vabhav Sharma Co-authored-by: Wasim Khan Signed-off-by: Wasim Khan --- Notes: V2: - Removed Signed-off and added Co-authored-by for co-author - Dropped PcdPciDebug Silicon/NXP/LS1043A/LS1043A.dsc.inc | 7 +++

[edk2-devel] [PATCH edk2-platforms v2 09/16] Silicon/NXP: Implement PciSegmentLib for PCIe Layerscape Controller

From: Wasim Khan We have different PCI config space region for bus 0 (Controller space) and bus[0x1-0xff] on NXP SoCs with PCIe LS controller. Add PciSegmentLib for PCIe LS controller. For config transactions for Bus0: - Config transaction address = PCIe controller address + offset For config

[edk2-devel] [PATCH edk2-platforms v2 05/16] Silicon/NXP: PciHostBridgeLib: Setup PCIe LsGen4 Controller and ATU Windows

From: Wasim Khan Setup PCIe LayerscapeGen4 controller and setup CFG, IO, MMIO and MMIO64 iATU windows. Check for PcdPciLsGen4Ctrl to enable LsGen4 PCIe controller. Co-authored-by: Vabhav Sharma Co-authored-by: Wasim Khan Signed-off-by: Wasim Khan --- Notes: V2: - Removed Signed-off a

[edk2-devel] [PATCH edk2-platforms v2 14/16] Platform/NXP: LS1043aRdbPkg: Enable NetworkPkg

From: Meenakshi Aggarwal Enable NetworkPkg for LS1043aRdb Platform. Signed-off-by: Wasim Khan --- Notes: V2: - Change author Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 11 +++ Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 5 + 2 files changed, 16 insertions(+) diff

[edk2-devel] [PATCH edk2-platforms v2 08/16] Silicon/NXP: PciHostBridgeLib: Dump Layerscale iATU windows

From: Wasim Khan Dump ATU windows for PCIe Layerscape controller. Signed-off-by: Wasim Khan --- Notes: V2: - Drop PcdPciDebug and use DEBUG_CODE_BEGIN/DEBUG_CODE_END - Passing Max window number as argument to LsDumpAtu() Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.c | 4

[edk2-devel] [PATCH edk2-platforms v2 13/16] Silicon/NXP/Drivers: Implement PciCpuIo2Dxe Driver

From: Wasim Khan NXP SoC has multiple PCIe RCs and there is no fix translation offset between I/O port accesses and MMIO accesses. Add PciCpuIo2Dxe driver to implement EFI_CPU_IO2_PROTOCOL to add the translation for different RCs for IO access. Signed-off-by: Wasim Khan Reviewed-by: Ard Biesheu

[edk2-devel] [PATCH edk2-platforms v2 10/16] Silicon/NXP: PciSegmentLib: Add ECAM config support for PCIe LS Controller

From: Wasim Khan PCIe Layerscape controller can be enabled for ECAM style configuration access using CFG SHIFT Feature. Check for PcdPciCfgShiftEnable to decide the configuration access scheme to be used with PCIe LS controller. Signed-off-by: Wasim Khan --- Notes: V2: - Addressed rev

[edk2-devel] [PATCH edk2-platforms v2 04/16] Silicon/NXP: PciHostBridgeLib: CFG Shift feature support for PCIeLS Ctrl

From: Wasim Khan PCIe layerscape controller supports CFG Shift feature. It can be enabled by setting BIT[28] of iATU Control 2 Register. Check PcdPciCfgShiftEnable to enable 'CFG Shift feature' in PCIe controller. if enable, PCIe layerscape controller shifts BDF from bits[27:12] to bits[31:16] an

[edk2-devel] [PATCH edk2-platforms v2 15/16] Platform/NXP: LS1043aRdbPkg: Enable PCIE support

From: Wasim Khan Enable generic PCIe drivers and Wire up PciHostBridgeLib, PciSegmentLib and PciCpuIo2Dxe. Signed-off-by: Wasim Khan --- Notes: V2: - No change Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 9 + Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 7 +++ 2 file

Re: [edk2-devel] [PATCH v8 35/46] OvmfPkg/PlatformPei: Reserve SEV-ES work area if S3 is supported

On 05/19/20 23:51, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > Protect the SEV-ES work area memory used by an SEV-ES guest. > > Regarding the lifecycle of the SEV-ES memory area: > PcdSevEsWorkArea > > (a) when and how it is initialized after first boo

[edk2-devel] Using debugger to debug UEFI application?

Hi, I just found the Intel UDK debugger and hopping to use it to debug my UEFI application.  Basically, the function ippsEncodeLZ77DynamicHuff_8u in Intel IPP 7 (tried 7.1 as well) used in my application will hang if secure boot is enabled on most systems (disabled runs fine - someone with vmwa

Re: [edk2-devel] Updating to latest EDK2 and now get NMAKE: fatal error U1073: Don't know how to make.. on some items?

Let me start by what I did to get the build working with the old BaseTools.   I renamed BaseTools and put back the prior BaseTools from Nov 29 2018 (build.exe date).  It started building out of the gate, then hit nasm.inc not found, so digging around end up comparing old and new for things and b