I actually agree with you, when we migrated from reviewboard to github pull requests, I was sorely disappointed with the PR functionality and ergonomics.
Tomas Pilar -----Original Message----- From: r...@edk2.groups.io <r...@edk2.groups.io> On Behalf Of Rebecca Cran via groups.io Sent: 14 May 2020 22:47 To: r...@edk2.groups.io; bret.barke...@microsoft.com; Kinney, Michael D <michael.d.kin...@intel.com>; devel@edk2.groups.io; ler...@redhat.com Subject: Re: [EXTERNAL] Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process On 5/14/20 3:26 PM, Bret Barkelew via groups.io wrote: > I feel like this process is a good compromise. It�s not perfect (frankly, > I�m a fan of enforced squash merges, which can maintain bisectability if > managed well), but it allows for rapid iteration, ease of contribution, and > approaches the workflow that many who have never used email to maintain a > project would be familiar with. > > It�s code management for the Instagram generation, and I for one welcome > our new insect overlords. Or at least, that's what Microsoft is betting on! :D Personally, I remain unconvinced about the usability of Github Pull Requests for a project the size of EDK2, but I hope to be proven wrong. -- Rebecca Cran IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#60264): https://edk2.groups.io/g/devel/message/60264 Mute This Topic: https://groups.io/mt/74144675/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
