[edk2-devel] [PATCH v2 07/12] SecurityPkg: Allow VariablePolicy state to delete authenticated variables

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 Causes AuthService to check IsVariablePolicyEnabled() before enforcing write protections to allow variable deletion when policy engine is disabled. Only allows deletion, not modification. Cc: Jiewen Yao Cc: Jian J Wang C

[edk2-devel] [PATCH v2 09/12] MdeModulePkg: Drop VarLock from RuntimeDxe variable driver

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 Now that everything should be moved to VariablePolicy, drop support for the deprecated VarLock SMI interface and associated functions from variable RuntimeDxe. Cc: Jian J Wang Cc: Hao A Wu Cc: Liming Gao Signed-off-by: M

[edk2-devel] [PATCH v2 11/12] OvmfPkg: Add VariablePolicy engine to OvmfPkg platform

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Michael Kubacki --- OvmfPkg/OvmfPkgIa32.dsc| 8 OvmfPkg/OvmfPkgIa32X64.dsc | 8 OvmfPkg/OvmfPkgX64.dsc | 8 3 files

[edk2-devel] [PATCH v2 00/12] Add the VariablePolicy feature

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2522 The 12 patches in this series add the VariablePolicy feature to the core, deprecate Edk2VarLock (while adding a compatibility layer to reduce code churn), and integrate the VariablePolicy libraries and protocols into V

[edk2-devel] [PATCH v2 12/12] EmulatorPkg: Add VariablePolicy engine to EmulatorPkg platform

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Michael Kubacki --- EmulatorPkg/EmulatorPkg.dsc | 6 ++ 1 file changed, 6 insertions(+) diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg

[edk2-devel] [PATCH v2 04/12] MdeModulePkg: Define the VarCheckPolicyLib and SMM interface

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 VariablePolicy is an updated interface to replace VarLock and VarCheckProtocol. This is an instance of a VarCheckLib that is backed by the VariablePolicyLib business logic. It also publishes the SMM calling interface for me

[edk2-devel] [PATCH v2 06/12] MdeModulePkg: Allow VariablePolicy state to delete protected variables

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 TcgMorLockSmm provides special protections for the TCG MOR variables. This will check IsVariablePolicyEnabled() before enforcing them to allow variable deletion when policy engine is disabled. Only allows deletion, not modi

[edk2-devel] [PATCH v2 01/12] MdeModulePkg: Define the VariablePolicy protocol interface

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 VariablePolicy is an updated interface to replace VarLock and VarCheckProtocol. Add the VariablePolicy protocol interface header and add to the MdeModulePkg.dec file. Cc: Jian J Wang Cc: Hao A Wu Cc: Liming Gao Signed-o

[edk2-devel] [PATCH v2 10/12] MdeModulePkg: Add a shell-based functional test for VariablePolicy

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 To verify that VariablePolicy is correctly integrated on platforms, add a Shell-based functional test to confirm expected behavior. NOTE: This test assumes that VariablePolicy is built with PcdAllowVariablePolicyEnforcement

[edk2-devel] [PATCH v2 03/12] MdeModulePkg: Define the VariablePolicyHelperLib

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 VariablePolicy is an updated interface to replace VarLock and VarCheckProtocol. Add the VariablePolicyHelperLib library, containing several functions to help with the repetitive process of creating a correctly structured an

[edk2-devel] [PATCH v2 05/12] MdeModulePkg: Connect VariablePolicy business logic to VariableServices

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 VariablePolicy is an updated interface to replace VarLock and VarCheckProtocol. Add connective code to publish the VariablePolicy protocol and wire it to either the SMM communication interface or directly into the VariableP

[edk2-devel] [PATCH v2 02/12] MdeModulePkg: Define the VariablePolicyLib

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 VariablePolicy is an updated interface to replace VarLock and VarCheckProtocol. Add the VariablePolicyLib library that implements the portable business logic for the VariablePolicy engine. Also add host-based CI test cases

[edk2-devel] [PATCH v2 08/12] MdeModulePkg: Change TCG MOR variables to use VariablePolicy

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 These were previously using VarLock, which is being deprecated. Cc: Jian J Wang Cc: Hao A Wu Cc: Liming Gao Signed-off-by: Michael Kubacki --- MdeModulePkg/Universal/Variable/RuntimeDxe/TcgMorLockDxe.c | 52 +

[edk2-devel] [PATCH v2] Add Features/Intel/OutOfBandManagement/SpcrFeaturePkg.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2710 It is used to support the Serial Port Console Redirection Table (SPCR). Signed-off-by: Ming Tan --- v2: Add the EFIAPI for function GetSpcrDevice() in Include/Library/SpcrDeviceLib.h and Library/SpcrDeviceLibNull/SpcrDeviceLibNull.c. .

Re: [edk2-devel] [PATCH] PcAtChipsetPkg: Wrong System YEAR displayed in SETUP

I am ok if you change the PCD default value to [2020, 2119]. Please send out separate patch for the PCD default value change if you want. Thanks, Ray > -Original Message- > From: Yau, KaiX > Sent: Tuesday, May 12, 2020 10:02 AM > To: Ni, Ray ; devel@edk2.groups.io; kai...@gmail.com > Cc

Re: [edk2-devel] [PATCH V3 5/5] MdeModulePkg: Add FMP Capsule Image Header extension

Hi Oleksiy, Thanks a lot for the update. But besides it, there are several other places need to be updated as well: https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c#L99 https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Library/DxeCapsuleLibF

Re: [edk2-devel] [PATCH] PcAtChipsetPkg: Wrong System YEAR displayed in SETUP

The PCD range (100 years) assumes that: there is no such a x86 system that can use a bios flashed in year 1998 and this system will be functional till 2097. Or even it can be functional till 2097, its bios should be flashed multiple times during the 100 years. I don't think we need to consider t

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Wed, 05/13/2020 9:30am-10:30am #cal-reminder

*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Wednesday, 13 May 2020, 9:30am to 10:30am, (GMT+08:00) Asia/Chongqing *Where:* https://bluejeans.com/889357567?src=join_info View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=805105 ) *Organizer:* Brian Richardson brian.richard.

Re: [edk2-devel] [PATCH v5 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid

Oleksiy: Seemly, this patch doesn't response to my comment. Is there the comments to be added for new field DeviceTypeGuid? Can its value be NULL? And, are MdeModulePkg\Universal\SerialDxe and MdeModulePkg\Bus\Pci\PciSioSerialDxe required to be updated together? Thanks Liming -Original M

Re: [edk2-devel] [PATCH V4 14/27] IntelFsp2Pkg: Add support for DebugCommonLib

Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Vitaly > Cheptsov > Sent: Monday, May 11, 2020 11:41 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH V4 14/27] IntelFsp2Pkg: Add support for > DebugCommonLib > > REF: https://bugzilla.

Re: [edk2-devel] [PATCH V4 15/27] IntelFsp2WrapperPkg: Add support for DebugCommonLib

Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Vitaly > Cheptsov > Sent: Monday, May 11, 2020 11:41 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH V4 15/27] IntelFsp2WrapperPkg: Add support > for DebugCommonLib > > REF: https://b

Re: [edk2-devel] [platform/devel-riscvplatforms PATCHv1 0/2] New RISC-V patches

> -Original Message- > From: Leif Lindholm [mailto:l...@nuviainc.com] > Sent: Tuesday, May 12, 2020 1:39 AM > To: Schaefer, Daniel (DualStudy) > Cc: devel@edk2.groups.io; Chen, Gilbert ; Chang, > Abner (HPS SW/FW Technologist) ; Michael D > Kinney > Subject: Re: [platform/devel-riscvpl

Re: [edk2-devel] [PATCH v5 3/7] MdePkg: REST style formset

One minor comment is to correct the style file path. With this change, Reviewed-by: Liming Gao + ## Include\Guid\HiiPlatformSetupFormset.h ==> Include/Guid/HiiPlatformSetupFormset.h + gEfiHiiResetStyleFormsetGuid = { 0x790217bd, 0xbecf, 0x485b, { 0x91, 0x70, 0x5f, 0xf7, 0x11, 0x31, 0x8b

Re: [edk2-devel] [PATCH edk2-platforms v4 0/9] BCM genet fixes

Hi, Well it looks like you fixed the tx map/unmap issue I noticed yesterday on discord as well as a couple other things that were discussed. So with the fix 2/9, Reviewed-by: Jeremy Linton Thanks, On 5/11/20 9:55 AM, Ard Biesheuvel wrote: This fixes the multicast/broadcast/promisc handli

Re: [edk2-devel] [platform/devel-riscvplatforms PATCHv1 2/2] ProcessorPkg/Library: Add EDK2 RISC-V OpenSBI library.

On Mon, May 11, 2020 at 19:20:15 +0200, Daniel Schaefer wrote: > EDK2 RISC-V OpenSBI library which pull in external source files under > RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi to the build process. > > Signed-off-by: Daniel Schaefer > Co-authored-by: Abner Chang > Co-authored-by: Gi

Re: [edk2-devel] [PATCH V4 00/27] Disabling safe string constraint assertions

Vitaly, Thank you for the contribution. There are a couple points about this approach that need to be discussed. You have included the from MdePkg/Include/Library/DebugLib.h. It is very rare for a lib class to include another lib class. This means that a module that has a dependency on the

Re: [edk2-devel] [PATCH V4 26/27] MdePkg: Introduce assertion on constraint debug mask bit

On 05/11/20 22:58, Laszlo Ersek wrote: > On 05/11/20 17:41, Vitaly Cheptsov wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 >> >> This bit allows to control assertion on constrain violation. (1) Ugh, sorry, my point (1) was going to be about out two instances of the same typo:

Re: [EXTERNAL] Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

On 05/11/20 22:09, Bret Barkelew wrote: > As a counterpoint: if we force a new branch or force push on every tweak, we > lose the “thread� of discussion on what caused the change, This is a github.com limitation. And the email archive mitigates it. In the current process, when I review v2 o

Re: [edk2-devel] Where to put the bhyve code in the edk2 repo: BhyvePkg, or under OvmfPkg?

On May 11, 2020, at 3:22 PM, Michael D Kinney wrote: > > Hi Laszlo, > > Is there an option for Bhyve to live in an edk2-platforms branch > or in edk2-staging branch until it meets the quality criteria for > OvmfPkg in the edk2 repo? Also, what is the quality criteria? I’d be interested in wor

[edk2-devel] [PATCH V3 1/5] MdePkg: Add new CPER Notification types

Add SEA, SEI, and PEI CPER Notification types defined in UEFI 2.8 errata a. (UEFI 2.8 errata a, mantis 2026) Signed-off-by: Oleksiy Yakovlev Reviewed-by: Liming Gao --- MdePkg/Include/Guid/Cper.h | 15 +++ MdePkg/MdePkg.dec | 9 + 2 files changed, 24 insertions(+)

[edk2-devel] [PATCH V3 0/5] Add definitions introduced in UEFI 2.8a

Following patches add/update structures/definitions, that were introduced/modified by UEFI Spec v.2.8 errata a from Feb 14. Oleksiy Yakovlev (5): MdePkg: Add new CPER Notification types MdePkg: Fix OUT parameters marked as IN OUT MdePkg: Add EFI_RT_PROPERTIES_TABLE MdePkg: Add FMP Capsule

[edk2-devel] [PATCH V3 2/5] MdePkg: Fix OUT parameters marked as IN OUT

Some OUT parameters in the specification were mistakenly marked as IN OUT. "IN OUT" replaced with "OUT" in the following interfaces EFI_BOOT_SERVICES.GetMemoryMap():MemoryMap EFI_BOOT_SERVICES.LocateHandleBuffer():NoHandles EFI_SIMPLE_POINTER_PROTOCOL.GetState():State EFI_ABSOLUTE_POINTER_PROTOCOL

[edk2-devel] [PATCH V3 4/5] MdePkg: Add FMP Capsule Image Header extension

Add bitmask to structure which gives a binary-inspectable mechanism to determine if a capsule contains an authentication section or depex section. (UEFI 2.8 errata a, mantis 2026) Signed-off-by: Oleksiy Yakovlev Reviewed-by: Liming Gao --- MdePkg/Include/Guid/FmpCapsule.h | 11 ++- 1 f

[edk2-devel] [PATCH V3 5/5] MdeModulePkg: Add FMP Capsule Image Header extension

Add bitmask to structure which gives a binary-inspectable mechanism to determine if a capsule contains an authentication section or depex section. (UEFI 2.8 errata a, mantis 2026) Signed-off-by: Oleksiy Yakovlev --- MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 4 +++- 1 file changed,

[edk2-devel] [PATCH V3 3/5] MdePkg: Add EFI_RT_PROPERTIES_TABLE

Define Guid & data structure for EFI_RT_PROPERTIES_TABLE, designed to be published by a platform if it no longer supports all EFI runtime services once ExitBootServices() has been called by the OS. (UEFI 2.8 errata a, mantis 2049) Signed-off-by: Oleksiy Yakovlev --- MdePkg/Include/Guid/RtPropert

Re: [edk2-devel] Help with Logo Display Problems

On 05/11/20 20:04, jim slaughter wrote: > Hello, > > Yes BootLogoEnableLogo() appears in several files and is not commented out. > > Files: > PlatformBm.c > BdsPlatform.c > BootLogoLib.c > BootLogoLib.h > PlatformBm.c That doesn't answer my question. Does the PlatformBootManagerLib instance th

Re: [edk2-devel] Where to put the bhyve code in the edk2 repo: BhyvePkg, or under OvmfPkg?

Hi Laszlo, Is there an option for Bhyve to live in an edk2-platforms branch or in edk2-staging branch until it meets the quality criteria for OvmfPkg in the edk2 repo? Mike > -Original Message- > From: Laszlo Ersek > Sent: Monday, May 11, 2020 2:12 PM > To: Kinney, Michael D ; Ard > Bie

Re: [edk2-devel] [PATCH edk2-platforms v4 2/9] Silicon/Broadcom/BcmGenetDxe: add support for broadcast filtering

On 5/11/20 10:34 PM, Jeremy Linton wrote: Hi, On 5/11/20 9:55 AM, Ard Biesheuvel wrote: Add a helper to configure the first MDF filter for filtering the broadcast Ethernet address. Signed-off-by: Ard Biesheuvel ---   Silicon/Broadcom/Drivers/Net/BcmGenetDxe/GenetUtil.h |  7 +   Silicon/Br

Re: [edk2-devel] [PATCH edk2-platforms v4 1/9] Silicon/Broadcom/BcmGenetDxe: whitespace/cosmetic cleanup

On 5/11/20 4:55 PM, Ard Biesheuvel wrote: Signed-off-by: Ard Biesheuvel --- Silicon/Broadcom/Drivers/Net/BcmGenetDxe/BcmGenetDxe.inf | 2 + Silicon/Broadcom/Drivers/Net/BcmGenetDxe/GenetUtil.h | 38 +- Silicon/Broadcom/Drivers/Net/BcmGenetDxe/DriverBinding.c | 19 +- Silicon/Broadco

Re: [edk2-devel] [PATCH edk2-platforms v4 7/9] Silicon/Broadcom/BcmGenetDxe: use MemoryFence() for MMIO write ordering

On 5/11/20 4:55 PM, Ard Biesheuvel wrote: ARM synchronization barriers can be used to stall execution and wait for cache or TLB maintenance to complete. TLB maintenance is irrelevant in the context of the GENET driver, but cache maintenance is important for non-cache coherent DMA, and synchroniza

Re: [edk2-devel] Where to put the bhyve code in the edk2 repo: BhyvePkg, or under OvmfPkg?

On 05/11/20 18:36, Kinney, Michael D wrote: > I agree that ArmVirtPkg contents should be added to OvmfPkg. I guess "OvmfPkg/Secondary/Bhyve" would be a compromise. (I would actually prefer "Staging" to "Secondary", according to the following definition: https://git.kernel.org/pub/scm/linux/kern

Re: [edk2-devel] [PATCH V4 27/27] MdePkg: Use assertion on constraint violation bit in SafeString

On 05/11/20 17:41, Vitaly Cheptsov wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 > > This change allows using SafeString interfaces for untrusted data > checking when constraint violation assertions are disabled. > > Signed-off-by: Vitaly Cheptsov > --- > MdePkg/Include/Libr

Re: [edk2-devel] [PATCH V4 26/27] MdePkg: Introduce assertion on constraint debug mask bit

On 05/11/20 17:41, Vitaly Cheptsov wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 > > This bit allows to control assertion on constrain violation. > > Signed-off-by: Vitaly Cheptsov > --- > MdePkg/Include/Library/DebugCommonLib.h| 18 ++ > MdePkg/I

Re: [edk2-devel] [PATCH V4 24/27] UefiCpuPkg: Add support for DebugCommonLib

On 05/11/20 17:41, Vitaly Cheptsov wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 > > Signed-off-by: Vitaly Cheptsov > --- > UefiCpuPkg/UefiCpuPkg.dsc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc > index d28cb5

Re: [edk2-devel] [PATCH V4 16/27] OvmfPkg: Add support for DebugCommonLib

On 05/11/20 17:41, Vitaly Cheptsov wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 > > Signed-off-by: Vitaly Cheptsov > --- > OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c| 98 > > OvmfPkg/Library/PlatformDebugLibIoPort/PlatformRomD

Re: [edk2-devel] [PATCH V4 01/27] MdePkg: Introduce DebugCommonLib interface and BaseDebugCommonLib

ah, one superficial comment: On 05/11/20 17:40, Vitaly Cheptsov wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 > > This library allows to make a common part of all DebugLib instances > and avoid the need to update every DebugLib on extending a new debug > mask PCD bit. > > Sig

Re: [edk2-devel] [PATCH V4 07/27] ArmVirtPkg: Add support for DebugCommonLib

On 05/11/20 17:41, Vitaly Cheptsov wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 > > Signed-off-by: Vitaly Cheptsov > --- > ArmVirtPkg/ArmVirt.dsc.inc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index cf4

Re: [edk2-devel] [PATCH V4 01/27] MdePkg: Introduce DebugCommonLib interface and BaseDebugCommonLib

On 05/11/20 17:40, Vitaly Cheptsov wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 > > This library allows to make a common part of all DebugLib instances > and avoid the need to update every DebugLib on extending a new debug > mask PCD bit. > > Signed-off-by: Vitaly Cheptsov >

Re: [edk2-devel] [PATCH edk2-platforms v4 2/9] Silicon/Broadcom/BcmGenetDxe: add support for broadcast filtering

Hi, On 5/11/20 9:55 AM, Ard Biesheuvel wrote: Add a helper to configure the first MDF filter for filtering the broadcast Ethernet address. Signed-off-by: Ard Biesheuvel --- Silicon/Broadcom/Drivers/Net/BcmGenetDxe/GenetUtil.h | 7 + Silicon/Broadcom/Drivers/Net/BcmGenetDxe/GenetUtil.c

[edk2-devel] [PATCH v2 5/5] MdePkg: Update structures for MpServices Protocol

From: Robert Phelps Added EXTENDED_PROCESSOR_INFORMATION structure and supporting structures and definitions. The intent is to support updated topology layout for CPUs. (PI 1.7a Mantis 2071) Signed-off-by: Robert Phelps Reviewed-by: Ray Ni --- MdePkg/Include/Protocol/MpService.h | 50 ++

[edk2-devel] [PATCH v2 3/5] MdePkg: EFI_MM_COMUNICATION2_PROTOCOL

From: Robert Phelps Created a new header to support the new EFI_MM_COMMUNICATION2_PROTOCOL Protocol as defined in the PI 1.7a Specification (PI 1.7a Mantis 1993) Signed-off-by: Robert Phelps Reviewed-by: Zhiguang Liu --- MdePkg/Include/Protocol/MmCommunication2.h | 72 ++

[edk2-devel] [PATCH v2 4/5] MdePkg: Added header file for Delayed Dispatch PPI

From: Robert Phelps Created new header file for the new EFI_DELAYED_DISPATCH_PPI PPI (PI 1.7 Mantis 1891) Signed-off-by: Robert Phelps Reviewed-by: Zhiguang Liu --- MdePkg/Include/Ppi/DelayedDispatch.h | 85 MdePkg/MdePkg.dec| 3 + 2 files ch

[edk2-devel] [PATCH v2 0/5] Add Definitions introduced in PI 1.7 and PI 1.7a

From: Robert Phelps The following patches add and update the current structures and definitions that were introduced by the PI 1.7 and PI 1.7a specifications Signed-off-by: Robert Phelps Robert Phelps (5): MdePkg: New Status Codes MdePkg: Updates to PI 1.7 Revision numbers for PEI and DXE

[edk2-devel] [PATCH v2 1/5] MdePkg: New Status Codes

From: Robert Phelps Updated PiStatusCodes to reflect changes to PI 1.7 Specification (PI 1.7 Mantis 1889) Signed-off-by: Robert Phelps Reviewed-by: Zhiguang Liu --- MdePkg/Include/Pi/PiStatusCode.h | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/MdePkg/I

[edk2-devel] [PATCH v2 2/5] MdePkg: Updates to PI 1.7 Revision numbers for

From: Robert Phelps Revision number defines and MACROs were incorrect for the current version of the Specification (PI 1.7 Mantis 1892) Signed-off-by: Robert Phelps Reviewed-by: Zhiguang Liu --- MdePkg/Include/Pi/PiDxeCis.h | 4 ++-- MdePkg/Include/Pi/PiPeiCis.h | 4 ++-- 2 files changed, 4 i

[edk2-devel] [PATCH v5 5/7] MdePkg: Bootable NVDIMM namespaces

Provided a mechanism for UEFI FW to identify and hand off bootable NVDIMM namespaces to the OS by standardizing the EFI device path. EFI device path for physical NVDIMM devices changed from an ACPI _ADR device to an ACPI NVDIMM device for correctness. (UEFI 2.8 mantis 1858) Signed-off-by: Oleksiy

[edk2-devel] [PATCH v5 2/7] BaseTools: REST style formset

In question level, a new flag EFI_IFR_FLAG_REST_STYLE is defined. (UEFI 2.8 mantis 1853) Signed-off-by: Oleksiy Yakovlev Reviewed-by: Liming Gao --- BaseTools/Source/C/Include/Common/UefiInternalFormRepresentation.h | 1 + 1 file changed, 1 insertion(+) diff --git a/BaseTools/Source/C/Includ

[edk2-devel] [PATCH v5 7/7] MdePkg: UEFI JSON Capsule Support

Added Guids and structures, that defines the work flow to perform capsule update using JSON objects. (UEFI 2.8 mantis 1935) Signed-off-by: Oleksiy Yakovlev --- MdePkg/Include/Guid/CapsuleReport.h | 29 +++ MdePkg/Include/Guid/JsonCapsule.h | 97 + Md

[edk2-devel] [PATCH v5 3/7] MdePkg: REST style formset

New ClassGuid EFI_HII_REST_STYLE_FORMSET_GUID is defined. In question level, a new flag EFI_IFR_FLAG_REST_STYLE is defined. (UEFI 2.8 mantis 1853) Signed-off-by: Oleksiy Yakovlev --- MdePkg/Include/Guid/HiiPlatformSetupFormset.h| 4 MdePkg/Include/Uefi/UefiInternalFormRepresentation

[edk2-devel] [PATCH v5 0/7] Add definitions introduced in UEFI 2.8

Following patches add/update structures/definitions, that was introduced/modified by UEFI Spec v.2.8. Oleksiy Yakovlev (7): MdePkg: Extend SERIAL_IO with DeviceTypeGuid BaseTools: REST style formset MdePkg: REST style formset BaseTools: Bootable NVDIMM namespaces MdePkg: Bootable NVDI

[edk2-devel] [PATCH v5 6/7] MdePkg: Add UEFI Spec Revision 2.8

Added entrie in the EFI_SYSTEM_TABLE related definitions section, to signify UEFI 2.8 spec revision. (UEFI 2.8 mantis 1926) Signed-off-by: Oleksiy Yakovlev Reviewed-by: Liming Gao --- MdePkg/Include/Uefi/UefiSpec.h | 1 + 1 file changed, 1 insertion(+) diff --git a/MdePkg/Include/Uefi/UefiSpe

[edk2-devel] [PATCH v5 4/7] BaseTools: Bootable NVDIMM namespaces

Provided a mechanism for UEFI FW to identify and hand off bootable NVDIMM namespaces to the OS by standardizing the EFI device path. EFI device path for physical NVDIMM devices changed from an ACPI _ADR device to an ACPI NVDIMM device for correctness. (UEFI 2.8 mantis 1858) Signed-off-by: Oleksiy

[edk2-devel] [PATCH v5 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid

EFI_SERIAL_IO_PROTOCOL_REVISION incremented to 0x00010001. CONST EFI_GUID *DeviceTypeGuid field added to the protocol structure. UEFI 2.8 mantis 1832. Signed-off-by: Oleksiy Yakovlev Reviewed-by: Liming Gao --- MdePkg/Include/Protocol/SerialIo.h | 3 ++- 1 file changed, 2 insertions(+), 1 dele

Re: [EXTERNAL] Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

As a counterpoint: if we force a new branch or force push on every tweak, we lose the “thread” of discussion on what caused the change, what changed as a result, and the easy hook for the original change requester to reply directly to the change as is. - Bret From: Laszlo Ersek via groups.io

Re: [edk2-devel] [PATCH v3 0/3] XCODE5 toolchain binary patching fix

On 05/07/20 15:06, Lendacky, Thomas wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2340 > > Commit 2db0ccc2d7fe ("UefiCpuPkg: Update CpuExceptionHandlerLib pass > XCODE5 tool chain") introduced binary patching in the > ExceptionHandlerAsm.nasm in order to support the XCODE5 toolcha

Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

On 05/11/20 03:37, Michael D Kinney wrote: > There was feedback from Laszlo related to rebase for > pull requests using the current CI process. To clarify, I don't think we should allow any github-side automatism to auto-rebase pull requests. I think such rebases need to occur on personal develop

Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

On 05/10/20 23:43, Rebecca Cran wrote: > Mike, > > On 5/10/20 3:29 PM, Michael D Kinney wrote: > >> There is no difference between CI checks run during code review >> and the final CI checks before merge.  I think it is an interesting >> conversation to decide how many times those CI checks shoul

Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

On 05/10/20 23:29, Michael D Kinney wrote: > Rebecca, > > There is no difference between CI checks run during code review > and the final CI checks before merge. I think it is an interesting > conversation to decide how many times those CI checks should be > run and if they should run automatica

Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

On 05/09/20 06:22, Ni, Ray wrote: > Mike, > It's a huge improvement to me as an Outlook user if pull-request-based review > is enabled! > > Please help me to understand: The pull-request-based review has been enabled > naturally when edk2 > was migrated to Github. People don't use it because it'

Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

On 05/09/20 04:59, Michael D Kinney wrote: > Hello, > > This is a proposal to change from the current email-based code review process > to > a GitHub pull request-based code review process for all repositories > maintained > in TianoCore. The current email-based code review process and commit m

[edk2-devel] [PATCH V4 05/11] CryptoPkg/OpensslLib: Set ARC4 disable in OpensslLib

From: Zhiguang Liu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 This patch is create by adding the setting "no_rc4" of process_files.pl and running it thru perl. It would remove the ARC4 from OpensslLib. Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Siyuan Fu Cc: Michael D Kinney Cc: Jiewen

[edk2-devel] [PATCH V4 10/11] CryptoPkg/BaseCryptLib: Retire HMAC SHA1 algorithm

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 HMAC SHA1 is not secure any longer. Remove the HMAC SHA1 support from edk2. Change the HMAC SHA1 field name in EDKII_CRYPTO_PROTOCOL to indicate the function is unsupported any longer. Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Siyuan Fu Cc: Mich

[edk2-devel] [PATCH V4 11/11] CryptoPkg/Crypto.h: Update the version of Crypto Driver

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 The binary is totally changed, so update the Crypto Version to 7: 1. Retire below deprecated function: MD4, ARC4, TDES, AES ECB MODE, HMAC MD5, HMAC SHA1 Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Siyuan Fu Cc: Michael D Kinney Cc: Jiewen Yao C

[edk2-devel] [PATCH V4 04/11] CryptoPkg/BaseCryptLib: Retire ARC4 algorithm

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 ARC4 is not secure any longer. Remove the ARC4 support from edk2. Change the ARC4 field name in EDKII_CRYPTO_PROTOCOL to indicate the function is unsupported any longer. Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Siyuan Fu Cc: Michael D Kinney C

Re: [edk2-devel] Help with Logo Display Problems

Jim, Sorry wrote this yesterday and did not hit send All my example are from OVMF using QEMU on a Mac. You should be able to run OVMF too as a way to learn things. > On May 9, 2020, at 8:00 PM, jim slaughter > wrote: > > Hello, > > I have followed previous directions provided and the

[edk2-devel] [PATCH V4 08/11] CryptoPkg/BaseCryptLib: Retire Aes Ecb mode algorithm

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 Aes Ecb mode is not secure any longer. Remove the Aes Ecb mode support from edk2. Change the Aes Ecb mode field name in EDKII_CRYPTO_PROTOCOL to indicate the function is unsupported any longer. Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Siyuan Fu

[edk2-devel] [PATCH V4 06/11] CryptoPkg/BaseCryptLib: Retire the TDES algorithm

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 TDES is not secure any longer. Remove the Tdes support from edk2. Change the Tdes field name in EDKII_CRYPTO_PROTOCOL to indicate the function is unsupported any longer. Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Siyuan Fu Cc: Michael D Kinney C

[edk2-devel] [PATCH V4 07/11] CryptoPkg/OpensslLib: Set TDES disable in OpensslLib

From: Zhiguang Liu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 This patch is create by adding the setting "no_des" of process_files.pl and running it thru perl. It would remove the TDES from OpensslLib. Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Siyuan Fu Cc: Michael D Kinney Cc: Jiewen

[edk2-devel] [PATCH V4 09/11] CryptoPkg/BaseCryptLib: Retire HMAC MD5 algorithm

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 HMAC MD5 is not secure any longer. Remove the HMAC MD5 support from edk2. Change the HMAC MD5 field name in EDKII_CRYPTO_PROTOCOL to indicate the function is unsupported any longer. Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Siyuan Fu Cc: Michael

[edk2-devel] [PATCH V4 02/11] CryptoPkg/BaseCrpytLib: Retire MD4 algorithm

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 MD4 is not secure any longer. Remove the MD4 support from edk2. Change the MD4 field name in EDKII_CRYPTO_PROTOCOL to indicate the function is unsupported any longer. Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Siyuan Fu Cc: Michael D Kinney Cc:

[edk2-devel] [PATCH V4 00/11] CryptoPkg: Retire the deprecated functions

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 Retire below deprecated functions: MD4, ARC4, TDES, AES ECB MODE, HMAC MD5, HMAC SHA1. V2: Seprate the MD5 and SHA1 changes to other patch set. Change the deprecated function wrapper implementatuion in EDKII_CRYPTO_PROTOCOL to call a dummy

[edk2-devel] [PATCH V4 01/11] CryptoPkg/CryptoDxe: Add function to indicate the deprecated algorithm

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 Add a internal worker function to indicate the deprecated functions. It would print out debug messages and asserts to inform the consumer they are using a deprecated function. Change the Name of BaseCryptLibServciceNotEnabled to correct spel

[edk2-devel] [PATCH V4 03/11] CryptoPkg/OpensslLib: Set MD4 disable in OpensslLib

From: Zhiguang Liu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 This patch is create by adding the setting "no_md4" of process_files.pl and running it thru perl. It would remove the MD4 from OpensslLib. Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Siyuan Fu Cc: Michael D Kinney Cc: Jiewen

Re: [edk2-devel] Help with Logo Display Problems

Hello, Yes BootLogoEnableLogo() appears in several files and is not commented out. Files: PlatformBm.c BdsPlatform.c BootLogoLib.c BootLogoLib.h PlatformBm.c Jim Slaughter ; On Mon, May 11, 2020 at 12:12 PM jim slaughter via groups.io wrote: > Hello, > > I do not know. Will look into this. >

[edk2-devel] [PATCH v2 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

Introduce an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/https servers. HTTP download speed is usually faster than tftp. The client is based on the same approach as tftp dynamic command, and uses the same UEFI Shell command line parameters. This makes it easy

Re: [edk2-devel] [platform/devel-riscvplatforms PATCHv1 0/2] New RISC-V patches

On Mon, May 11, 2020 at 19:20:13 +0200, Daniel Schaefer wrote: > We have moved most of our RISC-V implementation to edk2-platforms now, only > the > absolute minimum is in edk2, already merged. > All other patches going into edk2-platforms have already been merged, these > are new. Please be exp

Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

Hi Ray, Comments below. Mike > -Original Message- > From: Ni, Ray > Sent: Friday, May 8, 2020 9:23 PM > To: r...@edk2.groups.io; Kinney, Michael D > ; devel@edk2.groups.io > Subject: RE: [edk2-rfc] GitHub Pull Request based Code > Review Process > > Mike, > It's a huge improvement to m

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add the manifest-repos command

Hi Nate, A V2 patchset has been sent please see an additional comment below regarding your feedback. Thanks, Ashley -Original Message- From: Desimone, Nathaniel L Sent: Sunday, May 10, 2020 11:45 PM To: Desimone, Ashley E ; devel@edk2.groups.io Cc: Pandya, Puja ; Bjorge, Erik C ; Bre

Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

Hello, I have added the following repository to TianoCore to support the evaluation of the GitHub pull request based code review process and the email archive webbook. This is a copy of tianocore/edk2 repo as of May 10, 2020. https://github.com/tianocore/edk2-codereview I have updated

[edk2-devel] [platform/devel-riscvplatforms PATCHv1 1/2] ProcessorPkg/RiscVOpensbLlib: Add submodule opensbi

Add submodule opensbi under Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbLlib. The current supported opensbi version for RISC-V edk2 port is tags/v0.6. Signed-off-by: Daniel Schaefer Co-authored-by: Gilbert Chen Co-authored-by: Abner Chang Cc: Leif Lindholm Cc: Gilbert Chen Cc: Michael D K

[edk2-devel] [platform/devel-riscvplatforms PATCHv1 0/2] New RISC-V patches

We have moved most of our RISC-V implementation to edk2-platforms now, only the absolute minimum is in edk2, already merged. All other patches going into edk2-platforms have already been merged, these are new. The first adds opensbi as a submodule. We wanted to have it reviewed because it would b

[edk2-devel] [platform/devel-riscvplatforms PATCHv1 2/2] ProcessorPkg/Library: Add EDK2 RISC-V OpenSBI library.

EDK2 RISC-V OpenSBI library which pull in external source files under RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi to the build process. Signed-off-by: Daniel Schaefer Co-authored-by: Abner Chang Co-authored-by: Gilbert Chen Reviewed-by: Leif Lindholm Cc: Leif Lindholm Cc: Gilbert Che

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V2] EdkRepo: Add the manifest-repos command

Add the manifest_repos_command to list, add, or remove manifest repositories in the ekdrepo_user.cfg Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Cc: Prince Agyeman --- edkrepo/commands/arguments/manifest_repo_args.py | 22 + edkr

Re: [edk2-devel] Help with Logo Display Problems

Hello, I do not know. Will look into this. Is this call, BootLogoEnableLogo(), normally in the code? I have not added any code in this area. Jim S. ; On Mon, May 11, 2020 at 11:41 AM Laszlo Ersek wrote: > On 05/10/20 05:00, jim slaughter wrote: > > Hello, > > > > I have followed previous d

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RPi: add Gpio output set/clear functions to GpioLib

I was going to have a patch to support power-off using an alternate mechanism (not PSCI, but via GPIO for the https://raspberrypiwiki.com/index.php/X735 hat. Ultimately, I decided against complicating UEFI - an OS isn't required to use UEFI RT today over PSCI (OpenBSD didn't), the memory map bec

Re: [edk2-devel] Problems using Block Io protocol in a CSM (worked in UDK2014.SP1, no longer works on master)

On 05/09/20 04:59, Rebecca Cran wrote: > I'm working to update a CSM (for bhyve) from UDK2014.SP1 to the latest > master. I've already fixed several problems, but one I'm stuck on now is > that while the code previously had no problem finding Block Io protocol > via gBS->LocateHandleBuffer(ByProtoc

Re: [edk2-devel] [PATCH edk2-platforms v4 7/9] Silicon/Broadcom/BcmGenetDxe: use MemoryFence() for MMIO write ordering

Reviewed-by: Andrei Warkentin From: devel@edk2.groups.io on behalf of Ard Biesheuvel via groups.io Sent: Monday, May 11, 2020 9:55 AM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Pete Batard ; Jared McNeill ; Andrei Warkentin ; Samer El-Haj-Mahmoud ; Jeremy

Re: [edk2-devel] [PATCH edk2-platforms v4 4/9] Silicon/Broadcom/BcmGenetDxe: avoid uncached memory for streaming DMA

On 5/11/20 6:42 PM, Andrei Warkentin wrote: Is 1500 the max MTU that UEFI uses? Wasn't clear from the spec. Otherwise looks good - esp optimizing the allocations instead of wasting half page on every alloc 🙂. LGTM Reviewed-by: Andrei Warkentin Thanks. I couldn't disentangle that mess ei

Re: [edk2-devel] [PATCH edk2-platforms v4 2/9] Silicon/Broadcom/BcmGenetDxe: add support for broadcast filtering

Reviewed-by: Andrei Warkentin From: Ard Biesheuvel Sent: Monday, May 11, 2020 9:55 AM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Pete Batard ; Jared McNeill ; Andrei Warkentin ; Samer El-Haj-Mahmoud ; Jeremy Linton Subject: [PATCH edk2-platforms v4 2/9] Si

Re: [edk2-devel] [PATCH edk2-platforms v4 4/9] Silicon/Broadcom/BcmGenetDxe: avoid uncached memory for streaming DMA

Is 1500 the max MTU that UEFI uses? Wasn't clear from the spec. Otherwise looks good - esp optimizing the allocations instead of wasting half page on every alloc 🙂. LGTM Reviewed-by: Andrei Warkentin From: Ard Biesheuvel Sent: Monday, May 11, 2020 9:55 AM To:

  1   2   >