Hi,
Well it looks like you fixed the tx map/unmap issue I noticed yesterday
on discord as well as a couple other things that were discussed.
So with the fix 2/9,
Reviewed-by: Jeremy Linton <jeremy.lin...@arm.com>
Thanks,
On 5/11/20 9:55 AM, Ard Biesheuvel wrote:
This fixes the multicast/broadcast/promisc handling, and switches to
ordinary page allocations for RX buffers. Patch #1 is cosmetic only.
Note that these apply on top of the series sent out by Samer, and is
intended to be squashed into that series before merging.
Changes since v3:
- more cosmetic tweaks in #1
- move DmaUnmap() for TX buffers to the correct place
- use MemoryFence() instead of DSB for MMIO write ordering
- add unload support to the driver
- remove the Ax88772b driver from the RPi4 build - it is no longer needed,
and misbehaves when no cable is connected.
Changes since v2:
- fix MDF filter handling (fixes issue reported by Samer)
- add patch to deal with ExitBootServices() so we don't leave the RX DMA
ring running when we enter the OS
https://github.com/pftf/edk2-platforms/tree/rpi4_genet_v4_ardb
Cc: Pete Batard <p...@akeo.ie>
Cc: Jared McNeill <jmcne...@invisible.ca>
Cc: Andrei Warkentin <awarken...@vmware.com>
Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahm...@arm.com>
Cc: Jeremy Linton <jeremy.lin...@arm.com>
Ard Biesheuvel (9):
Silicon/Broadcom/BcmGenetDxe: whitespace/cosmetic cleanup
Silicon/Broadcom/BcmGenetDxe: add support for broadcast filtering
Silicon/Broadcom/BcmGenetDxe: fix multicast/broadcast handling
Silicon/Broadcom/BcmGenetDxe: avoid uncached memory for streaming DMA
Silicon/Broadcom/BcmGenetDxe: shut down devices on ExitBootServices()
Silicon/Broadcom/BcmGenetDxe: keep TX buffer mapped during DMA
transfer
Silicon/Broadcom/BcmGenetDxe: use MemoryFence() for MMIO write
ordering
Silicon/Broadcom/BcmGenetDxe: add unload support
Platform/RaspberryPi4: remove ASIX 88772b driver
Platform/RaspberryPi/RPi4/RPi4.dsc | 1 -
Platform/RaspberryPi/RPi4/RPi4.fdf | 1 -
.../Drivers/Net/BcmGenetDxe/BcmGenetDxe.inf | 13 +-
.../Drivers/Net/BcmGenetDxe/GenetUtil.h | 51 +-
.../Drivers/Net/BcmGenetDxe/DriverBinding.c | 122 ++-
.../Drivers/Net/BcmGenetDxe/GenericPhy.c | 16 +-
.../Drivers/Net/BcmGenetDxe/GenetUtil.c | 787 +++++++++---------
.../Drivers/Net/BcmGenetDxe/SimpleNetwork.c | 115 ++-
8 files changed, 621 insertions(+), 485 deletions(-)
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#59222): https://edk2.groups.io/g/devel/message/59222
Mute This Topic: https://groups.io/mt/74137442/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
