Re: [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg: Add library header files

Hi Ray, Chaganty, Could you please help review the change. Best Regards guomin > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guomin > Jiang > Sent: Tuesday, March 24, 2020 2:37 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > > Subject: [edk2-devel]

Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg/PersistenceLib: Correct the allocated size.

Reviewed-by: Sean Brogan -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57054): https://edk2.groups.io/g/devel/message/57054 Mute This Topic: https://groups.io/mt/72670002/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https:

Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.

Guomin, Can you speak to why you implemented differently than the suggested and validated patch?  Seems you created a local whereas ours just used the internal data member. Thanks sean -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57

[edk2-devel] [PATCH v1 1/1] NetworkPkg/Ip6Dxe: Validate source data record length

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2273 Ip6ConfigReadConfigData() reads configuration data from a UEFI variable and copies the data to another buffer. This change checks that the length of the data record being copied does not exceed the size of the source U

Re: [edk2-devel] [PATCH] SecurityPkg/MeasureBootLib: Return EFI_ACCESS_DENIED after image check fail

Hi Jiewen, Jiang, Chao, Could you help review the change. Best Regards Guomin > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guomin > Jiang > Sent: Wednesday, April 1, 2020 9:11 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J > ; Zhang, Chao B > Subject:

Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.

Hi Kinney, Sean, Bret, Could you help review the change. Best Regards guomin > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guomin > Jiang > Sent: Tuesday, March 31, 2020 2:50 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Sean Brogan > ; Bret Barkelew > > Subj

Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg/PersistenceLib: Correct the allocated size.

Hi Kinney, Sean, Bret, Could you help review the change? Best Regards Guomin > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guomin > Jiang > Sent: Tuesday, March 31, 2020 11:06 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Sean Brogan > ; Bret Barkelew > > Sub

[edk2-devel] [PATCH V2] BaseTools:Add the spare space FV image size checker

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2654 If FV is placed in FD region, its FV image size is fixed. When FV image size exceeds it, it will trig the build break. To alert the developer to adjust FV image size earlier, I request to add new checker for the the spare FV space. When the s

Re: [edk2-devel] Basetools fail without error message due to PCD type differs in architecture.

AH! Okay. I would agree that a build crash without an actionable error is something we want to fix. - Bret From: Lin, Derek (HPS SW) Sent: Tuesday, April 7, 2020 7:40 PM To: devel@edk2.groups.io; Bret Barkelew

Re: [edk2-devel] Basetools fail without error message due to PCD type differs in architecture.

Hi Bret, Thanks for your feedback. I'm very sorry that I didn't describe it clearly. The Basetools just "crash" in the configuration. The Basetools crash without any information, then build stops. I've looked into the BaseTools code, the python code crash, during the generation of PCD database

Re: [edk2-devel] [PATCH v1 1/2] SecurityPkg: Add PCD for SW SMI Command port

Reviewed-by: Guomin Jiang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Tuesday, April 7, 2020 2:34 AM > To: devel@edk2.groups.io > Cc: Kun Qin ; Wang, Jian J > ; Yao, Jiewen ; Zhang, > Chao B > Subject: [edk2-devel] [PATCH v1 1/2] SecurityPkg:

Re: [edk2-devel] [PATCH v1 2/2] SecurityPkg Tcg: Use SW SMI IO port PCD in Tpm.asl

Reviewed-by: Guomin Jiang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Tuesday, April 7, 2020 2:34 AM > To: devel@edk2.groups.io > Cc: Kun Qin ; Wang, Jian J > ; Yao, Jiewen ; Zhang, > Chao B > Subject: [edk2-devel] [PATCH v1 2/2] SecurityPkg

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Wed, 04/08/2020 9:30am-10:30am #cal-reminder

*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Wednesday, 8 April 2020, 9:30am to 10:30am, (GMT+08:00) Asia/Chongqing *Where:* https://zoom.com.cn/j/493235016 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=758251 ) *Organizer:* Brian Richardson brian.richard...@intel.com

[edk2-devel] [PATCH 1/2] .mailmap: update description to account for job changes

Signed-off-by: Eugene Cohen --- .mailmap | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.mailmap b/.mailmap index ae179b0886c7..80ae7ba62e2f 100644 --- a/.mailmap +++ b/.mailmap @@ -1,8 +1,7 @@ # -# This list is used by git-shortlog to fix a few botched name translati

[edk2-devel] [PATCH 0/2] .mailmap: Update description and my email address

In addition to fixing messed up names, mailmap can be used to record legitimate email address changes due to change of employers. Update the description in the mailmap comments section accordingly and then add a new entry for me reflecting my NUVIA email address. Signed-off-by: Eugene Cohen Eug

[edk2-devel] [PATCH 2/2] .mailmap: add entry for Eugene Cohen reflecting email change

Signed-off-by: Eugene Cohen --- .mailmap | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.mailmap b/.mailmap index 80ae7ba62e2f..ba246ff6cd80 100644 --- a/.mailmap +++ b/.mailmap @@ -22,6 +22,8 @@ Eric Dong Eric Dong Eric Dong Eric Dong Erik Bjorge +Eugene Cohen +Eugene Cohen

Re: [EXTERNAL] [edk2-devel] [PATCH v1 2/2] SecurityPkg Tcg: Use SW SMI IO port PCD in Tpm.asl

Reviewed-by: Bret Barkelew - Bret From: devel@edk2.groups.io on behalf of Michael Kubacki via groups.io Sent: Monday, April 6, 2020 11:34:22 AM To: devel@edk2.groups.io Cc: Kun Qin ; Jian J Wang ; Jiewen Yao ; Chao Zhang Subject: [EXTERNAL] [edk2-devel] [PA

Re: [EXTERNAL] [edk2-devel] [PATCH v1 1/2] SecurityPkg: Add PCD for SW SMI Command port

Reviewed-by: Bret Barkelew - Bret From: devel@edk2.groups.io on behalf of Michael Kubacki via groups.io Sent: Monday, April 6, 2020 11:34:21 AM To: devel@edk2.groups.io Cc: Kun Qin ; Jian J Wang ; Jiewen Yao ; Chao Zhang Subject: [EXTERNAL] [edk2-devel] [PA

Re: [EXTERNAL] [edk2-devel] [PATCH 3/7] MdePkg: REST style formset

Thanks for pointing out. Will update. Regards, Oleksiy. From: Bret Barkelew [mailto:bret.barke...@microsoft.com] Sent: Tuesday, April 07, 2020 6:13 PM To: Oleksiy Yakovlev; devel@edk2.groups.io Cc: bob.c.f...@intel.com; liming@intel.com; Kinney, Michael D; Felix Polyudov Subject: RE: [EXTERN

Re: [EXTERNAL] [edk2-devel] [PATCH 3/7] MdePkg: REST style formset

The other patch had a typo in the subject. This one has: extern EFI_GUID gEfiHiiUserCredentialFormsetGuid; +extern EFI_GUID gEfiHiiResetStyleFormsetGuid; Based on the name of the #DEFINE, I’m guessing this should be “gEfiHiiRestStyleFormsetGuid”, not “…Reset…”. - Bret From: Oleksiy Yakovlev<

Re: [EXTERNAL] [edk2-devel] [PATCH 3/7] MdePkg: REST style formset

Hi Bret. Can you be more specific? I do not see any typos in Subject field. Regards, Oleksiy. From: Bret Barkelew [mailto:bret.barke...@microsoft.com] Sent: Tuesday, April 07, 2020 5:50 PM To: devel@edk2.groups.io; Oleksiy Yakovlev Cc: bob.c.f...@intel.com; liming@intel.com; Kinney, Michael

Re: [EXTERNAL] [edk2-devel] [PATCH 3/7] MdePkg: REST style formset

Typo here. - Bret From: Oleksiy Yakovlev via groups.io Sent: Friday, April 3, 2020 1:35 PM To: devel@edk2.groups.io Cc: bob.c.f...@intel.com; liming@intel.com; Kinney, Mi

Re: [EXTERNAL] [edk2-devel] [PATCH 0/7] Add defenitions introduced in UEFI 2.8

Typo in the email subject. - Bret From: devel@edk2.groups.io on behalf of Oleksiy Yakovlev via groups.io Sent: Friday, April 3, 2020 1:22:31 PM To: devel@edk2.groups.io Cc: bob.c.f...@intel.com ; liming@intel.com ; Kinney, Michael D ; fel...@ami.com ; ol

Re: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] BaseTools: Remove deprecated Visual Studio Option

Reviewed-by: Bret Barkelew - Bret From: devel@edk2.groups.io on behalf of Sami Mujawar via groups.io Sent: Friday, April 3, 2020 11:05:47 AM To: devel@edk2.groups.io Cc: Sami Mujawar ; bob.c.f...@intel.com ; liming@intel.com ; l...@nuviainc.com ; matteo

Re: [EXTERNAL] [edk2-devel] Basetools fail without error message due to PCD type differs in architecture.

This seems like a legitimate configuration. I don’t know that it should be considered an error. A warning, maybe. This is also what the build report is perfect for finding. Did you check the PCD build report when debugging? - Bret From: Lin, Derek (HPS SW) via groups.io

Re: [EXTERNAL] [edk2-devel] [PATCH] BaseTools/WindowsVsToolChain.py: Update toolchain plugin

Reviewed-by: Bret Barkelew - Bret From: devel@edk2.groups.io on behalf of Zhang, Shenglei via groups.io Sent: Monday, April 6, 2020 11:47:37 PM To: devel@edk2.groups.io Cc: Bob Feng ; Liming Gao Subject: [EXTERNAL] [edk2-devel] [PATCH] BaseTools/WindowsVsToo

Re: [edk2-devel] [PATCH] .azurepiplines/pr-gate-steps.yml: Update python to 3.8.x for ci build

Reviewed-by: Bret Barkelew - Bret From: Gao, Liming Sent: Tuesday, April 7, 2020 12:52:35 AM To: devel@edk2.groups.io ; Zhang, Shenglei Cc: Sean Brogan ; Bret Barkelew ; Kinney, Michael D Subject: [EXTERNAL] RE: [edk2-devel] [PATCH] .azurepiplines/pr-gate-st

Re: [edk2-devel] [PATCH] pip-requirements.txt: Update extensions min version to 0.13.3

Reviewed-by: Bret Barkelew - Bret From: devel@edk2.groups.io on behalf of Liming Gao via groups.io Sent: Tuesday, April 7, 2020 12:52:24 AM To: devel@edk2.groups.io ; Zhang, Shenglei Cc: Sean Brogan ; Bret Barkelew ; Kinney, Michael D Subject: [EXTERNAL] Re: [edk2-devel] [PATCH] pip-requ

Re: [edk2-devel] [PATCH v2 21/28] Slicon/NXP: Add PlatformPei Lib

> OK, taking another look at this patch, this simply needs to be > deleted. Here is the sum total relevant difference compared to the > ArmPlatformPkg one. > > DEBUG ((DEBUG_INIT, "Edk2 version is %a\n", XPRINT > (WORKSPACE_GIT_VERSION))); > DEBUG ((DEBUG_INIT, "Edk2 platforms version is %a\n"

Re: [edk2-devel] [PATCH] EmulatorPkg: Add MagicPageLib header file declaration.

Reviewed-by: Ray Ni > -Original Message- > From: Jiang, Guomin > Sent: Tuesday, April 7, 2020 5:49 PM > To: devel@edk2.groups.io > Cc: Justen, Jordan L ; Andrew Fish > ; Ni, Ray > Subject: [PATCH] EmulatorPkg: Add MagicPageLib header file declaration. > > REF: https://bugzilla.tianoco

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

On 04/06/20 12:11, Ard Biesheuvel wrote: > On 4/5/20 8:39 AM, Sean via groups.io wrote: >> Platform and Core CI patches are ready for review.  I have 14 commits >> here. >> https://github.com/spbrogan/edk2/tree/PlatformAndCoreCIForOvmfArmVirtEmulatorPackages >> >> >> This adds support for "Platform

Re: [edk2-devel] [PATCH v2 23/28] NXP/LS1043aRdbPkg/ArmPlatformLib: Use Allocate pool

+Ard On Mon, Apr 06, 2020 at 15:26:45 +, Pankaj Bansal (OSS) wrote: > > -Original Message- > > From: Leif Lindholm > > Sent: Wednesday, April 1, 2020 11:34 PM > > To: Pankaj Bansal (OSS) > > Cc: Meenakshi Aggarwal ; Michael D Kinney > > ; devel@edk2.groups.io; Varun Sethi > > ; Samer

Re: [edk2-devel] [PATCH v2 21/28] Slicon/NXP: Add PlatformPei Lib

OK, taking another look at this patch, this simply needs to be deleted. Here is the sum total relevant difference compared to the ArmPlatformPkg one. DEBUG ((DEBUG_INIT, "Edk2 version is %a\n", XPRINT (WORKSPACE_GIT_VERSION))); DEBUG ((DEBUG_INIT, "Edk2 platforms version is %a\n", XPRINT (PAC

Re: [edk2-devel] [PATCH] OvmfPkg: supply missing lib class declarations in the DEC file

On 4/7/20 12:05 PM, Laszlo Ersek wrote: List the header files in the OvmfPkg DEC file for the following lib classes: - MemEncryptSevLib (one instance: BaseMemEncryptSevLib) - PlatformFvbLib (two instances: EmuVariableFvbLib, PlatformFvbLibNull) - VirtioLib (one instance: VirtioLib) - VirtioMm

Re: [edk2-devel] [PATCH] OvmfPkg: supply missing lib class declarations in the DEC file

On 4/7/20 12:05 PM, Laszlo Ersek wrote: List the header files in the OvmfPkg DEC file for the following lib classes: - MemEncryptSevLib (one instance: BaseMemEncryptSevLib) - PlatformFvbLib (two instances: EmuVariableFvbLib, PlatformFvbLibNull) - VirtioLib (one instance: VirtioLib) - VirtioMm

[edk2-devel] [PATCH] OvmfPkg: supply missing lib class declarations in the DEC file

List the header files in the OvmfPkg DEC file for the following lib classes: - MemEncryptSevLib (one instance: BaseMemEncryptSevLib) - PlatformFvbLib (two instances: EmuVariableFvbLib, PlatformFvbLibNull) - VirtioLib (one instance: VirtioLib) - VirtioMmioDeviceLib (one instance: VirtioMmioDevic

[edk2-devel] [PATCH] EmulatorPkg: Add MagicPageLib header file declaration.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2663 Add the public header file declaration. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Guomin Jiang --- EmulatorPkg/EmulatorPkg.dec | 1 + 1 file changed, 1 insertion(+) diff --git a/EmulatorPkg/EmulatorPkg.dec b/Emulator

Re: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table

On 4/7/20 9:27 AM, Wang, Jian J via groups.io wrote: Ard, My apologies. I was indeed working desperately to catch some deadlines recently. I agree to remove the properties table. For the whole series, Reviewed-by: Jian J Wang Thanks all. Merged into edk2/master. -=-=-=-=-=-=-=-=-=-=-=- G

Re: [edk2-devel] [EXT] Re: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock Transfer Limit 65535 in R/W.

Hi Leif, Gaurav, The changes look good to me, but I haven't tested it on Intel's SoCFPGA platform. I will need some time to test it as I'm working on some other tasks, maybe in a week or so. Thanks > -Original Message- > From: Gaurav Jain > Sent: Tuesday, April 7, 2020 3:02 PM > To:

Re: [edk2-devel] [PATCH] pip-requirements.txt: Update extensions min version to 0.13.3

Reviewed-by: Liming Gao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Zhang, Shenglei > Sent: Tuesday, April 7, 2020 2:48 PM > To: devel@edk2.groups.io > Cc: Sean Brogan ; Bret Barkelew > ; Kinney, Michael D > ; Gao, Liming > Subject: [edk2-devel] [PATCH] pip-requireme

Re: [edk2-devel] [PATCH] .azurepiplines/pr-gate-steps.yml: Update python to 3.8.x for ci build

Reviewed-by: Liming Gao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Zhang, Shenglei > Sent: Tuesday, April 7, 2020 2:48 PM > To: devel@edk2.groups.io > Cc: Sean Brogan ; Bret Barkelew > ; Kinney, Michael D > ; Gao, Liming > Subject: [edk2-devel] [PATCH] .azurepipline

Re: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table

Ard, My apologies. I was indeed working desperately to catch some deadlines recently. I agree to remove the properties table. For the whole series, Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Ard Biesheuvel > Sent: Monday, April 06, 2020 7:42 PM > To: Bi, Dan

Re: [edk2-devel] [EXT] Re: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock Transfer Limit 65535 in R/W.

> -Original Message- > From: Ard Biesheuvel > Sent: Monday, April 6, 2020 7:42 PM > To: Leif Lindholm ; Gaurav Jain > Cc: devel@edk2.groups.io; Pankaj Bansal ; > Haojian Zhuang ; Loh, Tien Hock > > Subject: [EXT] Re: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock > Transfer Limit 65535