> OK, taking another look at this patch, this simply needs to be > deleted. Here is the sum total relevant difference compared to the > ArmPlatformPkg one. > > DEBUG ((DEBUG_INIT, "Edk2 version is %a\n", XPRINT > (WORKSPACE_GIT_VERSION))); > DEBUG ((DEBUG_INIT, "Edk2 platforms version is %a\n", XPRINT > (PACKAGES_PATH_GIT_VERSION))); > > If all you want to do is to print that sort of thing, please don't > fork a core library to do so.
Not just the commit info. The plan is to print core/cluster info also from this peim. As I have already stated in PATCH 10/28, that some print information would be put into common code instead of SOC specific code. In fact the further plan is to fixup device tree in this library before DXE phase starts. So, this fork is needed. > > First of all, please do like most other platforms and override > gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString > if -D FIRMWARE_VER is specified on your build command line. > > You can then extract current top commits of your respective > repositories and not worry about getting this. > I would suggest iterating across all locations in PACKAGES_PATH and > then doing something similar to > https://git.linaro.org/uefi/uefi-tools.git/tree/edk2-build.sh#n400 > appending together. > OK, I can use this for printing git commit info. > If something like this should be integrated into the build system > (which might not be a bad idea), then it needs to be so properly, > rather than shoehorned in for each platform. I agree. Actually IMO, best place would be python script to do this. I don't have much experience with python script. That is why I made changes in shell script. > (In the past, this was difficult because we supported both git and > svn, but I would say we have given up pretending that is possible.) > > For now, you could add the printout in a standalone Depex TRUE PEIM > added to your [FV.FVMAIN_COMPACT]. As I said, that version print is just one of the many things that we wish to do in platform PEIM. > > / > Leif > > On Mon, Apr 06, 2020 at 14:53:02 +0000, Pankaj Bansal (OSS) wrote: -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57027): https://edk2.groups.io/g/devel/message/57027 Mute This Topic: https://groups.io/mt/72077454/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
