Re: [edk2-devel] [PATCH 1/1] ShellPkg: Add support for input with separately reported modifiers

Hi Micheal Rothman, Can you help to review this issue? Because of the uefi spec issue, some firmware implemented the different behavior. Should the edk2 code to handle such issue? If yes, here maybe the situation: 1. Change for all apps -> uefi spec update and accept such behavior with de

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Allow pin file to be checked out when combo is not in project manifest

Reviewed-by: Nate DeSimone -Original Message- From: Desimone, Ashley E Sent: Tuesday, March 31, 2020 5:51 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Allow pi

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 0/7] Adding support for archiving branch combos

Erik, Please remember to Cc: the reviewers on the cover letter as well next time. For the series... Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Bjorge, Erik C Sent: Tuesday, March 31, 2020 3:42 PM To: devel@edk2.groups.io Subject: [edk2-devel]

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Improve state tracking when checking out pin files

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Desimone, Ashley E Sent: Tuesday, March 31, 2020 2:00 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-devel] [

[edk2-devel] Query about VS2012

Hi All, We have a build failure with VS2012(https://bugzilla.tianocore.org/show_bug.cgi?id=2631). If no body uses VS2012, I would like to ignore this issue. I send this mail to collect information whether you are using VS2012. Thanks, Shenglei -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You recei

Re: [edk2-devel] [PATCH] NetworkPkg/Ip6Dxe: Fix ASSERT logic in Ip6ProcessRouterAdvertise()

With Laszlo's comments. Reviewed-by: Siyuan Fu > -Original Message- > From: Laszlo Ersek > Sent: 2020年4月1日 20:02 > To: Maciej Rabeda ; devel@edk2.groups.io > Cc: Wu, Jiaxin ; Fu, Siyuan > Subject: Re: [PATCH] NetworkPkg/Ip6Dxe: Fix ASSERT logic in > Ip6ProcessRouterAdvertise() > > Hi M

Re: [edk2-devel] [PATCH v6 00/42] SEV-ES guest support

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Lendacky, Thomas > Sent: Thursday, April 2, 2020 4:42 AM > To: Dong, Eric ; devel@edk2.groups.io > Cc: Justen, Jordan L ; Laszlo Ersek > ; Ard Biesheuvel ; Kinney, > Michael D ; Gao, Liming > ;

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V1 0/3] EdkRepo: Command completion in bash/zsh

This patch series adds command completions (also referred to as [TAB] completions) to EdkRepo. It also adds the currently checked out branch combination to the command prompt. This is a significant quality of life improvement for EdkRepo's users. The bash and zsh shells are supported. The reason w

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V1 1/3] EdkRepo: Generate command completion scripts

Adds code to edkrepo_cli.py to generate a bash/zsh compatible command completion script. Add a new command_completion_edkrepo.py script which is callable by the shell when needed for dynamic completion data. For example, providing completion for "edkrepo checkout" requires the shell to know the li

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V1 3/3] EdkRepo: Add command completion setup to Windows installer

Add configuration of command completion scripts to the Windows installer. This enables edkrepo command completions to work "out of box" on Git for Windows by adding the edkrepo command completions scripts to the Git for Windows /etc/profile.d directory Cc: Ashley DeSimone Cc: Puja Pandya Cc: Eri

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V1 2/3] EdkRepo: Add command completion setup to install.py

Add configuration of command completion scripts to install.py This enables edkrepo command completions to work "out of box" on most Linux systems by appending to the user's .bashrc and .zshrc startup scripts inclusion of the EdkRepo command completion scripts. Cc: Ashley DeSimone Cc: Puja Pandya

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 7/7] EdkRepo: Update List Repos for archived combos

Reviewed-by: Ashley DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Bjorge, Erik C Sent: Tuesday, March 31, 2020 3:42 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-devel] [edk2-staging/EdkRepo]

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 6/7] EdkRepo: Update clone for archived combos

Reviewed-by: Ashley DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Bjorge, Erik C Sent: Tuesday, March 31, 2020 3:42 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-devel] [edk2-staging/EdkRepo]

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 5/7] EdkRepo: Update Checkout Pin for archived combos

Reviewed-by: Ashley DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Bjorge, Erik C Sent: Tuesday, March 31, 2020 3:42 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-devel] [edk2-staging/EdkRepo]

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 4/7] EdkRepo: Update Sync for archived combos

Reviewed-by: Ashley DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Bjorge, Erik C Sent: Tuesday, March 31, 2020 3:42 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-devel] [edk2-staging/EdkRepo]

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 3/7] EdkRepo: Update Checkout for archived combos

Reviewed-by: Ashley DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Bjorge, Erik C Sent: Tuesday, March 31, 2020 3:42 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-devel] [edk2-staging/EdkRepo]

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 2/7] EdkRepo: Added ability to display archived combinations

Reviewed-by: Ashley DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Bjorge, Erik C Sent: Tuesday, March 31, 2020 3:42 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-devel] [edk2-staging/EdkRepo]

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 1/7] EdkRepo: Adding support for archiving combos

Reviewed-by: Ashley DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Bjorge, Erik C Sent: Tuesday, March 31, 2020 3:42 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-devel] [edk2-staging/EdkRepo]

Re: [edk2-devel] [PATCH v2 00/28] Add PEI phase to LS1043ARDB Platform

Hi Pankaj, I have now finished my review of individual patches. Beyond that, the build fails at the patch 10/28 "Silicon/NXP: remove print information from Soc lib" with the error edk2-platforms/Silicon/NXP/Library/SocLib/Chassis.c:209:1: error: ‘CpuMaskNext’ defined but not used [-Werror=unused-

Re: [edk2-devel] [PATCH v6 00/42] SEV-ES guest support

On 3/30/20 7:47 PM, Dong, Eric wrote: Hi Tom, Sorry for late response. It’s a huge patch, please give me two more weeks to detail review them. I have rough go through these patches and have some basic comments for them now: 1.It’s better to spit patch if changes files not in same package.

Re: [edk2-devel] [PATCH v2 27/28] Silicon/NXP: move MemoryInitPeiLib as per PEIM structures

On Fri, Mar 20, 2020 at 20:05:42 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > MemoryInitPeiLib would be linked to MemoryInitPeim, when we implement > PEI phase. therefore, move the library to directory of same name. > > Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm > --- >

Re: [edk2-devel] [PATCH v2 26/28] Platform/NXP/LS1043aRdbPkg: Add VarStore

On Fri, Mar 20, 2020 at 20:05:41 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > Add VarStore Fd. This Fd is used to store non volatile variables in > flash. > > Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm > --- > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 3 +- > Pla

Re: [edk2-devel] [PATCH v2 25/28] Platform/NXP: Modify FV rules

Please make the subject contain information. / Leif On Fri, Mar 20, 2020 at 20:05:40 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > Use same FV rules as ArmVirtPkg/ArmVirtRules.fdf.inc > > Signed-off-by: Pankaj Bansal > --- > Platform/NXP/FVRules.fdf.inc | 59 +

Re: [edk2-devel] [PATCH v2 24/28] NXP/LS1043aRdbPkg/ArmPlatformLib: Remove extern SocInit

On Fri, Mar 20, 2020 at 20:05:39 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > SocInit can be defined in SocLib.h > No need to make it extern in ArmPlatformLib > > Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm But do please move it as early as possible in the series. > ---

Re: [edk2-devel] [PATCH v2 23/28] NXP/LS1043aRdbPkg/ArmPlatformLib: Use Allocate pool

On Fri, Mar 20, 2020 at 20:05:38 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > Allocate Pages may allocate more memory than required for > VirtualMemoryTable. > There is no special requirement that VirtualMemoryTable size should be > page size aligned. > > Therefore, replace AllocatePage

Re: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table

On Mon, 30 Mar 2020 at 19:57, Ard Biesheuvel wrote: > > (adding Jian and Hao) > > Thanks for the acks, and apologies for failing to cc the MdeModulePkg > maintainers. > > Jian, Hao, do you have any opinion on this series? > Jian, Hao, Liming, Michael, It is not always clear to me how you at Inte

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

Hi Ard, I think adding a dependency in the module entry point libs is also good way to guarantee an intrinsic lib is available. I agree that it can provide module type and arch specific mappings. The NULL lib instance can do the same if the NULL instance is listed in the module/arch specific li

Re: [edk2-devel] [PATCH v1 1/1] INF Spec: Add file dependency to [Sources] syntax

Hi Pierre, We discussed this in the bug scrub yesterday. We think there may be a simpler way to address this issue without extending the INF syntax. It is our understanding that the ASL files need to be processed before C files when both are present in an INF. This is similar to the requirement

Re: [edk2-devel] [PATCH v2 22/28] NXP/LS1043aRdbPkg/ArmPlatformLib: Use default ArmPlatformHelper.S

On Fri, Mar 20, 2020 at 20:05:37 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > Default ArmPlatformHelper.S from ArmPlatformPkg is suffecient for > LS1043ARDB ArmPlatformLib. Use the same. The commit message could be clarified to to explicitly state that ArmPlatformHelper.S is being repla

Re: [edk2-devel] [PATCH v2 21/28] Slicon/NXP: Add PlatformPei Lib

On Fri, Mar 20, 2020 at 20:05:36 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > PlatformPeiLib is going to be linked to Platform PEIM. > > Signed-off-by: Pankaj Bansal > --- > .../Library/PlatformPeiLib/PlatformPeiLib.c | 30 ++ > .../Library/PlatformPeiLib/PlatformPeiLib.

Re: [edk2-devel] [PATCH v2] OvmfPkg/PvScsiDxe: Refactor setup of rings to separate function

On 04/01/20 00:56, Liran Alon wrote: > Previous to this change, PvScsiFreeRings() was not undoing all > operations that was done by PvScsiInitRings(). > This is because PvScsiInitRings() was both preparing rings (Allocate > memory and map it for device DMA) and setup the rings against device by > i

Re: [edk2-devel] [PATCH] OvmfPkg/PvScsiDxe: Fix VS2019 build error because of implicit cast

On 03/31/20 13:04, Liran Alon wrote: > Sean reported that VS2019 build produce the following build error: > INFO - PvScsi.c > INFO - Generating code > INFO - d:\a\1\s\OvmfPkg\PvScsiDxe\PvScsi.c(459): error C2220: the following > warning is treated as an error > INFO - d:\a\1\s\OvmfPkg\PvScsiDxe\Pv

Re: [edk2-devel] [PATCH] Maintainers.txt: Add Liran and Nikita as OvmfPkg/PvScsiDxe reviewers

On 03/31/20 13:02, Liran Alon wrote: > Laszlo suggested that as I have contributed the OvmfPkg PVSCSI driver, I > will also register myself as a reviewer in Maintainers.txt. > > In addition, as Nikita have assisted the development of the PVSCSI > driver and have developed another similar OvmfPkg S

Re: [edk2-devel] [PATCH] NetworkPkg/UefiPxeBcDxe: handle competing DHCP servers (more) gracefully

On 03/31/20 19:49, Maciej Rabeda wrote: > Always better than not detecting such stuff at all (or by ASSERT in > debug builds). Thanks for the patch! > > Reviewed-by: Maciej Rabeda Thanks All for the reviews; pushed as commit 3f55418d5396629c4458061f283068b6c46895fc, via

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Fix SMM/RT driver section alignment for XCODE5/CLANGPDB

On 03/30/20 13:37, Laszlo Ersek wrote: > On 03/29/20 15:21, Vitaly Cheptsov wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2642 >> >> This patch resolves the problem of using memory protection >> attributes when OVMF firmware is compiled with XCODE5 and CLANGPDB. >> >> CC: Andrew Fis

Re: [edk2-devel] [PATCH v2 20/28] Silicon/NXP/LS1043A: Move SocLib to Soc Package

On Fri, Mar 20, 2020 at 20:05:35 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > The SocLib contains code specific to an Soc. it should be part of > SOC package. > Therefore, move the SocLib to Soc Package. > Since we are moving the files to Soc Package, no need to mention the > Soc name in

Re: [edk2-devel] [PATCH v2 19/28] Silicon/NXP/LS1043A: Use ChassisLib from Chassis2 Pkg

On Fri, Mar 20, 2020 at 20:05:34 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > Now the we have added Chassis Package, move the chassis specific common > code for all SOCs belonging to same chassis to ChassisLib. > > Use ChassisLib APIs in SocLib. > > Signed-off-by: Pankaj Bansal There

Re: [edk2-devel] [PATCH v2 18/28] Silicon/NXP: Add Chassis2 Package

On Fri, Mar 20, 2020 at 20:05:33 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > A Chassis is a base framework used for building SoCs. > We can think of Chassis/Soc/Platform(a.k.a Borad) in Oops terms. Board? "Oops" is not a term I am familiar w

Re: [edk2-devel] [PATCH] NetworkPkg/Ip6Dxe: Fix ASSERT logic in Ip6ProcessRouterAdvertise()

Hey Laszlo, Thanks for your _meta-suggestions_ :) (1a): BZ created, referenced to BZ 2174, marked with 'regression': https://bugzilla.tianocore.org/show_bug.cgi?id=2655 (2): This will occur upon passed review and pull request to edk2/master Siyuan/Jiaxin, Can we get this through? Thanks, Ma

Re: [edk2-devel] API breakages and their implications. Was: [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support

On Tue, Mar 31, 2020 at 15:23:24 +0200, Laszlo Ersek wrote: > On 03/31/20 11:22, Leif Lindholm wrote: > > "This breaks many platforms" is a good argument for seeing if a > > solution can be found that does not break (as) many platforms. It is > > not an argument for duplicating drivers when the cha

Re: [edk2-devel] [PATCH v2 17/28] Silicon/NXP: Use Clock retrieval PPI in modules

On Fri, Mar 20, 2020 at 20:05:32 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > Use NXP_PLATFORM_GET_CLOCK_PPI in various Layerscape IP modules. > > Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm > --- > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 2 -- > Silicon/NXP/Dr

Re: [edk2-devel] [PATCH v2 16/28] Platform/NXP/LS1043aRdbPkg: Add Clock retrieval APIs

On Fri, Mar 20, 2020 at 20:05:31 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > The SOC takes primary clocking input from the external signal (a clock > generator on board). The input (frequency) is multiplied using multiple > phase locked loops (PLL) to create a variety of frequencies whi

Re: [edk2-devel] [PATCH v2 15/28] Silicon/NXP: Move RAM retrieval from SocLib

On Fri, Mar 20, 2020 at 20:05:30 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > RAM retrieval using SMC commands is common to all Layerscape SOCs. > Therefore, move it to commom MemoryInit Pei Lib. > > Signed-off-by: Pankaj Bansal > --- > Silicon/NXP/Include/DramInfo.h|

Re: [edk2-devel] [PATCH] NetworkPkg/Ip6Dxe: Fix ASSERT logic in Ip6ProcessRouterAdvertise()

Hi Maciej, On 04/01/20 11:53, Maciej Rabeda wrote: > This patch fixes reversed logic of recently added ASSERTs which should > ensure that Ip6IsNDOptionValid() implementation properly reacts to invalid > packets. > > Cc: Jiaxin Wu > Cc: Siyuan Fu > Signed-off-by: Maciej Rabeda > Tested-by: Lasz

Re: [edk2-devel] [PATCH] OvmfPkg/PvScsiDxe: Fix VS2019 build error because of implicit cast

On 04/01/20 10:50, Ard Biesheuvel wrote: > On Wed, 1 Apr 2020 at 10:37, Laszlo Ersek wrote: >> >> On 04/01/20 00:17, Liran Alon wrote: >> >>> I would also mention that there are some bizzare code in EDK2 that >>> defines it's own ASSERT() macro that just does CpuDeadLoop(). E.g. >>> ArmVirtPkg/Lib

Re: [edk2-devel] [PATCH v2] OvmfPkg/PvScsiDxe: Refactor setup of rings to separate function

On 01/04/2020 13:41, Laszlo Ersek wrote: On 04/01/20 00:56, Liran Alon wrote: + // + // Setup rings against device + // + Status = PvScsiSetupRings (Dev); + if (EFI_ERROR (Status)) { +goto FreeDMACommBuffer; I'm going to rename this label to "FreeDmaCommBuffer" upon pushing (due t

Re: [edk2-devel] [PATCH] OvmfPkg/PvScsiDxe: Fix VS2019 build error because of implicit cast

On 04/01/20 00:54, Sean via Groups.Io wrote: > I agree that safeintlib is not doing anything too interesting in this case > but that's not really the point.  The argument for it is that it becomes the > central point of code to check for safe conversions and an indicator that the > developer was

Re: [edk2-devel] [PATCH v2] OvmfPkg/PvScsiDxe: Refactor setup of rings to separate function

On 04/01/20 00:56, Liran Alon wrote: > Previous to this change, PvScsiFreeRings() was not undoing all > operations that was done by PvScsiInitRings(). > This is because PvScsiInitRings() was both preparing rings (Allocate > memory and map it for device DMA) and setup the rings against device by > i

Re: [edk2-devel] [PATCH v2 14/28] Platform/NXP: rename the ArmPlatformLib as per ArmPlatformPkg

On Fri, Mar 20, 2020 at 20:05:29 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > Keep the names and location of files as mentioned in ArmPlatformPkg. > This helps in porting the common changes (if any in future) easily. > > Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm > ---

Re: [edk2-devel] [PATCH v2 13/28] Silicon/NXP: Move dsc file

On Fri, Mar 20, 2020 at 20:05:28 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > As per convention being followed in edk2-platforms, keep the dec > file and dsc file together. > > Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm > --- > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.

Re: [edk2-devel] [PATCH v2 12/28] Silicon/NXP: Remove unnecessary PCDs

On Fri, Mar 20, 2020 at 20:05:27 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > The memory map of an SOC is fixed in hardware. it doesn't change with > platform that uses SOC. So, there is no need to keep PCDs for these values > and we can use macros for these in SOC header file. > > Any

Re: [edk2-devel] [PATCH v2 11/28] Silicon/NXP: remove not needed components

On Fri, Mar 20, 2020 at 20:05:26 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > The structures elements and functions that are not necessary for booting > for now are being deleted. > Once the directory structure has been changed (i.e. we have clear > distinction between chassis code and h

[edk2-devel] [PATCH v2] ShellPkg: Fix 'ping' command Ip4 receive flow.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2032 'ping' command's receive flow utilizes a single Rx token which it attempts to reuse before recycling the previously received packet. This causes a situation where under ICMP traffic, Ping6OnEchoReplyReceived() function will receive an alread

Re: [edk2-devel] [PATCH v2 10/28] Silicon/NXP: remove print information from Soc lib

On Fri, Mar 20, 2020 at 20:05:25 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > The Soc info being printed can be removed from SOC lib. > We are in the process of implementing PEI Phase. > After PEI phase impelmentation this info would be printed in implementation > commo

Re: [edk2-devel] [PATCH v2 08/28] Silicon/NXP/LS1043A: Use BaseSerialPortLib16550 as SerialPortLib

On Fri, Mar 20, 2020 at 20:05:23 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > UART Programming model in LS1043A is compatible with PC16550D. > Therefore, BaseSerialPortLib16550 can be used instead of our own > implementation of SerialPortLib. > > Signed-off-by: Pankaj Bansal Reviewed-

Re: [edk2-devel] [PATCH v2 09/28] Silicon/NXP: Drop DUartPortLib

On Fri, Mar 20, 2020 at 20:05:24 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > DUartPortLib is for ns16550 compatible UART in LS1043A. Therefore, we can > remove it and use BaseSerialPortLib16550. > > Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm > --- > Silicon/NXP/Librar

Re: [edk2-devel] [PATCH v2 07/28] Silicon/NXP: Implement SerialUartClockLib

On Fri, Mar 20, 2020 at 20:05:22 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > Implement SerialUartClockLib for all NXP Layerscape Platforms. > > Signed-off-by: Pankaj Bansal > --- > .../SerialUartClockLib/SerialUartClockLib.c | 27 +++ > .../SerialUartClockLib/Serial

[edk2-devel] [PATCH] NetworkPkg/Ip6Dxe: Fix ASSERT logic in Ip6ProcessRouterAdvertise()

This patch fixes reversed logic of recently added ASSERTs which should ensure that Ip6IsNDOptionValid() implementation properly reacts to invalid packets. Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Maciej Rabeda Tested-by: Laszlo Ersek --- NetworkPkg/Ip6Dxe/Ip6Nd.c | 6 +++--- 1 file changed,

Re: [edk2-devel] [PATCH v2 06/28] NXP/LS1043aRdb: Move Soc specific components to soc files

On Fri, Mar 20, 2020 at 20:05:21 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > Soc specific components ought to be part of Soc files and not > platform files. move the same to SOC files > > Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm > --- > Platform/NXP/LS1043aRdbPkg/LS

Re: [edk2-devel] [PATCH v3 0/3] Return GetVariable() attr if EFI_BUFFER_TOO_SMALL

On 04/01/20 03:15, Michael Kubacki wrote: > I have those options set correctly in git config. > > After a quick look, as far as I can tell, this is because the > Message-Id in my email is modified such the the In-Reply-To and > References headers do not refer to the actual Message-Id in the cover

Re: [edk2-devel] [PATCH v1 1/1] INF Spec: Add file dependency to [Sources] syntax

Hi Pierre, I will review the spec and code change in this week. Thanks, Bob -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of PierreGondois Sent: Monday, March 30, 2020 11:52 PM To: devel@edk2.groups.io; Sami Mujawar ; Feng, Bob C ; Gao, Liming C

Re: [edk2-devel] [PATCH] OvmfPkg/PvScsiDxe: Fix VS2019 build error because of implicit cast

On Wed, 1 Apr 2020 at 10:37, Laszlo Ersek wrote: > > On 04/01/20 00:17, Liran Alon wrote: > > > I would also mention that there are some bizzare code in EDK2 that > > defines it's own ASSERT() macro that just does CpuDeadLoop(). E.g. > > ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c > > This is a v

Re: [edk2-devel] [PATCH] OvmfPkg/PvScsiDxe: Fix VS2019 build error because of implicit cast

On 04/01/20 00:17, Liran Alon wrote: > I would also mention that there are some bizzare code in EDK2 that > defines it's own ASSERT() macro that just does CpuDeadLoop(). E.g. > ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c This is a very special case. Please see the justification in commit ad90df

[edk2-devel] [PATCH v2 0/2] Use submodule way to access brotli

Currently brotli is used and customized by edk2 in BaseTools and MdeModulePkg. These two patches make brotli a submodule in edk2. https://bugzilla.tianocore.org/show_bug.cgi?id=2558 https://bugzilla.tianocore.org/show_bug.cgi?id=2559 v2: Add submodule path in CISettings.py Cc: Liming Gao Cc: Jia

[edk2-devel] [PATCH] .azurepipelines: Update CI steps

From: Sean Brogan Update CI steps to build base tools after setup and update, as basetools might have dependencies that need to be resolved. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Shenglei Zhang --- .azurepipelines/templates/pr-gate-steps.yml |

Re: [edk2-devel] [PATCH] OvmfPkg/PvScsiDxe: Fix VS2019 build error because of implicit cast

On 04/01/20 00:13, Liran Alon wrote: > > On 01/04/2020 0:56, Laszlo Ersek wrote: >> On 03/31/20 17:53, Sean via Groups.Io wrote: >>> A couple of thoughts. >>> 1. I would suggest that ASSERT should not be the only protection for >>> an invalid operation as ASSERT is usually disabled on release buil