Reviewed-by: Ashley DeSimone <ashley.e.desim...@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bjorge, Erik C
Sent: Tuesday, March 31, 2020 3:42 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desim...@intel.com>; Pandya, Puja
<puja.pan...@intel.com>; Bret Barkelew <bret.barke...@microsoft.com>; Agyeman,
Prince <prince.agye...@intel.com>
Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 4/7] EdkRepo: Update
Sync for archived combos
Added support for archived combos in Sync command.
Signed-off-by: Erik Bjorge <erik.c.bjo...@intel.com>
Cc: Nate DeSimone <nathaniel.l.desim...@intel.com>
Cc: Puja Pandya <puja.pan...@intel.com>
Cc: Bret Barkelew <bret.barke...@microsoft.com>
Cc: Prince Agyeman <prince.agye...@intel.com>
---
edkrepo/commands/sync_command.py | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/edkrepo/commands/sync_command.py b/edkrepo/commands/sync_command.py
index 71c600a..daa558f 100644
--- a/edkrepo/commands/sync_command.py
+++ b/edkrepo/commands/sync_command.py
@@ -3,7 +3,7 @@
## @file
# sync_command.py
#
-# Copyright (c) 2017- 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017- 2020, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent #
@@ -19,7 +19,7 @@ from git import Repo
# Our modules
from edkrepo.commands.edkrepo_command import EdkrepoCommand from
edkrepo.commands.edkrepo_command import DryRunArgument, SubmoduleSkipArgument
-import edkrepo.commands.arguments.sync_args as arguments
+import edkrepo.commands.arguments.sync_args as arguments
from edkrepo.common.progress_handler import GitProgressHandler from
edkrepo.common.edkrepo_exception import EdkrepoUncommitedChangesException,
EdkrepoManifestNotFoundException from edkrepo.common.edkrepo_exception import
EdkrepoManifestChangedException @@ -38,7 +38,7 @@ from
edkrepo.common.common_repo_functions import generate_name_for_obsolete_back
from edkrepo.common.common_repo_functions import update_editor_config from
edkrepo.common.common_repo_functions import update_repo_commit_template,
get_latest_sha from edkrepo.common.common_repo_functions import
has_primary_repo_remote, fetch_from_primary_repo, in_sync_with_primary -from
edkrepo.common.common_repo_functions import update_hooks, maintain_submodules
+from edkrepo.common.common_repo_functions import update_hooks,
+maintain_submodules, combinations_in_manifest
from edkrepo.common.common_repo_functions import write_included_config,
remove_included_config from edkrepo.common.ui_functions import
init_color_console from edkrepo.config.config_factory import
get_workspace_path, get_workspace_manifest, get_edkrepo_global_data_directory
@@ -53,22 +53,22 @@ class SyncCommand(EdkrepoCommand):
def get_metadata(self):
metadata = {}
metadata['name'] = 'sync'
- metadata['help-text'] = arguments.COMMAND_DESCRIPTION
+ metadata['help-text'] = arguments.COMMAND_DESCRIPTION
args = []
metadata['arguments'] = args
args.append({'name' : 'fetch',
'positional' : False,
'required' : False,
- 'help-text': arguments.FETCH_HELP})
+ 'help-text': arguments.FETCH_HELP})
args.append({'name' : 'update-local-manifest',
'short-name': 'u',
'required' : False,
- 'help-text' : arguments.UPDATE_LOCAL_MANIFEST_HELP})
+ 'help-text' :
+ arguments.UPDATE_LOCAL_MANIFEST_HELP})
args.append({'name' : 'override',
'short-name': 'o',
'positional' : False,
'required' : False,
- 'help-text' : arguments.OVERRIDE_HELP})
+ 'help-text' : arguments.OVERRIDE_HELP})
args.append(SubmoduleSkipArgument)
return metadata
@@ -222,7 +222,7 @@ class SyncCommand(EdkrepoCommand):
if initial_manifest_remotes[remote_name] !=
new_manifest_remotes[remote_name]:
raise
EdkrepoManifestChangedException(SYNC_URL_CHANGE.format(remote_name))
#check to see if the currently checked out combo exists in the new
manifest.
- new_combos = [c.name for c in new_manifest_to_check.combinations]
+ new_combos = combinations_in_manifest(new_manifest_to_check)
if current_combo not in new_combos:
raise
EdkrepoManifestChangedException(SYNC_COMBO_CHANGE.format(current_combo,
initial_manifest.project_info.codename))
--
2.21.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#56872): https://edk2.groups.io/g/devel/message/56872
Mute This Topic: https://groups.io/mt/72688781/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
