[edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.

2020-03-30 Thread Guomin Jiang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2609 The copied pointer (SavedState) will be updated by LoadUnitTestCache call. But the change of SavedState will not update source pointer, which is NewFramework->SavedState in this case. Cc: Michael D Kinney Cc: Sean Brogan Cc: Bret Barkelew

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Ard Biesheuvel
On Tue, 31 Mar 2020 at 08:31, Sean via Groups.Io wrote: > > @Ard - > pflash change: https://github.com/spbrogan/edk2/pull/12 > > Logging change - I actually switched OVMF to use stdio since the log is > captured either way and now it shows up in the web log output. > https://github.com/spbrogan

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Sean via Groups.Io
@Ard - pflash change: https://github.com/spbrogan/edk2/pull/12 Logging change - I actually switched OVMF to use stdio since the log is captured either way and now it shows up in the web log output. https://github.com/spbrogan/edk2/pull/13 Do you have instructions for the cmdline for Qemu for Ar

Re: [edk2-devel] [PATCH 1/3] Platform/Intel: Add all pathes of feature domains to package path

2020-03-30 Thread Liming Gao
EDKII DEC spec https://github.com/tianocore-docs/edk2-DecSpecification/tree/release/1.27/2_dec_file_overview DEC File Overview An EDK II Package (directory) is a directory that contains an EDK II package declaration (DEC) file. Only one DEC file is permitted per directory. EDK II Packages ca

Re: [edk2-devel] [Patch V2 0/3] Fix build error of OpenBoard

2020-03-30 Thread Liming Gao
Reviewed-by: Liming Gao -Original Message- From: devel@edk2.groups.io On Behalf Of Heng Luo Sent: 2020年3月31日 11:49 To: devel@edk2.groups.io Subject: [edk2-devel] [Patch V2 0/3] Fix build error of OpenBoard *** BLURB HERE *** Heng Luo (3): Platform/Intel: Add all pathes of feature dom

Re: [edk2-devel] [PATCH 1/3] Platform/Intel: Add all pathes of feature domains to package path

2020-03-30 Thread Ni, Ray
Liming, Where can I find the rule? Thanks, Ray > -Original Message- > From: Gao, Liming > Sent: Tuesday, March 31, 2020 10:52 AM > To: Luo, Heng ; Ni, Ray ; > devel@edk2.groups.io > Cc: Bi, Dandan ; Dong, Eric > Subject: RE: [PATCH 1/3] Platform/Intel: Add all pathes of feature domains

[edk2-devel] [Patch V2 0/3] Fix build error of OpenBoard

2020-03-30 Thread Heng Luo
*** BLURB HERE *** Heng Luo (3): Platform/Intel: Add all pathes of feature domains to package path Features/Intel: Add LogoFeaturePkg to TemporaryBuildWorkaround Features/Intel: Correct wrong codes and remove unnecessary codes Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tem

[edk2-devel] [Patch V2 1/3] Platform/Intel: Add all pathes of feature domains to package path

2020-03-30 Thread Heng Luo
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2644 Add all pathes of feature domains to package path in build_bios.py. Cc: Dandan Bi Cc: Liming Gao Cc: Eric Dong Cc: Ray Ni Signed-off-by: Heng Luo --- Notes: v2: - Skip adding folders that contains package contents to the PA

[edk2-devel] [Patch V2 3/3] Features/Intel: Correct wrong codes and remove unnecessary codes

2020-03-30 Thread Heng Luo
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2644 Correct wrong codes and remove unnecessary codes in LogoFeaturePkg. Cc: Dandan Bi Cc: Liming Gao Cc: Eric Dong Cc: Ray Ni Signed-off-by: Heng Luo --- Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc | 9 -

[edk2-devel] [Patch V2 2/3] Features/Intel: Add LogoFeaturePkg to TemporaryBuildWorkaround

2020-03-30 Thread Heng Luo
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2644 Need to add LogoFeaturePkg to TemporaryBuildWorkaround because OpenBoard still includes TemporaryBuildWorkaround for building BIOS. Cc: Dandan Bi Cc: Liming Gao Cc: Eric Dong Cc: Ray Ni Signed-off-by: Heng Luo --- Features/Intel/Adva

[edk2-devel] [PATCH] UnitTestFrameworkPkg/PersistenceLib: Correct the allocated size.

2020-03-30 Thread Guomin Jiang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2608 According to logic and the practice, it is need to allocate ascii length by 2 for unicode string. Cc: Michael D Kinney Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Guomin Jiang --- .../UnitTestPersistenceLibSimpleFileSystem.c

Re: [edk2-devel] [PATCH 1/3] Platform/Intel: Add all pathes of feature domains to package path

2020-03-30 Thread Heng Luo
OK, it means we just need to check dec file Best Regards Heng > -Original Message- > From: Gao, Liming > Sent: Tuesday, March 31, 2020 10:52 AM > To: Luo, Heng ; Ni, Ray ; > devel@edk2.groups.io > Cc: Bi, Dandan ; Dong, Eric > Subject: RE: [PATCH 1/3] Platform/Intel: Add all pathes of f

Re: [edk2-devel] [PATCH 1/3] Platform/Intel: Add all pathes of feature domains to package path

2020-03-30 Thread Liming Gao
Ray: Package has dec file in its root directory. Package DSC file is optional. Thanks Liming -Original Message- From: Luo, Heng Sent: 2020年3月31日 9:25 To: Ni, Ray ; devel@edk2.groups.io Cc: Bi, Dandan ; Gao, Liming ; Dong, Eric Subject: RE: [PATCH 1/3] Platform/Intel: Add all pathes o

Re: [edk2-devel] [PATCH 1/3] Platform/Intel: Add all pathes of feature domains to package path

2020-03-30 Thread Dong, Eric
Liming, Please help to provide comments for this mail. It break the open board now Thanks, Eric From: Luo, Heng Sent: Tuesday, March 31, 2020 9:25 AM To: Ni, Ray ; devel@edk2.groups.io Cc: Bi, Dandan ; Gao, Liming ; Dong, Eric Subject: RE: [PATCH 1/3] Platform/Intel: Add all pathes of feature d

[edk2-devel] Upcoming Event: TianoCore Community Meeting - APAC/NAMO - Thu, 04/02/2020 7:30pm-8:30pm #cal-reminder

2020-03-30 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Community Meeting - APAC/NAMO *When:* Thursday, 2 April 2020, 7:30pm to 8:30pm, (GMT-07:00) America/Los Angeles *Where:* https://bluejeans.com/889357567?src=join_info View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=700768 ) *Organizer:* Brian Richardson bria

Re: [edk2-devel] [PATCH V3 0/2] MdePkg-IndustryStandard: CXL Base Specification registers

2020-03-30 Thread Javeed, Ashraf
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Javeed, > Ashraf > Sent: Tuesday, March 31, 2020 7:33 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH V3 0/2] MdePkg-IndustryStandard: CXL Base > Specification registers > > These set of two patches introduces t

[edk2-devel] [PATCH V3 0/2] MdePkg-IndustryStandard: CXL Base Specification registers

2020-03-30 Thread Javeed, Ashraf
These set of two patches introduces the CXL Base Specification register definitions to the MDE; the Cxl11.h has the register definitions for revision 1.1, and the header Cxl.h is the main wrapper header file to support all versions of CXL Base Specification register definitions. Ashraf Javeed (

[edk2-devel] [PATCH V3 2/2] MdePkg-IndustryStandard: Main header for all versions of CXL registers

2020-03-30 Thread Javeed, Ashraf
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2611 Introducing the Cxl.h as the main header file to support all versions of CXL Base Specification register definitions. Signed-off-by: Ashraf Javeed Cc: Michael D Kinney Cc: Liming Gao --- MdePkg/Include/IndustryStandard/Cxl.h | 18 +++

[edk2-devel] [PATCH V3 1/2] MdePkg-IndustryStandard: CXL 1.1 Base Specification registers

2020-03-30 Thread Javeed, Ashraf
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2611 Register definitions from chapter 7 of CXL Base Specification Rev.1.1 are ported into the new Cxl11.h. The CXL Flex Bus registers are based on the PCIe Extended Capability DVSEC structure header, led to the inclusion of upgraded Pci.h. Signe

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support

2020-03-30 Thread Ni, Ray
Leif, Please understand that the concern of this change is all the platforms that uses this serial port lib must be changed otherwise build breaks. Ard, Using Guided HOB sounds a good idea to me: ) The benefits of using HOB is: Length field in the HOB header can be used for extension if more par

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-03-30 Thread Guomin Jiang
Hi Laszlo, Thanks for you spending time review the changes. And I just want to present how to reproduce the build error. When build OvmfPkgX64, you can encounter this issue with your local change. The error as below: TcgPei.lib(AutoGen.obj) : error LNK2001: unresolved external symbol _fltused c

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Wed, 04/01/2020 9:30am-10:30am #cal-reminder

2020-03-30 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Wednesday, 1 April 2020, 9:30am to 10:30am, (GMT+08:00) Asia/Chongqing *Where:* https://zoom.com.cn/j/493235016 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=758250 ) *Organizer:* Brian Richardson brian.richard...@intel.com

Re: [edk2-devel] [PATCH 3/3] Features/Intel: Correct wrong codes and remove unnecessary codes

2020-03-30 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Heng Luo > Sent: Monday, March 30, 2020 2:03 PM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming ; > Dong, Eric ; Ni, Ray > > Subject: [edk2-devel] [PATCH 3/3] Features/Intel: Correct wrong code

Re: [edk2-devel] [PATCH 2/3] Features/Intel: Add LogoFeaturePkg to TemporaryBuildWorkaround

2020-03-30 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Heng Luo > Sent: Monday, March 30, 2020 2:03 PM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming ; > Dong, Eric ; Ni, Ray > > Subject: [edk2-devel] [PATCH 2/3] Features/Intel: Add LogoFeaturePkg

Re: [edk2-devel] [PATCH 1/3] Platform/Intel: Add all pathes of feature domains to package path

2020-03-30 Thread Heng Luo
Hi Liming, I will apply the change below if you agree to we treat a folder that contains ".dec" and "dsc" files as a package directory: diff --git a/Platform/Intel/build_bios.py b/Platform/Intel/build_bios.py index b9ad980510..bb25699ed8 100644 --- a/Platform/Intel/build_bios.py +++ b/Platform/I

Re: [edk2-devel] [PATCH v6 00/42] SEV-ES guest support

2020-03-30 Thread Dong, Eric
Hi Tom, Sorry for late response. It’s a huge patch, please give me two more weeks to detail review them. I have rough go through these patches and have some basic comments for them now: 1. It’s better to spit patch if changes files not in same package. Like patch 1/42. 2. All func

[edk2-devel] [PATCH] NetworkPkg/UefiPxeBcDxe: handle competing DHCP servers (more) gracefully

2020-03-30 Thread Laszlo Ersek
When DHCP is misconfigured on a network segment, such that two DHCP servers attempt to reply to requests (and therefore race with each other), the edk2 PXE client can confuse itself. In PxeBcDhcp4BootInfo() / PxeBcDhcp6BootInfo(), the client may refer to a DHCP reply packet as an "earlier" packet

Re: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function

2020-03-30 Thread Yao, Jiewen
Hi Mike "But what we really want to know is if another library or module us using a deprecated lib function." The protocol is internal API, the library is external API. What we are discussing now is how to handle internal API. For external API, this patch removed the deprecated lib API and the

Re: [edk2-devel] [PATCH v2] NetworkPkg/Ip6Dxe: Improve Neightbor Discovery message validation.

2020-03-30 Thread Laszlo Ersek
Hi Maciej, On 03/30/20 14:23, Maciej Rabeda wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2174 > > Problem has been identified with Ip6ProcessRouterAdvertise() when > Router Advertise packet contains options with malicious/invalid > 'Length' field. This can lead to platform enterin

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Michael D Kinney
Sean, I agree a r/w file system with simple access from host and QEMU is a much better choice. When Laszlo gets some time, I would be interested in his recommendations. My negative experience was from a Windows host. Perhaps that are must better virtual disk tools from a Linux host. Mike F

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Rebecca Cran
On 3/30/20 3:42 PM, Sean via Groups.Io wrote: @Rebecca - Agree.  I need to package up a newer version.  I have treated this as lower priority.  Is there a feature you need or just best practices on keeping current? Just best practices around keeping current. I don't think it's a problem just

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Ard Biesheuvel
On Mon, 30 Mar 2020 at 23:42, Sean via Groups.Io wrote: > > @Rebecca - Agree. I need to package up a newer version. I have treated this > as lower priority. Is there a feature you need or just best practices on > keeping current? > @Ard - Padding in python is easy. I just need to understand

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-03-30 Thread Ard Biesheuvel
On Mon, 30 Mar 2020 at 23:29, Matthew Carlson via Groups.Io wrote: > > So it's not required by OpenSSL, it's required by the compiler whenever > floating point is used, which can be in multiple places. For example, this is > used in mu_plus (the Microsoft UEFI value add to EDK2) by the > OnScre

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Sean via Groups.Io
@Rebecca - Agree.  I need to package up a newer version.  I have treated this as lower priority.  Is there a feature you need or just best practices on keeping current? @Ard - Padding in python is easy.  I just need to understand the requirements. @Mike - I would like to get to read/write filesys

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Michael D Kinney
Hi Laszlo, I think using the QEMU feature to map a path from the host as a FAT formatted driver has value to provision QEMU with a set of target tests to run. I agree there is no persistent storage of writes to this type of drive. I believe writes are supported if file state is needed during th

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-03-30 Thread Matthew Carlson via Groups.Io
So it's not required by OpenSSL, it's required by the compiler whenever floating point is used, which can be in multiple places. For example, this is used in mu_plus (the Microsoft UEFI value add to EDK2) by the OnScreenKeyboard driver as well as the UiToolKit driver. If you happen to use BaseCr

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Ard Biesheuvel
On Mon, 30 Mar 2020 at 22:56, Laszlo Ersek wrote: > > On 03/30/20 19:44, Ard Biesheuvel wrote: > > On Mon, 30 Mar 2020 at 19:11, Sean via Groups.Io > > wrote: > >> > >> On Mon, Mar 30, 2020 at 10:04 AM, Ard Biesheuvel wrote: > >> > >> Is there any way I could contribute ArmVirtQemu to this? Or wo

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Rebecca Cran
On 3/30/20 3:03 PM, Sean via Groups.Io wrote: Laszlo/Ard - I have cleaned up git history and pushed to https://github.com/spbrogan/edk2 master. If you want you can create a PR against that branch and it should kick OVMF, Emulator, and ArmVirt to build and run. Looking for feedback. The

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Laszlo Ersek
On 03/30/20 08:07, Ard Biesheuvel wrote: > On Mon, 30 Mar 2020 at 01:16, Sean via Groups.Io > wrote: >> >> Ard/Laszlo or anyone familiar with QEMU. >> >> I read up on the ovmf readme and the qemu wiki but still have a few issues i >> am hoping for quick/easy answers. >> >> 1. How do i programmati

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Sean via Groups.Io
Laszlo/Ard - I have cleaned up git history and pushed to https://github.com/spbrogan/edk2 master. If you want you can create a PR against that branch and it should kick OVMF, Emulator, and ArmVirt to build and run. Looking for feedback. @Laszlo - I followed Ard's parameters but feel free to m

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Laszlo Ersek
On 03/30/20 19:44, Ard Biesheuvel wrote: > On Mon, 30 Mar 2020 at 19:11, Sean via Groups.Io > wrote: >> >> On Mon, Mar 30, 2020 at 10:04 AM, Ard Biesheuvel wrote: >> >> Is there any way I could contribute ArmVirtQemu to this? Or would it >> be easier if I provided comments/instructions? >> >> Eith

Re: [edk2-devel] [PATCH v3 13/17] OvmfPkg/PvScsiDxe: Setup requests and completions rings

2020-03-30 Thread Laszlo Ersek
On 03/30/20 19:24, Liran Alon wrote: > > On 30/03/2020 18:54, Laszlo Ersek wrote: >> On 03/28/20 21:00, Liran Alon wrote: >>> @@ -509,6 +720,14 @@ PvScsiUninit ( >>> IN OUT PVSCSI_DEV *Dev >>> ) >>> { >>> + // >>> + // Reset device to stop device usage of the rings. >>> + // This is r

Re: [edk2-devel] [PATCH v2 1/1] MdePkg/UefiScsiLib: Set FUA bit for synchronous SCSI Write operations

2020-03-30 Thread Zurcher, Christopher J
This change has been validated on an internal development platform; I will share the details offline. Thanks, Christopher Zurcher > -Original Message- > From: Gao, Liming > Sent: Monday, March 30, 2020 06:51 > To: Liu, Zhiguang ; Zurcher, Christopher J > ; devel@edk2.groups.io > Cc: Kin

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Ard Biesheuvel
On Mon, 30 Mar 2020 at 21:07, Sean via Groups.Io wrote: > > > > On Mon, Mar 30, 2020 at 10:44 AM, Ard Biesheuvel wrote: > > Thanks. But can I get these actions to trigger from my branch as well? > Or do I need special powers for that? > > Right now it requires manually running so it requires "spec

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Sean via Groups.Io
On Mon, Mar 30, 2020 at 10:44 AM, Ard Biesheuvel wrote: > > Thanks. But can I get these actions to trigger from my branch as well? > Or do I need special powers for that? Right now it requires manually running so it requires "special powers". :) I am happy to get this into a branch that you can

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-03-30 Thread Laszlo Ersek
On 03/30/20 11:02, Ard Biesheuvel wrote: > On Mon, 30 Mar 2020 at 10:52, Guomin Jiang > wrote: >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2596 >> >> OpenSSL requires _fltused to be defined as a constant anywhere >> floating point is used. >> This is to satisfy the linker, however, i

Re: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table

2020-03-30 Thread Ard Biesheuvel
(adding Jian and Hao) Thanks for the acks, and apologies for failing to cc the MdeModulePkg maintainers. Jian, Hao, do you have any opinion on this series? On Mon, 30 Mar 2020 at 15:42, Gao, Liming wrote: > > Ack-by: Liming Gao > > > -Original Message- > > From: devel@edk2.groups.io

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Ard Biesheuvel
On Mon, 30 Mar 2020 at 19:11, Sean via Groups.Io wrote: > > On Mon, Mar 30, 2020 at 10:04 AM, Ard Biesheuvel wrote: > > Is there any way I could contribute ArmVirtQemu to this? Or would it > be easier if I provided comments/instructions? > > Either way. > Any instructions you provide would be grea

Re: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function

2020-03-30 Thread Michael D Kinney
Hi, I would prefer we only extend the protocol interface and never remove any fields from the Protocol/PPI structures so no offsets are ever changed. The main remaining issue is how a platform developer knows if they are using a deprecated interface. The best method is to know at build time wit

Re: [edk2-devel] [PATCH v3 13/17] OvmfPkg/PvScsiDxe: Setup requests and completions rings

2020-03-30 Thread Liran Alon
On 30/03/2020 18:54, Laszlo Ersek wrote: On 03/28/20 21:00, Liran Alon wrote: STATIC EFI_STATUS PvScsiInit ( @@ -466,6 +669,14 @@ PvScsiInit ( goto RestorePciAttributes; } + // + // Init PVSCSI rings + // + Status = PvScsiInitRings (Dev); + if (EFI_ERROR (Status)) { +

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Sean via Groups.Io
On Mon, Mar 30, 2020 at 10:04 AM, Ard Biesheuvel wrote: > > Is there any way I could contribute ArmVirtQemu to this? Or would it > be easier if I provided comments/instructions? Either way. Any instructions you provide would be great.  I was going to hack something up for feedback but happy for

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Ard Biesheuvel
On Mon, 30 Mar 2020 at 19:01, Sean via Groups.Io wrote: > > On Mon, Mar 30, 2020 at 02:36 AM, Ard Biesheuvel wrote: > > It should be trivial to extend this to ARM, using TCG emulation. > > One question though: what happens if the boot does not make it to the > shell, and crashes for some reason? T

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Sean via Groups.Io
On Mon, Mar 30, 2020 at 02:36 AM, Ard Biesheuvel wrote: > > It should be trivial to extend this to ARM, using TCG emulation. > > One question though: what happens if the boot does not make it to the > shell, and crashes for some reason? The QEMU process will hang, so I'd > assume some kind of ti

Re: [edk2-devel] [PATCH v1 1/2] DynamicTablesPkg: SRAT: Fix entry points

2020-03-30 Thread Sami Mujawar
Hi Ard, Please see my reply inline marked [SAMI]. Regards, Sami Mujawar -Original Message- From: Ard Biesheuvel Sent: 30 March 2020 09:08 AM To: edk2-devel-groups-io ; Sami Mujawar Cc: Alexei Fedorov ; Matteo Carlini ; Laura Moretta ; nd Subject: Re: [edk2-devel] [PATCH v1 1/2] D

Re: [EXTERNAL] [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-03-30 Thread Bret Barkelew via Groups.Io
Reviewed-by: Bret Barkelew - Bret From: devel@edk2.groups.io on behalf of Guomin Jiang via Groups.Io Sent: Monday, March 30, 2020 1:52:47 AM To: devel@edk2.groups.io Cc: Jian J Wang ; Xiaoyu Lu Subject: [EXTERNAL] [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: A

Re: [edk2-devel] [PATCH v6 00/42] SEV-ES guest support

2020-03-30 Thread Lendacky, Thomas
I've gotten some nice feedback from Laszlo, especially on the OvmfPkg side of this patchset, but haven't seen much response from the other maintainers. Is there any feedback on the MdePkg, MdeModulePkg and UefiCpuPkg changes that needs to be addressed in order to merge this? I do have some min

Re: [edk2-devel] [PATCH v3 00/17] OvmfPkg: Support booting from VMware PVSCSI controller

2020-03-30 Thread Laszlo Ersek
On 03/28/20 21:00, Liran Alon wrote: > Hi, > > This series adds driver support for VMware PVSCSI controller. > > This controller is supported by VMware and QEMU. This work is part of > the more general agenda of enhancing OVMF boot device support to have > feature parity with SeaBIOS (Which suppo

Re: [edk2-devel] [PATCH v1 1/1] INF Spec: Add file dependency to [Sources] syntax

2020-03-30 Thread PierreGondois
The Bugzilla ticket number was erroneous in the v1. The v2 is available at: https://edk2.groups.io/g/devel/message/56663 Regards, Pierre -Original Message- From: PierreGondois Sent: 30 March 2020 16:43 To: devel@edk2.groups.io Cc: Pierre Gondois ; liming@intel.com; sami.muja...@arm

Re: [edk2-devel] [PATCH v3 16/17] OvmfPkg/PvScsiDxe: Reset device on ExitBootServices()

2020-03-30 Thread Laszlo Ersek
On 03/28/20 21:00, Liran Alon wrote: > This causes the device to forget about the request/completion rings. > We allocated said rings in EfiBootServicesData type memory, and code > executing after ExitBootServices() is permitted to overwrite it. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi

Re: [edk2-devel] [PATCH v3 15/17] OvmfPkg/PvScsiDxe: Support sending SCSI request and receive response

2020-03-30 Thread Laszlo Ersek
On 03/28/20 21:00, Liran Alon wrote: > Implement EXT_SCSI_PASS_THRU.PassThru(). > > Machines should be able to boot after this commit. > Tested with Ubuntu 16.04 guest. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 > Signed-off-by: Liran Alon > --- > OvmfPkg/OvmfPkg.dec

Re: [edk2-devel] [PATCH v2 1/1] INF Spec: Add file dependency to [Sources] syntax

2020-03-30 Thread PierreGondois
The Bugzilla ticket number was erroneous in the v1. The v1 is available at: https://edk2.groups.io/g/devel/message/56658 Regards, Pierre -Original Message- From: PierreGondois Sent: 30 March 2020 17:17 To: devel@edk2.groups.io Cc: Pierre Gondois ; liming@intel.com; Sami Mujawar ;

[edk2-devel] [PATCH v2 1/1] INF Spec: Add file dependency to [Sources] syntax

2020-03-30 Thread PierreGondois
From: Pierre Gondois BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2646 When building an edk2 module, a C file was including a .hex file generated by the compilation of an ASL file. To describe this dependency between an ASL file and a C file, the edk2 patch, - named "BaseTools: Build ASL

[edk2-devel] [PATCH v4 1/1] BaseTools: Enable file dependencies in .inf files

2020-03-30 Thread PierreGondois
From: Pierre Gondois BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2425 The dependencies for C files are satisfied by the build system. However, there are use cases where source files with different languages are inter-dependent. The EDKII build framework currently doesn't have options to s

Re: [edk2-devel] [PATCH v3 14/17] OvmfPkg/PvScsiDxe: Introduce DMA communication buffer

2020-03-30 Thread Laszlo Ersek
On 03/28/20 21:00, Liran Alon wrote: > In case device is constrained by IOMMU or guest is running under AMD SEV, > input/output buffers provided to device (DataBuffer and SenseData) needs > to be explicitly mapped to device by PciIo->Map(). > > To avoid the overhead of mapping/unmapping the DataBu

[edk2-devel] Upcoming Event: TianoCore Community Meeting - EMEA/NAMO - Thu, 04/02/2020 9:00am-10:00am #cal-reminder

2020-03-30 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Community Meeting - EMEA/NAMO *When:* Thursday, 2 April 2020, 9:00am to 10:00am, (GMT-07:00) America/Los Angeles *Where:* https://bluejeans.com/889357567?src=join_info View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=700767 ) *Organizer:* Brian Richardson bri

Re: [edk2-devel] [PATCH v3 13/17] OvmfPkg/PvScsiDxe: Setup requests and completions rings

2020-03-30 Thread Laszlo Ersek
On 03/28/20 21:00, Liran Alon wrote: > These rings are shared memory buffers between host and device in which > a cyclic buffer is managed to send request descriptors from host to > device and receive completion descriptors from device to host. > > Note that because device may be constrained by IO

Re: [edk2-devel] [PATCH v1 1/1] INF Spec: Add file dependency to [Sources] syntax

2020-03-30 Thread PierreGondois
Hello Liming and Bob, I couldn't find the list of maintainers for the specification files, but it seems Liming is a maintainer. If a maintainer is missing, please feel free to cc him, Regards, Pierre -Original Message- From: PierreGondois Sent: Monday, March 30, 2020 4:43 PM To: devel

[edk2-devel] [PATCH v1 1/1] INF Spec: Add file dependency to [Sources] syntax

2020-03-30 Thread PierreGondois
From: Pierre Gondois BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2464 When building an edk2 module, a C file was including a .hex file generated by the compilation of an ASL file. To describe this dependency between an ASL file and a C file, the edk2 patch, - named "BaseTools: Build ASL

Re: [edk2-devel] [PATCH v3 12/17] OvmfPkg/PvScsiDxe: Reset adapter on init

2020-03-30 Thread Laszlo Ersek
On 03/28/20 21:00, Liran Alon wrote: > The following commits will complete the implementation of > device initialization. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 > Reviewed-by: Laszlo Ersek > Signed-off-by: Liran Alon > --- > OvmfPkg/PvScsiDxe/PvScsi.c | 114 +++

Re: [edk2-devel] [PATCH V2 2/2] MdePkg-IndustryStandard: CXL 1.1 Base Specification registers

2020-03-30 Thread Javeed, Ashraf
OK Thanks Ashraf > -Original Message- > From: Gao, Liming > Sent: Monday, March 30, 2020 7:27 PM > To: Javeed, Ashraf ; devel@edk2.groups.io > Cc: Kinney, Michael D > Subject: RE: [PATCH V2 2/2] MdePkg-IndustryStandard: CXL 1.1 Base > Specification registers > > Ashraf: > Please cha

Re: [edk2-devel] [PATCH V2 1/2] MdePkg-IndustryStandard: CXL 1.1 Base Specification registers

2020-03-30 Thread Javeed, Ashraf
OK Thanks Ashraf > -Original Message- > From: Gao, Liming > Sent: Monday, March 30, 2020 7:26 PM > To: Javeed, Ashraf ; devel@edk2.groups.io > Cc: Kinney, Michael D > Subject: RE: [PATCH V2 1/2] MdePkg-IndustryStandard: CXL 1.1 Base > Specification registers > > Ashraf: > Please inclu

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RPi4/ConfigDxe: Replace SD Host with eMMC2 SDHCI option

2020-03-30 Thread Ard Biesheuvel
On Thu, 26 Mar 2020 at 18:09, Pete Batard wrote: > > From: Andrei Warkentin > > SD Host is not usable on Pi 4 so replace it with an eMMC2 option. > > Note that is a menu only change at this stage, since we don't have > eMMC support finalized. > > Signed-off-by: Pete Batard Reviewed-by: Ard Bies

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RPi/AcpiTables: Move PPTT constants to the alsc source

2020-03-30 Thread Ard Biesheuvel
On Fri, 27 Mar 2020 at 11:35, Pete Batard wrote: > > There's no real reason to have the PPTT constants factorized in > AcpiTables.h, and hiding them away with the interrupts is only > going to end up being counter-productive for folks trying to > understand or maintain the code. > > Move these sec

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/AcpiLib: add GICC table init macro for ACPI 6.3

2020-03-30 Thread Pete Batard
On 2020.03.30 15:42, Ard Biesheuvel wrote: On Mon, 30 Mar 2020 at 16:39, Pete Batard wrote: On 2020.03.30 15:34, Ard Biesheuvel wrote: ... Again, I am happy to merge this patch. The argument is about whether we need to upgrade RPi4 to 6.3 Last time I checked, quite a few of the people wh

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] EmbeddedPkg/AcpiLib: add GICC table init macro for ACPI 6.3

2020-03-30 Thread Ard Biesheuvel
On Fri, 27 Mar 2020 at 14:01, Pete Batard wrote: > > ACPI 6.3 added a 16-bit SPE overflow Interrupt field, replacing > 2 of the 3 reserved bytes that are defined at the end of the > GICC structure for 6.0. > > Add a new macro to initialise the new field. > > Signed-off-by: Pete Batard > --- > Em

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/AcpiLib: add GICC table init macro for ACPI 6.3

2020-03-30 Thread Ard Biesheuvel
On Mon, 30 Mar 2020 at 16:39, Pete Batard wrote: > > On 2020.03.30 15:34, Ard Biesheuvel wrote: > ... > > Again, I am happy to merge this patch. The argument is about whether > > we need to upgrade RPi4 to 6.3 > > > > Last time I checked, quite a few of the people who contributed code to > the pla

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/AcpiLib: add GICC table init macro for ACPI 6.3

2020-03-30 Thread Pete Batard
On 2020.03.30 15:34, Ard Biesheuvel wrote: On Mon, 30 Mar 2020 at 16:29, Pete Batard wrote: On 2020.03.30 15:16, Ard Biesheuvel wrote: On Mon, 30 Mar 2020 at 16:07, Pete Batard wrote: On 2020.03.30 15:01, Ard Biesheuvel wrote: On Mon, 30 Mar 2020 at 15:56, Pete Batard wrote: On 2020.03

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/AcpiLib: add GICC table init macro for ACPI 6.3

2020-03-30 Thread Ard Biesheuvel
On Mon, 30 Mar 2020 at 16:29, Pete Batard wrote: > > On 2020.03.30 15:16, Ard Biesheuvel wrote: > > On Mon, 30 Mar 2020 at 16:07, Pete Batard wrote: > >> > >> On 2020.03.30 15:01, Ard Biesheuvel wrote: > >>> On Mon, 30 Mar 2020 at 15:56, Pete Batard wrote: > > On 2020.03.30 14:20, Ard

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/AcpiLib: add GICC table init macro for ACPI 6.3

2020-03-30 Thread Pete Batard
On 2020.03.30 15:19, Ard Biesheuvel wrote: On Mon, 30 Mar 2020 at 16:07, Pete Batard wrote: On 2020.03.30 15:01, Ard Biesheuvel wrote: On Mon, 30 Mar 2020 at 15:56, Pete Batard wrote: On 2020.03.30 14:20, Ard Biesheuvel wrote: On Mon, 30 Mar 2020 at 15:12, Ard Biesheuvel wrote: On Mon,

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/AcpiLib: add GICC table init macro for ACPI 6.3

2020-03-30 Thread Pete Batard
On 2020.03.30 15:16, Ard Biesheuvel wrote: On Mon, 30 Mar 2020 at 16:07, Pete Batard wrote: On 2020.03.30 15:01, Ard Biesheuvel wrote: On Mon, 30 Mar 2020 at 15:56, Pete Batard wrote: On 2020.03.30 14:20, Ard Biesheuvel wrote: On Mon, 30 Mar 2020 at 15:12, Ard Biesheuvel wrote: On Mon,

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/AcpiLib: add GICC table init macro for ACPI 6.3

2020-03-30 Thread Ard Biesheuvel
On Mon, 30 Mar 2020 at 16:07, Pete Batard wrote: > > On 2020.03.30 15:01, Ard Biesheuvel wrote: > > On Mon, 30 Mar 2020 at 15:56, Pete Batard wrote: > >> > >> On 2020.03.30 14:20, Ard Biesheuvel wrote: > >>> On Mon, 30 Mar 2020 at 15:12, Ard Biesheuvel > >>> wrote: > > On Mon, 30 Mar

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/AcpiLib: add GICC table init macro for ACPI 6.3

2020-03-30 Thread Ard Biesheuvel
On Mon, 30 Mar 2020 at 16:07, Pete Batard wrote: > > On 2020.03.30 15:01, Ard Biesheuvel wrote: > > On Mon, 30 Mar 2020 at 15:56, Pete Batard wrote: > >> > >> On 2020.03.30 14:20, Ard Biesheuvel wrote: > >>> On Mon, 30 Mar 2020 at 15:12, Ard Biesheuvel > >>> wrote: > > On Mon, 30 Mar

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/AcpiLib: add GICC table init macro for ACPI 6.3

2020-03-30 Thread Pete Batard
On 2020.03.30 15:01, Ard Biesheuvel wrote: On Mon, 30 Mar 2020 at 15:56, Pete Batard wrote: On 2020.03.30 14:20, Ard Biesheuvel wrote: On Mon, 30 Mar 2020 at 15:12, Ard Biesheuvel wrote: On Mon, 30 Mar 2020 at 15:09, Pete Batard wrote: On 2020.03.30 14:06, Ard Biesheuvel wrote: On Fri,

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/AcpiLib: add GICC table init macro for ACPI 6.3

2020-03-30 Thread Ard Biesheuvel
On Mon, 30 Mar 2020 at 15:56, Pete Batard wrote: > > On 2020.03.30 14:20, Ard Biesheuvel wrote: > > On Mon, 30 Mar 2020 at 15:12, Ard Biesheuvel > > wrote: > >> > >> On Mon, 30 Mar 2020 at 15:09, Pete Batard wrote: > >>> > >>> On 2020.03.30 14:06, Ard Biesheuvel wrote: > On Fri, 27 Mar 202

Re: [edk2-devel] [PATCH V2 2/2] MdePkg-IndustryStandard: CXL 1.1 Base Specification registers

2020-03-30 Thread Liming Gao
Ashraf: Please change patch title to specify the wrap Cxl.h header file to be added to include all version Cxl. Thanks Liming > -Original Message- > From: Javeed, Ashraf > Sent: Sunday, March 22, 2020 1:07 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > > Subje

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/AcpiLib: add GICC table init macro for ACPI 6.3

2020-03-30 Thread Pete Batard
On 2020.03.30 14:20, Ard Biesheuvel wrote: On Mon, 30 Mar 2020 at 15:12, Ard Biesheuvel wrote: On Mon, 30 Mar 2020 at 15:09, Pete Batard wrote: On 2020.03.30 14:06, Ard Biesheuvel wrote: On Fri, 27 Mar 2020 at 14:06, Pete Batard wrote: Incidentally, this is not an [edk2-platform] patch,

Re: [edk2-devel] [PATCH V2 1/2] MdePkg-IndustryStandard: CXL 1.1 Base Specification registers

2020-03-30 Thread Liming Gao
Ashraf: Please include PciExpress50.h in Pci.h, and remove other PciExpressionXX.h, because PciExpress50.h includes all version PciExpress. Thanks Liming > -Original Message- > From: Javeed, Ashraf > Sent: Sunday, March 22, 2020 1:07 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael

Re: [edk2-devel] [PATCH v2 1/1] MdePkg/UefiScsiLib: Set FUA bit for synchronous SCSI Write operations

2020-03-30 Thread Liming Gao
Zurcher: What functionality test has been done for this test? Thanks Liming > -Original Message- > From: Liu, Zhiguang > Sent: Monday, March 30, 2020 9:52 AM > To: Zurcher, Christopher J ; > devel@edk2.groups.io > Cc: Kinney, Michael D ; Wang, Jian J > ; Gao, Liming > Subject: RE: [P

Re: [edk2-devel] [PATCH 1/1] BaseTools: Use SEH exceptions in CLANGPDB for IA32

2020-03-30 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Liu, Zhiguang > Sent: Monday, March 30, 2020 11:26 AM > To: devel@edk2.groups.io; chept...@ispras.ru > Cc: Gao, Liming ; Marvin Häuser > Subject: RE: [edk2-devel] [PATCH 1/1] BaseTools: Use SEH exceptions in > CLANGPDB for IA32 > >

Re: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table

2020-03-30 Thread Liming Gao
Ack-by: Liming Gao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Friday, March 27, 2020 1:01 PM > To: Ard Biesheuvel ; devel@edk2.groups.io > Cc: Laszlo Ersek ; Leif Lindholm ; > Kinney, Michael D ; Ni, Ray > ; Bret Barkelew > Subject: Re: [edk2-de

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/AcpiLib: add GICC table init macro for ACPI 6.3

2020-03-30 Thread Ard Biesheuvel
On Mon, 30 Mar 2020 at 15:12, Ard Biesheuvel wrote: > > On Mon, 30 Mar 2020 at 15:09, Pete Batard wrote: > > > > On 2020.03.30 14:06, Ard Biesheuvel wrote: > > > On Fri, 27 Mar 2020 at 14:06, Pete Batard wrote: > > >> > > >> Incidentally, this is not an [edk2-platform] patch, as the subject line

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/AcpiLib: add GICC table init macro for ACPI 6.3

2020-03-30 Thread Ard Biesheuvel
On Mon, 30 Mar 2020 at 15:09, Pete Batard wrote: > > On 2020.03.30 14:06, Ard Biesheuvel wrote: > > On Fri, 27 Mar 2020 at 14:06, Pete Batard wrote: > >> > >> Incidentally, this is not an [edk2-platform] patch, as the subject line > >> from previous mail seemed to indicate, but an [edk2] patch. >

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/AcpiLib: add GICC table init macro for ACPI 6.3

2020-03-30 Thread Pete Batard
On 2020.03.30 14:06, Ard Biesheuvel wrote: On Fri, 27 Mar 2020 at 14:06, Pete Batard wrote: Incidentally, this is not an [edk2-platform] patch, as the subject line from previous mail seemed to indicate, but an [edk2] patch. Do we have a user for this? Yes we do. I have a pachset lined up

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/AcpiLib: add GICC table init macro for ACPI 6.3

2020-03-30 Thread Ard Biesheuvel
On Fri, 27 Mar 2020 at 14:06, Pete Batard wrote: > > Incidentally, this is not an [edk2-platform] patch, as the subject line > from previous mail seemed to indicate, but an [edk2] patch. > Do we have a user for this? > > On 2020.03.27 13:01, Pete Batard wrote: > > ACPI 6.3 added a 16-bit SPE ove

[edk2-devel] [PATCH v2] NetworkPkg/Ip6Dxe: Improve Neightbor Discovery message validation.

2020-03-30 Thread Maciej Rabeda
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2174 Problem has been identified with Ip6ProcessRouterAdvertise() when Router Advertise packet contains options with malicious/invalid 'Length' field. This can lead to platform entering infinite loop when processing options from that packet. Cc:

Re: [edk2-devel] [PATCH v2 28/28] Platform/NXP/LS1043aRdbPkg: Add PEI Phase

2020-03-30 Thread Leif Lindholm
On Fri, Mar 20, 2020 at 20:05:43 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > Add PEI phase to LS1043aRdb. This is needed becuase we need to have > dynamic PCDs support to be able to reserve memory before reporting > memory to UEFI fimrware. > > Signed-off-by: Pankaj Bansal > --- > Pl

Re: [edk2-devel] [PATCH] OvmfPkg/GenericQemuLoadImageLib: Fix VS2019 UINT32 conversion error

2020-03-30 Thread Ard Biesheuvel
On Mon, 30 Mar 2020 at 13:39, Laszlo Ersek wrote: > > On 03/29/20 15:51, Ard Biesheuvel wrote: > > Building OVMF for X64 with secure boot enabled on VS2019 results in > > the following error: > > > > > > d:\a\1\s\OvmfPkg\Library\GenericQemuLoadImageLib\GenericQemuLoadImageLib.c(154): > > er

Re: [edk2-devel] [PATCH 6/8] NetWorkPkg/Pcd.inc: Enable the MD5 for iSCSI

2020-03-30 Thread Maciej Rabeda
Reviewed-by: Maciej Rabeda On 27-Mar-20 02:56, Gao, Zhichao wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1682 iSCSI driver required the MD5 function. Change the PcdMD5Enable to TRUE when NETWORK_ISCSI_ENABLE is TURE. Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by

Re: [edk2-devel] [PATCH] OvmfPkg/GenericQemuLoadImageLib: Fix VS2019 UINT32 conversion error

2020-03-30 Thread Laszlo Ersek
On 03/29/20 15:51, Ard Biesheuvel wrote: > Building OVMF for X64 with secure boot enabled on VS2019 results in > the following error: > > > d:\a\1\s\OvmfPkg\Library\GenericQemuLoadImageLib\GenericQemuLoadImageLib.c(154): > error C2220: the following warning is treated as an error > > d:\

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Fix SMM/RT driver section alignment for XCODE5/CLANGPDB

2020-03-30 Thread Laszlo Ersek
On 03/29/20 15:21, Vitaly Cheptsov wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2642 > > This patch resolves the problem of using memory protection > attributes when OVMF firmware is compiled with XCODE5 and CLANGPDB. > > CC: Andrew Fish > CC: Laszlo Ersek > CC: Marvin Häuser >

  1   2   >