Reviewed-by: Ray Ni <ray...@intel.com> > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Heng Luo > Sent: Monday, March 30, 2020 2:03 PM > To: devel@edk2.groups.io > Cc: Bi, Dandan <dandan...@intel.com>; Gao, Liming <liming....@intel.com>; > Dong, Eric <eric.d...@intel.com>; Ni, Ray > <ray...@intel.com> > Subject: [edk2-devel] [PATCH 3/3] Features/Intel: Correct wrong codes and > remove unnecessary codes > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2644 > > Correct wrong codes and remove unnecessary codes in LogoFeaturePkg. > > Cc: Dandan Bi <dandan...@intel.com> > Cc: Liming Gao <liming....@intel.com> > Cc: Eric Dong <eric.d...@intel.com> > Cc: Ray Ni <ray...@intel.com> > Signed-off-by: Heng Luo <heng....@intel.com> > --- > Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc | 9 > --------- > Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory.fdf | 2 +- > 2 files changed, 1 insertion(+), 10 deletions(-) > > diff --git > a/Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc > b/Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc > index fca0bfd540..d2dcdeb36a 100644 > --- a/Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc > +++ b/Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc > @@ -25,15 +25,6 @@ > !error "DXE_ARCH must be specified to build this feature!" > > !endif > > > > -################################################################################ > > -# > > -# Packages Section - Make sure PCD can be directly used in a conditional > statement > > -# in a DSC which includes this DSC file. > > -# > > -################################################################################ > > -[Packages] > > - LogoFeaturePkg/LogoFeaturePkg.dec > > - > > > ################################################################################ > > # > > # Library Class section - list of all Library Classes needed by this feature. > > diff --git > a/Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory.fdf > b/Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory.fdf > index 080c87223c..fead9f3b02 100644 > --- a/Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory.fdf > +++ b/Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory.fdf > @@ -6,7 +6,7 @@ > # SPDX-License-Identifier: BSD-2-Clause-Patent > > # > > ## > > -!if gSmbiosFeaturePkgTokenSpaceGuid.PcdJpgEnable == TRUE > > +!if gLogoFeaturePkgTokenSpaceGuid.PcdJpgEnable == TRUE > > INF LogoFeaturePkg/LogoDxe/JpegLogoDxe.inf > > !else > > INF LogoFeaturePkg/LogoDxe/LogoDxe.inf > > -- > 2.24.0.windows.2 > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#56600): https://edk2.groups.io/g/devel/message/56600 > Mute This Topic: https://groups.io/mt/72646659/1712937 > Group Owner: devel+ow...@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray...@intel.com] > -=-=-=-=-=-=
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56701): https://edk2.groups.io/g/devel/message/56701 Mute This Topic: https://groups.io/mt/72646659/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
